From: Jagan Teki <jagan@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sun8i_emac: Fix mdio read sequence
Date: Mon, 28 Nov 2016 13:31:15 +0530 [thread overview]
Message-ID: <CAD6G_RT3EFhPFKXLR+z2MOP7LbckYoYoLMZunxHJwG4A3TE4-Q@mail.gmail.com> (raw)
In-Reply-To: <8B78B046-EB13-4F68-9BA7-17479F4C0A93@theobroma-systems.com>
On Fri, Nov 25, 2016 at 9:50 PM, Dr. Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> Jagan,
>
>> On 25 Nov 2016, at 17:18, Jagan Teki <jagan@openedev.com> wrote:
>>
>> On Wed, Nov 16, 2016 at 7:10 AM, Andre Przywara <andre.przywara@arm.com> wrote:
>>> From: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>>
>>> To send a parametrized command to the PHY over MDIO, we should write
>>> the data first, the trigger the execution by the command register
>>> write. Fix the access pattern in our MDIO write routine.
>>> Apparently this doesn't really matter with the Realtek PHY on the
>>> Pine64, but other PHYs (which require more setup) will choke on
>>> the wrong order.
>>
>> Any tested-by this on non-realtek, because I always remember to have
>> CMD with DATA sequence for mdio write for most of the PHY's and ie
>> default sequence though.
>
> We have a KSZ9031 on all our boards? so it was tested against the KSZ9031.
Applied to u-boot-spi/sunxi
thanks!
--
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
prev parent reply other threads:[~2016-11-28 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 1:40 [U-Boot] [PATCH] sun8i_emac: Fix mdio read sequence Andre Przywara
2016-11-25 16:18 ` Jagan Teki
2016-11-25 16:20 ` Dr. Philipp Tomsich
2016-11-28 8:01 ` Jagan Teki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD6G_RT3EFhPFKXLR+z2MOP7LbckYoYoLMZunxHJwG4A3TE4-Q@mail.gmail.com \
--to=jagan@openedev.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.