From: Pengfei Li <lpf.vector@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christopher Lameter <cl@linux.com>,
penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] mm, slab: Make kmalloc_info[] contain all types of names
Date: Thu, 5 Sep 2019 21:51:14 +0800 [thread overview]
Message-ID: <CAD7_sbH+1ZeHVcDWwVkWmNjCzDU4TUAN1zXWCmj1bftyU5o6TA@mail.gmail.com> (raw)
In-Reply-To: <8641aeba-ab8c-f5a1-a6ad-cf8c0f86baa7@suse.cz>
On Thu, Sep 5, 2019 at 8:25 PM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 9/3/19 6:04 PM, Pengfei Li wrote:
> > There are three types of kmalloc, KMALLOC_NORMAL, KMALLOC_RECLAIM
> > and KMALLOC_DMA.
> >
> > The name of KMALLOC_NORMAL is contained in kmalloc_info[].name,
> > but the names of KMALLOC_RECLAIM and KMALLOC_DMA are dynamically
> > generated by kmalloc_cache_name().
> >
> > Patch1 predefines the names of all types of kmalloc to save
> > the time spent dynamically generating names.
> >
> > The other 4 patches did some cleanup work.
> >
> > These changes make sense, and the time spent by new_kmalloc_cache()
> > has been reduced by approximately 36.3%.
> >
> > Time spent by
> > new_kmalloc_cache()
> > 5.3-rc7 66264
> > 5.3-rc7+patch 42188
>
> Note that the caches are created only once upon boot, so I doubt that
Thank you for your comments.
Yes, kmalloc-xxx are only created at boot time.
> these time savings (is it in CPU cycles?) will be noticeable at all.
Yes, it is CPU cycles.
> But diffstat looks ok, and it avoids using kmalloc() (via kasprintf()) to
> allocate names for kmalloc(), so in that sense I think it's worthwhile
> to consider. Thanks.
>
Thanks.
> > Pengfei Li (5):
> > mm, slab: Make kmalloc_info[] contain all types of names
> > mm, slab_common: Remove unused kmalloc_cache_name()
> > mm, slab: Remove unused kmalloc_size()
> > mm, slab_common: Make 'type' is enum kmalloc_cache_type
> > mm, slab_common: Make initializing KMALLOC_DMA start from 1
> >
> > include/linux/slab.h | 20 ---------
> > mm/slab.c | 7 +--
> > mm/slab.h | 2 +-
> > mm/slab_common.c | 101 +++++++++++++++++++++++--------------------
> > 4 files changed, 59 insertions(+), 71 deletions(-)
> >
>
next prev parent reply other threads:[~2019-09-05 13:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:04 [PATCH 0/5] mm, slab: Make kmalloc_info[] contain all types of names Pengfei Li
2019-09-03 16:04 ` [PATCH 1/5] " Pengfei Li
2019-09-09 14:59 ` Vlastimil Babka
2019-09-09 16:53 ` Pengfei Li
2019-09-09 16:53 ` Pengfei Li
2019-09-09 18:30 ` Rasmus Villemoes
2019-09-09 19:48 ` Vlastimil Babka
2019-09-10 0:52 ` Pengfei Li
2019-09-10 0:52 ` Pengfei Li
2019-09-03 16:04 ` [PATCH 2/5] mm, slab_common: Remove unused kmalloc_cache_name() Pengfei Li
2019-09-09 14:59 ` Vlastimil Babka
2019-09-09 16:54 ` Pengfei Li
2019-09-09 16:54 ` Pengfei Li
2019-09-03 16:04 ` [PATCH 3/5] mm, slab: Remove unused kmalloc_size() Pengfei Li
2019-09-09 15:07 ` Vlastimil Babka
2019-09-03 16:04 ` [PATCH 4/5] mm, slab_common: Make 'type' is enum kmalloc_cache_type Pengfei Li
2019-09-09 15:08 ` Vlastimil Babka
2019-09-03 16:04 ` [PATCH 5/5] mm, slab_common: Make initializing KMALLOC_DMA start from 1 Pengfei Li
2019-09-04 19:27 ` [PATCH 0/5] mm, slab: Make kmalloc_info[] contain all types of names Christopher Lameter
2019-09-04 19:27 ` Christopher Lameter
2019-09-05 0:40 ` Pengfei Li
2019-09-05 0:40 ` Pengfei Li
2019-09-05 12:25 ` Vlastimil Babka
2019-09-05 13:51 ` Pengfei Li [this message]
2019-09-05 13:51 ` Pengfei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD7_sbH+1ZeHVcDWwVkWmNjCzDU4TUAN1zXWCmj1bftyU5o6TA@mail.gmail.com \
--to=lpf.vector@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.