From: Doug Anderson <dianders@google.com>
To: Kees Cook <keescook@chromium.org>
Cc: Rabin Vincent <rabin@rab.in>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Laura Abbott <lauraa@codeaurora.org>,
Jon Medhurst <tixy@linaro.org>
Subject: Re: [PATCH 2/2] arm: use fixmap for text patching when text is RO
Date: Wed, 23 Apr 2014 15:51:45 -0700 [thread overview]
Message-ID: <CAD=FV=U4WxMLyEAgGExc=Q7r9jy=AS3mtxSoi=M+Qgw_e=U-bg@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jJFRapP6EA_T6fCK1po_4sf=34mpC13t9L0SCo1COB5gQ@mail.gmail.com>
Kees,
On Wed, Apr 23, 2014 at 2:09 PM, Kees Cook <keescook@chromium.org> wrote:
> I think we can use this for the kgdb case too. Has anyone tried that
> yet? Perhaps implementing text_poke() in terms of patch_map/unmap
> calls would be best? Then the arm-specific kgdb hooks can use that,
> since it does the icache flushing separately.
Yes. I just tried using these patches and it worked for me. :) I
didn't actually implement text_poke(), though.
Atop our 3.8 tree, in case anyone is curious
* https://chromium-review.googlesource.com/196670
* https://chromium-review.googlesource.com/196671
* https://chromium-review.googlesource.com/196672
* https://chromium-review.googlesource.com/196673
* https://chromium-review.googlesource.com/196674
Please include me on the CC list for spins of your patches...
-Doug
WARNING: multiple messages have this Message-ID (diff)
From: dianders@google.com (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: use fixmap for text patching when text is RO
Date: Wed, 23 Apr 2014 15:51:45 -0700 [thread overview]
Message-ID: <CAD=FV=U4WxMLyEAgGExc=Q7r9jy=AS3mtxSoi=M+Qgw_e=U-bg@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jJFRapP6EA_T6fCK1po_4sf=34mpC13t9L0SCo1COB5gQ@mail.gmail.com>
Kees,
On Wed, Apr 23, 2014 at 2:09 PM, Kees Cook <keescook@chromium.org> wrote:
> I think we can use this for the kgdb case too. Has anyone tried that
> yet? Perhaps implementing text_poke() in terms of patch_map/unmap
> calls would be best? Then the arm-specific kgdb hooks can use that,
> since it does the icache flushing separately.
Yes. I just tried using these patches and it worked for me. :) I
didn't actually implement text_poke(), though.
Atop our 3.8 tree, in case anyone is curious
* https://chromium-review.googlesource.com/196670
* https://chromium-review.googlesource.com/196671
* https://chromium-review.googlesource.com/196672
* https://chromium-review.googlesource.com/196673
* https://chromium-review.googlesource.com/196674
Please include me on the CC list for spins of your patches...
-Doug
next prev parent reply other threads:[~2014-04-23 22:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 21:27 [PATCH 1/2] arm: fixmap: implement __set_fixmap() Rabin Vincent
2014-04-04 21:27 ` Rabin Vincent
2014-04-04 21:27 ` [PATCH 2/2] arm: use fixmap for text patching when text is RO Rabin Vincent
2014-04-04 21:27 ` Rabin Vincent
2014-04-07 13:57 ` Jon Medhurst (Tixy)
2014-04-07 13:57 ` Jon Medhurst (Tixy)
2014-04-07 18:04 ` Kees Cook
2014-04-07 18:04 ` Kees Cook
2014-04-08 9:31 ` Jon Medhurst (Tixy)
2014-04-08 9:31 ` Jon Medhurst (Tixy)
2014-04-10 19:34 ` Rabin Vincent
2014-04-10 19:34 ` Rabin Vincent
2014-04-23 21:09 ` Kees Cook
2014-04-23 21:09 ` Kees Cook
2014-04-23 22:51 ` Doug Anderson [this message]
2014-04-23 22:51 ` Doug Anderson
2014-04-24 21:28 ` [PATCHv2 " Rabin Vincent
2014-04-24 21:28 ` Rabin Vincent
2014-04-25 0:52 ` [PATCH 1/2] arm: fixmap: implement __set_fixmap() Doug Anderson
2014-04-25 0:52 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=U4WxMLyEAgGExc=Q7r9jy=AS3mtxSoi=M+Qgw_e=U-bg@mail.gmail.com' \
--to=dianders@google.com \
--cc=keescook@chromium.org \
--cc=lauraa@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.