[PATCH V4 0/4] Add PM8350C PMIC PWM support for backlight

[PATCH V4 0/4] Add PM8350C PMIC PWM support for backlight

[Satya Priya]

This series depends on [1], which adds driver for Qualcomm LPG.

[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=615848

Satya Priya (4):
  dt-bindings: leds: Add pm8350c pmic support
  leds: Add pm8350c support to Qualcomm LPG driver
  arm64: dts: qcom: pm8350c: Add pwm support
  arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2

 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml |  1 +
 arch/arm64/boot/dts/qcom/pm8350c.dtsi                     |  7 +++++++
 arch/arm64/boot/dts/qcom/sc7280-idp2.dts                  |  4 ++++
 drivers/leds/rgb/leds-qcom-lpg.c                          | 13 +++++++++++++
 4 files changed, 25 insertions(+)

-- 
2.7.4

[PATCH V4 1/4] dt-bindings: leds: Add pm8350c pmic support

[Satya Priya]

Add pm8350c pmic pwm support.

Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in V2:
 - No changes.

Changes in V3:
 - No changes.

Changes in V4:
 - No changes.

 Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
index 336bd8e..409a4c7 100644
--- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
@@ -19,6 +19,7 @@ properties:
     enum:
       - qcom,pm8150b-lpg
       - qcom,pm8150l-lpg
+      - qcom,pm8350c-pwm
       - qcom,pm8916-pwm
       - qcom,pm8941-lpg
       - qcom,pm8994-lpg
-- 
2.7.4

[PATCH V4 2/4] leds: Add pm8350c support to Qualcomm LPG driver

[Satya Priya]

Add pm8350c compatible and lpg_data to the driver.

Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes in V2:
 - Added const for lpg_channel_data[] struct.

Changes in V3:
 - Correct the num_channels and add respective base addresses.

Changes in V4:
 - Remove .pwm_9bit_mask, add .triled_base and .triled_mask.

 drivers/leds/rgb/leds-qcom-lpg.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
index c1ad678..ab29610 100644
--- a/drivers/leds/rgb/leds-qcom-lpg.c
+++ b/drivers/leds/rgb/leds-qcom-lpg.c
@@ -1374,9 +1374,22 @@ static const struct lpg_data pm8150l_lpg_data = {
 	},
 };
 
+static const struct lpg_data pm8350c_pwm_data = {
+	.triled_base = 0xef00,
+
+	.num_channels = 4,
+	.channels = (const struct lpg_channel_data[]) {
+		{ .base = 0xe800, .triled_mask = BIT(7) },
+		{ .base = 0xe900, .triled_mask = BIT(6) },
+		{ .base = 0xea00, .triled_mask = BIT(5) },
+		{ .base = 0xeb00 },
+	},
+};
+
 static const struct of_device_id lpg_of_table[] = {
 	{ .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data },
 	{ .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data },
+	{ .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data },
 	{ .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
 	{ .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
 	{ .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },
-- 
2.7.4

[PATCH V4 3/4] arm64: dts: qcom: pm8350c: Add pwm support

[Satya Priya]

Add pwm support for PM8350C pmic.

Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes in V2:
 - Dropped suffix '4' from pwm phandle and removed "status=ok".

Changes in V3:
 - Add reg property.

Changes in V4:
 - No Changes.

 arch/arm64/boot/dts/qcom/pm8350c.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index e1b75ae..1ba6318 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -29,6 +29,13 @@
 			interrupt-controller;
 			#interrupt-cells = <2>;
 		};
+
+		pm8350c_pwm: pwm@e800 {
+			compatible = "qcom,pm8350c-pwm";
+			reg = <0xe800>;
+			#pwm-cells = <2>;
+			status = "disabled";
+		};
 	};
 };
 
-- 
2.7.4

[PATCH V4 4/4] arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2

[Satya Priya]

Enable pm8350c pmic pwm support for backlight on sc7280-idp2.

Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes in V3:
 - New patch added in V3, to enable pwm support on sc7280-idp2 board.

Changes in V4:
 - No changes.

 arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
index 73b9911..d4f7cab 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
@@ -34,3 +34,7 @@
 &nvme_3v3_regulator {
 	gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>;
 };
+
+&pm8350c_pwm {
+	status = "okay";
+};
-- 
2.7.4

Re: [PATCH V4 1/4] dt-bindings: leds: Add pm8350c pmic support

[Bjorn Andersson]

On Mon 21 Feb 21:55 PST 2022, Satya Priya wrote:

> Add pm8350c pmic pwm support.
> 
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> Changes in V2:
>  - No changes.
> 
> Changes in V3:
>  - No changes.
> 
> Changes in V4:
>  - No changes.
> 
>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> index 336bd8e..409a4c7 100644
> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
> @@ -19,6 +19,7 @@ properties:
>      enum:
>        - qcom,pm8150b-lpg
>        - qcom,pm8150l-lpg
> +      - qcom,pm8350c-pwm
>        - qcom,pm8916-pwm
>        - qcom,pm8941-lpg
>        - qcom,pm8994-lpg
> -- 
> 2.7.4
> 

Re: [PATCH V4 2/4] leds: Add pm8350c support to Qualcomm LPG driver

[Bjorn Andersson]

On Mon 21 Feb 21:55 PST 2022, Satya Priya wrote:

> Add pm8350c compatible and lpg_data to the driver.
> 
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> Changes in V2:
>  - Added const for lpg_channel_data[] struct.
> 
> Changes in V3:
>  - Correct the num_channels and add respective base addresses.
> 
> Changes in V4:
>  - Remove .pwm_9bit_mask, add .triled_base and .triled_mask.

This changed the patch quite a bit. In general when this happen I would
suggest that you don't keep previously acquired Reviewed-bys.

Regards,
Bjorn

> 
>  drivers/leds/rgb/leds-qcom-lpg.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
> index c1ad678..ab29610 100644
> --- a/drivers/leds/rgb/leds-qcom-lpg.c
> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
> @@ -1374,9 +1374,22 @@ static const struct lpg_data pm8150l_lpg_data = {
>  	},
>  };
>  
> +static const struct lpg_data pm8350c_pwm_data = {
> +	.triled_base = 0xef00,
> +
> +	.num_channels = 4,
> +	.channels = (const struct lpg_channel_data[]) {
> +		{ .base = 0xe800, .triled_mask = BIT(7) },
> +		{ .base = 0xe900, .triled_mask = BIT(6) },
> +		{ .base = 0xea00, .triled_mask = BIT(5) },
> +		{ .base = 0xeb00 },
> +	},
> +};
> +
>  static const struct of_device_id lpg_of_table[] = {
>  	{ .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data },
>  	{ .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data },
> +	{ .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data },
>  	{ .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
>  	{ .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
>  	{ .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },
> -- 
> 2.7.4
> 

Re: [PATCH V4 3/4] arm64: dts: qcom: pm8350c: Add pwm support

[Bjorn Andersson]

On Mon 21 Feb 21:55 PST 2022, Satya Priya wrote:

> Add pwm support for PM8350C pmic.
> 
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> Changes in V2:
>  - Dropped suffix '4' from pwm phandle and removed "status=ok".
> 
> Changes in V3:
>  - Add reg property.
> 
> Changes in V4:
>  - No Changes.
> 
>  arch/arm64/boot/dts/qcom/pm8350c.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> index e1b75ae..1ba6318 100644
> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> @@ -29,6 +29,13 @@
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  		};
> +
> +		pm8350c_pwm: pwm@e800 {
> +			compatible = "qcom,pm8350c-pwm";
> +			reg = <0xe800>;
> +			#pwm-cells = <2>;
> +			status = "disabled";
> +		};
>  	};
>  };
>  
> -- 
> 2.7.4
> 

Re: [PATCH V4 4/4] arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2

[Bjorn Andersson]

On Mon 21 Feb 21:55 PST 2022, Satya Priya wrote:

> Enable pm8350c pmic pwm support for backlight on sc7280-idp2.
> 
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> Changes in V3:
>  - New patch added in V3, to enable pwm support on sc7280-idp2 board.
> 
> Changes in V4:
>  - No changes.
> 
>  arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> index 73b9911..d4f7cab 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> @@ -34,3 +34,7 @@
>  &nvme_3v3_regulator {
>  	gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>;
>  };
> +
> +&pm8350c_pwm {
> +	status = "okay";
> +};
> -- 
> 2.7.4
> 

Re: [PATCH V4 2/4] leds: Add pm8350c support to Qualcomm LPG driver

[Stephen Boyd]

Quoting Satya Priya (2022-02-21 21:55:07)
> Add pm8350c compatible and lpg_data to the driver.
>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---

Still

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Re: [PATCH V4 2/4] leds: Add pm8350c support to Qualcomm LPG driver

[Doug Anderson]

Hi,

On Mon, Feb 21, 2022 at 9:55 PM Satya Priya <quic_c_skakit@quicinc.com> wrote:
>
> Add pm8350c compatible and lpg_data to the driver.
>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---
> Changes in V2:
>  - Added const for lpg_channel_data[] struct.
>
> Changes in V3:
>  - Correct the num_channels and add respective base addresses.
>
> Changes in V4:
>  - Remove .pwm_9bit_mask, add .triled_base and .triled_mask.
>
>  drivers/leds/rgb/leds-qcom-lpg.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

Tested-by: Douglas Anderson <dianders@chromium.org>

I'm very interested in knowing if there's anything blocking this patch
(and the one from Bjorn that it depends on) from landing. Thanks! :-)

-Doug

Re: [PATCH V4 0/4] Add PM8350C PMIC PWM support for backlight

[Doug Anderson]

Pavel,

On Mon, Feb 21, 2022 at 9:55 PM Satya Priya <quic_c_skakit@quicinc.com> wrote:
>
> This series depends on [1], which adds driver for Qualcomm LPG.
>
> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=615848
>
> Satya Priya (4):
>   dt-bindings: leds: Add pm8350c pmic support
>   leds: Add pm8350c support to Qualcomm LPG driver
>   arm64: dts: qcom: pm8350c: Add pwm support
>   arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2

I see Bjorn's patch in your tree. Thanks!

...could you add patch #1 and #2 from this series too? They are both
small and ready to go.

-Doug

Re: [PATCH V4 0/4] Add PM8350C PMIC PWM support for backlight

[Bjorn Andersson]

On Wed 04 May 06:45 PDT 2022, Doug Anderson wrote:

> Pavel,
> 
> On Mon, Feb 21, 2022 at 9:55 PM Satya Priya <quic_c_skakit@quicinc.com> wrote:
> >
> > This series depends on [1], which adds driver for Qualcomm LPG.
> >
> > [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=615848
> >
> > Satya Priya (4):
> >   dt-bindings: leds: Add pm8350c pmic support
> >   leds: Add pm8350c support to Qualcomm LPG driver
> >   arm64: dts: qcom: pm8350c: Add pwm support
> >   arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2
> 
> I see Bjorn's patch in your tree. Thanks!
> 
> ...could you add patch #1 and #2 from this series too? They are both
> small and ready to go.
> 

To add to that, now that the binding has been accepted I will pick the
two dts patches (patch 3 and 4) through the Qualcomm tree.

So Pavel, please pick up the first two through your tree.

Regards,
Bjorn

Re: (subset) [PATCH V4 0/4] Add PM8350C PMIC PWM support for backlight

[Bjorn Andersson]

On Tue, 22 Feb 2022 11:25:05 +0530, Satya Priya wrote:
> This series depends on [1], which adds driver for Qualcomm LPG.
> 
> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=615848
> 
> Satya Priya (4):
>   dt-bindings: leds: Add pm8350c pmic support
>   leds: Add pm8350c support to Qualcomm LPG driver
>   arm64: dts: qcom: pm8350c: Add pwm support
>   arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2
> 
> [...]

Applied, thanks!

[3/4] arm64: dts: qcom: pm8350c: Add pwm support
      commit: 5be66d2dc8873edcf215804067b1c076b00c6887
[4/4] arm64: dts: qcom: Enable pm8350c pwm for sc7280-idp2
      commit: 82096cc644098ab610e6df5238341907ea662164

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

Re: [PATCH V4 0/4] Add PM8350C PMIC PWM support for backlight

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Hi!

> This series depends on [1], which adds driver for Qualcomm LPG.
> 
> [1]
> https://patchwork.kernel.org/project/linux-arm-msm/list/?series=615848

Thank you, I added 1 and 2 of the series.

Best regards,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]