All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
@ 2022-08-31 14:16 ` Francesco Dolcini
  0 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-08-31 14:16 UTC (permalink / raw)
  To: dri-devel, Thierry Reding
  Cc: Aishwarya Kothari, Sam Ravnborg, David Airlie, Daniel Vetter,
	Marcel Ziswiler, linux-kernel, Francesco Dolcini

From: Aishwarya Kothari <aishwarya.kothari@toradex.com>

In case bpc is not set for a panel it then throws a WARN(). Add bpc to
the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.

Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
Signed-off-by: Aishwarya Kothari <aishwarya.kothari@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ff5e1a44c43a..fef3fb0f45c9 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2505,6 +2505,7 @@ static const struct display_timing logictechno_lt161010_2nh_timing = {
 static const struct panel_desc logictechno_lt161010_2nh = {
 	.timings = &logictechno_lt161010_2nh_timing,
 	.num_timings = 1,
+	.bpc = 6,
 	.size = {
 		.width = 154,
 		.height = 86,
@@ -2534,6 +2535,7 @@ static const struct display_timing logictechno_lt170410_2whc_timing = {
 static const struct panel_desc logictechno_lt170410_2whc = {
 	.timings = &logictechno_lt170410_2whc_timing,
 	.num_timings = 1,
+	.bpc = 8,
 	.size = {
 		.width = 217,
 		.height = 136,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
@ 2022-08-31 14:16 ` Francesco Dolcini
  0 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-08-31 14:16 UTC (permalink / raw)
  To: dri-devel, Thierry Reding
  Cc: David Airlie, Aishwarya Kothari, linux-kernel, Marcel Ziswiler,
	Francesco Dolcini, Sam Ravnborg

From: Aishwarya Kothari <aishwarya.kothari@toradex.com>

In case bpc is not set for a panel it then throws a WARN(). Add bpc to
the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.

Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
Signed-off-by: Aishwarya Kothari <aishwarya.kothari@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index ff5e1a44c43a..fef3fb0f45c9 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2505,6 +2505,7 @@ static const struct display_timing logictechno_lt161010_2nh_timing = {
 static const struct panel_desc logictechno_lt161010_2nh = {
 	.timings = &logictechno_lt161010_2nh_timing,
 	.num_timings = 1,
+	.bpc = 6,
 	.size = {
 		.width = 154,
 		.height = 86,
@@ -2534,6 +2535,7 @@ static const struct display_timing logictechno_lt170410_2whc_timing = {
 static const struct panel_desc logictechno_lt170410_2whc = {
 	.timings = &logictechno_lt170410_2whc_timing,
 	.num_timings = 1,
+	.bpc = 8,
 	.size = {
 		.width = 217,
 		.height = 136,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
  2022-08-31 14:16 ` Francesco Dolcini
@ 2022-10-17 14:18   ` Francesco Dolcini
  -1 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-10-17 14:18 UTC (permalink / raw)
  To: dri-devel, Thierry Reding, Sam Ravnborg
  Cc: Francesco Dolcini, David Airlie, Aishwarya Kothari, linux-kernel,
	Marcel Ziswiler

On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> From: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> 
> In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> 
> Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")

Hello,
just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
should do?

Francesco


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
@ 2022-10-17 14:18   ` Francesco Dolcini
  0 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-10-17 14:18 UTC (permalink / raw)
  To: dri-devel, Thierry Reding, Sam Ravnborg
  Cc: David Airlie, Francesco Dolcini, Aishwarya Kothari, linux-kernel,
	Marcel Ziswiler

On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> From: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> 
> In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> 
> Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")

Hello,
just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
should do?

Francesco


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
  2022-10-17 14:18   ` Francesco Dolcini
@ 2022-11-10 13:12     ` Francesco Dolcini
  -1 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-11-10 13:12 UTC (permalink / raw)
  To: Doug Anderson
  Cc: dri-devel, Thierry Reding, Sam Ravnborg, David Airlie,
	Francesco Dolcini, Aishwarya Kothari, linux-kernel,
	Marcel Ziswiler, Francesco Dolcini

On Mon, Oct 17, 2022 at 04:18:13PM +0200, Francesco Dolcini wrote:
> On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> > From: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> > 
> > In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> > the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> > 
> > Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
> 
> Hello,
> just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
> should do?

Hello Doug,
can you help on this patch? I am not sure who is supposed to pick this
small fix, but it looks like you recently took patches on
"drm/panel: simple:", so maybe you can help.

Francesco


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
@ 2022-11-10 13:12     ` Francesco Dolcini
  0 siblings, 0 replies; 8+ messages in thread
From: Francesco Dolcini @ 2022-11-10 13:12 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Francesco Dolcini, David Airlie, Aishwarya Kothari, linux-kernel,
	dri-devel, Marcel Ziswiler, Thierry Reding, Francesco Dolcini,
	Sam Ravnborg

On Mon, Oct 17, 2022 at 04:18:13PM +0200, Francesco Dolcini wrote:
> On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> > From: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> > 
> > In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> > the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> > 
> > Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
> 
> Hello,
> just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
> should do?

Hello Doug,
can you help on this patch? I am not sure who is supposed to pick this
small fix, but it looks like you recently took patches on
"drm/panel: simple:", so maybe you can help.

Francesco


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
  2022-11-10 13:12     ` Francesco Dolcini
@ 2022-11-10 15:32       ` Doug Anderson
  -1 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2022-11-10 15:32 UTC (permalink / raw)
  To: Francesco Dolcini
  Cc: David Airlie, Aishwarya Kothari, linux-kernel, dri-devel,
	Marcel Ziswiler, Thierry Reding, Francesco Dolcini, Sam Ravnborg

Hi,

On Thu, Nov 10, 2022 at 5:13 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> On Mon, Oct 17, 2022 at 04:18:13PM +0200, Francesco Dolcini wrote:
> > On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> > > From: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> > >
> > > In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> > > the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> > >
> > > Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
> >
> > Hello,
> > just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
> > should do?
>
> Hello Doug,
> can you help on this patch? I am not sure who is supposed to pick this
> small fix, but it looks like you recently took patches on
> "drm/panel: simple:", so maybe you can help.

Sure. It looks fine to me so I don't mind applying it. I did a quick
double-check and I was amused that the datasheet of the 800x480 screen
claims that it can show 16.7M colors with an 18-bit interface. ;-)

Pushed to drm-misc-fixes:

876153ab068b drm/panel: simple: set bpc field for logic technologies displays

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays
@ 2022-11-10 15:32       ` Doug Anderson
  0 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2022-11-10 15:32 UTC (permalink / raw)
  To: Francesco Dolcini
  Cc: dri-devel, Thierry Reding, Sam Ravnborg, David Airlie,
	Francesco Dolcini, Aishwarya Kothari, linux-kernel,
	Marcel Ziswiler

Hi,

On Thu, Nov 10, 2022 at 5:13 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> On Mon, Oct 17, 2022 at 04:18:13PM +0200, Francesco Dolcini wrote:
> > On Wed, Aug 31, 2022 at 04:16:22PM +0200, Francesco Dolcini wrote:
> > > From: Aishwarya Kothari <aishwarya.kothari@toradex.com>
> > >
> > > In case bpc is not set for a panel it then throws a WARN(). Add bpc to
> > > the panels logictechno_lt170410_2whc and logictechno_lt161010_2nh.
> > >
> > > Fixes: 5728fe7fa539 ("drm/panel: simple: add display timings for logic technologies displays")
> >
> > Hello,
> > just a gently ping on this. It applies cleanly on v6.1-rc1, anything I
> > should do?
>
> Hello Doug,
> can you help on this patch? I am not sure who is supposed to pick this
> small fix, but it looks like you recently took patches on
> "drm/panel: simple:", so maybe you can help.

Sure. It looks fine to me so I don't mind applying it. I did a quick
double-check and I was amused that the datasheet of the 800x480 screen
claims that it can show 16.7M colors with an 18-bit interface. ;-)

Pushed to drm-misc-fixes:

876153ab068b drm/panel: simple: set bpc field for logic technologies displays

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-11-10 16:51 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 14:16 [PATCH v1] drm/panel: simple: set bpc field for logic technologies displays Francesco Dolcini
2022-08-31 14:16 ` Francesco Dolcini
2022-10-17 14:18 ` Francesco Dolcini
2022-10-17 14:18   ` Francesco Dolcini
2022-11-10 13:12   ` Francesco Dolcini
2022-11-10 13:12     ` Francesco Dolcini
2022-11-10 15:32     ` Doug Anderson
2022-11-10 15:32       ` Doug Anderson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.