* [PATCH] kernel/debug: remove unnecessary CONFIG options
@ 2022-02-21 6:19 tangmeng
2022-02-22 17:30 ` Doug Anderson
0 siblings, 1 reply; 2+ messages in thread
From: tangmeng @ 2022-02-21 6:19 UTC (permalink / raw)
To: jason.wessel, daniel.thompson, dianders
Cc: kgdb-bugreport, linux-kernel, tangmeng
In kernel/Makefile has:
obj-$(CONFIG_KGDB) += debug/
so kernel/debug/Makefile don't need this 'obj-$(CONFIG_KGDB) +=',
delete it from kernel/debug/Makefile.
Signed-off-by: tangmeng <tangmeng@uniontech.com>
---
kernel/debug/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/debug/Makefile b/kernel/debug/Makefile
index 332ee6c6ec2c..9c49ff7c75f4 100644
--- a/kernel/debug/Makefile
+++ b/kernel/debug/Makefile
@@ -3,5 +3,5 @@
# Makefile for the linux kernel debugger
#
-obj-$(CONFIG_KGDB) += debug_core.o gdbstub.o
+obj-y += debug_core.o gdbstub.o
obj-$(CONFIG_KGDB_KDB) += kdb/
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel/debug: remove unnecessary CONFIG options
2022-02-21 6:19 [PATCH] kernel/debug: remove unnecessary CONFIG options tangmeng
@ 2022-02-22 17:30 ` Doug Anderson
0 siblings, 0 replies; 2+ messages in thread
From: Doug Anderson @ 2022-02-22 17:30 UTC (permalink / raw)
To: tangmeng; +Cc: Jason Wessel, Daniel Thompson, kgdb-bugreport, LKML
Hi,
On Sun, Feb 20, 2022 at 10:20 PM tangmeng <tangmeng@uniontech.com> wrote:
>
> In kernel/Makefile has:
> obj-$(CONFIG_KGDB) += debug/
>
> so kernel/debug/Makefile don't need this 'obj-$(CONFIG_KGDB) +=',
> delete it from kernel/debug/Makefile.
>
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
> ---
> kernel/debug/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems fine to me, with the nit that your Signed-off-by is supposed to
have your "real name", not your username. See
`Documentation/process/submitting-patches.rst`. Some maintainers will
let this slide, but if you're going to submit a patch fixing a nitty
issue then it seems fair to get called out on nits. ;-)
-Doug
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-22 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 6:19 [PATCH] kernel/debug: remove unnecessary CONFIG options tangmeng
2022-02-22 17:30 ` Doug Anderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.