From: Doug Anderson <dianders@chromium.org> To: David Collins <collinsd@codeaurora.org> Cc: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-arm-msm@vger.kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org>, devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, Rajendra Nayak <rnayak@codeaurora.org>, Stephen Boyd <sboyd@kernel.org> Subject: Re: [PATCH v3 2/2] regulator: add QCOM RPMh regulator driver Date: Thu, 17 May 2018 14:23:15 -0700 [thread overview] Message-ID: <CAD=FV=UiZEFTAtO9C0UbRO=ow5=dv6zNG-XMqhHm1Fmp2GwVcA@mail.gmail.com> (raw) In-Reply-To: <3a4195365ab0d252fdf064d2300f45b9b777991c.1526088081.git.collinsd@codeaurora.org> Hi, On Fri, May 11, 2018 at 7:28 PM, David Collins <collinsd@codeaurora.org> wrote: > +static int rpmh_regulator_parse_vrm_modes(struct rpmh_vreg *vreg, > + struct device *dev, struct device_node *node) > +{ > + const char *prop; > + int i, len, ret, mode; > + u32 *buf; > + > + /* qcom,allowed-drms-modes is optional */ > + prop = "qcom,allowed-drms-modes"; As per comments in bindings patch: this is a duplicate of your new attribute you added to the regulator core. Makes no sense to have a private attribute too with the same value. > + prop = "qcom,drms-mode-max-microamps"; As per comments in the bindings patch, I think we should move "qcom,drms-mode-max-microamps" to the regulator core. > + prop = "qcom,regulator-initial-microvolt"; As per comments in bindings patch: seems like we should get rid of "qcom,regulator-initial-microvolt" or move to the core. > + /* > + * Default the voltage selector to an error value in the > + * case that qcom,regulator-initial-microvolt is not > + * specified in device tree since the true voltage is > + * not known. Note that this value causes > + * devm_regulator_register() to fail in the case that > + * regulator-min-microvolt and regulator-max-microvolt > + * are specified in device tree due to > + * machine_constraints_voltage() bailing when the > + * get_voltage_sel() callback returns this error value. > + */ > + vreg->voltage_selector = -EINVAL; As per comments in other threads, adjust this comment and use -ENOTRECOVERABLE now. NOTE: I think this driver is looking really good now. Hopefully the above things should be quick to spin (even getting "max-microamps" in the core should be quick I think) and we can get something landed! :) -Doug
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/2] regulator: add QCOM RPMh regulator driver Date: Thu, 17 May 2018 14:23:15 -0700 [thread overview] Message-ID: <CAD=FV=UiZEFTAtO9C0UbRO=ow5=dv6zNG-XMqhHm1Fmp2GwVcA@mail.gmail.com> (raw) In-Reply-To: <3a4195365ab0d252fdf064d2300f45b9b777991c.1526088081.git.collinsd@codeaurora.org> Hi, On Fri, May 11, 2018 at 7:28 PM, David Collins <collinsd@codeaurora.org> wrote: > +static int rpmh_regulator_parse_vrm_modes(struct rpmh_vreg *vreg, > + struct device *dev, struct device_node *node) > +{ > + const char *prop; > + int i, len, ret, mode; > + u32 *buf; > + > + /* qcom,allowed-drms-modes is optional */ > + prop = "qcom,allowed-drms-modes"; As per comments in bindings patch: this is a duplicate of your new attribute you added to the regulator core. Makes no sense to have a private attribute too with the same value. > + prop = "qcom,drms-mode-max-microamps"; As per comments in the bindings patch, I think we should move "qcom,drms-mode-max-microamps" to the regulator core. > + prop = "qcom,regulator-initial-microvolt"; As per comments in bindings patch: seems like we should get rid of "qcom,regulator-initial-microvolt" or move to the core. > + /* > + * Default the voltage selector to an error value in the > + * case that qcom,regulator-initial-microvolt is not > + * specified in device tree since the true voltage is > + * not known. Note that this value causes > + * devm_regulator_register() to fail in the case that > + * regulator-min-microvolt and regulator-max-microvolt > + * are specified in device tree due to > + * machine_constraints_voltage() bailing when the > + * get_voltage_sel() callback returns this error value. > + */ > + vreg->voltage_selector = -EINVAL; As per comments in other threads, adjust this comment and use -ENOTRECOVERABLE now. NOTE: I think this driver is looking really good now. Hopefully the above things should be quick to spin (even getting "max-microamps" in the core should be quick I think) and we can get something landed! :) -Doug
next prev parent reply other threads:[~2018-05-17 21:23 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-12 2:28 [PATCH v3 0/2] regulator: add QCOM RPMh regulator driver David Collins 2018-05-12 2:28 ` David Collins 2018-05-12 2:28 ` David Collins 2018-05-12 2:28 ` [PATCH v3 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings David Collins 2018-05-12 2:28 ` David Collins 2018-05-17 21:22 ` Doug Anderson 2018-05-17 21:22 ` Doug Anderson 2018-05-18 0:16 ` David Collins 2018-05-18 0:16 ` David Collins 2018-05-18 1:01 ` Doug Anderson 2018-05-18 1:01 ` Doug Anderson 2018-05-19 0:46 ` David Collins 2018-05-19 0:46 ` David Collins 2018-05-21 18:01 ` Doug Anderson 2018-05-21 18:01 ` Doug Anderson 2018-05-22 0:00 ` David Collins 2018-05-22 0:00 ` David Collins 2018-05-22 16:43 ` Doug Anderson 2018-05-22 16:43 ` Doug Anderson 2018-05-22 16:43 ` Doug Anderson 2018-05-22 16:55 ` Mark Brown 2018-05-22 16:55 ` Mark Brown 2018-05-22 22:46 ` David Collins 2018-05-22 22:46 ` David Collins 2018-05-23 0:08 ` Doug Anderson 2018-05-23 0:08 ` Doug Anderson 2018-05-23 1:19 ` David Collins 2018-05-23 1:19 ` David Collins 2018-05-23 5:10 ` Doug Anderson 2018-05-23 5:10 ` Doug Anderson 2018-05-23 8:29 ` Mark Brown 2018-05-23 8:29 ` Mark Brown 2018-05-23 15:23 ` Doug Anderson 2018-05-23 15:23 ` Doug Anderson 2018-05-23 15:40 ` Mark Brown 2018-05-23 15:40 ` Mark Brown 2018-05-23 15:50 ` Doug Anderson 2018-05-23 15:50 ` Doug Anderson 2018-05-23 15:56 ` Mark Brown 2018-05-23 15:56 ` Mark Brown 2018-05-30 5:30 ` Doug Anderson 2018-05-30 5:30 ` Doug Anderson 2018-05-30 9:37 ` Mark Brown 2018-05-30 9:37 ` Mark Brown 2018-05-30 14:46 ` Doug Anderson 2018-05-30 14:46 ` Doug Anderson 2018-05-30 15:02 ` Mark Brown 2018-05-30 15:02 ` Mark Brown 2018-05-30 15:34 ` Doug Anderson 2018-05-30 15:34 ` Doug Anderson 2018-05-30 15:48 ` Mark Brown 2018-05-30 15:48 ` Mark Brown 2018-05-30 16:06 ` Doug Anderson 2018-05-30 16:06 ` Doug Anderson 2018-05-30 16:07 ` Mark Brown 2018-05-30 16:07 ` Mark Brown 2018-05-30 16:09 ` Doug Anderson 2018-05-30 16:09 ` Doug Anderson 2018-05-30 16:13 ` Mark Brown 2018-05-30 16:13 ` Mark Brown 2018-05-30 16:31 ` Doug Anderson 2018-05-30 16:31 ` Doug Anderson 2018-05-30 16:36 ` Mark Brown 2018-05-30 16:36 ` Mark Brown 2018-05-30 16:41 ` Doug Anderson 2018-05-30 16:41 ` Doug Anderson 2018-05-30 16:41 ` Doug Anderson 2018-05-30 16:59 ` Mark Brown 2018-05-30 16:59 ` Mark Brown 2018-05-18 22:24 ` Rob Herring 2018-05-18 22:24 ` Rob Herring 2018-05-12 2:28 ` [PATCH v3 2/2] regulator: add QCOM RPMh regulator driver David Collins 2018-05-12 2:28 ` David Collins 2018-05-17 21:23 ` Doug Anderson [this message] 2018-05-17 21:23 ` Doug Anderson 2018-05-18 0:16 ` David Collins 2018-05-18 0:16 ` David Collins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAD=FV=UiZEFTAtO9C0UbRO=ow5=dv6zNG-XMqhHm1Fmp2GwVcA@mail.gmail.com' \ --to=dianders@chromium.org \ --cc=broonie@kernel.org \ --cc=collinsd@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=rnayak@codeaurora.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.