From: Doug Anderson <dianders@chromium.org>
To: Vinod Polimera <quic_vpolimer@quicinc.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
quic_kalyant <quic_kalyant@quicinc.com>
Subject: Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe
Date: Thu, 17 Mar 2022 17:11:58 -0700 [thread overview]
Message-ID: <CAD=FV=V4SWtyz4fFEmvKD_N-2ioS4R65UDZRU7utQm=0CSzp=g@mail.gmail.com> (raw)
In-Reply-To: <1647269217-14064-2-git-send-email-quic_vpolimer@quicinc.com>
Hi,
On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera
<quic_vpolimer@quicinc.com> wrote:
>
> use max clock during probe/bind sequence from the opp table.
> The clock will be scaled down when framework sends an update.
>
> Fixes: 25fdd5933("drm/msm: Add SDM845 DPU support")
The "Fixes:" format is a little wrong. Should have more digits and a
space before the parenthesis. AKA:
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
This looks good to me now other than the bad Fixes tag. I presume
you'll want to spin with the extra verbosity in the CL description
that Stephen asked for, though.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org>
To: Vinod Polimera <quic_vpolimer@quicinc.com>
Cc: quic_kalyant <quic_kalyant@quicinc.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe
Date: Thu, 17 Mar 2022 17:11:58 -0700 [thread overview]
Message-ID: <CAD=FV=V4SWtyz4fFEmvKD_N-2ioS4R65UDZRU7utQm=0CSzp=g@mail.gmail.com> (raw)
In-Reply-To: <1647269217-14064-2-git-send-email-quic_vpolimer@quicinc.com>
Hi,
On Mon, Mar 14, 2022 at 7:47 AM Vinod Polimera
<quic_vpolimer@quicinc.com> wrote:
>
> use max clock during probe/bind sequence from the opp table.
> The clock will be scaled down when framework sends an update.
>
> Fixes: 25fdd5933("drm/msm: Add SDM845 DPU support")
The "Fixes:" format is a little wrong. Should have more digits and a
space before the parenthesis. AKA:
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
This looks good to me now other than the bad Fixes tag. I presume
you'll want to spin with the extra verbosity in the CL description
that Stephen asked for, though.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2022-03-18 0:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 14:46 [PATCH v6 0/5] Update mdp clk to max supported value to support higher refresh rates Vinod Polimera
2022-03-14 14:46 ` Vinod Polimera
2022-03-14 14:46 ` [PATCH v6 1/5] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table during probe Vinod Polimera
2022-03-14 14:46 ` Vinod Polimera
2022-03-14 19:25 ` Dmitry Baryshkov
2022-03-14 19:25 ` Dmitry Baryshkov
2022-03-17 21:11 ` Stephen Boyd
2022-03-17 21:11 ` Stephen Boyd
2022-03-21 16:21 ` Vinod Polimera
2022-03-21 16:21 ` Vinod Polimera
2022-03-21 17:39 ` Dmitry Baryshkov
2022-03-21 17:39 ` Dmitry Baryshkov
2022-03-18 0:11 ` Doug Anderson [this message]
2022-03-18 0:11 ` Doug Anderson
2022-03-14 14:46 ` [PATCH v6 2/5] arm64: dts: qcom: sm7280: remove assigned-clock-rate property for mdp clk Vinod Polimera
2022-03-14 14:46 ` Vinod Polimera
2022-03-18 0:12 ` Doug Anderson
2022-03-18 0:12 ` Doug Anderson
2022-03-14 14:46 ` [PATCH v6 3/5] arm64: dts: qcom: sm7180: " Vinod Polimera
2022-03-14 14:46 ` Vinod Polimera
2022-03-18 0:12 ` Doug Anderson
2022-03-18 0:12 ` Doug Anderson
2022-03-14 14:46 ` [PATCH v6 4/5] arm64: dts: qcom: sdm845: " Vinod Polimera
2022-03-14 14:46 ` Vinod Polimera
2022-03-18 0:12 ` Doug Anderson
2022-03-18 0:12 ` Doug Anderson
2022-03-14 14:46 ` [PATCH v6 5/5] arm64: dts: qcom: sm8250: " Vinod Polimera
2022-03-14 14:46 ` Vinod Polimera
2022-03-18 0:12 ` Doug Anderson
2022-03-18 0:12 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=V4SWtyz4fFEmvKD_N-2ioS4R65UDZRU7utQm=0CSzp=g@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kalyant@quicinc.com \
--cc=quic_vpolimer@quicinc.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.