From: Doug Anderson <dianders@chromium.org> To: Kukjin Kim <kgene.kim@samsung.com> Cc: "Andreas Färber" <afaerber@suse.de>, linux-samsung-soc <linux-samsung-soc@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "Vincent Palatin" <vpalatin@chromium.org>, "Javier Martinez Canillas" <javier.martinez@collabora.co.uk>, "Tomasz Figa" <t.figa@samsung.com>, "Ben Dooks" <ben-linux@fluff.org>, "Rob Herring" <robh+dt@kernel.org>, "Pawel Moll" <pawel.moll@arm.com>, "Mark Rutland" <mark.rutland@arm.com>, "Ian Campbell" <ijc+devicetree@hellion.org.uk>, "Kumar Gala" <galak@codeaurora.org>, "Russell King" <linux@arm.linux.org.uk>, "open list" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v7] ARM: dts: Prepare node labels for exynos5250 Date: Fri, 22 Aug 2014 09:14:56 -0700 [thread overview] Message-ID: <CAD=FV=VS8e4Fs-j4CFvGYtvj58QwOk52gWh7AfnZcpswVRnDKA@mail.gmail.com> (raw) In-Reply-To: <080101cfbdf6$c8fd1f30$5af75d90$@samsung.com> Kukjin, On Fri, Aug 22, 2014 at 3:49 AM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Andreas Färber wrote: >> >> Allows them to be extended by reference. >> >> Reviewed-by: Doug Anderson <dianders@chromium.org> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> v6 -> v7: >> * Dropped uart* labels (Tomasz Figa) >> >> v6: Split off from Snow/SMDK cleanups (Doug Anderson) >> >> arch/arm/boot/dts/exynos5250.dtsi | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >> index 492e1eff37bd..42eafd19cfb2 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -218,7 +218,7 @@ >> clock-names = "fimg2d"; >> }; >> >> - codec@11000000 { >> + mfc: codec@11000000 { >> compatible = "samsung,mfc-v6"; >> reg = <0x11000000 0x10000>; >> interrupts = <0 96 0>; >> @@ -227,7 +227,7 @@ >> clock-names = "mfc"; >> }; >> >> - rtc@101E0000 { >> + rtc: rtc@101E0000 { >> clocks = <&clock CLK_RTC>; >> clock-names = "rtc"; >> status = "disabled"; >> @@ -261,7 +261,7 @@ >> clock-names = "uart", "clk_uart_baud0"; >> }; >> >> - sata@122F0000 { >> + sata: sata@122F0000 { >> compatible = "snps,dwc-ahci"; >> samsung,sata-freq = <66>; >> reg = <0x122F0000 0x1ff>; >> @@ -573,7 +573,7 @@ >> #phy-cells = <1>; >> }; >> >> - usb@12110000 { >> + ehci: usb@12110000 { > > I'm not sure which one is recommended between above and "ehci: ehci@12110000 {" My understanding is that more generic names should be used for node names. AKA: "usb" and not "ehci". "mmc" and not "dwmmc". In another thread I was pointed at ePAPR <http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf>: The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. >> - hdmi { >> + hdmi: hdmi { > > Should be > > + hdmi: hdmi@14530000 { ? Seems like that should be a followon patch.
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7] ARM: dts: Prepare node labels for exynos5250 Date: Fri, 22 Aug 2014 09:14:56 -0700 [thread overview] Message-ID: <CAD=FV=VS8e4Fs-j4CFvGYtvj58QwOk52gWh7AfnZcpswVRnDKA@mail.gmail.com> (raw) In-Reply-To: <080101cfbdf6$c8fd1f30$5af75d90$@samsung.com> Kukjin, On Fri, Aug 22, 2014 at 3:49 AM, Kukjin Kim <kgene.kim@samsung.com> wrote: > Andreas F?rber wrote: >> >> Allows them to be extended by reference. >> >> Reviewed-by: Doug Anderson <dianders@chromium.org> >> Signed-off-by: Andreas F?rber <afaerber@suse.de> >> --- >> v6 -> v7: >> * Dropped uart* labels (Tomasz Figa) >> >> v6: Split off from Snow/SMDK cleanups (Doug Anderson) >> >> arch/arm/boot/dts/exynos5250.dtsi | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >> index 492e1eff37bd..42eafd19cfb2 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -218,7 +218,7 @@ >> clock-names = "fimg2d"; >> }; >> >> - codec at 11000000 { >> + mfc: codec at 11000000 { >> compatible = "samsung,mfc-v6"; >> reg = <0x11000000 0x10000>; >> interrupts = <0 96 0>; >> @@ -227,7 +227,7 @@ >> clock-names = "mfc"; >> }; >> >> - rtc at 101E0000 { >> + rtc: rtc at 101E0000 { >> clocks = <&clock CLK_RTC>; >> clock-names = "rtc"; >> status = "disabled"; >> @@ -261,7 +261,7 @@ >> clock-names = "uart", "clk_uart_baud0"; >> }; >> >> - sata at 122F0000 { >> + sata: sata at 122F0000 { >> compatible = "snps,dwc-ahci"; >> samsung,sata-freq = <66>; >> reg = <0x122F0000 0x1ff>; >> @@ -573,7 +573,7 @@ >> #phy-cells = <1>; >> }; >> >> - usb at 12110000 { >> + ehci: usb at 12110000 { > > I'm not sure which one is recommended between above and "ehci: ehci at 12110000 {" My understanding is that more generic names should be used for node names. AKA: "usb" and not "ehci". "mmc" and not "dwmmc". In another thread I was pointed at ePAPR <http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf>: The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. >> - hdmi { >> + hdmi: hdmi { > > Should be > > + hdmi: hdmi at 14530000 { ? Seems like that should be a followon patch.
next prev parent reply other threads:[~2014-08-22 16:15 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-02 0:52 [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` [PATCH v6 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` [PATCH v6 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250 Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 4:48 ` Doug Anderson 2014-08-02 4:48 ` Doug Anderson 2014-08-02 4:48 ` Doug Anderson 2014-08-02 12:19 ` Tomasz Figa 2014-08-02 12:19 ` Tomasz Figa 2014-08-02 13:00 ` Andreas Färber 2014-08-02 13:00 ` Andreas Färber 2014-08-02 13:00 ` Andreas Färber 2014-08-20 13:06 ` Andreas Färber 2014-08-20 13:06 ` Andreas Färber 2014-08-20 13:02 ` [PATCH v7] " Andreas Färber 2014-08-20 13:02 ` Andreas Färber 2014-08-20 13:02 ` Andreas Färber 2014-08-22 10:49 ` Kukjin Kim 2014-08-22 10:49 ` Kukjin Kim 2014-08-22 11:37 ` Andreas Färber 2014-08-22 11:37 ` Andreas Färber 2014-08-22 16:14 ` Doug Anderson [this message] 2014-08-22 16:14 ` Doug Anderson 2014-08-02 0:52 ` [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 4:54 ` Doug Anderson 2014-08-02 4:54 ` Doug Anderson 2014-08-02 4:54 ` Doug Anderson 2014-08-02 12:21 ` Tomasz Figa 2014-08-02 12:21 ` Tomasz Figa 2014-08-02 12:56 ` Tomasz Figa 2014-08-02 12:56 ` Tomasz Figa 2014-08-02 13:08 ` Andreas Färber 2014-08-02 13:08 ` Andreas Färber 2014-08-02 13:09 ` Tomasz Figa 2014-08-02 13:09 ` Tomasz Figa 2014-08-02 0:52 ` [PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 2:17 ` Javier Martinez Canillas 2014-08-02 2:17 ` Javier Martinez Canillas 2014-08-02 0:52 ` [PATCH v6 06/10] ARM: dts: Clean up exynos5250-smdk5250 Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 12:57 ` Tomasz Figa 2014-08-02 12:57 ` Tomasz Figa 2014-08-02 0:52 ` [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 13:02 ` Tomasz Figa 2014-08-02 13:02 ` Tomasz Figa 2014-08-02 13:02 ` Tomasz Figa 2014-08-02 13:10 ` Andreas Färber 2014-08-02 13:10 ` Andreas Färber 2014-08-02 0:52 ` [PATCH v6 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` [PATCH v6 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 0:52 ` Andreas Färber 2014-08-02 13:18 ` Tomasz Figa 2014-08-02 13:18 ` Tomasz Figa 2014-08-04 15:22 ` Doug Anderson 2014-08-04 15:22 ` Doug Anderson 2014-08-04 15:22 ` Doug Anderson 2014-08-04 17:31 ` Javier Martinez Canillas 2014-08-04 17:31 ` Javier Martinez Canillas 2014-08-04 17:31 ` Javier Martinez Canillas 2014-08-20 12:50 ` Andreas Färber 2014-08-20 12:50 ` Andreas Färber 2014-08-20 12:50 ` Andreas Färber 2014-08-02 2:34 ` [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring Javier Martinez Canillas 2014-08-02 2:34 ` Javier Martinez Canillas 2014-08-02 4:57 ` Doug Anderson 2014-08-02 4:57 ` Doug Anderson 2014-08-02 10:25 ` Andreas Färber 2014-08-02 10:25 ` Andreas Färber 2014-08-02 13:13 ` Tomasz Figa 2014-08-02 13:13 ` Tomasz Figa 2014-08-02 16:05 ` Andreas Färber 2014-08-02 16:05 ` Andreas Färber 2014-08-04 15:42 ` Doug Anderson 2014-08-04 15:42 ` Doug Anderson 2014-08-04 17:43 ` Javier Martinez Canillas 2014-08-04 17:43 ` Javier Martinez Canillas 2014-08-07 8:40 ` Javier Martinez Canillas 2014-08-07 8:40 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAD=FV=VS8e4Fs-j4CFvGYtvj58QwOk52gWh7AfnZcpswVRnDKA@mail.gmail.com' \ --to=dianders@chromium.org \ --cc=afaerber@suse.de \ --cc=ben-linux@fluff.org \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=javier.martinez@collabora.co.uk \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=t.figa@samsung.com \ --cc=vpalatin@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.