From: Doug Anderson <dianders@chromium.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Chris Zhong" <zyw@rock-chips.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Mike Turquette" <mturquette@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
"Grant Likely" <grant.likely@linaro.org>,
"Lin Huang" <hl@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>,
"Eddie Cai" <cf@rock-chips.com>,
zhangqing <zhangqing@rock-chips.com>, xxx <xxx@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Olof Johansson" <olof@lixom.net>,
"Sonny Rao" <sonnyrao@chromium.org>,
"Dmitry Torokhov" <dtor@chromium.org>,
"Javier Martinez Canillas" <javier.martinez@collabora.co.uk>,
"Kever Yang" <kever.yang@rock-chips.com>
Subject: Re: [PATCH v3 2/5] MFD: RK808: Add new mfd driver for RK808
Date: Thu, 21 Aug 2014 08:41:23 -0700 [thread overview]
Message-ID: <CAD=FV=VYy5sgLmjUfUGe0ai=wMBFHROLK6yKvMzfmundWSMiCA@mail.gmail.com> (raw)
In-Reply-To: <20140821153836.GO4266@lee--X1>
Lee,
On Thu, Aug 21, 2014 at 8:38 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Thu, 21 Aug 2014, Chris Zhong wrote:
>> The RK808 chip is a power management IC for multimedia and handheld
>> devices. It contains the following components:
>>
>> - Regulators
>> - RTC
>>
>> The rk808 core driver is registered as a platform driver and provides
>> communication through I2C with the host device for the different
>> components.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>>
>> ---
>>
>> Changes in v3: None
>
> Why haven't you fixed up my review comments?
I saw in a private message from Chris that his v2 was actually the
wrong version (an old branch from his tree) by mistake. His v3 is
what v2 was supposed to be. He didn't have time to fixup review
comments yet (he just wanted to send the correct v2), so expect a v4.
Chris: you probably should have included that somewhere in your email
on the lists so people weren't confused.
-Doug
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Chris Zhong" <zyw@rock-chips.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Mike Turquette" <mturquette@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
rtc-linux@googlegroups.com,
"Grant Likely" <grant.likely@linaro.org>,
"Lin Huang" <hl@rock-chips.com>,
"Tao Huang" <huangtao@rock-chips.com>,
"Eddie Cai" <cf@rock-chips.com>,
zhangqing <zhangqing@rock-chips.com>, xxx <xxx@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Olof Johansson" <olof@lixom.net>, "Sonny Rao" <sonnyrao@chr>
Subject: Re: [PATCH v3 2/5] MFD: RK808: Add new mfd driver for RK808
Date: Thu, 21 Aug 2014 08:41:23 -0700 [thread overview]
Message-ID: <CAD=FV=VYy5sgLmjUfUGe0ai=wMBFHROLK6yKvMzfmundWSMiCA@mail.gmail.com> (raw)
In-Reply-To: <20140821153836.GO4266@lee--X1>
Lee,
On Thu, Aug 21, 2014 at 8:38 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Thu, 21 Aug 2014, Chris Zhong wrote:
>> The RK808 chip is a power management IC for multimedia and handheld
>> devices. It contains the following components:
>>
>> - Regulators
>> - RTC
>>
>> The rk808 core driver is registered as a platform driver and provides
>> communication through I2C with the host device for the different
>> components.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>>
>> ---
>>
>> Changes in v3: None
>
> Why haven't you fixed up my review comments?
I saw in a private message from Chris that his v2 was actually the
wrong version (an old branch from his tree) by mistake. His v3 is
what v2 was supposed to be. He didn't have time to fixup review
comments yet (he just wanted to send the correct v2), so expect a v4.
Chris: you probably should have included that somewhere in your email
on the lists so people weren't confused.
-Doug
next prev parent reply other threads:[~2014-08-21 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 13:30 [PATCH v3 2/5] MFD: RK808: Add new mfd driver for RK808 Chris Zhong
2014-08-21 13:30 ` Chris Zhong
2014-08-21 15:38 ` Lee Jones
2014-08-21 15:41 ` Doug Anderson [this message]
2014-08-21 15:41 ` Doug Anderson
2014-08-22 16:21 ` Dmitry Torokhov
2014-08-23 10:31 Chris Zhong
2014-08-23 10:31 ` Chris Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VYy5sgLmjUfUGe0ai=wMBFHROLK6yKvMzfmundWSMiCA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@chromium.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kever.yang@rock-chips.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=sonnyrao@chromium.org \
--cc=xxx@rock-chips.com \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.