All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Vikas Sajjan <vikas.sajjan@linaro.org>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Tomasz Figa <t.figa@samsung.com>,
	Yadwinder Singh Brar <yadi.brar01@gmail.com>,
	Mike Turquette <mturquette@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	Patch Tracking <patches@linaro.org>,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v2 3/5] clk: samsung: Add set_rate() clk_ops for PLL35xx
Date: Thu, 30 May 2013 09:25:29 -0700	[thread overview]
Message-ID: <CAD=FV=VnrVAR6Uiy9VXAhbPLQxzeuQXZ3m0WQ6YhJzehaUdBog@mail.gmail.com> (raw)
In-Reply-To: <1369834677-20312-4-git-send-email-vikas.sajjan@linaro.org>

Vikas / Yadwinder,

On Wed, May 29, 2013 at 6:37 AM, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> From: Yadwinder Singh Brar <yadi.brar@samsung.com>
>
> This patch add set_rate() and round_rate() for PLL35xx
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> ---
>  drivers/clk/samsung/clk-pll.c |  103 ++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 102 insertions(+), 1 deletion(-)
[ cut ]
> +#define PLL35XX_LOCK_STAT_MASK  (0x1)

optional: Mask is _slightly_ overkill here. Could just assume that
it's a 1-bit thing and do (1 << PLL35XX_LOCK_STAT_SHIFT).


All comments are optional, so feel free to add my Reviewed-by:

Reviewed-by: Doug Anderson <dianders@chromium.org>

WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] clk: samsung: Add set_rate() clk_ops for PLL35xx
Date: Thu, 30 May 2013 09:25:29 -0700	[thread overview]
Message-ID: <CAD=FV=VnrVAR6Uiy9VXAhbPLQxzeuQXZ3m0WQ6YhJzehaUdBog@mail.gmail.com> (raw)
In-Reply-To: <1369834677-20312-4-git-send-email-vikas.sajjan@linaro.org>

Vikas / Yadwinder,

On Wed, May 29, 2013 at 6:37 AM, Vikas Sajjan <vikas.sajjan@linaro.org> wrote:
> From: Yadwinder Singh Brar <yadi.brar@samsung.com>
>
> This patch add set_rate() and round_rate() for PLL35xx
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> ---
>  drivers/clk/samsung/clk-pll.c |  103 ++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 102 insertions(+), 1 deletion(-)
[ cut ]
> +#define PLL35XX_LOCK_STAT_MASK  (0x1)

optional: Mask is _slightly_ overkill here. Could just assume that
it's a 1-bit thing and do (1 << PLL35XX_LOCK_STAT_SHIFT).


All comments are optional, so feel free to add my Reviewed-by:

Reviewed-by: Doug Anderson <dianders@chromium.org>

  reply	other threads:[~2013-05-30 16:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29 13:37 [PATCH v2 0/5] Add generic set_rate clk_ops for PLL35xx and PLL36xx for samsung SoCs Vikas Sajjan
2013-05-29 13:37 ` Vikas Sajjan
2013-05-29 13:37 ` [PATCH v2 1/5] clk: samsung: Use clk->base instead of directly using clk->con0 for PLL3xxx Vikas Sajjan
2013-05-29 13:37   ` Vikas Sajjan
2013-05-29 17:58   ` Doug Anderson
2013-05-29 17:58     ` Doug Anderson
2013-05-29 13:37 ` [PATCH v2 2/5] clk: samsung: Add support to register rate_table " Vikas Sajjan
2013-05-29 13:37   ` Vikas Sajjan
2013-05-29 23:44   ` Doug Anderson
2013-05-29 23:44     ` Doug Anderson
2013-05-30  6:55     ` Yadwinder Singh Brar
2013-05-30  6:55       ` Yadwinder Singh Brar
2013-05-30 15:55       ` Doug Anderson
2013-05-30 15:55         ` Doug Anderson
2013-06-03 15:25       ` Tomasz Figa
2013-06-03 15:25         ` Tomasz Figa
2013-06-03 20:58         ` Doug Anderson
2013-06-03 20:58           ` Doug Anderson
2013-06-04 11:32         ` Yadwinder Singh Brar
2013-06-04 11:32           ` Yadwinder Singh Brar
2013-06-05 13:40           ` Tomasz Figa
2013-06-05 13:40             ` Tomasz Figa
2013-06-06  9:01             ` Yadwinder Singh Brar
2013-06-06  9:01               ` Yadwinder Singh Brar
2013-06-08 11:58               ` Tomasz Figa
2013-06-08 11:58                 ` Tomasz Figa
2013-05-29 13:37 ` [PATCH v2 3/5] clk: samsung: Add set_rate() clk_ops for PLL35xx Vikas Sajjan
2013-05-29 13:37   ` Vikas Sajjan
2013-05-30 16:25   ` Doug Anderson [this message]
2013-05-30 16:25     ` Doug Anderson
2013-05-29 13:37 ` [PATCH v2 4/5] clk: samsung: Add set_rate() clk_ops for PLL36xx Vikas Sajjan
2013-05-29 13:37   ` Vikas Sajjan
2013-05-30 16:50   ` Doug Anderson
2013-05-30 16:50     ` Doug Anderson
2013-05-29 13:37 ` [PATCH v2 5/5] clk: samsung: Add EPLL and VPLL freq table for exynos5250 SoC Vikas Sajjan
2013-05-29 13:37   ` Vikas Sajjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=VnrVAR6Uiy9VXAhbPLQxzeuQXZ3m0WQ6YhJzehaUdBog@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=kgene.kim@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=patches@linaro.org \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    --cc=vikas.sajjan@linaro.org \
    --cc=yadi.brar01@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.