From: Doug Anderson <dianders@chromium.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
"Ravi Kumar Bokka (Temp)" <rbokka@codeaurora.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: nvmem: qfprom: Add optional power-domains property
Date: Thu, 29 Jul 2021 09:19:20 -0700 [thread overview]
Message-ID: <CAD=FV=Vtp0HGFpoS4cdZOQ0GUBbhiyw=TuYxWNTGVAyMUKMhvQ@mail.gmail.com> (raw)
In-Reply-To: <1627560036-1626-2-git-send-email-rnayak@codeaurora.org>
Hi,
On Thu, Jul 29, 2021 at 5:01 AM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>
> qfprom devices on some SoCs need to vote on the performance state
> of a power-domain, so add the power-domains optional property to the
> bindings
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> index 861b205..a498a08 100644
> --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> @@ -51,6 +51,9 @@ properties:
> vcc-supply:
> description: Our power supply.
>
> + power-domains:
> + description: A phandle to a power domain node.
> +
I'm trying to channel my inner Rob here by saying that this
description doesn't add anything and this should just be:
power-domains:
maxItems: 1
Here's an example of Rob saying this:
https://lore.kernel.org/linux-devicetree/20210712151322.GA1931925@robh.at.kernel.org/
Other than that, feel free to add my "Reviewed-by" tag.
-Doug
next prev parent reply other threads:[~2021-07-29 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 12:00 [PATCH v2 0/3] nvmem: qfprom: Add binding updates and power-domain handling Rajendra Nayak
2021-07-29 12:00 ` [PATCH v2 1/3] dt-bindings: nvmem: qfprom: Add optional power-domains property Rajendra Nayak
2021-07-29 16:19 ` Doug Anderson [this message]
2021-07-30 5:57 ` Rajendra Nayak
2021-07-29 12:00 ` [PATCH v2 2/3] nvmem: qfprom: sc7280: Handle the additional power-domains vote Rajendra Nayak
2021-07-29 16:07 ` Doug Anderson
2021-07-30 5:55 ` Rajendra Nayak
2021-07-29 12:00 ` [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add qfprom node Rajendra Nayak
2021-07-29 16:24 ` Doug Anderson
2021-07-30 5:58 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Vtp0HGFpoS4cdZOQ0GUBbhiyw=TuYxWNTGVAyMUKMhvQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rbokka@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.