All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Frank Mori Hess <fmh6jj@gmail.com>
Cc: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	John Youn <John.Youn@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"# 4.0+" <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc2: Fix shutdown callback in platform
Date: Fri, 29 May 2020 12:46:26 -0700	[thread overview]
Message-ID: <CAD=FV=VuX6pAtU+3-uXAJ8sXecbuiRNDj6RP36Xkyp-_G85-VA@mail.gmail.com> (raw)
In-Reply-To: <CAJz5OpcP860ANLLZELB7GNSsGAY2SvataZVAMyQj_HG0udkOmg@mail.gmail.com>

Hi,

On Fri, May 29, 2020 at 12:45 PM Frank Mori Hess <fmh6jj@gmail.com> wrote:
>
> On Fri, May 29, 2020 at 3:33 PM Minas Harutyunyan
> <Minas.Harutyunyan@synopsys.com> wrote:
> > So, can we conclude on this solution?
> >
> > dwc2_disable_global_interrupts(hsotg);
> > synchronize_irq(hsotg->irq)
>
> That solution is fine with me.  Disabling the dwc2 interrupt sources
> in initialization before the handlers are registered is also worth
> doing, but it doesn't have to be in the same patch.

Sounds fine to me.

-Doug

  reply	other threads:[~2020-05-29 19:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29 11:56 [PATCH] usb: dwc2: Fix shutdown callback in platform Minas Harutyunyan
2020-05-29 14:49 ` Doug Anderson
     [not found]   ` <0f6b1580-41d8-b7e7-206b-64cda87abfd5@synopsys.com>
2020-05-29 16:37     ` Doug Anderson
2020-05-29 17:44       ` Frank Mori Hess
2020-05-29 17:52         ` Doug Anderson
2020-05-29 18:21           ` Frank Mori Hess
2020-05-29 18:45             ` Doug Anderson
2020-05-29 19:00               ` Alan Stern
2020-05-29 19:07                 ` Doug Anderson
     [not found]                   ` <52f936c5-7f3f-5da0-33b8-3e6d4a4008d1@synopsys.com>
2020-05-29 19:45                     ` Frank Mori Hess
2020-05-29 19:46                       ` Doug Anderson [this message]
     [not found]                         ` <f68ce0c2-7014-64ff-73e3-94d93897e3b2@synopsys.com>
2020-05-29 20:29                           ` Frank Mori Hess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=VuX6pAtU+3-uXAJ8sXecbuiRNDj6RP36Xkyp-_G85-VA@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=John.Youn@synopsys.com \
    --cc=Minas.Harutyunyan@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=fmh6jj@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.