* [PATCH] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU
@ 2019-04-24 16:28 ` Matthias Kaehlcke
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-04-24 16:28 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
The Mali GPU of the rk3288 can be used as cooling device, add
a #cooling-cells entry for it.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
arch/arm/boot/dts/rk3288.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index ca7d52daa8fb..767e62908a6e 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -1275,6 +1275,7 @@
interrupt-names = "job", "mmu", "gpu";
clocks = <&cru ACLK_GPU>;
operating-points-v2 = <&gpu_opp_table>;
+ #cooling-cells = <2>; /* min followed by max */
power-domains = <&power RK3288_PD_GPU>;
status = "disabled";
};
--
2.21.0.593.g511ec345e18-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU
@ 2019-04-24 16:28 ` Matthias Kaehlcke
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Kaehlcke @ 2019-04-24 16:28 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: devicetree, Douglas Anderson, linux-kernel, linux-rockchip,
Matthias Kaehlcke, linux-arm-kernel
The Mali GPU of the rk3288 can be used as cooling device, add
a #cooling-cells entry for it.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
arch/arm/boot/dts/rk3288.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index ca7d52daa8fb..767e62908a6e 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -1275,6 +1275,7 @@
interrupt-names = "job", "mmu", "gpu";
clocks = <&cru ACLK_GPU>;
operating-points-v2 = <&gpu_opp_table>;
+ #cooling-cells = <2>; /* min followed by max */
power-domains = <&power RK3288_PD_GPU>;
status = "disabled";
};
--
2.21.0.593.g511ec345e18-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU
2019-04-24 16:28 ` Matthias Kaehlcke
@ 2019-05-15 17:59 ` Doug Anderson
-1 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2019-05-15 17:59 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
open list:ARM/Rockchip SoC...,
devicetree, LKML
Hi,
On Wed, Apr 24, 2019 at 9:28 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> The Mali GPU of the rk3288 can be used as cooling device, add
> a #cooling-cells entry for it.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index ca7d52daa8fb..767e62908a6e 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1275,6 +1275,7 @@
> interrupt-names = "job", "mmu", "gpu";
> clocks = <&cru ACLK_GPU>;
> operating-points-v2 = <&gpu_opp_table>;
> + #cooling-cells = <2>; /* min followed by max */
> power-domains = <&power RK3288_PD_GPU>;
> status = "disabled";
> };
Seems like a good idea to me. Presumably we should also add this to
the bindings?
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU
@ 2019-05-15 17:59 ` Doug Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2019-05-15 17:59 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Mark Rutland, devicetree, Heiko Stuebner, LKML,
open list:ARM/Rockchip SoC...,
Rob Herring, Linux ARM
Hi,
On Wed, Apr 24, 2019 at 9:28 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> The Mali GPU of the rk3288 can be used as cooling device, add
> a #cooling-cells entry for it.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> arch/arm/boot/dts/rk3288.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index ca7d52daa8fb..767e62908a6e 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -1275,6 +1275,7 @@
> interrupt-names = "job", "mmu", "gpu";
> clocks = <&cru ACLK_GPU>;
> operating-points-v2 = <&gpu_opp_table>;
> + #cooling-cells = <2>; /* min followed by max */
> power-domains = <&power RK3288_PD_GPU>;
> status = "disabled";
> };
Seems like a good idea to me. Presumably we should also add this to
the bindings?
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU
2019-05-15 17:59 ` Doug Anderson
@ 2019-05-15 18:43 ` Doug Anderson
-1 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2019-05-15 18:43 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
open list:ARM/Rockchip SoC...,
devicetree, LKML
Hi,
On Wed, May 15, 2019 at 10:59 AM Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Wed, Apr 24, 2019 at 9:28 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> > The Mali GPU of the rk3288 can be used as cooling device, add
> > a #cooling-cells entry for it.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > arch/arm/boot/dts/rk3288.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> > index ca7d52daa8fb..767e62908a6e 100644
> > --- a/arch/arm/boot/dts/rk3288.dtsi
> > +++ b/arch/arm/boot/dts/rk3288.dtsi
> > @@ -1275,6 +1275,7 @@
> > interrupt-names = "job", "mmu", "gpu";
> > clocks = <&cru ACLK_GPU>;
> > operating-points-v2 = <&gpu_opp_table>;
> > + #cooling-cells = <2>; /* min followed by max */
> > power-domains = <&power RK3288_PD_GPU>;
> > status = "disabled";
> > };
>
> Seems like a good idea to me. Presumably we should also add this to
> the bindings?
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
I guess we could now also do a follow-up CL that starts using the GPU
as a cooling device. Presumably it's still OK to specify this and it
will just be ignored if there's no GPU driver? It's a little funny
because the upstream device tree uses the CPU to cool things down if
the GPU temperature sensor trips. Downstream uses the GPU to cool
down the GPU. ...though, of course, it's not really all that simple
since everything is packed in so tightly.
The other case that sticks as a sore thumb is the upstream
"rk3288-veyron-mickey" where all the comments still talk about the GPU
cooling but we have only the CPU cooling actually in the device tree.
:-)
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU
@ 2019-05-15 18:43 ` Doug Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2019-05-15 18:43 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Mark Rutland, devicetree, Heiko Stuebner, LKML,
open list:ARM/Rockchip SoC...,
Rob Herring, Linux ARM
Hi,
On Wed, May 15, 2019 at 10:59 AM Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Wed, Apr 24, 2019 at 9:28 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> > The Mali GPU of the rk3288 can be used as cooling device, add
> > a #cooling-cells entry for it.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > arch/arm/boot/dts/rk3288.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> > index ca7d52daa8fb..767e62908a6e 100644
> > --- a/arch/arm/boot/dts/rk3288.dtsi
> > +++ b/arch/arm/boot/dts/rk3288.dtsi
> > @@ -1275,6 +1275,7 @@
> > interrupt-names = "job", "mmu", "gpu";
> > clocks = <&cru ACLK_GPU>;
> > operating-points-v2 = <&gpu_opp_table>;
> > + #cooling-cells = <2>; /* min followed by max */
> > power-domains = <&power RK3288_PD_GPU>;
> > status = "disabled";
> > };
>
> Seems like a good idea to me. Presumably we should also add this to
> the bindings?
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
I guess we could now also do a follow-up CL that starts using the GPU
as a cooling device. Presumably it's still OK to specify this and it
will just be ignored if there's no GPU driver? It's a little funny
because the upstream device tree uses the CPU to cool things down if
the GPU temperature sensor trips. Downstream uses the GPU to cool
down the GPU. ...though, of course, it's not really all that simple
since everything is packed in so tightly.
The other case that sticks as a sore thumb is the upstream
"rk3288-veyron-mickey" where all the comments still talk about the GPU
cooling but we have only the CPU cooling actually in the device tree.
:-)
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-15 18:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 16:28 [PATCH] ARM: dts: rockchip: Add #cooling-cells entry for rk3288 GPU Matthias Kaehlcke
2019-04-24 16:28 ` Matthias Kaehlcke
2019-05-15 17:59 ` Doug Anderson
2019-05-15 17:59 ` Doug Anderson
2019-05-15 18:43 ` Doug Anderson
2019-05-15 18:43 ` Doug Anderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.