* [PATCH] remoteproc: Fix wrong rvring index computation
@ 2019-10-04 7:37 Clement Leger
2019-11-21 18:20 ` patchwork-bot+linux-remoteproc
2020-04-29 23:26 ` Doug Anderson
0 siblings, 2 replies; 4+ messages in thread
From: Clement Leger @ 2019-10-04 7:37 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc, linux-kernel
Cc: Clement Leger
Index of rvring is computed using pointer arithmetic. However, since
rvring->rvdev->vring is the base of the vring array, computation
of rvring idx should be reversed. It previously lead to writing at negative
indices in the resource table.
Signed-off-by: Clement Leger <cleger@kalray.eu>
---
drivers/remoteproc/remoteproc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 3c5fbbbfb0f1..ab7443874635 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -400,7 +400,7 @@ rproc_parse_vring(struct rproc_vdev *rvdev, struct fw_rsc_vdev *rsc, int i)
void rproc_free_vring(struct rproc_vring *rvring)
{
struct rproc *rproc = rvring->rvdev->rproc;
- int idx = rvring->rvdev->vring - rvring;
+ int idx = rvring - rvring->rvdev->vring;
struct fw_rsc_vdev *rsc;
idr_remove(&rproc->notifyids, rvring->notifyid);
--
2.15.0.276.g89ea799
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: Fix wrong rvring index computation
2019-10-04 7:37 [PATCH] remoteproc: Fix wrong rvring index computation Clement Leger
@ 2019-11-21 18:20 ` patchwork-bot+linux-remoteproc
2020-04-29 23:26 ` Doug Anderson
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2019-11-21 18:20 UTC (permalink / raw)
To: Clement Leger; +Cc: linux-remoteproc
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next).
On Fri, 4 Oct 2019 09:37:36 +0200 you wrote:
> Index of rvring is computed using pointer arithmetic. However, since
> rvring->rvdev->vring is the base of the vring array, computation
> of rvring idx should be reversed. It previously lead to writing at negative
> indices in the resource table.
>
> Signed-off-by: Clement Leger <cleger@kalray.eu>
>
> [...]
Here is a summary with links:
- remoteproc: Fix wrong rvring index computation
https://git.kernel.org/andersson/remoteproc/c/00a0eec59ddbb1ce966b19097d8a8d2f777e726a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: Fix wrong rvring index computation
2019-10-04 7:37 [PATCH] remoteproc: Fix wrong rvring index computation Clement Leger
2019-11-21 18:20 ` patchwork-bot+linux-remoteproc
@ 2020-04-29 23:26 ` Doug Anderson
2020-04-30 6:42 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2020-04-29 23:26 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc, LKML
Cc: Clement Leger, stable, Evan Green
Hi,
On Fri, 4 Oct 2019 Clement Leger <cleger@kalray.eu> wrote:
>
> Index of rvring is computed using pointer arithmetic. However, since
> rvring->rvdev->vring is the base of the vring array, computation
> of rvring idx should be reversed. It previously lead to writing at negative
> indices in the resource table.
>
> Signed-off-by: Clement Leger <cleger@kalray.eu>
> ---
> drivers/remoteproc/remoteproc_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Randomly stumbled upon this in a list of patches. This patch landed
in mainline as:
00a0eec59ddb remoteproc: Fix wrong rvring index computation
Should it be queued up for stable? I'm guessing:
Fixes: c0d631570ad5 ("remoteproc: set vring addresses in resource table")
-Doug
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: Fix wrong rvring index computation
2020-04-29 23:26 ` Doug Anderson
@ 2020-04-30 6:42 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-04-30 6:42 UTC (permalink / raw)
To: Doug Anderson
Cc: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc, LKML,
Clement Leger, stable, Evan Green
On Wed, Apr 29, 2020 at 04:26:41PM -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, 4 Oct 2019 Clement Leger <cleger@kalray.eu> wrote:
> >
> > Index of rvring is computed using pointer arithmetic. However, since
> > rvring->rvdev->vring is the base of the vring array, computation
> > of rvring idx should be reversed. It previously lead to writing at negative
> > indices in the resource table.
> >
> > Signed-off-by: Clement Leger <cleger@kalray.eu>
> > ---
> > drivers/remoteproc/remoteproc_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Randomly stumbled upon this in a list of patches. This patch landed
> in mainline as:
>
> 00a0eec59ddb remoteproc: Fix wrong rvring index computation
>
> Should it be queued up for stable? I'm guessing:
>
> Fixes: c0d631570ad5 ("remoteproc: set vring addresses in resource table")
Thanks, now queued up.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-30 6:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 7:37 [PATCH] remoteproc: Fix wrong rvring index computation Clement Leger
2019-11-21 18:20 ` patchwork-bot+linux-remoteproc
2020-04-29 23:26 ` Doug Anderson
2020-04-30 6:42 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.