From: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Cc: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-arm-msm
<linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
dri-devel
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Bjorn Andersson
<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
freedreno
<freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Georgi Djakov
<georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Linux ARM
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes
Date: Wed, 17 Oct 2018 11:28:38 -0700 [thread overview]
Message-ID: <CAD=FV=WzkRtcdy_=eatp=AEkJ54d=qvNGzNYCMCMnVAWtrXAQg@mail.gmail.com> (raw)
In-Reply-To: <20180827151112.25211-6-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Hi,
On Mon, Aug 27, 2018 at 8:11 AM Jordan Crouse <jcrouse@codeaurora.org> wrote:
> + gpu@5000000 {
> + compatible = "qcom,adreno-630.2", "qcom,adreno";
> + #stream-id-cells = <16>;
> +
> + reg = <0x5000000 0x40000>;
> + reg-names = "kgsl_3d0_reg_memory";
> +
> + /*
> + * Look ma, no clocks! The GPU clocks and power are
> + * controlled entirely by the GMU
> + */
> +
> + interrupts = <0 300 0>;
> + interrupt-names = "kgsl_3d0_irq";
Drive-by feedback here. The "interrupts" above should be:
interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
* GIC_SPI is 0, but GIC_SPI is more documenting.
* having 0 for the final element means 'IRQ_TYPE_NONE'. On newer
kernels commit 6ef6386ef7c1 ("irqchip/gic-v3: Loudly complain about
the use of IRQ_TYPE_NONE") will cause loud yells if you do this. This
turns out to be a bit silly because (IIUC) the flags in the device
tree are totally ignored if the driver passes in flags itself [1].
...but I guess we should do it right. I believe the code requesting
this irq is a6xx_gmu_get_irq() which requests a level high interrupt,
so we should list level high here.
[1] https://lore.kernel.org/lkml/CAD=FV=XmiOh0Mg0f4a=W0NCH8eb--OQhP2jNAv2ZMpUBOn9n6Q@mail.gmail.com/T/#u
-Doug
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: dianders@chromium.org (Doug Anderson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes
Date: Wed, 17 Oct 2018 11:28:38 -0700 [thread overview]
Message-ID: <CAD=FV=WzkRtcdy_=eatp=AEkJ54d=qvNGzNYCMCMnVAWtrXAQg@mail.gmail.com> (raw)
In-Reply-To: <20180827151112.25211-6-jcrouse@codeaurora.org>
Hi,
On Mon, Aug 27, 2018 at 8:11 AM Jordan Crouse <jcrouse@codeaurora.org> wrote:
> + gpu at 5000000 {
> + compatible = "qcom,adreno-630.2", "qcom,adreno";
> + #stream-id-cells = <16>;
> +
> + reg = <0x5000000 0x40000>;
> + reg-names = "kgsl_3d0_reg_memory";
> +
> + /*
> + * Look ma, no clocks! The GPU clocks and power are
> + * controlled entirely by the GMU
> + */
> +
> + interrupts = <0 300 0>;
> + interrupt-names = "kgsl_3d0_irq";
Drive-by feedback here. The "interrupts" above should be:
interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
* GIC_SPI is 0, but GIC_SPI is more documenting.
* having 0 for the final element means 'IRQ_TYPE_NONE'. On newer
kernels commit 6ef6386ef7c1 ("irqchip/gic-v3: Loudly complain about
the use of IRQ_TYPE_NONE") will cause loud yells if you do this. This
turns out to be a bit silly because (IIUC) the flags in the device
tree are totally ignored if the driver passes in flags itself [1].
...but I guess we should do it right. I believe the code requesting
this irq is a6xx_gmu_get_irq() which requests a level high interrupt,
so we should list level high here.
[1] https://lore.kernel.org/lkml/CAD=FV=XmiOh0Mg0f4a=W0NCH8eb--OQhP2jNAv2ZMpUBOn9n6Q at mail.gmail.com/T/#u
-Doug
next prev parent reply other threads:[~2018-10-17 18:28 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 15:11 [PATCH 0/9] Add interconnect support + bindings for A630 GPU Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
2018-08-27 15:11 ` [PATCH 2/9] drm/msm/a6xx: Fix PDC register overlap Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
2018-08-27 15:11 ` [PATCH 4/9] dt-bindings: Document qcom,adreno-gmu Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
[not found] ` <20180827151112.25211-1-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-08-27 15:11 ` [PATCH 1/9] drm/msm/a6xx: rnndb updates for a6xx Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
2018-08-27 15:11 ` [PATCH 3/9] drm/msm/a6xx: Rename gmu phandle to qcom, gmu Jordan Crouse
2018-08-27 15:11 ` [PATCH 3/9] drm/msm/a6xx: Rename gmu phandle to qcom,gmu Jordan Crouse
2018-08-27 15:11 ` [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
[not found] ` <20180827151112.25211-6-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-08-28 10:30 ` Vivek Gautam
2018-08-28 10:30 ` Vivek Gautam
2018-10-10 9:46 ` Viresh Kumar
2018-10-10 9:46 ` Viresh Kumar
2018-10-10 14:29 ` Jordan Crouse
2018-10-10 14:29 ` Jordan Crouse
[not found] ` <20181010142905.GB9977-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org>
2018-10-10 14:31 ` Viresh Kumar
2018-10-10 14:31 ` Viresh Kumar
2018-10-10 14:48 ` Jordan Crouse
2018-10-10 14:48 ` [Freedreno] " Jordan Crouse
[not found] ` <20181010144856.GC9977-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org>
2018-10-10 14:51 ` Viresh Kumar
2018-10-10 14:51 ` [Freedreno] " Viresh Kumar
2018-10-10 15:10 ` Jordan Crouse
2018-10-10 15:10 ` [Freedreno] " Jordan Crouse
[not found] ` <20181010151006.GD9977-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org>
2018-10-11 5:02 ` Viresh Kumar
2018-10-11 5:02 ` [Freedreno] " Viresh Kumar
2018-10-11 14:54 ` Jordan Crouse
2018-10-11 14:54 ` [Freedreno] " Jordan Crouse
[not found] ` <20181011145456.GG9977-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org>
2018-10-15 10:03 ` Viresh Kumar
2018-10-15 10:03 ` [Freedreno] " Viresh Kumar
2018-10-15 14:34 ` Jordan Crouse
2018-10-15 14:34 ` [Freedreno] " Jordan Crouse
[not found] ` <20181015143444.GA4751-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org>
2018-10-22 10:38 ` Viresh Kumar
2018-10-22 10:38 ` [Freedreno] " Viresh Kumar
2018-10-22 13:20 ` Niklas Cassel
2018-10-22 13:20 ` Niklas Cassel
2018-10-22 14:37 ` Jordan Crouse
2018-10-22 14:37 ` Jordan Crouse
2018-10-22 14:34 ` Jordan Crouse
2018-10-22 14:34 ` Jordan Crouse
2018-10-17 18:28 ` Doug Anderson [this message]
2018-10-17 18:28 ` Doug Anderson
2018-08-27 15:11 ` [PATCH 6/9] PM / OPP: dt-bindings: Add opp-interconnect-bw Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
2018-09-27 8:23 ` Georgi Djakov
2018-09-27 8:23 ` Georgi Djakov
[not found] ` <0998a374-6cb0-9218-d2e3-92f8ee9861ed-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-10-10 9:59 ` Viresh Kumar
2018-10-10 9:59 ` Viresh Kumar
2018-10-10 14:27 ` Jordan Crouse
2018-10-10 14:27 ` Jordan Crouse
[not found] ` <20181010142723.GA9977-9PYrDHPZ2Orvke4nUoYGnHL1okKdlPRT@public.gmane.org>
2018-10-10 14:29 ` Viresh Kumar
2018-10-10 14:29 ` Viresh Kumar
[not found] ` <20180827151112.25211-7-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-15 14:34 ` Rob Herring
2018-10-15 14:34 ` Rob Herring
2018-10-15 15:12 ` Jordan Crouse
2018-10-15 15:12 ` Jordan Crouse
2018-08-27 15:11 ` [PATCH 7/9] OPP: Add dev_pm_opp_get_interconnect_bw() Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
[not found] ` <20180827151112.25211-8-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-05 6:36 ` Sharat Masetty
2018-10-05 6:36 ` Sharat Masetty
[not found] ` <49858ede-66db-b58f-e586-411896efad4b-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-05 17:13 ` Jordan Crouse
2018-10-05 17:13 ` Jordan Crouse
2018-08-27 15:11 ` [PATCH 8/9] drm/msm/a6xx: Add support for an interconnect path Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
[not found] ` <20180827151112.25211-9-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-08-28 1:23 ` kbuild test robot
2018-08-28 1:23 ` kbuild test robot
2018-08-27 15:11 ` [PATCH 9/9] arm64: dts: Add interconnect for the GPU on SDM845 Jordan Crouse
2018-08-27 15:11 ` Jordan Crouse
[not found] ` <20180827151112.25211-10-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-08-28 18:16 ` Jordan Crouse
2018-08-28 18:16 ` [Freedreno] " Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WzkRtcdy_=eatp=AEkJ54d=qvNGzNYCMCMnVAWtrXAQg@mail.gmail.com' \
--to=dianders-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vireshk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.