From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Clark <robdclark@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD
Date: Wed, 27 Jan 2021 13:11:17 -0800 [thread overview]
Message-ID: <CAD=FV=XEsZVfgoOzMAMtye+NB17cP5VO9s=_yVZ2Frp4y4Y6Ug@mail.gmail.com> (raw)
In-Reply-To: <161160651990.76967.1833069919954122114@swboyd.mtv.corp.google.com>
Hi,
On Mon, Jan 25, 2021 at 12:28 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> > +/*
> > + * Some panels simply don't always come up and need to be power cycled to
> > + * work properly. We'll allow for a handful of retries.
> > + */
> > +#define MAX_PANEL_PREPARE_TRIES 5
>
> Is this define used anywhere else? Feels like it would be better to
> inline the constant and move the comment above the loop, but I guess
> this is OK too.
Hrm, usually I only add a #define like this when I need to use the
same number more than once, but I'm not doing that here. Maybe I did
in an earlier version of the code and then didn't go back and remove
the #define when I reworked it?
Since this is a bit of a style issue, I will leave it to the
simple-panel maintainers to decide. I'm happy to spin this and add
the comment before the loop and just hardcode "5" in the loop instead
of using MAX_PANEL_PREPARE_TRIES, so just let me know.
-Doug
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Rob Clark <robdclark@chromium.org>,
David Airlie <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD
Date: Wed, 27 Jan 2021 13:11:17 -0800 [thread overview]
Message-ID: <CAD=FV=XEsZVfgoOzMAMtye+NB17cP5VO9s=_yVZ2Frp4y4Y6Ug@mail.gmail.com> (raw)
In-Reply-To: <161160651990.76967.1833069919954122114@swboyd.mtv.corp.google.com>
Hi,
On Mon, Jan 25, 2021 at 12:28 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> > +/*
> > + * Some panels simply don't always come up and need to be power cycled to
> > + * work properly. We'll allow for a handful of retries.
> > + */
> > +#define MAX_PANEL_PREPARE_TRIES 5
>
> Is this define used anywhere else? Feels like it would be better to
> inline the constant and move the comment above the loop, but I guess
> this is OK too.
Hrm, usually I only add a #define like this when I need to use the
same number more than once, but I'm not doing that here. Maybe I did
in an earlier version of the code and then didn't go back and remove
the #define when I reworked it?
Since this is a bit of a style issue, I will leave it to the
simple-panel maintainers to decide. I'm happy to spin this and add
the comment before the loop and just hardcode "5" in the loop instead
of using MAX_PANEL_PREPARE_TRIES, so just let me know.
-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-27 21:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 22:44 [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1 Douglas Anderson
2021-01-15 22:44 ` Douglas Anderson
2021-01-15 22:44 ` [PATCH v2 1/5] drm/panel-simple: Undo enable if HPD never asserts Douglas Anderson
2021-01-15 22:44 ` Douglas Anderson
2021-01-15 22:49 ` Stephen Boyd
2021-01-15 22:49 ` Stephen Boyd
2021-01-15 22:44 ` [PATCH v2 2/5] drm/panel-simple: Don't wait longer for HPD than hpd_absent_delay Douglas Anderson
2021-01-15 22:44 ` Douglas Anderson
2021-01-25 20:26 ` Stephen Boyd
2021-01-25 20:26 ` Stephen Boyd
2021-01-15 22:44 ` [PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD Douglas Anderson
2021-01-15 22:44 ` Douglas Anderson
2021-01-25 20:28 ` Stephen Boyd
2021-01-25 20:28 ` Stephen Boyd
2021-01-27 21:11 ` Doug Anderson [this message]
2021-01-27 21:11 ` Doug Anderson
2021-01-15 22:44 ` [PATCH v2 4/5] dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1 Douglas Anderson
2021-01-15 22:44 ` Douglas Anderson
2021-01-15 22:59 ` Doug Anderson
2021-01-15 22:59 ` Doug Anderson
2021-01-25 20:29 ` Stephen Boyd
2021-01-25 20:29 ` Stephen Boyd
2021-02-08 21:50 ` Rob Herring
2021-02-08 21:50 ` Rob Herring
2021-01-15 22:44 ` [PATCH v2 5/5] drm/panel-simple: " Douglas Anderson
2021-01-15 22:44 ` Douglas Anderson
2021-01-25 20:29 ` Stephen Boyd
2021-01-25 20:29 ` Stephen Boyd
2021-03-05 15:42 ` [PATCH v2 0/5] drm/panel-simple: Patches for N116BCA-EA1 Doug Anderson
2021-03-05 15:42 ` Doug Anderson
2021-03-10 23:25 ` Linus Walleij
2021-03-10 23:25 ` Linus Walleij
2021-03-10 23:47 ` Doug Anderson
2021-03-10 23:47 ` Doug Anderson
2021-03-11 0:57 ` Linus Walleij
2021-03-11 0:57 ` Linus Walleij
2021-03-11 1:01 ` Doug Anderson
2021-03-11 1:01 ` Doug Anderson
2021-03-11 16:20 ` Linus Walleij
2021-03-11 16:20 ` Linus Walleij
2021-03-11 16:15 ` Linus Walleij
2021-03-11 16:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XEsZVfgoOzMAMtye+NB17cP5VO9s=_yVZ2Frp4y4Y6Ug@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=sam@ravnborg.org \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.