From: Doug Anderson <dianders@chromium.org> To: Kalle Valo <kvalo@codeaurora.org> Cc: Rakesh Pillai <pillair@codeaurora.org>, Peter Oh <peter.oh@eero.com>, Brian Norris <briannorris@chromium.org>, linux-wireless <linux-wireless@vger.kernel.org>, ath10k <ath10k@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing Date: Wed, 26 Aug 2020 07:54:17 -0700 [thread overview] Message-ID: <CAD=FV=XMPZhS6NHGcxTu5DWbsg5PvL=8Je2JyQF=zX-hY3R0Lw@mail.gmail.com> (raw) In-Reply-To: <877dtlcvs1.fsf@codeaurora.org> Hi, On Wed, Aug 26, 2020 at 7:44 AM Kalle Valo <kvalo@codeaurora.org> wrote: > > (Guys, PLEASE edit your quotes. These long emails my use of patchwork > horrible.) > > "Rakesh Pillai" <pillair@codeaurora.org> writes: > > >> -----Original Message----- > >> From: Peter Oh <peter.oh@eero.com> > >> Sent: Tuesday, July 21, 2020 7:03 AM > >> To: Kalle Valo <kvalo@codeaurora.org> > >> Cc: Brian Norris <briannorris@chromium.org>; Doug Anderson > >> <dianders@chromium.org>; linux-wireless <linux- > >> wireless@vger.kernel.org>; Rakesh Pillai <pillair@codeaurora.org>; ath10k > >> <ath10k@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org> > >> Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing > >> > >> I'll take my word back. > >> It's not this patch problem, but by others. > >> I have 2 extra patches before the 3 patches so my system looks like > >> > >> backports from ath.git 5.6-rc1 + linux kernel 4.4 (similar to OpenWrt) > >> On top of the working system, I cherry-picked these 5. > >> > >> #1. > >> ath10k: Avoid override CE5 configuration for QCA99X0 chipsets > >> ath.git commit 521fc37be3d879561ca5ab42d64719cf94116af0 > >> #2. > >> ath10k: Fix NULL pointer dereference in AHB device probe > >> wireless-drivers.git commit 1cfd3426ef989b83fa6176490a38777057e57f6c > >> #3. > >> ath10k: Add interrupt summary based CE processing > >> https://patchwork.kernel.org/patch/11628299/ > > > > This patch is applicable only for snoc target WCN3990, since there is > > a check for per_ce_irq. For PCI targets, per_ce_irq is false, and > > hence follows a different path. > > This information should be in the commit log. But I have a patch in the > pending branch which removes per_ce_irq: > > [v2,2/2] ath10k: Get rid of "per_ce_irq" hw param > > https://patchwork.kernel.org/patch/11654621/ > > So how will multilple hardware support work then? In theory my patches and Rakesh's patches could be squashed. His patch made things marginally better but still didn't really address the root cause. When addressing the root cause, I ended up deleting most of the code that he introduced. I think it'd be fine to just apply all 3 patches (Rakesh's plus my 2) and the end result will be good, but if desired either Rakesh or I could post a squashed series. > In theory I like the patch but there's no information in the patch if > this works or breaks other hardware, especially QCA9884 or QCA6174 PCI > devices. I really need some kind of assurance that this works with all > ath10k devices, not just WCN3990 which you are working on. > > I have written about this in the wiki: > > https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#hardware_families The end result is that it should only affect "wcn3990-wifi", which is what this was tested on. Specifically you can see that "snoc.c" only includes one compatible string: "qcom,wcn3990-wifi". You can also see that the only place that has "per_ce_irq" set to true is "WCN3990_HW_1_0_DEV_VERSION". -Doug
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org> To: Kalle Valo <kvalo@codeaurora.org> Cc: Brian Norris <briannorris@chromium.org>, linux-wireless <linux-wireless@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, ath10k <ath10k@lists.infradead.org>, Peter Oh <peter.oh@eero.com>, Rakesh Pillai <pillair@codeaurora.org> Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing Date: Wed, 26 Aug 2020 07:54:17 -0700 [thread overview] Message-ID: <CAD=FV=XMPZhS6NHGcxTu5DWbsg5PvL=8Je2JyQF=zX-hY3R0Lw@mail.gmail.com> (raw) In-Reply-To: <877dtlcvs1.fsf@codeaurora.org> Hi, On Wed, Aug 26, 2020 at 7:44 AM Kalle Valo <kvalo@codeaurora.org> wrote: > > (Guys, PLEASE edit your quotes. These long emails my use of patchwork > horrible.) > > "Rakesh Pillai" <pillair@codeaurora.org> writes: > > >> -----Original Message----- > >> From: Peter Oh <peter.oh@eero.com> > >> Sent: Tuesday, July 21, 2020 7:03 AM > >> To: Kalle Valo <kvalo@codeaurora.org> > >> Cc: Brian Norris <briannorris@chromium.org>; Doug Anderson > >> <dianders@chromium.org>; linux-wireless <linux- > >> wireless@vger.kernel.org>; Rakesh Pillai <pillair@codeaurora.org>; ath10k > >> <ath10k@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org> > >> Subject: Re: [PATCH] ath10k: Add interrupt summary based CE processing > >> > >> I'll take my word back. > >> It's not this patch problem, but by others. > >> I have 2 extra patches before the 3 patches so my system looks like > >> > >> backports from ath.git 5.6-rc1 + linux kernel 4.4 (similar to OpenWrt) > >> On top of the working system, I cherry-picked these 5. > >> > >> #1. > >> ath10k: Avoid override CE5 configuration for QCA99X0 chipsets > >> ath.git commit 521fc37be3d879561ca5ab42d64719cf94116af0 > >> #2. > >> ath10k: Fix NULL pointer dereference in AHB device probe > >> wireless-drivers.git commit 1cfd3426ef989b83fa6176490a38777057e57f6c > >> #3. > >> ath10k: Add interrupt summary based CE processing > >> https://patchwork.kernel.org/patch/11628299/ > > > > This patch is applicable only for snoc target WCN3990, since there is > > a check for per_ce_irq. For PCI targets, per_ce_irq is false, and > > hence follows a different path. > > This information should be in the commit log. But I have a patch in the > pending branch which removes per_ce_irq: > > [v2,2/2] ath10k: Get rid of "per_ce_irq" hw param > > https://patchwork.kernel.org/patch/11654621/ > > So how will multilple hardware support work then? In theory my patches and Rakesh's patches could be squashed. His patch made things marginally better but still didn't really address the root cause. When addressing the root cause, I ended up deleting most of the code that he introduced. I think it'd be fine to just apply all 3 patches (Rakesh's plus my 2) and the end result will be good, but if desired either Rakesh or I could post a squashed series. > In theory I like the patch but there's no information in the patch if > this works or breaks other hardware, especially QCA9884 or QCA6174 PCI > devices. I really need some kind of assurance that this works with all > ath10k devices, not just WCN3990 which you are working on. > > I have written about this in the wiki: > > https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#hardware_families The end result is that it should only affect "wcn3990-wifi", which is what this was tested on. Specifically you can see that "snoc.c" only includes one compatible string: "qcom,wcn3990-wifi". You can also see that the only place that has "per_ce_irq" set to true is "WCN3990_HW_1_0_DEV_VERSION". -Doug _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-08-26 14:55 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-26 17:52 [PATCH] ath10k: Add interrupt summary based CE processing Rakesh Pillai 2020-06-26 17:52 ` Rakesh Pillai 2020-06-26 21:37 ` Doug Anderson 2020-06-26 21:37 ` Doug Anderson 2020-06-26 21:49 ` Doug Anderson 2020-06-26 21:49 ` Doug Anderson 2020-06-26 21:52 ` Brian Norris 2020-06-26 21:52 ` Brian Norris 2020-07-16 6:38 ` Kalle Valo 2020-07-16 6:38 ` Kalle Valo 2020-07-21 0:33 ` Peter Oh 2020-07-21 0:33 ` Peter Oh 2020-07-21 0:40 ` Doug Anderson 2020-07-21 0:40 ` Doug Anderson 2020-07-21 0:43 ` Peter Oh 2020-07-21 0:43 ` Peter Oh [not found] ` <CALhWmc1B0+SONV6_AF+nUzgxZdekPD3sZuhrsmwVQx1Q-cgT_g@mail.gmail.com> 2020-07-21 0:56 ` Peter Oh 2020-07-21 0:56 ` Peter Oh 2020-07-21 0:58 ` Peter Oh 2020-07-21 0:58 ` Peter Oh 2020-07-21 1:32 ` Peter Oh 2020-07-21 1:32 ` Peter Oh 2020-07-21 11:24 ` Rakesh Pillai 2020-07-21 11:24 ` Rakesh Pillai 2020-08-26 14:43 ` Kalle Valo 2020-08-26 14:43 ` Kalle Valo 2020-08-26 14:54 ` Doug Anderson [this message] 2020-08-26 14:54 ` Doug Anderson 2020-07-21 15:37 ` Doug Anderson 2020-07-21 15:37 ` Doug Anderson 2020-09-01 11:59 ` Kalle Valo 2020-09-01 11:59 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAD=FV=XMPZhS6NHGcxTu5DWbsg5PvL=8Je2JyQF=zX-hY3R0Lw@mail.gmail.com' \ --to=dianders@chromium.org \ --cc=ath10k@lists.infradead.org \ --cc=briannorris@chromium.org \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=peter.oh@eero.com \ --cc=pillair@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.