From: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> To: Jayant Shekhar <jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Georgi Djakov <georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Evan Green <evgreen-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, linux-arm-msm <linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, dri-devel <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Abhinav Kumar <abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, "Kristian H. Kristensen" <hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Chandan Uddaraju <chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, freedreno <freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Jeykumar Sankaran <jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Sravanthi Kollukuduru <skolluku-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Subject: Re: [v5 2/3] drm/msm/dpu: Integrate interconnect API in MDSS Date: Fri, 18 Jan 2019 09:52:12 -0800 [thread overview] Message-ID: <CAD=FV=XUeMTGH+CDwGs3PfK4igdQrCbwucw7_2ViBc4i7grvxg@mail.gmail.com> (raw) In-Reply-To: <1547056325-1919-3-git-send-email-jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Hi, On Wed, Jan 9, 2019 at 9:52 AM Jayant Shekhar <jshekhar@codeaurora.org> wrote: > @@ -127,7 +153,11 @@ static int dpu_mdss_enable(struct msm_mdss *mdss) > { > struct dpu_mdss *dpu_mdss = to_dpu_mdss(mdss); > struct dss_module_power *mp = &dpu_mdss->mp; > - int ret; > + int ret, i; > + u64 avg_bw = dpu_mdss->num_paths ? MAX_BW / dpu_mdss->num_paths : 0; > + > + for (i = 0; i < dpu_mdss->num_paths; i++) > + icc_set(dpu_mdss->path[i], avg_bw, kBps_to_icc(MAX_BW)); You'll need to change icc_set() here to icc_set_bw() to match v13, AKA: - https://patchwork.kernel.org/patch/10766335/ - https://lkml.kernel.org/r/20190116161103.6937-2-georgi.djakov@linaro.org > ret = msm_dss_enable_clk(mp->clk_config, mp->num_clk, true); > if (ret) > @@ -140,12 +170,15 @@ static int dpu_mdss_disable(struct msm_mdss *mdss) > { > struct dpu_mdss *dpu_mdss = to_dpu_mdss(mdss); > struct dss_module_power *mp = &dpu_mdss->mp; > - int ret; > + int ret, i; > > ret = msm_dss_enable_clk(mp->clk_config, mp->num_clk, false); > if (ret) > DPU_ERROR("clock disable failed, ret:%d\n", ret); > > + for (i = 0; i < dpu_mdss->num_paths; i++) > + icc_set(dpu_mdss->path[i], 0, 0); This will also need to change to icc_set_bw() I'm curious what the plan is for landing this series. Sean / Rob / Gerogi: do you have any preference? Options I'd imagine: A) Wait until interconnect lands (in 5.1?) and land this through drm-misc / msm-next in the version after (5.2?) B) Georgi provides an immutable branch for interconnect when his lands (assuming he's sending his stuff upstream via pull request) and that immutable branch gets merged into the the relevant drm tree. C) Sean and/or Rob Acks this series and indicates that it should go in through Gerogi's tree (probably only works if Georgi plans to send a pull request). If we're going this route then (IIUC) we'd want to land this in Gerogi's tree sooner rather than later so it can get some bake time in linux-next (we've been baking it in Chrome OS for a while, but nice to see it in linux-next too). Does anyone have a preference? It's be nice if whoever is planning to land this could indicate whether they'd prefer Jayant send a new version to handle the API change or if the relevant maintainer can just do the fixup when the patch lands. Thanks! -Doug _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org> To: Jayant Shekhar <jshekhar@codeaurora.org>, Sean Paul <seanpaul@chromium.org>, Rob Clark <robdclark@gmail.com>, Georgi Djakov <georgi.djakov@linaro.org> Cc: dri-devel <dri-devel@lists.freedesktop.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, freedreno <freedreno@lists.freedesktop.org>, devicetree@vger.kernel.org, Sravanthi Kollukuduru <skolluku@codeaurora.org>, LKML <linux-kernel@vger.kernel.org>, "Kristian H. Kristensen" <hoegsberg@chromium.org>, Abhinav Kumar <abhinavk@codeaurora.org>, Jeykumar Sankaran <jsanka@codeaurora.org>, Chandan Uddaraju <chandanu@codeaurora.org>, nganji@codeaurora.org, Evan Green <evgreen@chromium.org> Subject: Re: [v5 2/3] drm/msm/dpu: Integrate interconnect API in MDSS Date: Fri, 18 Jan 2019 09:52:12 -0800 [thread overview] Message-ID: <CAD=FV=XUeMTGH+CDwGs3PfK4igdQrCbwucw7_2ViBc4i7grvxg@mail.gmail.com> (raw) In-Reply-To: <1547056325-1919-3-git-send-email-jshekhar@codeaurora.org> Hi, On Wed, Jan 9, 2019 at 9:52 AM Jayant Shekhar <jshekhar@codeaurora.org> wrote: > @@ -127,7 +153,11 @@ static int dpu_mdss_enable(struct msm_mdss *mdss) > { > struct dpu_mdss *dpu_mdss = to_dpu_mdss(mdss); > struct dss_module_power *mp = &dpu_mdss->mp; > - int ret; > + int ret, i; > + u64 avg_bw = dpu_mdss->num_paths ? MAX_BW / dpu_mdss->num_paths : 0; > + > + for (i = 0; i < dpu_mdss->num_paths; i++) > + icc_set(dpu_mdss->path[i], avg_bw, kBps_to_icc(MAX_BW)); You'll need to change icc_set() here to icc_set_bw() to match v13, AKA: - https://patchwork.kernel.org/patch/10766335/ - https://lkml.kernel.org/r/20190116161103.6937-2-georgi.djakov@linaro.org > ret = msm_dss_enable_clk(mp->clk_config, mp->num_clk, true); > if (ret) > @@ -140,12 +170,15 @@ static int dpu_mdss_disable(struct msm_mdss *mdss) > { > struct dpu_mdss *dpu_mdss = to_dpu_mdss(mdss); > struct dss_module_power *mp = &dpu_mdss->mp; > - int ret; > + int ret, i; > > ret = msm_dss_enable_clk(mp->clk_config, mp->num_clk, false); > if (ret) > DPU_ERROR("clock disable failed, ret:%d\n", ret); > > + for (i = 0; i < dpu_mdss->num_paths; i++) > + icc_set(dpu_mdss->path[i], 0, 0); This will also need to change to icc_set_bw() I'm curious what the plan is for landing this series. Sean / Rob / Gerogi: do you have any preference? Options I'd imagine: A) Wait until interconnect lands (in 5.1?) and land this through drm-misc / msm-next in the version after (5.2?) B) Georgi provides an immutable branch for interconnect when his lands (assuming he's sending his stuff upstream via pull request) and that immutable branch gets merged into the the relevant drm tree. C) Sean and/or Rob Acks this series and indicates that it should go in through Gerogi's tree (probably only works if Georgi plans to send a pull request). If we're going this route then (IIUC) we'd want to land this in Gerogi's tree sooner rather than later so it can get some bake time in linux-next (we've been baking it in Chrome OS for a while, but nice to see it in linux-next too). Does anyone have a preference? It's be nice if whoever is planning to land this could indicate whether they'd prefer Jayant send a new version to handle the API change or if the relevant maintainer can just do the fixup when the patch lands. Thanks! -Doug
next prev parent reply other threads:[~2019-01-18 17:52 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-09 17:52 [v5 0/3] Use interconnect API in MDSS on SDM845 Jayant Shekhar 2019-01-09 17:52 ` Jayant Shekhar 2019-01-09 17:52 ` [v5 1/3] drm/msm/dpu: clean up references of DPU custom bus scaling Jayant Shekhar 2019-01-09 17:52 ` Jayant Shekhar [not found] ` <1547056325-1919-1-git-send-email-jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2019-01-09 17:52 ` [v5 2/3] drm/msm/dpu: Integrate interconnect API in MDSS Jayant Shekhar 2019-01-09 17:52 ` Jayant Shekhar [not found] ` <1547056325-1919-3-git-send-email-jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2019-01-18 17:52 ` Doug Anderson [this message] 2019-01-18 17:52 ` Doug Anderson 2019-01-09 17:52 ` [v5 3/3] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845 Jayant Shekhar 2019-01-09 17:52 ` Jayant Shekhar [not found] ` <1547056325-1919-4-git-send-email-jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2019-01-11 14:35 ` Rob Herring 2019-01-11 14:35 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAD=FV=XUeMTGH+CDwGs3PfK4igdQrCbwucw7_2ViBc4i7grvxg@mail.gmail.com' \ --to=dianders-f7+t8e8rja9g9huczpvpmw@public.gmane.org \ --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=evgreen-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=jshekhar-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=skolluku-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.