All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] drm/panel-edp: Add AUO B133UAN01
Date: Thu, 24 Mar 2022 11:27:46 -0700	[thread overview]
Message-ID: <CAD=FV=X_a9aU0ZvXg1AkGS5j1oKDJmPdZt0Hs22eEcWWczTe_A@mail.gmail.com> (raw)
In-Reply-To: <20220324111335.2.I816014b6c62da5a33af5021f3cc35cea66552c00@changeid>

Hi,

On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Add support for the AUO B133UAN01 13.3" WUXGA panel.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> output of edid-decode:
>
>   Block 0, Base EDID:
>     EDID Structure Version & Revision: 1.4
>     Vendor & Product Identification:
>       Manufacturer: AUO
>       Model: 34196
>       Made in: 2020
>     Basic Display Parameters & Features:
>       Digital display
>       Bits per primary color channel: 8
>       DisplayPort interface
>       Maximum image size: 29 cm x 18 cm
>       Gamma: 2.20
>       Supported color formats: RGB 4:4:4
>       First detailed timing includes the native pixel format and preferred refresh rate
>     Color Characteristics:
>       Red  : 0.6513, 0.3271
>       Green: 0.2900, 0.6279
>       Blue : 0.1503, 0.0517
>       White: 0.3134, 0.3291
>     Established Timings I & II: none
>     Standard Timings: none
>     Detailed Timing Descriptors:
>       DTD 1:  1920x1200   60.026 Hz   8:5    74.192 kHz 156.100 MHz (286 mm x 178 mm)
>                    Hfront   16 Hsync  16 Hback 152 Hpol N
>                    Vfront    3 Vsync  14 Vback  19 Vpol N
>       Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 00 00 00 00 00 00 00 00 00 00 00 00 20 '............... '
>       Alphanumeric Data String: 'AUO'
>       Alphanumeric Data String: 'B133UAN01.0 '
>
>  drivers/gpu/drm/panel/panel-edp.c | 32 +++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

I can review this patch and it can be landed if you really need it,
but I'd prefer not to. Instead I'd rather see the panel added to
_just_ the "edp_panels" structure. That maps the panel ID to the
delays. If we do it that way:

1. We don't need the binding.

2. We don't need to hardcode the mode in this file.

3. We support second sourcing the panel.

4. We simplify our device tree files.


Let me know if we can just go that way. If we really have a reason to
support the old hardcoded mode we can land something like this but I'd
rather avoid it if possible.

Also: note that even if we land this, adding the entry to the
"edp_panels" structure would help future-proof us a bit.

-Doug

WARNING: multiple messages have this Message-ID (diff)
From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH 2/2] drm/panel-edp: Add AUO B133UAN01
Date: Thu, 24 Mar 2022 11:27:46 -0700	[thread overview]
Message-ID: <CAD=FV=X_a9aU0ZvXg1AkGS5j1oKDJmPdZt0Hs22eEcWWczTe_A@mail.gmail.com> (raw)
In-Reply-To: <20220324111335.2.I816014b6c62da5a33af5021f3cc35cea66552c00@changeid>

Hi,

On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> Add support for the AUO B133UAN01 13.3" WUXGA panel.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> output of edid-decode:
>
>   Block 0, Base EDID:
>     EDID Structure Version & Revision: 1.4
>     Vendor & Product Identification:
>       Manufacturer: AUO
>       Model: 34196
>       Made in: 2020
>     Basic Display Parameters & Features:
>       Digital display
>       Bits per primary color channel: 8
>       DisplayPort interface
>       Maximum image size: 29 cm x 18 cm
>       Gamma: 2.20
>       Supported color formats: RGB 4:4:4
>       First detailed timing includes the native pixel format and preferred refresh rate
>     Color Characteristics:
>       Red  : 0.6513, 0.3271
>       Green: 0.2900, 0.6279
>       Blue : 0.1503, 0.0517
>       White: 0.3134, 0.3291
>     Established Timings I & II: none
>     Standard Timings: none
>     Detailed Timing Descriptors:
>       DTD 1:  1920x1200   60.026 Hz   8:5    74.192 kHz 156.100 MHz (286 mm x 178 mm)
>                    Hfront   16 Hsync  16 Hback 152 Hpol N
>                    Vfront    3 Vsync  14 Vback  19 Vpol N
>       Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 00 00 00 00 00 00 00 00 00 00 00 00 20 '............... '
>       Alphanumeric Data String: 'AUO'
>       Alphanumeric Data String: 'B133UAN01.0 '
>
>  drivers/gpu/drm/panel/panel-edp.c | 32 +++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

I can review this patch and it can be landed if you really need it,
but I'd prefer not to. Instead I'd rather see the panel added to
_just_ the "edp_panels" structure. That maps the panel ID to the
delays. If we do it that way:

1. We don't need the binding.

2. We don't need to hardcode the mode in this file.

3. We support second sourcing the panel.

4. We simplify our device tree files.


Let me know if we can just go that way. If we really have a reason to
support the old hardcoded mode we can land something like this but I'd
rather avoid it if possible.

Also: note that even if we land this, adding the entry to the
"edp_panels" structure would help future-proof us a bit.

-Doug

  reply	other threads:[~2022-03-24 18:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 18:13 [PATCH 1/2] dt-bindings: display: simple: Add AUO B133UAN01 panel Matthias Kaehlcke
2022-03-24 18:13 ` Matthias Kaehlcke
2022-03-24 18:13 ` [PATCH 2/2] drm/panel-edp: Add AUO B133UAN01 Matthias Kaehlcke
2022-03-24 18:13   ` Matthias Kaehlcke
2022-03-24 18:27   ` Doug Anderson [this message]
2022-03-24 18:27     ` Doug Anderson
2022-03-24 19:21     ` Matthias Kaehlcke
2022-03-24 19:21       ` Matthias Kaehlcke
2022-03-24 20:53 ` [PATCH 1/2] dt-bindings: display: simple: Add AUO B133UAN01 panel Doug Anderson
2022-03-24 20:53   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=X_a9aU0ZvXg1AkGS5j1oKDJmPdZt0Hs22eEcWWczTe_A@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.