From: Siwei Liu <loseweigh@gmail.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>, Alexander Duyck <alexander.duyck@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Stephen Hemminger <stephen@networkplumber.org>, David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>, virtio-dev@lists.oasis-open.org, "Brandeburg, Jesse" <jesse.brandeburg@intel.com>, "Duyck, Alexander H" <alexander.h.duyck@intel.com>, Jakub Kicinski <kubakici@wp.pl> Subject: Re: Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available Date: Fri, 2 Mar 2018 12:44:56 -0800 [thread overview] Message-ID: <CADGSJ20w4pMetRjjGO0pEgM5ZtL0y+LtTAy-7AF5ZXaV=Ldm1g@mail.gmail.com> (raw) In-Reply-To: <20180302220932-mutt-send-email-mst@kernel.org> On Fri, Mar 2, 2018 at 12:10 PM, Michael S. Tsirkin <mst@redhat.com> wrote: > On Fri, Mar 02, 2018 at 11:52:27AM -0800, Samudrala, Sridhar wrote: >> >> >> On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote: >> > On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: >> > > The design limits things to a 1:1 relationship since we just have the >> > > child and backup pointers, but I don't think I am seeing exception >> > > handling to prevent us from overwriting the child pointers so there >> > > may be a leak there. >> > > >> > > Thanks. >> > > >> > > - Alex >> > In fact maintaining a list in that case would be nicer, and >> > just use an arbitrary one. >> > E.g. one can see how a user wanting to swap device 1 for device 2 >> > might first add device 2 with same MAC then drop device 1. >> >> It should be possible to swap VF1 with VF2 by >> 1.- enabling virtio link >> 2.- unplugging VF1 >> 3.- plugging VF2 >> 4.- disabling virtio link >> > > True, but it isn't hard to avoid breakage if user > swapped steps 2 and 3. No need to make it more > fragile that it has to be. The migration case, VF2 is associated with another PF on another machine (destination), I wonder how it is possible. Even with local plugging of VF2 on the same PF, the MAC address requirement (VF1's == VF2's) would fail the MAC address assignment on VF2. -Siwei > > -- > MST > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org >
WARNING: multiple messages have this Message-ID (diff)
From: Siwei Liu <loseweigh@gmail.com> To: "Michael S. Tsirkin" <mst@redhat.com> Cc: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>, Alexander Duyck <alexander.duyck@gmail.com>, Jiri Pirko <jiri@resnulli.us>, Stephen Hemminger <stephen@networkplumber.org>, David Miller <davem@davemloft.net>, Netdev <netdev@vger.kernel.org>, virtio-dev@lists.oasis-open.org, "Brandeburg, Jesse" <jesse.brandeburg@intel.com>, "Duyck, Alexander H" <alexander.h.duyck@intel.com>, Jakub Kicinski <kubakici@wp.pl> Subject: Re: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available Date: Fri, 2 Mar 2018 12:44:56 -0800 [thread overview] Message-ID: <CADGSJ20w4pMetRjjGO0pEgM5ZtL0y+LtTAy-7AF5ZXaV=Ldm1g@mail.gmail.com> (raw) In-Reply-To: <20180302220932-mutt-send-email-mst@kernel.org> On Fri, Mar 2, 2018 at 12:10 PM, Michael S. Tsirkin <mst@redhat.com> wrote: > On Fri, Mar 02, 2018 at 11:52:27AM -0800, Samudrala, Sridhar wrote: >> >> >> On 3/2/2018 11:41 AM, Michael S. Tsirkin wrote: >> > On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: >> > > The design limits things to a 1:1 relationship since we just have the >> > > child and backup pointers, but I don't think I am seeing exception >> > > handling to prevent us from overwriting the child pointers so there >> > > may be a leak there. >> > > >> > > Thanks. >> > > >> > > - Alex >> > In fact maintaining a list in that case would be nicer, and >> > just use an arbitrary one. >> > E.g. one can see how a user wanting to swap device 1 for device 2 >> > might first add device 2 with same MAC then drop device 1. >> >> It should be possible to swap VF1 with VF2 by >> 1.- enabling virtio link >> 2.- unplugging VF1 >> 3.- plugging VF2 >> 4.- disabling virtio link >> > > True, but it isn't hard to avoid breakage if user > swapped steps 2 and 3. No need to make it more > fragile that it has to be. The migration case, VF2 is associated with another PF on another machine (destination), I wonder how it is possible. Even with local plugging of VF2 on the same PF, the MAC address requirement (VF1's == VF2's) would fail the MAC address assignment on VF2. -Siwei > > -- > MST > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-03-02 20:44 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-01 20:08 [PATCH v4 0/2] Enable virtio_net to act as a backup for a passthru device Sridhar Samudrala 2018-03-01 20:08 ` [virtio-dev] " Sridhar Samudrala 2018-03-01 20:08 ` [PATCH v4 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Sridhar Samudrala 2018-03-01 20:08 ` [virtio-dev] " Sridhar Samudrala 2018-03-01 20:08 ` [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala 2018-03-01 20:08 ` [virtio-dev] " Sridhar Samudrala 2018-03-02 8:36 ` Jiri Pirko 2018-03-02 15:26 ` Alexander Duyck 2018-03-02 15:26 ` [virtio-dev] " Alexander Duyck 2018-03-02 16:20 ` Jiri Pirko 2018-03-02 16:37 ` Samudrala, Sridhar 2018-03-02 16:37 ` [virtio-dev] " Samudrala, Sridhar 2018-03-02 17:06 ` Alexander Duyck 2018-03-02 17:06 ` [virtio-dev] " Alexander Duyck 2018-03-02 19:42 ` Michael S. Tsirkin 2018-03-02 19:42 ` [virtio-dev] " Michael S. Tsirkin 2018-03-02 20:49 ` Siwei Liu 2018-03-02 20:49 ` [virtio-dev] " Siwei Liu 2018-03-03 11:31 ` Jiri Pirko 2018-03-03 18:04 ` Alexander Duyck 2018-03-03 18:04 ` [virtio-dev] " Alexander Duyck 2018-03-03 21:25 ` Jiri Pirko 2018-03-04 0:26 ` Alexander Duyck 2018-03-04 0:26 ` [virtio-dev] " Alexander Duyck 2018-03-04 7:13 ` Jiri Pirko 2018-03-04 18:24 ` Alexander Duyck 2018-03-04 18:24 ` [virtio-dev] " Alexander Duyck 2018-03-04 18:50 ` Jiri Pirko 2018-03-04 21:54 ` Samudrala, Sridhar 2018-03-04 21:54 ` [virtio-dev] " Samudrala, Sridhar 2018-03-04 21:58 ` Alexander Duyck 2018-03-04 21:58 ` [virtio-dev] " Alexander Duyck 2018-03-05 9:21 ` Jiri Pirko 2018-03-05 16:11 ` Stephen Hemminger 2018-03-05 22:30 ` Jiri Pirko 2018-03-05 22:47 ` Alexander Duyck 2018-03-05 22:47 ` [virtio-dev] " Alexander Duyck 2018-03-06 3:15 ` Stephen Hemminger 2018-03-06 19:08 ` Alexander Duyck 2018-03-06 19:08 ` [virtio-dev] " Alexander Duyck 2018-03-06 22:59 ` Jiri Pirko 2018-03-06 23:27 ` Alexander Duyck 2018-03-06 23:27 ` [virtio-dev] " Alexander Duyck 2018-03-07 2:38 ` Michael S. Tsirkin 2018-03-07 2:38 ` [virtio-dev] " Michael S. Tsirkin 2018-03-07 17:50 ` Alexander Duyck 2018-03-07 17:50 ` [virtio-dev] " Alexander Duyck 2018-03-07 18:06 ` Stephen Hemminger 2018-03-07 18:55 ` Alexander Duyck 2018-03-07 18:55 ` [virtio-dev] " Alexander Duyck 2018-03-07 20:11 ` Michael S. Tsirkin 2018-03-07 20:11 ` [virtio-dev] " Michael S. Tsirkin 2018-03-12 18:47 ` Samudrala, Sridhar 2018-03-12 18:47 ` [virtio-dev] " Samudrala, Sridhar 2018-03-02 19:41 ` Michael S. Tsirkin 2018-03-02 19:41 ` [virtio-dev] " Michael S. Tsirkin 2018-03-02 19:52 ` Samudrala, Sridhar 2018-03-02 19:52 ` [virtio-dev] " Samudrala, Sridhar 2018-03-02 20:10 ` Michael S. Tsirkin 2018-03-02 20:10 ` [virtio-dev] " Michael S. Tsirkin 2018-03-02 20:44 ` Siwei Liu [this message] 2018-03-02 20:44 ` Siwei Liu 2018-03-02 20:56 ` Samudrala, Sridhar 2018-03-02 20:56 ` [virtio-dev] " Samudrala, Sridhar 2018-03-02 21:33 ` Michael S. Tsirkin 2018-03-02 21:33 ` [virtio-dev] " Michael S. Tsirkin 2018-03-02 21:31 ` Michael S. Tsirkin 2018-03-02 21:31 ` [virtio-dev] " Michael S. Tsirkin 2018-03-02 22:26 ` Siwei Liu 2018-03-02 22:26 ` [virtio-dev] " Siwei Liu 2018-03-04 4:00 ` Michael S. Tsirkin 2018-03-04 4:00 ` [virtio-dev] " Michael S. Tsirkin 2018-03-02 21:11 ` Siwei Liu 2018-03-02 21:11 ` [virtio-dev] " Siwei Liu 2018-03-02 21:36 ` Michael S. Tsirkin 2018-03-02 21:36 ` [virtio-dev] " Michael S. Tsirkin 2018-03-02 23:56 ` Siwei Liu 2018-03-02 23:56 ` [virtio-dev] " Siwei Liu 2018-03-04 4:04 ` Michael S. Tsirkin 2018-03-04 4:04 ` [virtio-dev] " Michael S. Tsirkin 2018-03-12 21:53 ` Siwei Liu 2018-03-12 21:53 ` [virtio-dev] " Siwei Liu 2018-03-02 23:12 ` Samudrala, Sridhar 2018-03-02 23:12 ` [virtio-dev] " Samudrala, Sridhar 2018-03-03 0:09 ` Siwei Liu 2018-03-03 0:09 ` [virtio-dev] " Siwei Liu 2018-03-12 20:12 ` Jiri Pirko 2018-03-12 20:58 ` Samudrala, Sridhar 2018-03-12 20:58 ` [virtio-dev] " Samudrala, Sridhar 2018-03-12 21:08 ` Jiri Pirko 2018-03-14 0:36 ` Samudrala, Sridhar 2018-03-14 0:36 ` [virtio-dev] " Samudrala, Sridhar 2018-03-14 0:54 ` Stephen Hemminger 2018-03-14 15:45 ` Jiri Pirko 2018-03-12 22:44 ` Siwei Liu 2018-03-12 22:44 ` [virtio-dev] " Siwei Liu 2018-03-14 0:28 ` Samudrala, Sridhar 2018-03-14 0:28 ` [virtio-dev] " Samudrala, Sridhar 2018-03-14 0:44 ` Michael S. Tsirkin 2018-03-14 0:44 ` [virtio-dev] " Michael S. Tsirkin 2018-03-14 4:50 ` Siwei Liu 2018-03-14 4:50 ` [virtio-dev] " Siwei Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADGSJ20w4pMetRjjGO0pEgM5ZtL0y+LtTAy-7AF5ZXaV=Ldm1g@mail.gmail.com' \ --to=loseweigh@gmail.com \ --cc=alexander.duyck@gmail.com \ --cc=alexander.h.duyck@intel.com \ --cc=davem@davemloft.net \ --cc=jesse.brandeburg@intel.com \ --cc=jiri@resnulli.us \ --cc=kubakici@wp.pl \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=sridhar.samudrala@intel.com \ --cc=stephen@networkplumber.org \ --cc=virtio-dev@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.