From: amit daniel kachhap <amit.daniel@samsung.com> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: LAK <linux-arm-kernel@lists.infradead.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, Kukjin Kim <kgene.kim@samsung.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Russell King <linux@arm.linux.org.uk> Subject: Re: [PATCH v4 0/5] exynos: Move pmu driver to driver/soc folder and add exynos7 support Date: Tue, 25 Nov 2014 13:46:54 +0530 [thread overview] Message-ID: <CADGdYn4itcB-PHqZZUoR9Xdf17MXgo0LzbPXj0fuU_GL5bqDEw@mail.gmail.com> (raw) In-Reply-To: <36336460.BrNftCFaUT@amdc1032> On Mon, Nov 24, 2014 at 6:50 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > Hi, > > On Monday, November 24, 2014 07:36:10 AM Amit Daniel Kachhap wrote: >> This patch series [1 - 5] performs, >> >> 1) Moves pmu driver to driver/soc/samsung folder. This is needed as exynos7 is >> an arm64 based platform and hence PMU driver should be in driver folder. >> Some discussion happened about this in the v1 version. Finally adding it in >> driver/soc folder as it too SoC specific and not a general driver. >> Entire discussion can be found here (A). >> 2) Add exynos7 PMU support. > > Some months ago (when the work on moving PMU driver out of mach-exynos > started) I asked how much code would be shared between arm32 and arm64 > SoCs. Now it seems that the code in question is minimal so I still > wonder whether it is really worth to have a common driver (please note > that in case of arm32 kernel all arm64 PMU code is just a dead code, > similarly for arm64 kernel and arm32 PMU code). Would it be possible > to do the analysis of the additional source code needed vs saved code > in the resulting binary for the case of having separate drivers? yes your suggestion is good. It may done by keeping the data pmu_config[] arrays in .h file under CONFIG_ARM(or CONFIG_ARM64) and NULL for non required platforms. Keep them in 2 separate files may be confusing. > > Could you also please take a look into fixing patch #4 to be compatible > with http://lkml.iu.edu/hypermail/linux/kernel/1407.1/00298.html ? This patch makes sense. Thanks for pointing out. > (It seems that just adding separate struct exynos_pmu_conf_extra for > ->pmu_config_extra shold be okay.) Yes right struct exynos_pmu_conf_extra should work for exynos7. I think both of the above optimizations may go as a separate patch. Regards, Amit D > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > >> 3) Enables the driver for 32bit arm exynos platforms. >> >> Changes from V3: >> * Fixed Kconfig as per Russell feedback >> * Rebased the series against Pankaj SoC restart consolidation patches (D) as per >> Kukjin request. >> * Link to V3 can be found here (C) >> >> Changes from V2: >> * Added review comment changes suggested by Pankaj. >> * Removed mfd client support in this patch series. This will be added later in >> the power domain patch series. >> * Link to V2 can be found here (B) >> >> Changes from V1: >> * Move pmu driver in driver/soc/samsung folder >> * Removed the power domain features. They will posted as a separate series. >> * Added exynos7 PMU support. >> * Link to v1 can be found here (A) >> >> This complete patch series is rebased on Kukjin for-next tree. >> >> (A) - http://www.spinics.net/lists/linux-samsung-soc/msg38442.html >> (B) - http://www.spinics.net/lists/arm-kernel/msg375910.html >> (C) - http://www.spinics.net/lists/linux-samsung-soc/msg39237.html >> (D) - http://www.spinics.net/lists/linux-samsung-soc/msg39095.html >> >> Amit Daniel Kachhap (5): >> ARM: EXYNOS: Move pmu specific header files under "linux/soc/samsung" >> drivers: soc: Add support for Exynos PMU driver >> driver: soc: exynos-pmu: Add an API to be called after wakeup >> drivers: soc: exynos-pmu: Add support for Exynos7 >> arm: exynos: Select SOC_SAMSUNG config option >> >> .../devicetree/bindings/arm/samsung/pmu.txt | 1 + >> arch/arm/mach-exynos/Kconfig | 1 + >> arch/arm/mach-exynos/Makefile | 2 +- >> arch/arm/mach-exynos/exynos.c | 2 +- >> arch/arm/mach-exynos/mcpm-exynos.c | 2 +- >> arch/arm/mach-exynos/platsmp.c | 2 +- >> arch/arm/mach-exynos/pm.c | 4 +- >> arch/arm/mach-exynos/suspend.c | 4 +- >> drivers/soc/Kconfig | 1 + >> drivers/soc/Makefile | 1 + >> drivers/soc/samsung/Kconfig | 20 + >> drivers/soc/samsung/Makefile | 1 + >> .../pmu.c => drivers/soc/samsung/exynos-pmu.c | 442 +++++++++++++++++++- >> .../linux/soc/samsung}/exynos-pmu.h | 1 + >> .../linux/soc/samsung/exynos-regs-pmu.h | 273 ++++++++++++ >> 15 files changed, 744 insertions(+), 13 deletions(-) >> create mode 100644 drivers/soc/samsung/Kconfig >> create mode 100644 drivers/soc/samsung/Makefile >> rename arch/arm/mach-exynos/pmu.c => drivers/soc/samsung/exynos-pmu.c (64%) >> rename {arch/arm/mach-exynos => include/linux/soc/samsung}/exynos-pmu.h (89%) >> rename arch/arm/mach-exynos/regs-pmu.h => include/linux/soc/samsung/exynos-regs-pmu.h (63%) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: amit.daniel@samsung.com (amit daniel kachhap) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 0/5] exynos: Move pmu driver to driver/soc folder and add exynos7 support Date: Tue, 25 Nov 2014 13:46:54 +0530 [thread overview] Message-ID: <CADGdYn4itcB-PHqZZUoR9Xdf17MXgo0LzbPXj0fuU_GL5bqDEw@mail.gmail.com> (raw) In-Reply-To: <36336460.BrNftCFaUT@amdc1032> On Mon, Nov 24, 2014 at 6:50 PM, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > Hi, > > On Monday, November 24, 2014 07:36:10 AM Amit Daniel Kachhap wrote: >> This patch series [1 - 5] performs, >> >> 1) Moves pmu driver to driver/soc/samsung folder. This is needed as exynos7 is >> an arm64 based platform and hence PMU driver should be in driver folder. >> Some discussion happened about this in the v1 version. Finally adding it in >> driver/soc folder as it too SoC specific and not a general driver. >> Entire discussion can be found here (A). >> 2) Add exynos7 PMU support. > > Some months ago (when the work on moving PMU driver out of mach-exynos > started) I asked how much code would be shared between arm32 and arm64 > SoCs. Now it seems that the code in question is minimal so I still > wonder whether it is really worth to have a common driver (please note > that in case of arm32 kernel all arm64 PMU code is just a dead code, > similarly for arm64 kernel and arm32 PMU code). Would it be possible > to do the analysis of the additional source code needed vs saved code > in the resulting binary for the case of having separate drivers? yes your suggestion is good. It may done by keeping the data pmu_config[] arrays in .h file under CONFIG_ARM(or CONFIG_ARM64) and NULL for non required platforms. Keep them in 2 separate files may be confusing. > > Could you also please take a look into fixing patch #4 to be compatible > with http://lkml.iu.edu/hypermail/linux/kernel/1407.1/00298.html ? This patch makes sense. Thanks for pointing out. > (It seems that just adding separate struct exynos_pmu_conf_extra for > ->pmu_config_extra shold be okay.) Yes right struct exynos_pmu_conf_extra should work for exynos7. I think both of the above optimizations may go as a separate patch. Regards, Amit D > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > >> 3) Enables the driver for 32bit arm exynos platforms. >> >> Changes from V3: >> * Fixed Kconfig as per Russell feedback >> * Rebased the series against Pankaj SoC restart consolidation patches (D) as per >> Kukjin request. >> * Link to V3 can be found here (C) >> >> Changes from V2: >> * Added review comment changes suggested by Pankaj. >> * Removed mfd client support in this patch series. This will be added later in >> the power domain patch series. >> * Link to V2 can be found here (B) >> >> Changes from V1: >> * Move pmu driver in driver/soc/samsung folder >> * Removed the power domain features. They will posted as a separate series. >> * Added exynos7 PMU support. >> * Link to v1 can be found here (A) >> >> This complete patch series is rebased on Kukjin for-next tree. >> >> (A) - http://www.spinics.net/lists/linux-samsung-soc/msg38442.html >> (B) - http://www.spinics.net/lists/arm-kernel/msg375910.html >> (C) - http://www.spinics.net/lists/linux-samsung-soc/msg39237.html >> (D) - http://www.spinics.net/lists/linux-samsung-soc/msg39095.html >> >> Amit Daniel Kachhap (5): >> ARM: EXYNOS: Move pmu specific header files under "linux/soc/samsung" >> drivers: soc: Add support for Exynos PMU driver >> driver: soc: exynos-pmu: Add an API to be called after wakeup >> drivers: soc: exynos-pmu: Add support for Exynos7 >> arm: exynos: Select SOC_SAMSUNG config option >> >> .../devicetree/bindings/arm/samsung/pmu.txt | 1 + >> arch/arm/mach-exynos/Kconfig | 1 + >> arch/arm/mach-exynos/Makefile | 2 +- >> arch/arm/mach-exynos/exynos.c | 2 +- >> arch/arm/mach-exynos/mcpm-exynos.c | 2 +- >> arch/arm/mach-exynos/platsmp.c | 2 +- >> arch/arm/mach-exynos/pm.c | 4 +- >> arch/arm/mach-exynos/suspend.c | 4 +- >> drivers/soc/Kconfig | 1 + >> drivers/soc/Makefile | 1 + >> drivers/soc/samsung/Kconfig | 20 + >> drivers/soc/samsung/Makefile | 1 + >> .../pmu.c => drivers/soc/samsung/exynos-pmu.c | 442 +++++++++++++++++++- >> .../linux/soc/samsung}/exynos-pmu.h | 1 + >> .../linux/soc/samsung/exynos-regs-pmu.h | 273 ++++++++++++ >> 15 files changed, 744 insertions(+), 13 deletions(-) >> create mode 100644 drivers/soc/samsung/Kconfig >> create mode 100644 drivers/soc/samsung/Makefile >> rename arch/arm/mach-exynos/pmu.c => drivers/soc/samsung/exynos-pmu.c (64%) >> rename {arch/arm/mach-exynos => include/linux/soc/samsung}/exynos-pmu.h (89%) >> rename arch/arm/mach-exynos/regs-pmu.h => include/linux/soc/samsung/exynos-regs-pmu.h (63%) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2014-11-25 8:16 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-11-24 2:06 [PATCH v4 0/5] exynos: Move pmu driver to driver/soc folder and add exynos7 support Amit Daniel Kachhap 2014-11-24 2:06 ` Amit Daniel Kachhap 2014-11-24 2:06 ` [PATCH v4 1/5] ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung" Amit Daniel Kachhap 2014-11-24 2:06 ` Amit Daniel Kachhap 2014-11-24 2:06 ` [PATCH v4 2/5] drivers: soc: Add support for Exynos PMU driver Amit Daniel Kachhap 2014-11-24 2:06 ` Amit Daniel Kachhap 2014-11-24 2:06 ` [PATCH v4 3/5] driver: soc: exynos-pmu: Add an API to be called after wakeup Amit Daniel Kachhap 2014-11-24 2:06 ` Amit Daniel Kachhap 2014-11-24 2:06 ` [PATCH v4 4/5] drivers: soc: exynos-pmu: Add support for Exynos7 Amit Daniel Kachhap 2014-11-24 2:06 ` Amit Daniel Kachhap 2014-11-24 2:06 ` [PATCH v4 5/5] arm: exynos: Select SOC_SAMSUNG config option Amit Daniel Kachhap 2014-11-24 2:06 ` Amit Daniel Kachhap 2014-11-24 13:20 ` [PATCH v4 0/5] exynos: Move pmu driver to driver/soc folder and add exynos7 support Bartlomiej Zolnierkiewicz 2014-11-24 13:20 ` Bartlomiej Zolnierkiewicz 2014-11-25 8:16 ` amit daniel kachhap [this message] 2014-11-25 8:16 ` amit daniel kachhap 2014-11-25 8:16 ` amit daniel kachhap [not found] <E1XtXCn-0007Sm-GE@feisty.vs19.net> 2014-11-26 9:55 ` Pankaj Dubey 2014-11-26 9:55 ` Pankaj Dubey
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CADGdYn4itcB-PHqZZUoR9Xdf17MXgo0LzbPXj0fuU_GL5bqDEw@mail.gmail.com \ --to=amit.daniel@samsung.com \ --cc=b.zolnierkie@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.