[meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Derek Straka]

Update the license checksum and verify the terms remain the same

Signed-off-by: Derek Straka <derek@asterius.io>
---
 meta-python/recipes-devtools/python/python-sqlalchemy.inc           | 6 +++---
 .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    | 0
 .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  | 0
 3 files changed, 3 insertions(+), 3 deletions(-)
 rename meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb} (100%)
 rename meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb} (100%)

diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
index 2683a6a..0c191ae 100644
--- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
+++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
@@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object Relational Mapper that gives \
 application developers the full power and flexibility of SQL"
 HOMEPAGE = "http://www.sqlalchemy.org/"
 LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
 
 PYPI_PACKAGE = "SQLAlchemy"
 inherit pypi
 
-SRC_URI[md5sum] = "077f9bd3339957f53068b5572a152674"
-SRC_URI[sha256sum] = "8b79a5ed91cdcb5abe97b0045664c55c140aec09e5dd5c01303e23de5fe7a95a"
+SRC_URI[md5sum] = "03db1c8f8ae911977c0bf3950a4c9c21"
+SRC_URI[sha256sum] = "6b55ec379c11ad696f9371ce8e0de93c7f21134323f56a56a1b0d8fbef17013c"
 
 RDEPENDS_${PN} += " \
     ${PYTHON_PN}-json \
diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy_1.1.15.bb b/meta-python/recipes-devtools/python/python-sqlalchemy_1.1.17.bb
similarity index 100%
rename from meta-python/recipes-devtools/python/python-sqlalchemy_1.1.15.bb
rename to meta-python/recipes-devtools/python/python-sqlalchemy_1.1.17.bb
diff --git a/meta-python/recipes-devtools/python/python3-sqlalchemy_1.1.15.bb b/meta-python/recipes-devtools/python/python3-sqlalchemy_1.1.17.bb
similarity index 100%
rename from meta-python/recipes-devtools/python/python3-sqlalchemy_1.1.15.bb
rename to meta-python/recipes-devtools/python/python3-sqlalchemy_1.1.17.bb
-- 
2.7.4

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Khem Raj]

On 3/2/18 6:06 AM, Derek Straka wrote:
> Update the license checksum and verify the terms remain the same
> 
> Signed-off-by: Derek Straka <derek@asterius.io>
> ---
>  meta-python/recipes-devtools/python/python-sqlalchemy.inc           | 6 +++---
>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    | 0
>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  | 0
>  3 files changed, 3 insertions(+), 3 deletions(-)
>  rename meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb} (100%)
>  rename meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb} (100%)
> 
> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> index 2683a6a..0c191ae 100644
> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object Relational Mapper that gives \
>  application developers the full power and flexibility of SQL"
>  HOMEPAGE = "http://www.sqlalchemy.org/"
>  LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>  

what changed here ?

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Derek Straka]

What more would you like in the commit message?  The license terms are the
same; the copyright moved to 2018.  Do we really need to put the results of
the diff in the commit message?

On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:

On 3/2/18 6:06 AM, Derek Straka wrote:
> Update the license checksum and verify the terms remain the same
>
> Signed-off-by: Derek Straka <derek@asterius.io>
> ---
>  meta-python/recipes-devtools/python/python-sqlalchemy.inc           | 6
+++---
>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    | 0
>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  | 0
>  3 files changed, 3 insertions(+), 3 deletions(-)
>  rename meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
=> python-sqlalchemy_1.1.17.bb} (100%)
>  rename meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
=> python3-sqlalchemy_1.1.17.bb} (100%)
>
> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> index 2683a6a..0c191ae 100644
> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object Relational
Mapper that gives \
>  application developers the full power and flexibility of SQL"
>  HOMEPAGE = "http://www.sqlalchemy.org/"
>  LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>

what changed here ?

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Khem Raj]

On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
> What more would you like in the commit message?  The license terms are the
> same; the copyright moved to 2018.  Do we really need to put the results of
> the diff in the commit message?
>

Not strictly, but you can. In general a line or two about the reason
is always a good thing.
The commit message wasn't clear about it.
This is essentially to let users as well as reviewers know that license changes
were reviewed and a line in commit message is there for later to go back
and see what changed


>
> On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>
> On 3/2/18 6:06 AM, Derek Straka wrote:
>> Update the license checksum and verify the terms remain the same
>>
>> Signed-off-by: Derek Straka <derek@asterius.io>
>> ---
>>  meta-python/recipes-devtools/python/python-sqlalchemy.inc           | 6
>> +++---
>>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    | 0
>>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  | 0
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>  rename meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
>> => python-sqlalchemy_1.1.17.bb} (100%)
>>  rename meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
>> => python3-sqlalchemy_1.1.17.bb} (100%)
>>
>> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> index 2683a6a..0c191ae 100644
>> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object Relational
>> Mapper that gives \
>>  application developers the full power and flexibility of SQL"
>>  HOMEPAGE = "http://www.sqlalchemy.org/"
>>  LICENSE = "MIT"
>> -LIC_FILES_CHKSUM = "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>>
>
> what changed here ?
>
>

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Derek Straka]

This is the exact same commit message I've used at least 10s of times
without any negative feedback.  Saying the terms remain the same seems
sufficient to me to acknowledge the fact I looked at the license and it was
reviewed as you stated.  I can start putting the diff in the commit if it
adds value but let's start being consistent as a community in what we
expect.

Even as a maintainer of several layers in meta-openembedded I don't know
what we as a community expect...

On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:

On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
> What more would you like in the commit message?  The license terms are the
> same; the copyright moved to 2018.  Do we really need to put the results
of
> the diff in the commit message?
>

Not strictly, but you can. In general a line or two about the reason
is always a good thing.
The commit message wasn't clear about it.
This is essentially to let users as well as reviewers know that license
changes
were reviewed and a line in commit message is there for later to go back
and see what changed


>
> On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>
> On 3/2/18 6:06 AM, Derek Straka wrote:
>> Update the license checksum and verify the terms remain the same
>>
>> Signed-off-by: Derek Straka <derek@asterius.io>
>> ---
>>  meta-python/recipes-devtools/python/python-sqlalchemy.inc           | 6
>> +++---
>>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    | 0
>>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  | 0
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>  rename meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
>> => python-sqlalchemy_1.1.17.bb} (100%)
>>  rename meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
>> => python3-sqlalchemy_1.1.17.bb} (100%)
>>
>> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> index 2683a6a..0c191ae 100644
>> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object Relational
>> Mapper that gives \
>>  application developers the full power and flexibility of SQL"
>>  HOMEPAGE = "http://www.sqlalchemy.org/"
>>  LICENSE = "MIT"
>> -LIC_FILES_CHKSUM = "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>>
>
> what changed here ?
>
>

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Tim Orling]

I usually would have said “the copyright year changed, but the terms remain
the same”, but I agree we need consistency. Tooling to make the license
diff easy to generate is probably the key (and is in progress).

Thank you again, Derek, for all your efforts to keep meta-python up to date.

And thank you to Khem for taking the time to review and comment when few
others ever do.

On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <derek@asterius.io> wrote:

> This is the exact same commit message I've used at least 10s of times
> without any negative feedback.  Saying the terms remain the same seems
> sufficient to me to acknowledge the fact I looked at the license and it was
> reviewed as you stated.  I can start putting the diff in the commit if it
> adds value but let's start being consistent as a community in what we
> expect.
>
> Even as a maintainer of several layers in meta-openembedded I don't know
> what we as a community expect...
>
> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>
> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
> > What more would you like in the commit message?  The license terms are
> the
> > same; the copyright moved to 2018.  Do we really need to put the results
> of
> > the diff in the commit message?
> >
>
> Not strictly, but you can. In general a line or two about the reason
> is always a good thing.
> The commit message wasn't clear about it.
> This is essentially to let users as well as reviewers know that license
> changes
> were reviewed and a line in commit message is there for later to go back
> and see what changed
>
>
> >
> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
> >
> > On 3/2/18 6:06 AM, Derek Straka wrote:
> >> Update the license checksum and verify the terms remain the same
> >>
> >> Signed-off-by: Derek Straka <derek@asterius.io>
> >> ---
> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc           | 6
> >> +++---
> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    |
> 0
> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  |
> 0
> >>  3 files changed, 3 insertions(+), 3 deletions(-)
> >>  rename meta-python/recipes-devtools/python/{
> python-sqlalchemy_1.1.15.bb
> >> => python-sqlalchemy_1.1.17.bb} (100%)
> >>  rename meta-python/recipes-devtools/python/{
> python3-sqlalchemy_1.1.15.bb
> >> => python3-sqlalchemy_1.1.17.bb} (100%)
> >>
> >> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >> index 2683a6a..0c191ae 100644
> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
> Relational
> >> Mapper that gives \
> >>  application developers the full power and flexibility of SQL"
> >>  HOMEPAGE = "http://www.sqlalchemy.org/"
> >>  LICENSE = "MIT"
> >> -LIC_FILES_CHKSUM =
> "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
> >> +LIC_FILES_CHKSUM =
> "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
> >>
> >
> > what changed here ?
> >
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Derek Straka]

Overall, it seems like there are bigger issues to worry about.  I just want
consistency.  I'm willing to conform to whatever people want.

On Mar 3, 2018 12:19 AM, "Tim Orling" <ticotimo@gmail.com> wrote:

> I usually would have said “the copyright year changed, but the terms
> remain the same”, but I agree we need consistency. Tooling to make the
> license diff easy to generate is probably the key (and is in progress).
>
> Thank you again, Derek, for all your efforts to keep meta-python up to
> date.
>
> And thank you to Khem for taking the time to review and comment when few
> others ever do.
>
> On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <derek@asterius.io> wrote:
>
>> This is the exact same commit message I've used at least 10s of times
>> without any negative feedback.  Saying the terms remain the same seems
>> sufficient to me to acknowledge the fact I looked at the license and it
>> was
>> reviewed as you stated.  I can start putting the diff in the commit if it
>> adds value but let's start being consistent as a community in what we
>> expect.
>>
>> Even as a maintainer of several layers in meta-openembedded I don't know
>> what we as a community expect...
>>
>> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>
>> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
>> > What more would you like in the commit message?  The license terms are
>> the
>> > same; the copyright moved to 2018.  Do we really need to put the results
>> of
>> > the diff in the commit message?
>> >
>>
>> Not strictly, but you can. In general a line or two about the reason
>> is always a good thing.
>> The commit message wasn't clear about it.
>> This is essentially to let users as well as reviewers know that license
>> changes
>> were reviewed and a line in commit message is there for later to go back
>> and see what changed
>>
>>
>> >
>> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>> >
>> > On 3/2/18 6:06 AM, Derek Straka wrote:
>> >> Update the license checksum and verify the terms remain the same
>> >>
>> >> Signed-off-by: Derek Straka <derek@asterius.io>
>> >> ---
>> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>  | 6
>> >> +++---
>> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}
>> | 0
>> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}
>> | 0
>> >>  3 files changed, 3 insertions(+), 3 deletions(-)
>> >>  rename meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.
>> 15.bb
>> >> => python-sqlalchemy_1.1.17.bb} (100%)
>> >>  rename meta-python/recipes-devtools/python/{python3-sqlalchemy_1.
>> 1.15.bb
>> >> => python3-sqlalchemy_1.1.17.bb} (100%)
>> >>
>> >> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> index 2683a6a..0c191ae 100644
>> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
>> Relational
>> >> Mapper that gives \
>> >>  application developers the full power and flexibility of SQL"
>> >>  HOMEPAGE = "http://www.sqlalchemy.org/"
>> >>  LICENSE = "MIT"
>> >> -LIC_FILES_CHKSUM = "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf5
>> 38"
>> >> +LIC_FILES_CHKSUM = "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22
>> bb"
>> >>
>> >
>> > what changed here ?
>> >
>> >
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
>

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Khem Raj]

On Fri, Mar 2, 2018 at 9:22 PM, Derek Straka <derek@asterius.io> wrote:
> Overall, it seems like there are bigger issues to worry about.  I just want
> consistency.  I'm willing to conform to whatever people want.
>

There is no issue here.

read through several reviews on ML where license checksums are changed,
you will find reviewers calling out of explanations if it was missing.

moreover Its also described in commit guidelines

https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Describing_license_changes


> On Mar 3, 2018 12:19 AM, "Tim Orling" <ticotimo@gmail.com> wrote:
>>
>> I usually would have said “the copyright year changed, but the terms
>> remain the same”, but I agree we need consistency. Tooling to make the
>> license diff easy to generate is probably the key (and is in progress).
>>
>> Thank you again, Derek, for all your efforts to keep meta-python up to
>> date.
>>
>> And thank you to Khem for taking the time to review and comment when few
>> others ever do.
>>
>> On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <derek@asterius.io> wrote:
>>>
>>> This is the exact same commit message I've used at least 10s of times
>>> without any negative feedback.  Saying the terms remain the same seems
>>> sufficient to me to acknowledge the fact I looked at the license and it
>>> was
>>> reviewed as you stated.  I can start putting the diff in the commit if it
>>> adds value but let's start being consistent as a community in what we
>>> expect.
>>>
>>> Even as a maintainer of several layers in meta-openembedded I don't know
>>> what we as a community expect...
>>>
>>> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>>
>>> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
>>> > What more would you like in the commit message?  The license terms are
>>> > the
>>> > same; the copyright moved to 2018.  Do we really need to put the
>>> > results
>>> of
>>> > the diff in the commit message?
>>> >
>>>
>>> Not strictly, but you can. In general a line or two about the reason
>>> is always a good thing.
>>> The commit message wasn't clear about it.
>>> This is essentially to let users as well as reviewers know that license
>>> changes
>>> were reviewed and a line in commit message is there for later to go back
>>> and see what changed
>>>
>>>
>>> >
>>> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>> >
>>> > On 3/2/18 6:06 AM, Derek Straka wrote:
>>> >> Update the license checksum and verify the terms remain the same
>>> >>
>>> >> Signed-off-by: Derek Straka <derek@asterius.io>
>>> >> ---
>>> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc           |
>>> >> 6
>>> >> +++---
>>> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    |
>>> >> 0
>>> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  |
>>> >> 0
>>> >>  3 files changed, 3 insertions(+), 3 deletions(-)
>>> >>  rename
>>> >> meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
>>> >> => python-sqlalchemy_1.1.17.bb} (100%)
>>> >>  rename
>>> >> meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
>>> >> => python3-sqlalchemy_1.1.17.bb} (100%)
>>> >>
>>> >> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>> >> index 2683a6a..0c191ae 100644
>>> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
>>> >> Relational
>>> >> Mapper that gives \
>>> >>  application developers the full power and flexibility of SQL"
>>> >>  HOMEPAGE = "http://www.sqlalchemy.org/"
>>> >>  LICENSE = "MIT"
>>> >> -LIC_FILES_CHKSUM =
>>> >> "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
>>> >> +LIC_FILES_CHKSUM =
>>> >> "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>>> >>
>>> >
>>> > what changed here ?
>>> >
>>> >
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Khem Raj]

On Fri, Mar 2, 2018 at 9:19 PM, Tim Orling <ticotimo@gmail.com> wrote:
> I usually would have said “the copyright year changed, but the terms remain
> the same”, but I agree we need consistency. Tooling to make the license diff
> easy to generate is probably the key (and is in progress).

This is documented it in commit guidelines for OE, so consistency is
soft imposed.
and I expect maintainers/reviewers to help point this out whenever they can
but tooling would certainly help,

this information is very helpful to end users, who ship products and
have to meet compliance
requirements with their licensing policy, whenever they upgrade packages

>
> Thank you again, Derek, for all your efforts to keep meta-python up to date.
>
> And thank you to Khem for taking the time to review and comment when few
> others ever do.
>
> On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <derek@asterius.io> wrote:
>>
>> This is the exact same commit message I've used at least 10s of times
>> without any negative feedback.  Saying the terms remain the same seems
>> sufficient to me to acknowledge the fact I looked at the license and it
>> was
>> reviewed as you stated.  I can start putting the diff in the commit if it
>> adds value but let's start being consistent as a community in what we
>> expect.
>>
>> Even as a maintainer of several layers in meta-openembedded I don't know
>> what we as a community expect...
>>
>> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>
>> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
>> > What more would you like in the commit message?  The license terms are
>> > the
>> > same; the copyright moved to 2018.  Do we really need to put the results
>> of
>> > the diff in the commit message?
>> >
>>
>> Not strictly, but you can. In general a line or two about the reason
>> is always a good thing.
>> The commit message wasn't clear about it.
>> This is essentially to let users as well as reviewers know that license
>> changes
>> were reviewed and a line in commit message is there for later to go back
>> and see what changed
>>
>>
>> >
>> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>> >
>> > On 3/2/18 6:06 AM, Derek Straka wrote:
>> >> Update the license checksum and verify the terms remain the same
>> >>
>> >> Signed-off-by: Derek Straka <derek@asterius.io>
>> >> ---
>> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc           |
>> >> 6
>> >> +++---
>> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}    |
>> >> 0
>> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}  |
>> >> 0
>> >>  3 files changed, 3 insertions(+), 3 deletions(-)
>> >>  rename
>> >> meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
>> >> => python-sqlalchemy_1.1.17.bb} (100%)
>> >>  rename
>> >> meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
>> >> => python3-sqlalchemy_1.1.17.bb} (100%)
>> >>
>> >> diff --git a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> index 2683a6a..0c191ae 100644
>> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
>> >> Relational
>> >> Mapper that gives \
>> >>  application developers the full power and flexibility of SQL"
>> >>  HOMEPAGE = "http://www.sqlalchemy.org/"
>> >>  LICENSE = "MIT"
>> >> -LIC_FILES_CHKSUM =
>> >> "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
>> >> +LIC_FILES_CHKSUM =
>> >> "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>> >>
>> >
>> > what changed here ?
>> >
>> >
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Derek Straka]

Sure.  I'll start following those requirements, but honestly one of the
reasons I dislike contributing to anything yocto/meta-oe is the lack of
clear rules and consistency in general.  Most of the wiki page are
completely out of date and none of the style items are consistently
enforced.  It makes it difficult to contribute and discourages
contributions at least for me.

On Mar 3, 2018 12:57 AM, "Khem Raj" <raj.khem@gmail.com> wrote:

On Fri, Mar 2, 2018 at 9:22 PM, Derek Straka <derek@asterius.io> wrote:
> Overall, it seems like there are bigger issues to worry about.  I just
want
> consistency.  I'm willing to conform to whatever people want.
>

There is no issue here.

read through several reviews on ML where license checksums are changed,
you will find reviewers calling out of explanations if it was missing.

moreover Its also described in commit guidelines

https://www.openembedded.org/wiki/Commit_Patch_Message_
Guidelines#Describing_license_changes


> On Mar 3, 2018 12:19 AM, "Tim Orling" <ticotimo@gmail.com> wrote:
>>
>> I usually would have said “the copyright year changed, but the terms
>> remain the same”, but I agree we need consistency. Tooling to make the
>> license diff easy to generate is probably the key (and is in progress).
>>
>> Thank you again, Derek, for all your efforts to keep meta-python up to
>> date.
>>
>> And thank you to Khem for taking the time to review and comment when few
>> others ever do.
>>
>> On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <derek@asterius.io> wrote:
>>>
>>> This is the exact same commit message I've used at least 10s of times
>>> without any negative feedback.  Saying the terms remain the same seems
>>> sufficient to me to acknowledge the fact I looked at the license and it
>>> was
>>> reviewed as you stated.  I can start putting the diff in the commit if
it
>>> adds value but let's start being consistent as a community in what we
>>> expect.
>>>
>>> Even as a maintainer of several layers in meta-openembedded I don't know
>>> what we as a community expect...
>>>
>>> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>>
>>> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
>>> > What more would you like in the commit message?  The license terms are
>>> > the
>>> > same; the copyright moved to 2018.  Do we really need to put the
>>> > results
>>> of
>>> > the diff in the commit message?
>>> >
>>>
>>> Not strictly, but you can. In general a line or two about the reason
>>> is always a good thing.
>>> The commit message wasn't clear about it.
>>> This is essentially to let users as well as reviewers know that license
>>> changes
>>> were reviewed and a line in commit message is there for later to go back
>>> and see what changed
>>>
>>>
>>> >
>>> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>> >
>>> > On 3/2/18 6:06 AM, Derek Straka wrote:
>>> >> Update the license checksum and verify the terms remain the same
>>> >>
>>> >> Signed-off-by: Derek Straka <derek@asterius.io>
>>> >> ---
>>> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc
 |
>>> >> 6
>>> >> +++---
>>> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}
|
>>> >> 0
>>> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}
|
>>> >> 0
>>> >>  3 files changed, 3 insertions(+), 3 deletions(-)
>>> >>  rename
>>> >> meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
>>> >> => python-sqlalchemy_1.1.17.bb} (100%)
>>> >>  rename
>>> >> meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
>>> >> => python3-sqlalchemy_1.1.17.bb} (100%)
>>> >>
>>> >> diff --git a/meta-python/recipes-devtools/python/python-
sqlalchemy.inc
>>> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>> >> index 2683a6a..0c191ae 100644
>>> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
>>> >> Relational
>>> >> Mapper that gives \
>>> >>  application developers the full power and flexibility of SQL"
>>> >>  HOMEPAGE = "http://www.sqlalchemy.org/"
>>> >>  LICENSE = "MIT"
>>> >> -LIC_FILES_CHKSUM =
>>> >> "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
>>> >> +LIC_FILES_CHKSUM =
>>> >> "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>>> >>
>>> >
>>> > what changed here ?
>>> >
>>> >
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Khem Raj]

On Fri, Mar 2, 2018 at 10:06 PM, Derek Straka <derek@asterius.io> wrote:
> Sure.  I'll start following those requirements, but honestly one of the
> reasons I dislike contributing to anything yocto/meta-oe is the lack of
> clear rules and consistency in general.  Most of the wiki page are
> completely out of date and none of the style items are consistently
> enforced.  It makes it difficult to contribute and discourages contributions
> at least for me.

Its a good point and I think if there are ideas how to improve this
situation would help
the community in general. My intention to provide feedback on your patch
was not to discourage you from contributing but to make the patch a bit better.
you can ignore the feedback if you think it is inadequate and not important
but certainly not feel discouraged. Your contributions are always appreciated.

>
> On Mar 3, 2018 12:57 AM, "Khem Raj" <raj.khem@gmail.com> wrote:
>
> On Fri, Mar 2, 2018 at 9:22 PM, Derek Straka <derek@asterius.io> wrote:
>> Overall, it seems like there are bigger issues to worry about.  I just
>> want
>> consistency.  I'm willing to conform to whatever people want.
>>
>
> There is no issue here.
>
> read through several reviews on ML where license checksums are changed,
> you will find reviewers calling out of explanations if it was missing.
>
> moreover Its also described in commit guidelines
>
> https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Describing_license_changes
>
>
>> On Mar 3, 2018 12:19 AM, "Tim Orling" <ticotimo@gmail.com> wrote:
>>>
>>> I usually would have said “the copyright year changed, but the terms
>>> remain the same”, but I agree we need consistency. Tooling to make the
>>> license diff easy to generate is probably the key (and is in progress).
>>>
>>> Thank you again, Derek, for all your efforts to keep meta-python up to
>>> date.
>>>
>>> And thank you to Khem for taking the time to review and comment when few
>>> others ever do.
>>>
>>> On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <derek@asterius.io> wrote:
>>>>
>>>> This is the exact same commit message I've used at least 10s of times
>>>> without any negative feedback.  Saying the terms remain the same seems
>>>> sufficient to me to acknowledge the fact I looked at the license and it
>>>> was
>>>> reviewed as you stated.  I can start putting the diff in the commit if
>>>> it
>>>> adds value but let's start being consistent as a community in what we
>>>> expect.
>>>>
>>>> Even as a maintainer of several layers in meta-openembedded I don't know
>>>> what we as a community expect...
>>>>
>>>> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>>>
>>>> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io> wrote:
>>>> > What more would you like in the commit message?  The license terms are
>>>> > the
>>>> > same; the copyright moved to 2018.  Do we really need to put the
>>>> > results
>>>> of
>>>> > the diff in the commit message?
>>>> >
>>>>
>>>> Not strictly, but you can. In general a line or two about the reason
>>>> is always a good thing.
>>>> The commit message wasn't clear about it.
>>>> This is essentially to let users as well as reviewers know that license
>>>> changes
>>>> were reviewed and a line in commit message is there for later to go back
>>>> and see what changed
>>>>
>>>>
>>>> >
>>>> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
>>>> >
>>>> > On 3/2/18 6:06 AM, Derek Straka wrote:
>>>> >> Update the license checksum and verify the terms remain the same
>>>> >>
>>>> >> Signed-off-by: Derek Straka <derek@asterius.io>
>>>> >> ---
>>>> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>>> >> |
>>>> >> 6
>>>> >> +++---
>>>> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}
>>>> >> |
>>>> >> 0
>>>> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb}
>>>> >> |
>>>> >> 0
>>>> >>  3 files changed, 3 insertions(+), 3 deletions(-)
>>>> >>  rename
>>>> >> meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
>>>> >> => python-sqlalchemy_1.1.17.bb} (100%)
>>>> >>  rename
>>>> >> meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
>>>> >> => python3-sqlalchemy_1.1.17.bb} (100%)
>>>> >>
>>>> >> diff --git
>>>> >> a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>>> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>>> >> index 2683a6a..0c191ae 100644
>>>> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>>> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
>>>> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
>>>> >> Relational
>>>> >> Mapper that gives \
>>>> >>  application developers the full power and flexibility of SQL"
>>>> >>  HOMEPAGE = "http://www.sqlalchemy.org/"
>>>> >>  LICENSE = "MIT"
>>>> >> -LIC_FILES_CHKSUM =
>>>> >> "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
>>>> >> +LIC_FILES_CHKSUM =
>>>> >> "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
>>>> >>
>>>> >
>>>> > what changed here ?
>>>> >
>>>> >
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>

Re: [meta-python][PATCH] python-sqlalchemy: update to version 1.1.17

[Derek Straka]

I'll send it a v2 this morning.  Thanks for the feedback.

-Derek

On Mar 3, 2018 5:22 AM, "Khem Raj" <raj.khem@gmail.com> wrote:

> On Fri, Mar 2, 2018 at 10:06 PM, Derek Straka <derek@asterius.io> wrote:
> > Sure.  I'll start following those requirements, but honestly one of the
> > reasons I dislike contributing to anything yocto/meta-oe is the lack of
> > clear rules and consistency in general.  Most of the wiki page are
> > completely out of date and none of the style items are consistently
> > enforced.  It makes it difficult to contribute and discourages
> contributions
> > at least for me.
>
> Its a good point and I think if there are ideas how to improve this
> situation would help
> the community in general. My intention to provide feedback on your patch
> was not to discourage you from contributing but to make the patch a bit
> better.
> you can ignore the feedback if you think it is inadequate and not important
> but certainly not feel discouraged. Your contributions are always
> appreciated.
>
> >
> > On Mar 3, 2018 12:57 AM, "Khem Raj" <raj.khem@gmail.com> wrote:
> >
> > On Fri, Mar 2, 2018 at 9:22 PM, Derek Straka <derek@asterius.io> wrote:
> >> Overall, it seems like there are bigger issues to worry about.  I just
> >> want
> >> consistency.  I'm willing to conform to whatever people want.
> >>
> >
> > There is no issue here.
> >
> > read through several reviews on ML where license checksums are changed,
> > you will find reviewers calling out of explanations if it was missing.
> >
> > moreover Its also described in commit guidelines
> >
> > https://www.openembedded.org/wiki/Commit_Patch_Message_
> Guidelines#Describing_license_changes
> >
> >
> >> On Mar 3, 2018 12:19 AM, "Tim Orling" <ticotimo@gmail.com> wrote:
> >>>
> >>> I usually would have said “the copyright year changed, but the terms
> >>> remain the same”, but I agree we need consistency. Tooling to make the
> >>> license diff easy to generate is probably the key (and is in progress).
> >>>
> >>> Thank you again, Derek, for all your efforts to keep meta-python up to
> >>> date.
> >>>
> >>> And thank you to Khem for taking the time to review and comment when
> few
> >>> others ever do.
> >>>
> >>> On Fri, Mar 2, 2018 at 8:45 PM Derek Straka <derek@asterius.io> wrote:
> >>>>
> >>>> This is the exact same commit message I've used at least 10s of times
> >>>> without any negative feedback.  Saying the terms remain the same seems
> >>>> sufficient to me to acknowledge the fact I looked at the license and
> it
> >>>> was
> >>>> reviewed as you stated.  I can start putting the diff in the commit if
> >>>> it
> >>>> adds value but let's start being consistent as a community in what we
> >>>> expect.
> >>>>
> >>>> Even as a maintainer of several layers in meta-openembedded I don't
> know
> >>>> what we as a community expect...
> >>>>
> >>>> On Mar 2, 2018 11:34 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
> >>>>
> >>>> On Fri, Mar 2, 2018 at 8:15 PM, Derek Straka <derek@asterius.io>
> wrote:
> >>>> > What more would you like in the commit message?  The license terms
> are
> >>>> > the
> >>>> > same; the copyright moved to 2018.  Do we really need to put the
> >>>> > results
> >>>> of
> >>>> > the diff in the commit message?
> >>>> >
> >>>>
> >>>> Not strictly, but you can. In general a line or two about the reason
> >>>> is always a good thing.
> >>>> The commit message wasn't clear about it.
> >>>> This is essentially to let users as well as reviewers know that
> license
> >>>> changes
> >>>> were reviewed and a line in commit message is there for later to go
> back
> >>>> and see what changed
> >>>>
> >>>>
> >>>> >
> >>>> > On Mar 2, 2018 9:52 PM, "Khem Raj" <raj.khem@gmail.com> wrote:
> >>>> >
> >>>> > On 3/2/18 6:06 AM, Derek Straka wrote:
> >>>> >> Update the license checksum and verify the terms remain the same
> >>>> >>
> >>>> >> Signed-off-by: Derek Straka <derek@asterius.io>
> >>>> >> ---
> >>>> >>  meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >>>> >> |
> >>>> >> 6
> >>>> >> +++---
> >>>> >>  .../{python-sqlalchemy_1.1.15.bb => python-sqlalchemy_1.1.17.bb}
> >>>> >> |
> >>>> >> 0
> >>>> >>  .../{python3-sqlalchemy_1.1.15.bb => python3-sqlalchemy_1.1.17.bb
> }
> >>>> >> |
> >>>> >> 0
> >>>> >>  3 files changed, 3 insertions(+), 3 deletions(-)
> >>>> >>  rename
> >>>> >> meta-python/recipes-devtools/python/{python-sqlalchemy_1.1.15.bb
> >>>> >> => python-sqlalchemy_1.1.17.bb} (100%)
> >>>> >>  rename
> >>>> >> meta-python/recipes-devtools/python/{python3-sqlalchemy_1.1.15.bb
> >>>> >> => python3-sqlalchemy_1.1.17.bb} (100%)
> >>>> >>
> >>>> >> diff --git
> >>>> >> a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >>>> >> b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >>>> >> index 2683a6a..0c191ae 100644
> >>>> >> --- a/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >>>> >> +++ b/meta-python/recipes-devtools/python/python-sqlalchemy.inc
> >>>> >> @@ -2,13 +2,13 @@ DESCRIPTION = "Python SQL toolkit and Object
> >>>> >> Relational
> >>>> >> Mapper that gives \
> >>>> >>  application developers the full power and flexibility of SQL"
> >>>> >>  HOMEPAGE = "http://www.sqlalchemy.org/"
> >>>> >>  LICENSE = "MIT"
> >>>> >> -LIC_FILES_CHKSUM =
> >>>> >> "file://LICENSE;md5=452f4b8adb0feba42e5be5f1fbfbf538"
> >>>> >> +LIC_FILES_CHKSUM =
> >>>> >> "file://LICENSE;md5=b1c412c9d8d1ce018f7a9374407c22bb"
> >>>> >>
> >>>> >
> >>>> > what changed here ?
> >>>> >
> >>>> >
> >>>> --
> >>>> _______________________________________________
> >>>> Openembedded-devel mailing list
> >>>> Openembedded-devel@lists.openembedded.org
> >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
>