From: Li Yang <leoyang.li@nxp.com>
To: Will Deacon <will@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
lkml <linux-kernel@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel
Date: Wed, 12 Feb 2020 13:59:46 -0600 [thread overview]
Message-ID: <CADRPPNQ-FcA-xdjp02ybsYeU9UFxCZU5dpf0wHThTmLHcjovCQ@mail.gmail.com> (raw)
In-Reply-To: <20200212104902.GA3664@willie-the-truck>
On Wed, Feb 12, 2020 at 4:50 AM Will Deacon <will@kernel.org> wrote:
>
> On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote:
> > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module")
> > introduced a side effect that changed the module name from arm-smmu to
> > arm-smmu-mod. This breaks the users of kernel parameters for the driver
> > (e.g. arm-smmu.disable_bypass). This patch changes the module name back
> > to be consistent.
> >
> > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > ---
> > drivers/iommu/Makefile | 4 ++--
> > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%)
>
> Can't we just override MODULE_PARAM_PREFIX instead of renaming the file?
I can do that. But on the other hand, the "mod" in the module name
arm-smmu-mod.ko seems to be redundant and looks a little bit weird.
Wouldn't it be cleaner to make it just arm-smmu.ko?
Regards,
Leo
WARNING: multiple messages have this Message-ID (diff)
From: Li Yang <leoyang.li@nxp.com>
To: Will Deacon <will@kernel.org>
Cc: Will Deacon <will.deacon@arm.com>,
lkml <linux-kernel@vger.kernel.org>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel
Date: Wed, 12 Feb 2020 13:59:46 -0600 [thread overview]
Message-ID: <CADRPPNQ-FcA-xdjp02ybsYeU9UFxCZU5dpf0wHThTmLHcjovCQ@mail.gmail.com> (raw)
In-Reply-To: <20200212104902.GA3664@willie-the-truck>
On Wed, Feb 12, 2020 at 4:50 AM Will Deacon <will@kernel.org> wrote:
>
> On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote:
> > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module")
> > introduced a side effect that changed the module name from arm-smmu to
> > arm-smmu-mod. This breaks the users of kernel parameters for the driver
> > (e.g. arm-smmu.disable_bypass). This patch changes the module name back
> > to be consistent.
> >
> > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > ---
> > drivers/iommu/Makefile | 4 ++--
> > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%)
>
> Can't we just override MODULE_PARAM_PREFIX instead of renaming the file?
I can do that. But on the other hand, the "mod" in the module name
arm-smmu-mod.ko seems to be redundant and looks a little bit weird.
Wouldn't it be cleaner to make it just arm-smmu.ko?
Regards,
Leo
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Li Yang <leoyang.li@nxp.com>
To: Will Deacon <will@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
lkml <linux-kernel@vger.kernel.org>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel
Date: Wed, 12 Feb 2020 13:59:46 -0600 [thread overview]
Message-ID: <CADRPPNQ-FcA-xdjp02ybsYeU9UFxCZU5dpf0wHThTmLHcjovCQ@mail.gmail.com> (raw)
In-Reply-To: <20200212104902.GA3664@willie-the-truck>
On Wed, Feb 12, 2020 at 4:50 AM Will Deacon <will@kernel.org> wrote:
>
> On Tue, Feb 11, 2020 at 06:37:20PM -0600, Li Yang wrote:
> > Commit cd221bd24ff5 ("iommu/arm-smmu: Allow building as a module")
> > introduced a side effect that changed the module name from arm-smmu to
> > arm-smmu-mod. This breaks the users of kernel parameters for the driver
> > (e.g. arm-smmu.disable_bypass). This patch changes the module name back
> > to be consistent.
> >
> > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > ---
> > drivers/iommu/Makefile | 4 ++--
> > drivers/iommu/{arm-smmu.c => arm-smmu-common.c} | 0
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> > rename drivers/iommu/{arm-smmu.c => arm-smmu-common.c} (100%)
>
> Can't we just override MODULE_PARAM_PREFIX instead of renaming the file?
I can do that. But on the other hand, the "mod" in the module name
arm-smmu-mod.ko seems to be redundant and looks a little bit weird.
Wouldn't it be cleaner to make it just arm-smmu.ko?
Regards,
Leo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-12 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 0:37 [PATCH] iommu/arm-smmu: fix the module name to be consistent with older kernel Li Yang
2020-02-12 0:37 ` Li Yang
2020-02-12 0:37 ` Li Yang
2020-02-12 10:49 ` Will Deacon
2020-02-12 10:49 ` Will Deacon
2020-02-12 10:49 ` Will Deacon
2020-02-12 19:59 ` Li Yang [this message]
2020-02-12 19:59 ` Li Yang
2020-02-12 19:59 ` Li Yang
2020-02-13 9:16 ` Will Deacon
2020-02-13 9:16 ` Will Deacon
2020-02-13 9:16 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADRPPNQ-FcA-xdjp02ybsYeU9UFxCZU5dpf0wHThTmLHcjovCQ@mail.gmail.com \
--to=leoyang.li@nxp.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.