All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neal Cardwell <ncardwell@google.com>
To: marcelo.leitner@gmail.com
Cc: Michael Tuexen <michael.tuexen@lurchi.franken.de>,
	nhorman@tuxdriver.com, Dmitry Vyukov <dvyukov@google.com>,
	lucien.xin@gmail.com, Netdev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, David Miller <davem@davemloft.net>,
	dsa@cumulusnetworks.com, Eric Dumazet <edumazet@google.com>,
	syzkaller@googlegroups.com
Subject: Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs
Date: Tue, 29 May 2018 12:03:46 -0400	[thread overview]
Message-ID: <CADVnQymCNEtQFThsbQ0u7jirx24i45f5L7P-2dPf8omkshqwmg@mail.gmail.com> (raw)
In-Reply-To: <20180529154514.GC3788@localhost.localdomain>

On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner <
marcelo.leitner@gmail.com> wrote:
> - patch2 - fix rtx attack vector
>    - Add the floor value to rto_min to HZ/20 (which fits the values
>      that Michael shared on the other email)

I would encourage allowing minimum RTO values down to 5ms, if the ACK
policy in the receiver makes this feasible. Our experience is that in
datacenter environments it can be advantageous to allow timer-based loss
recoveries using timeout values as low as 5ms, e.g.:


https://www.ietf.org/proceedings/97/slides/slides-97-tcpm-tcp-options-for-low-latency-00.pdf
   https://tools.ietf.org/html/draft-wang-tcpm-low-latency-opt-00

cheers,
neal

WARNING: multiple messages have this Message-ID (diff)
From: Neal Cardwell <ncardwell@google.com>
To: marcelo.leitner@gmail.com
Cc: Michael Tuexen <michael.tuexen@lurchi.franken.de>,
	nhorman@tuxdriver.com, Dmitry Vyukov <dvyukov@google.com>,
	lucien.xin@gmail.com, Netdev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, David Miller <davem@davemloft.net>,
	dsa@cumulusnetworks.com, Eric Dumazet <edumazet@google.com>,
	syzkaller@googlegroups.com
Subject: Re: [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs
Date: Tue, 29 May 2018 16:03:46 +0000	[thread overview]
Message-ID: <CADVnQymCNEtQFThsbQ0u7jirx24i45f5L7P-2dPf8omkshqwmg@mail.gmail.com> (raw)
In-Reply-To: <20180529154514.GC3788@localhost.localdomain>

On Tue, May 29, 2018 at 11:45 AM Marcelo Ricardo Leitner <
marcelo.leitner@gmail.com> wrote:
> - patch2 - fix rtx attack vector
>    - Add the floor value to rto_min to HZ/20 (which fits the values
>      that Michael shared on the other email)

I would encourage allowing minimum RTO values down to 5ms, if the ACK
policy in the receiver makes this feasible. Our experience is that in
datacenter environments it can be advantageous to allow timer-based loss
recoveries using timeout values as low as 5ms, e.g.:


https://www.ietf.org/proceedings/97/slides/slides-97-tcpm-tcp-options-for-low-latency-00.pdf
   https://tools.ietf.org/html/draft-wang-tcpm-low-latency-opt-00

cheers,
neal

  reply	other threads:[~2018-05-29 16:04 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 17:41 [PATCH net] sctp: not allow to set rto_min with a value below 200 msecs Xin Long
2018-05-25 17:41 ` Xin Long
2018-05-25 19:13 ` Neil Horman
2018-05-25 19:13   ` Neil Horman
2018-05-26 15:42   ` Michael Tuexen
2018-05-26 15:42     ` Michael Tuexen
2018-05-26 15:50     ` Dmitry Vyukov
2018-05-26 15:50       ` Dmitry Vyukov
2018-05-27  1:01       ` Neil Horman
2018-05-27  1:01         ` Neil Horman
2018-05-28 19:43         ` Marcelo Ricardo Leitner
2018-05-28 19:43           ` Marcelo Ricardo Leitner
2018-05-29 11:41           ` Neil Horman
2018-05-29 11:41             ` Neil Horman
2018-05-29 13:06             ` Michael Tuexen
2018-05-29 13:06               ` Michael Tuexen
2018-05-29 15:45               ` Marcelo Ricardo Leitner
2018-05-29 15:45                 ` Marcelo Ricardo Leitner
2018-05-29 16:03                 ` Neal Cardwell [this message]
2018-05-29 16:03                   ` Neal Cardwell
2018-05-29 17:06                   ` Marcelo Ricardo Leitner
2018-05-29 17:06                     ` Marcelo Ricardo Leitner
2018-05-29 17:45                     ` Xin Long
2018-05-29 17:45                       ` Xin Long
2018-05-29 18:02                       ` Marcelo Ricardo Leitner
2018-05-29 18:02                         ` Marcelo Ricardo Leitner
2018-06-04  8:34                       ` Dmitry Vyukov
2018-06-04  8:34                         ` Dmitry Vyukov
2018-06-04 12:15                         ` Xin Long
2018-06-04 12:15                           ` Xin Long
2018-05-27  8:58       ` Michael Tuexen
2018-05-27  8:58         ` Michael Tuexen
2018-05-28 18:56         ` Marcelo Ricardo Leitner
2018-05-28 18:56           ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADVnQymCNEtQFThsbQ0u7jirx24i45f5L7P-2dPf8omkshqwmg@mail.gmail.com \
    --to=ncardwell@google.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=michael.tuexen@lurchi.franken.de \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.