[PATCH] arm64: dts: freescale: fix typo Makefile

[PATCH] arm64: dts: freescale: fix typo Makefile

[Anders Roxell]

While trying to do 'make dtbs_install' the following error shows up

make[3]: *** No rule to make target
  '/srv/src/kernel/next/out/obj-arm64-next-20201105/dtbsinstall/freescale/imx8mm-kontron-n801x-s.dts',
  needed by '__dtbs_install'.
make[3]: Target '__dtbs_install' not remade because of errors.
make[2]: *** [/srv/src/kernel/bisecting/scripts/Makefile.dtbinst:34:
  arch/arm64/boot/dts/freescale] Error 2
make[2]: Target '__dtbs_install' not remade because of errors.
make[1]: *** [/srv/src/kernel/bisecting/Makefile:1344: dtbs_install]
  Error 2
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'dtbs_install' not remade because of errors.

Fix typo in imx8mm-kontron-n801x-s.dts change file ending to *.dtb

Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 arch/arm64/boot/dts/freescale/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 876bf484bbe6..6f0777ee6cd6 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -32,7 +32,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
-dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dts
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
-- 
2.28.0

Re: [PATCH] arm64: dts: freescale: fix typo Makefile

[Krzysztof Kozlowski]

On Thu, Nov 05, 2020 at 12:18:23PM +0100, Anders Roxell wrote:
> While trying to do 'make dtbs_install' the following error shows up
> 
> make[3]: *** No rule to make target
>   '/srv/src/kernel/next/out/obj-arm64-next-20201105/dtbsinstall/freescale/imx8mm-kontron-n801x-s.dts',
>   needed by '__dtbs_install'.
> make[3]: Target '__dtbs_install' not remade because of errors.
> make[2]: *** [/srv/src/kernel/bisecting/scripts/Makefile.dtbinst:34:
>   arch/arm64/boot/dts/freescale] Error 2
> make[2]: Target '__dtbs_install' not remade because of errors.
> make[1]: *** [/srv/src/kernel/bisecting/Makefile:1344: dtbs_install]
>   Error 2
> make: *** [Makefile:185: __sub-make] Error 2
> make: Target 'dtbs_install' not remade because of errors.

Don't paste unrelated messages and don't wrap too early ("Error 2"
should not be after new line). This blob is not useful at all.

Keep only first two lines, all rest is meaningless.

> 
> Fix typo in imx8mm-kontron-n801x-s.dts change file ending to *.dtb
> 
> Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

You need to CC the maintainers of platform. Unfortunately Makefile is
not included, so point to the DTS file to get the proper folks and
mailing lists.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: freescale: fix typo Makefile

[Anders Roxell]

On Fri, 6 Nov 2020 at 16:12, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Thu, Nov 05, 2020 at 12:18:23PM +0100, Anders Roxell wrote:
> > While trying to do 'make dtbs_install' the following error shows up
> >
> > make[3]: *** No rule to make target
> >   '/srv/src/kernel/next/out/obj-arm64-next-20201105/dtbsinstall/freescale/imx8mm-kontron-n801x-s.dts',
> >   needed by '__dtbs_install'.
> > make[3]: Target '__dtbs_install' not remade because of errors.
> > make[2]: *** [/srv/src/kernel/bisecting/scripts/Makefile.dtbinst:34:
> >   arch/arm64/boot/dts/freescale] Error 2
> > make[2]: Target '__dtbs_install' not remade because of errors.
> > make[1]: *** [/srv/src/kernel/bisecting/Makefile:1344: dtbs_install]
> >   Error 2
> > make: *** [Makefile:185: __sub-make] Error 2
> > make: Target 'dtbs_install' not remade because of errors.
>
> Don't paste unrelated messages and don't wrap too early ("Error 2"
> should not be after new line). This blob is not useful at all.
>
> Keep only first two lines, all rest is meaningless.

Thank you for your review Krzysztof, I'll do that.

>
> >
> > Fix typo in imx8mm-kontron-n801x-s.dts change file ending to *.dtb
> >
> > Fixes: 8668d8b2e67f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards")
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> You need to CC the maintainers of platform. Unfortunately Makefile is
> not included, so point to the DTS file to get the proper folks and
> mailing lists.

Ok, I'll send out a v2 shortly.

Cheers,
Anders