* [net-next regression] kselftest failure in fib_nl_newrule()
@ 2018-04-24 9:46 Anders Roxell
2018-04-24 16:17 ` Roopa Prabhu
0 siblings, 1 reply; 2+ messages in thread
From: Anders Roxell @ 2018-04-24 9:46 UTC (permalink / raw)
To: roopa, davem, dsa; +Cc: netdev, Linux Kernel Mailing List
Hi,
fib-onlink-tests.sh (from kselftest) found a regression between
next-20180424 [1] (worked with tag next-20180423 [2])
here is tree commits that look suspicious specially this patch (sha:
f9d4b0c1e969)
rewrites fib_nl_newrule().his patch (sha: f9d4b0c1e969) rewrites
fib_nl_newrule().
b16fb418b1bf ("net: fib_rules: add extack support")
f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs
into fib_nl2rule")
8a14e46f1402 ("net/ipv6: Fix missing rcu dereferences on from")
Cheers,
Anders
[1] https://lkft.validation.linaro.org/scheduler/job/195181#L3447
[2] https://lkft.validation.linaro.org/scheduler/job/193410#L3438
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [net-next regression] kselftest failure in fib_nl_newrule()
2018-04-24 9:46 [net-next regression] kselftest failure in fib_nl_newrule() Anders Roxell
@ 2018-04-24 16:17 ` Roopa Prabhu
0 siblings, 0 replies; 2+ messages in thread
From: Roopa Prabhu @ 2018-04-24 16:17 UTC (permalink / raw)
To: Anders Roxell
Cc: David Miller, David Ahern, netdev, Linux Kernel Mailing List
On Tue, Apr 24, 2018 at 2:46 AM, Anders Roxell <anders.roxell@linaro.org> wrote:
> Hi,
>
> fib-onlink-tests.sh (from kselftest) found a regression between
> next-20180424 [1] (worked with tag next-20180423 [2])
>
> here is tree commits that look suspicious specially this patch (sha:
> f9d4b0c1e969)
> rewrites fib_nl_newrule().his patch (sha: f9d4b0c1e969) rewrites
> fib_nl_newrule().
>
> b16fb418b1bf ("net: fib_rules: add extack support")
> f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs
> into fib_nl2rule")
> 8a14e46f1402 ("net/ipv6: Fix missing rcu dereferences on from")
>
> Cheers,
> Anders
> [1] https://lkft.validation.linaro.org/scheduler/job/195181#L3447
> [2] https://lkft.validation.linaro.org/scheduler/job/193410#L3438
Thanks for the report.
It should be fixed by my last commit:
9c20b9372fba "net: fib_rules: fix l3mdev netlink attr processing"
Just ran them again and they pass.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-24 16:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 9:46 [net-next regression] kselftest failure in fib_nl_newrule() Anders Roxell
2018-04-24 16:17 ` Roopa Prabhu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.