All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anders Roxell <anders.roxell@linaro.org>
To: Laura Abbott <labbott@redhat.com>
Cc: shuah@kernel.org, Pintu Kumar <pintu.ping@gmail.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-kselftest@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/android/ion: Makefile: fix build error
Date: Fri, 9 Mar 2018 00:30:02 +0100	[thread overview]
Message-ID: <CADYN=9LcM1N3xSEMq_AgF7=JmC-ZPif2=J2mY9X_yqg1gHMb7Q@mail.gmail.com> (raw)
In-Reply-To: <9e41eb91-8bac-0bf0-987d-8d95c0bfce94@redhat.com>

On 8 March 2018 at 20:32, Laura Abbott <labbott@redhat.com> wrote:
> On 03/08/2018 06:37 AM, Anders Roxell wrote:
>>
>> Fails to build iomap_test.c due to missing include
>>
>> gcc  -I. -I../../../../../drivers/staging/android/uapi/ -Wall -O2 -g
>> ionmap_test.c ipcsocket.c ionutils.c   -o ionmap_test
>> ionmap_test.c:12:27: fatal error: linux/dma-buf.h: No such file or
>> directory
>>   #include <linux/dma-buf.h>
>>                             ^
>> compilation terminated.
>> <builtin>: recipe for target 'ionmap_test' failed
>> make[2]: *** [ionmap_test] Error 1
>>
>> In the current code, we add a new -I ../../../../../usr/include/ to the
>> INCLUDEDIR variable. Also add ionmap_test to the .gitignore file.
>> > Fixes: ac93f7046a53 ("selftests: ion: Add simple test with the vgem
>> > driver")
>
>
> Where is this hash from?

In linux-next.

> It's not in Linus' master branch.
> Are the /usr/include header properly sanitized

That my understanding but please correct me if I'm wrong.

Cheers,
Anders

>, if so that's nice
> because there's been debates before about how best to pick up
> the sanitized headers. I see that used several other places
> around self-tests too. Anyway, you can add
>
> Acked-by: Laura Abbott <labbott@redhat.com>
>
> Thanks,
> Laura
>
>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> ---
>>   tools/testing/selftests/android/ion/.gitignore | 1 +
>>   tools/testing/selftests/android/ion/Makefile   | 2 +-
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/android/ion/.gitignore
>> b/tools/testing/selftests/android/ion/.gitignore
>> index 67e6f391b2a9..95e8f4561474 100644
>> --- a/tools/testing/selftests/android/ion/.gitignore
>> +++ b/tools/testing/selftests/android/ion/.gitignore
>> @@ -1,2 +1,3 @@
>>   ionapp_export
>>   ionapp_import
>> +ionmap_test
>> diff --git a/tools/testing/selftests/android/ion/Makefile
>> b/tools/testing/selftests/android/ion/Makefile
>> index d23b6d537d8b..e03695287f76 100644
>> --- a/tools/testing/selftests/android/ion/Makefile
>> +++ b/tools/testing/selftests/android/ion/Makefile
>> @@ -1,5 +1,5 @@
>>   -INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/
>> +INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/
>> -I../../../../../usr/include/
>>   CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g
>>     TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test
>>
>

WARNING: multiple messages have this Message-ID (diff)
From: anders.roxell at linaro.org (Anders Roxell)
Subject: [PATCH] selftests/android/ion: Makefile: fix build error
Date: Fri, 9 Mar 2018 00:30:02 +0100	[thread overview]
Message-ID: <CADYN=9LcM1N3xSEMq_AgF7=JmC-ZPif2=J2mY9X_yqg1gHMb7Q@mail.gmail.com> (raw)
In-Reply-To: <9e41eb91-8bac-0bf0-987d-8d95c0bfce94@redhat.com>

On 8 March 2018 at 20:32, Laura Abbott <labbott at redhat.com> wrote:
> On 03/08/2018 06:37 AM, Anders Roxell wrote:
>>
>> Fails to build iomap_test.c due to missing include
>>
>> gcc  -I. -I../../../../../drivers/staging/android/uapi/ -Wall -O2 -g
>> ionmap_test.c ipcsocket.c ionutils.c   -o ionmap_test
>> ionmap_test.c:12:27: fatal error: linux/dma-buf.h: No such file or
>> directory
>>   #include <linux/dma-buf.h>
>>                             ^
>> compilation terminated.
>> <builtin>: recipe for target 'ionmap_test' failed
>> make[2]: *** [ionmap_test] Error 1
>>
>> In the current code, we add a new -I ../../../../../usr/include/ to the
>> INCLUDEDIR variable. Also add ionmap_test to the .gitignore file.
>> > Fixes: ac93f7046a53 ("selftests: ion: Add simple test with the vgem
>> > driver")
>
>
> Where is this hash from?

In linux-next.

> It's not in Linus' master branch.
> Are the /usr/include header properly sanitized

That my understanding but please correct me if I'm wrong.

Cheers,
Anders

>, if so that's nice
> because there's been debates before about how best to pick up
> the sanitized headers. I see that used several other places
> around self-tests too. Anyway, you can add
>
> Acked-by: Laura Abbott <labbott at redhat.com>
>
> Thanks,
> Laura
>
>
>> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
>> ---
>>   tools/testing/selftests/android/ion/.gitignore | 1 +
>>   tools/testing/selftests/android/ion/Makefile   | 2 +-
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/android/ion/.gitignore
>> b/tools/testing/selftests/android/ion/.gitignore
>> index 67e6f391b2a9..95e8f4561474 100644
>> --- a/tools/testing/selftests/android/ion/.gitignore
>> +++ b/tools/testing/selftests/android/ion/.gitignore
>> @@ -1,2 +1,3 @@
>>   ionapp_export
>>   ionapp_import
>> +ionmap_test
>> diff --git a/tools/testing/selftests/android/ion/Makefile
>> b/tools/testing/selftests/android/ion/Makefile
>> index d23b6d537d8b..e03695287f76 100644
>> --- a/tools/testing/selftests/android/ion/Makefile
>> +++ b/tools/testing/selftests/android/ion/Makefile
>> @@ -1,5 +1,5 @@
>>   -INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/
>> +INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/
>> -I../../../../../usr/include/
>>   CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g
>>     TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: anders.roxell@linaro.org (Anders Roxell)
Subject: [PATCH] selftests/android/ion: Makefile: fix build error
Date: Fri, 9 Mar 2018 00:30:02 +0100	[thread overview]
Message-ID: <CADYN=9LcM1N3xSEMq_AgF7=JmC-ZPif2=J2mY9X_yqg1gHMb7Q@mail.gmail.com> (raw)
Message-ID: <20180308233002.a1Msk7E9tCRxuplN4L4hCLd2j53idaMHivkdlI-QJss@z> (raw)
In-Reply-To: <9e41eb91-8bac-0bf0-987d-8d95c0bfce94@redhat.com>

On 8 March 2018@20:32, Laura Abbott <labbott@redhat.com> wrote:
> On 03/08/2018 06:37 AM, Anders Roxell wrote:
>>
>> Fails to build iomap_test.c due to missing include
>>
>> gcc  -I. -I../../../../../drivers/staging/android/uapi/ -Wall -O2 -g
>> ionmap_test.c ipcsocket.c ionutils.c   -o ionmap_test
>> ionmap_test.c:12:27: fatal error: linux/dma-buf.h: No such file or
>> directory
>>   #include <linux/dma-buf.h>
>>                             ^
>> compilation terminated.
>> <builtin>: recipe for target 'ionmap_test' failed
>> make[2]: *** [ionmap_test] Error 1
>>
>> In the current code, we add a new -I ../../../../../usr/include/ to the
>> INCLUDEDIR variable. Also add ionmap_test to the .gitignore file.
>> > Fixes: ac93f7046a53 ("selftests: ion: Add simple test with the vgem
>> > driver")
>
>
> Where is this hash from?

In linux-next.

> It's not in Linus' master branch.
> Are the /usr/include header properly sanitized

That my understanding but please correct me if I'm wrong.

Cheers,
Anders

>, if so that's nice
> because there's been debates before about how best to pick up
> the sanitized headers. I see that used several other places
> around self-tests too. Anyway, you can add
>
> Acked-by: Laura Abbott <labbott at redhat.com>
>
> Thanks,
> Laura
>
>
>> Signed-off-by: Anders Roxell <anders.roxell at linaro.org>
>> ---
>>   tools/testing/selftests/android/ion/.gitignore | 1 +
>>   tools/testing/selftests/android/ion/Makefile   | 2 +-
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/android/ion/.gitignore
>> b/tools/testing/selftests/android/ion/.gitignore
>> index 67e6f391b2a9..95e8f4561474 100644
>> --- a/tools/testing/selftests/android/ion/.gitignore
>> +++ b/tools/testing/selftests/android/ion/.gitignore
>> @@ -1,2 +1,3 @@
>>   ionapp_export
>>   ionapp_import
>> +ionmap_test
>> diff --git a/tools/testing/selftests/android/ion/Makefile
>> b/tools/testing/selftests/android/ion/Makefile
>> index d23b6d537d8b..e03695287f76 100644
>> --- a/tools/testing/selftests/android/ion/Makefile
>> +++ b/tools/testing/selftests/android/ion/Makefile
>> @@ -1,5 +1,5 @@
>>   -INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/
>> +INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/
>> -I../../../../../usr/include/
>>   CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g
>>     TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-03-08 23:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 14:37 [PATCH] selftests/android/ion: Makefile: fix build error Anders Roxell
2018-03-08 14:37 ` Anders Roxell
2018-03-08 14:37 ` anders.roxell
2018-03-08 19:32 ` Laura Abbott
2018-03-08 19:32   ` Laura Abbott
2018-03-08 19:32   ` labbott
2018-03-08 23:30   ` Anders Roxell [this message]
2018-03-08 23:30     ` Anders Roxell
2018-03-08 23:30     ` anders.roxell
2018-03-21 16:52     ` Shuah Khan
2018-03-21 16:52       ` Shuah Khan
2018-03-21 16:52       ` shuah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADYN=9LcM1N3xSEMq_AgF7=JmC-ZPif2=J2mY9X_yqg1gHMb7Q@mail.gmail.com' \
    --to=anders.roxell@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pintu.ping@gmail.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.