Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox

From: Sughosh Ganu <sughosh.ganu@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: jassisinghbrar@gmail.com, ilias.apalodimas@linaro.org,
	 takahiro.akashi@linaro.org, patrick.delaunay@foss.st.com,
	 patrice.chotard@foss.st.com, sjg@chromium.org,
	bmeng.cn@gmail.com,  trini@konsulko.com,
	etienne.carriere@linaro.org, monstr@monstr.eu,
	 Jassi Brar <jaswinder.singh@linaro.org>,
	u-boot@lists.denx.de,
	 Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox
Date: Mon, 22 Aug 2022 10:15:10 +0530	[thread overview]
Message-ID: <CADg8p955jquj3qZM=TG+1HRGME-j+yapcg5-B39+9YNjgr+JGw@mail.gmail.com> (raw)
In-Reply-To: <904f572b-9bb9-2dee-5c4f-58ee82bf37f5@gmx.de>

hello Heinrich,

On Sun, 21 Aug 2022 at 12:46, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 7/22/22 19:42, jassisinghbrar@gmail.com wrote:
> > From: Jassi Brar <jaswinder.singh@linaro.org>
> >
> > The mtd and synquacer (developerbox) support was dropped from v6[1]
> > This patchset re-introduces the support over last v7[2] submission of the patchset.
>
> So this series should have been marked v8?
>
> >
> > All the comments on this code over v5 submission have been addressed. Moving forward
> > a changelog will be maintained.
> >
> > [1] https://lore.kernel.org/all/20220704051658.1085442-1-sughosh.ganu@linaro.org/
> > [2] https://lore.kernel.org/all/20220714183913.118505-1-sughosh.ganu@linaro.org/
>
> How does this series relate to
>
> [PATCH v8 00/13] FWU: Add FWU Multi Bank Update feature support
> https://lore.kernel.org/all/20220817124323.375968-1-sughosh.ganu@linaro.org/?
>
> Is it superseded by that series?
>
> This series has "FWU metadata on MTD device without GPT" while the other
> has "FWU metadata on device with GPT partitioned layout".
>
> Do we need both?

Yes, we need both the patch series. The first series([PATCH v8 00/13]
FWU: Add FWU Multi Bank Update feature support) adds support for the
feature and for platforms with GPT partitioning layout, and is
enabling the feature on the ST DK2 board. The second series is adding
support for the feature on MTD partition based devices and enabling
the feature on the Synquacer board.

-sughosh

>
> Best regards
>
> Heinrich
>
> >
> > Jassi Brar (2):
> >    dt: fwu: developerbox: enable fwu banks and mdata regions
> >    fwu: DeveloperBox: add support for FWU
> >
> > Sughosh Ganu (3):
> >    dt/bindings: Add bindings for FWU Metadata mtd storage
> >    FWU: Add FWU metadata access driver for MTD storage regions
> >    FWU: mtd: Add helper functions for accessing FWU metadata
> >
> >   .../synquacer-sc2a11-developerbox-u-boot.dtsi |  22 +-
> >   board/socionext/developerbox/Makefile         |   1 +
> >   board/socionext/developerbox/developerbox.c   |  13 +
> >   board/socionext/developerbox/fwu_plat.c       |  95 ++++++
> >   configs/synquacer_developerbox_defconfig      |  13 +-
> >   doc/board/socionext/developerbox.rst          |  96 ++++++
> >   .../firmware/fwu-mdata-mtd.yaml               |  38 +++
> >   drivers/fwu-mdata/Kconfig                     |   8 +
> >   drivers/fwu-mdata/Makefile                    |   1 +
> >   drivers/fwu-mdata/fwu_mdata_mtd.c             | 308 ++++++++++++++++++
> >   include/configs/synquacer.h                   |  10 +
> >   lib/fwu_updates/Makefile                      |   1 +
> >   lib/fwu_updates/fwu_mtd.c                     | 173 ++++++++++
> >   13 files changed, 776 insertions(+), 3 deletions(-)
> >   create mode 100644 board/socionext/developerbox/fwu_plat.c
> >   create mode 100644 doc/device-tree-bindings/firmware/fwu-mdata-mtd.yaml
> >   create mode 100644 drivers/fwu-mdata/fwu_mdata_mtd.c
> >   create mode 100644 lib/fwu_updates/fwu_mtd.c
> >
>