All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jassi Brar <jaswinder.singh@linaro.org>
To: Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,
	 Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Takahiro Akashi <takahiro.akashi@linaro.org>,
	 Patrick Delaunay <patrick.delaunay@foss.st.com>,
	 Patrice Chotard <patrice.chotard@foss.st.com>,
	Simon Glass <sjg@chromium.org>,  Bin Meng <bmeng.cn@gmail.com>,
	Tom Rini <trini@konsulko.com>,
	 Etienne Carriere <etienne.carriere@linaro.org>,
	Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH v7 06/13] FWU: stm32mp1: Add helper functions for accessing FWU metadata
Date: Thu, 21 Jul 2022 22:39:29 -0500	[thread overview]
Message-ID: <CAJe_ZhchyGKundKjYG8YKMbtzEfX4b9HnsQCqUOXDkp=EfvZ4g@mail.gmail.com> (raw)
In-Reply-To: <20220714183913.118505-7-sughosh.ganu@linaro.org>

On Thu, 14 Jul 2022 at 13:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
> Add helper functions needed for accessing the FWU metadata which
> contains information on the updatable images. These functions have
> been added for the STM32MP157C-DK2 board which has the updatable
> images on the uSD card, formatted as GPT partitions.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> Changes since V6: None
>
>  board/st/stm32mp1/stm32mp1.c | 40 ++++++++++++++++
>  include/fwu.h                |  3 ++
>  lib/fwu_updates/Makefile     |  6 +++
>  lib/fwu_updates/fwu_gpt.c    | 88 ++++++++++++++++++++++++++++++++++++
>  4 files changed, 137 insertions(+)
>  create mode 100644 lib/fwu_updates/Makefile
>  create mode 100644 lib/fwu_updates/fwu_gpt.c
>
fwu_gpt is to be used by all platforms that have the gpt-scheme, not just STM.

So do you want to break this patch into two ? One generic that
introduces the helper functions and another for stm using that api

Also, you may want to specify GPL-2.0-or-later everywhere.

thanks.

  parent reply	other threads:[~2022-07-22  3:39 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 18:39 [PATCH v7 00/13] FWU: Add FWU Multi Bank Update feature support Sughosh Ganu
2022-07-14 18:39 ` [PATCH v7 01/13] dt/bindings: Add bindings for FWU Metadata storage device Sughosh Ganu
2022-07-15  6:05   ` Heinrich Schuchardt
2022-07-16 21:13   ` Jassi Brar
2022-07-18  5:32     ` Sughosh Ganu
2022-07-14 18:39 ` [PATCH v7 02/13] FWU: Add FWU metadata structure and driver for accessing metadata Sughosh Ganu
2022-07-15 10:13   ` Ilias Apalodimas
2022-07-14 18:39 ` [PATCH v7 03/13] FWU: Add FWU metadata access driver for GPT partitioned block devices Sughosh Ganu
2022-07-14 18:39 ` [PATCH v7 04/13] stm32mp1: dk2: Add a node for the FWU metadata device Sughosh Ganu
2022-07-15  6:17   ` Ilias Apalodimas
2022-07-14 18:39 ` [PATCH v7 05/13] stm32mp1: dk2: Add image information for capsule updates Sughosh Ganu
2022-07-15  6:35   ` Ilias Apalodimas
2022-07-14 18:39 ` [PATCH v7 06/13] FWU: stm32mp1: Add helper functions for accessing FWU metadata Sughosh Ganu
2022-07-15  7:52   ` Ilias Apalodimas
2022-07-22  3:39   ` Jassi Brar [this message]
2022-07-22 16:08     ` Sughosh Ganu
2022-07-14 18:39 ` [PATCH v7 07/13] FWU: STM32MP1: Add support to read boot index from backup register Sughosh Ganu
2022-07-15  6:17   ` Ilias Apalodimas
2022-07-14 18:39 ` [PATCH v7 08/13] FWU: Add boot time checks as highlighted by the FWU specification Sughosh Ganu
2022-07-15  7:02   ` Ilias Apalodimas
2022-07-20  7:35     ` Ilias Apalodimas
2022-07-27 11:04       ` Sughosh Ganu
2022-07-14 18:39 ` [PATCH v7 09/13] FWU: Add support for the FWU Multi Bank Update feature Sughosh Ganu
2022-07-15 11:58   ` Ilias Apalodimas
2022-07-14 18:39 ` [PATCH v7 10/13] FWU: cmd: Add a command to read FWU metadata Sughosh Ganu
2022-07-15 10:23   ` Ilias Apalodimas
2022-07-14 18:39 ` [PATCH v7 11/13] mkeficapsule: Add support for generating empty capsules Sughosh Ganu
2022-07-15 13:52   ` Ilias Apalodimas
2022-07-14 18:39 ` [PATCH v7 12/13] mkeficapsule: Add support for setting OEM flags in capsule header Sughosh Ganu
2022-07-15 16:40   ` Ilias Apalodimas
2022-07-18  5:35     ` Sughosh Ganu
2022-07-14 18:39 ` [PATCH v7 13/13] FWU: doc: Add documentation for the FWU feature Sughosh Ganu
2022-07-15 14:25   ` Heinrich Schuchardt
2022-07-22 17:42 ` [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox jassisinghbrar
2022-07-22 17:43   ` jassisinghbrar
2022-07-22 17:43     ` [PATCH 1/5] dt/bindings: Add bindings for FWU Metadata mtd storage jassisinghbrar
2022-07-25  7:04       ` Sughosh Ganu
2022-07-22 17:43     ` [PATCH 2/5] FWU: Add FWU metadata access driver for MTD storage regions jassisinghbrar
2022-09-01  6:45       ` Heinrich Schuchardt
2022-07-22 17:43     ` [PATCH 3/5] FWU: mtd: Add helper functions for accessing FWU metadata jassisinghbrar
2022-09-01  7:01       ` Heinrich Schuchardt
2022-07-22 17:43     ` [PATCH 4/5] dt: fwu: developerbox: enable fwu banks and mdata regions jassisinghbrar
2022-07-22 17:43     ` [PATCH 5/5] fwu: DeveloperBox: add support for FWU jassisinghbrar
2022-09-01  7:07       ` Heinrich Schuchardt
2022-09-01  7:22         ` Heinrich Schuchardt
2022-09-26 18:10           ` Jassi Brar
2022-07-25  7:18   ` [PATCH 0/5] FWU: Add support for mtd backed feature on DeveloperBox Sughosh Ganu
2022-07-25 13:31     ` Jassi Brar
2022-08-21  6:56   ` Heinrich Schuchardt
2022-08-21  7:16   ` Heinrich Schuchardt
2022-08-22  4:45     ` Sughosh Ganu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJe_ZhchyGKundKjYG8YKMbtzEfX4b9HnsQCqUOXDkp=EfvZ4g@mail.gmail.com' \
    --to=jaswinder.singh@linaro.org \
    --cc=bmeng.cn@gmail.com \
    --cc=etienne.carriere@linaro.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=monstr@monstr.eu \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@linaro.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.