[BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Dinh Nguyen]

Hi,

The stmmac ethernet has stopped working in linux-next and linus/master
branch(v4.17-11782-gbe779f03d563)

It appears that the stmmac ethernet has stopped working after these 2 commits:

4dbbe8dde848 net: stmmac: Add support for U32 TC filter using Flexible RX Parser
5f0456b43140 net: stmmac: Implement logic to automatically select HW Interface

If I move to this commit "565020aaeebf net: stmmac: Disable ACS
Feature for GMAC >= 4", then the stmmac works again on SoCFPGA.

I was following this thread:
https://www.spinics.net/lists/netdev/msg502858.html

Was wondering if there was a patch to fix dwmac-sun8i that the socfpga
platform needs as well?

Thanks,
Dinh

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Jose Abreu]

Hello,

On 13-06-2018 21:46, Dinh Nguyen wrote:
> Hi,
>
> The stmmac ethernet has stopped working in linux-next and linus/master
> branch(v4.17-11782-gbe779f03d563)
>
> It appears that the stmmac ethernet has stopped working after these 2 commits:
>
> 4dbbe8dde848 net: stmmac: Add support for U32 TC filter using Flexible RX Parser
> 5f0456b43140 net: stmmac: Implement logic to automatically select HW Interface
>
> If I move to this commit "565020aaeebf net: stmmac: Disable ACS
> Feature for GMAC >= 4", then the stmmac works again on SoCFPGA.
>
> I was following this thread:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_netdev_msg502858.html&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=yaVFU4TjGY0gVF8El1uKcisy6TPsyCl9uN7Wsis-qhY&m=fvPkLp2xlWolmIYwoFLmALhxlycg1w0UmxiYdT7qojc&s=aC4a2U3X_siDxSNz3c5OeadhEJWll31yP-oi5nNar94&e=
>
> Was wondering if there was a patch to fix dwmac-sun8i that the socfpga
> platform needs as well?

Probably. I will check and get back to you ASAP.

Thanks and Best Regards,
Jose Miguel Abreu

>
> Thanks,
> Dinh

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Jose Abreu]

On 14-06-2018 08:38, Jose Abreu wrote:
> Hello,
>
> On 13-06-2018 21:46, Dinh Nguyen wrote:
>> Hi,
>>
>> The stmmac ethernet has stopped working in linux-next and linus/master
>> branch(v4.17-11782-gbe779f03d563)
>>
>> It appears that the stmmac ethernet has stopped working after these 2 commits:
>>
>> 4dbbe8dde848 net: stmmac: Add support for U32 TC filter using Flexible RX Parser
>> 5f0456b43140 net: stmmac: Implement logic to automatically select HW Interface
>>
>> If I move to this commit "565020aaeebf net: stmmac: Disable ACS
>> Feature for GMAC >= 4", then the stmmac works again on SoCFPGA.
>>
>> I was following this thread:
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_netdev_msg502858.html&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=yaVFU4TjGY0gVF8El1uKcisy6TPsyCl9uN7Wsis-qhY&m=fvPkLp2xlWolmIYwoFLmALhxlycg1w0UmxiYdT7qojc&s=aC4a2U3X_siDxSNz3c5OeadhEJWll31yP-oi5nNar94&e=
>>
>> Was wondering if there was a patch to fix dwmac-sun8i that the socfpga
>> platform needs as well?
> Probably. I will check and get back to you ASAP.

This seems to be a different problem. Can you send me your dmesg
log and DT bindings you are using?

>
> Thanks and Best Regards,
> Jose Miguel Abreu
>
>> Thanks,
>> Dinh

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Marek Vasut]

On 06/14/2018 10:18 AM, Jose Abreu wrote:
> On 14-06-2018 08:38, Jose Abreu wrote:
>> Hello,
>>
>> On 13-06-2018 21:46, Dinh Nguyen wrote:
>>> Hi,
>>>
>>> The stmmac ethernet has stopped working in linux-next and linus/master
>>> branch(v4.17-11782-gbe779f03d563)
>>>
>>> It appears that the stmmac ethernet has stopped working after these 2 commits:
>>>
>>> 4dbbe8dde848 net: stmmac: Add support for U32 TC filter using Flexible RX Parser
>>> 5f0456b43140 net: stmmac: Implement logic to automatically select HW Interface
>>>
>>> If I move to this commit "565020aaeebf net: stmmac: Disable ACS
>>> Feature for GMAC >= 4", then the stmmac works again on SoCFPGA.
>>>
>>> I was following this thread:
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_netdev_msg502858.html&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=yaVFU4TjGY0gVF8El1uKcisy6TPsyCl9uN7Wsis-qhY&m=fvPkLp2xlWolmIYwoFLmALhxlycg1w0UmxiYdT7qojc&s=aC4a2U3X_siDxSNz3c5OeadhEJWll31yP-oi5nNar94&e=
>>>
>>> Was wondering if there was a patch to fix dwmac-sun8i that the socfpga
>>> platform needs as well?
>> Probably. I will check and get back to you ASAP.
> 
> This seems to be a different problem. Can you send me your dmesg
> log and DT bindings you are using?

arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dts
for example fails for me in next/master. Worked on 4.17-rc7.

-- 
Best regards,
Marek Vasut

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Dinh Nguyen]

On Thu, Jun 14, 2018 at 6:14 AM Marek Vasut <marex@denx.de> wrote:
>
> On 06/14/2018 10:18 AM, Jose Abreu wrote:
> > On 14-06-2018 08:38, Jose Abreu wrote:
> >> Hello,
> >>
> >> On 13-06-2018 21:46, Dinh Nguyen wrote:
> >>> Hi,
> >>>
> >>> The stmmac ethernet has stopped working in linux-next and linus/master
> >>> branch(v4.17-11782-gbe779f03d563)
> >>>
> >>> It appears that the stmmac ethernet has stopped working after these 2 commits:
> >>>
> >>> 4dbbe8dde848 net: stmmac: Add support for U32 TC filter using Flexible RX Parser
> >>> 5f0456b43140 net: stmmac: Implement logic to automatically select HW Interface
> >>>
> >>> If I move to this commit "565020aaeebf net: stmmac: Disable ACS
> >>> Feature for GMAC >= 4", then the stmmac works again on SoCFPGA.
> >>>
> >>> I was following this thread:
> >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_netdev_msg502858.html&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=yaVFU4TjGY0gVF8El1uKcisy6TPsyCl9uN7Wsis-qhY&m=fvPkLp2xlWolmIYwoFLmALhxlycg1w0UmxiYdT7qojc&s=aC4a2U3X_siDxSNz3c5OeadhEJWll31yP-oi5nNar94&e=
> >>>
> >>> Was wondering if there was a patch to fix dwmac-sun8i that the socfpga
> >>> platform needs as well?
> >> Probably. I will check and get back to you ASAP.
> >
> > This seems to be a different problem. Can you send me your dmesg
> > log and DT bindings you are using?
>
> arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dts
> for example fails for me in next/master. Worked on 4.17-rc7.
>

I'm using "arch/arm/boot/dts/socfpga_arria5_socdk.dts". Here's my boot log:

It appears to just get stuck in "eth0: link becomes ready", times out
and reinits:

[    0.000000] Linux version 4.17.0-11782-gbe779f03d563-dirty (dinguyen@linux-bu
ilds1) (gcc version 7.2.1 20171011 (Linaro GCC 7.2-2017.11)) #26 SMP Thu Jun 14
09:01:38 CDT 2018
[    0.000000] CPU: ARMv7 Processor [413fc090] revision 0 (ARMv7), cr=10c5387d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instructio
n cache
[    0.000000] OF: fdt: Machine model: Altera SOCFPGA Arria V SoC Development Ki
t
[    0.000000] debug: ignoring loglevel setting.
[    0.000000] Memory policy: Data cache writealloc
[    0.000000] On node 0 totalpages: 262144
[    0.000000]   Normal zone: 1536 pages used for memmap
[    0.000000]   Normal zone: 0 pages reserved
[    0.000000]   Normal zone: 196608 pages, LIFO batch:31
[    0.000000]   HighMem zone: 65536 pages, LIFO batch:15
[    0.000000] random: get_random_bytes called from start_kernel+0xac/0x488 with
 crng_init=0
[    0.000000] percpu: Embedded 16 pages/cpu @(ptrval) s36044 r8192 d21300 u6553
6
[    0.000000] pcpu-alloc: s36044 r8192 d21300 u65536 alloc=16*4096
[    0.000000] pcpu-alloc: [0] 0 [0] 1
[    0.000000] Built 1 zonelists, mobility grouping on.  Total pages: 260608
[    0.000000] Kernel command line: root=/dev/nfs rw nfsroot=10.122.105.139:/hom
e/dinguyen/rootfs_yocto ip=dhcp debug ignore_loglevel
[    0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
[    0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
[    0.000000] Memory: 1027460K/1048576K available (7168K kernel code, 508K rwda
ta, 1540K rodata, 1024K init, 133K bss, 21116K reserved, 0K cma-reserved, 262144
K highmem)
[    0.000000] Virtual kernel memory layout:
[    0.000000]     vector  : 0xffff0000 - 0xffff1000   (   4 kB)
[    0.000000]     fixmap  : 0xffc00000 - 0xfff00000   (3072 kB)
[    0.000000]     vmalloc : 0xf0800000 - 0xff800000   ( 240 MB)
[    0.000000]     lowmem  : 0xc0000000 - 0xf0000000   ( 768 MB)
[    0.000000]     pkmap   : 0xbfe00000 - 0xc0000000   (   2 MB)
[    0.000000]     modules : 0xbf000000 - 0xbfe00000   (  14 MB)
[    0.000000]       .text : 0x(ptrval) - 0x(ptrval)   (8160 kB)
[    0.000000]       .init : 0x(ptrval) - 0x(ptrval)   (1024 kB)
[    0.000000]       .data : 0x(ptrval) - 0x(ptrval)   ( 509 kB)
[    0.000000]        .bss : 0x(ptrval) - 0x(ptrval)   ( 134 kB)
[    0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=2, Nodes=1
[    0.000000] ftrace: allocating 25769 entries in 76 pages
[    0.000000] Hierarchical RCU implementation.
[    0.000000]  RCU event tracing is enabled.
[    0.000000] NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16
[    0.000000] L2C-310 enabling early BRESP for Cortex-A9
[    0.000000] L2C-310 full line of zeros enabled for Cortex-A9
[    0.000000] L2C-310 ID prefetch enabled, offset 8 lines
[    0.000000] L2C-310 dynamic clock gating enabled, standby mode enabled
[    0.000000] L2C-310 cache controller enabled, 8 ways, 512 kB
[    0.000000] L2C-310: CACHE_ID 0x410030c9, AUX_CTRL 0x76460001
[    0.000000] clocksource: timer1: mask: 0xffffffff max_cycles: 0xffffffff, max
_idle_ns: 19112604467 ns
[    0.000004] sched_clock: 32 bits at 100MHz, resolution 10ns, wraps every 2147
4836475ns
[    0.000014] Switching to timer-based delay loop, resolution 10ns
[    0.000150] Console: colour dummy device 80x30
[    0.000528] console [tty0] enabled
[    0.000552] Calibrating delay loop (skipped), value calculated using timer fr
equency.. 200.00 BogoMIPS (lpj=1000000)
[    0.000575] pid_max: default: 32768 minimum: 301
[    0.000689] Mount-cache hash table entries: 2048 (order: 1, 8192 bytes)
[    0.000708] Mountpoint-cache hash table entries: 2048 (order: 1, 8192 bytes)
[    0.001202] CPU: Testing write buffer coherency: ok
[    0.001236] CPU0: Spectre v2: using BPIALL workaround
[    0.001454] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
[    0.001923] Setting up static identity map for 0x100000 - 0x100060
[    0.002042] Hierarchical SRCU implementation.
[    0.002489] smp: Bringing up secondary CPUs ...
[    0.003035] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001
[    0.003041] CPU1: Spectre v2: using BPIALL workaround
[    0.003146] smp: Brought up 1 node, 2 CPUs
[    0.003165] SMP: Total of 2 processors activated (400.00 BogoMIPS).
[    0.003177] CPU: All CPU(s) started in SVC mode.
[    0.003986] devtmpfs: initialized
[    0.007541] VFP support v0.3: implementor 41 architecture 3 part 30 variant 9
 rev 4
[    0.007737] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, ma
x_idle_ns: 19112604462750000 ns
[    0.007764] futex hash table entries: 512 (order: 3, 32768 bytes)
[    0.008640] NET: Registered protocol family 16
[    0.009583] DMA: preallocated 256 KiB pool for atomic coherent allocations
[    0.010648] hw-breakpoint: found 5 (+1 reserved) breakpoint and 1 watchpoint
registers.
[    0.010676] hw-breakpoint: maximum watchpoint size is 4 bytes.
[    0.027506] vgaarb: loaded
[    0.027786] SCSI subsystem initialized
[    0.028018] usbcore: registered new interface driver usbfs
[    0.028109] usbcore: registered new interface driver hub
[    0.028190] usbcore: registered new device driver usb
[    0.028375] usb_phy_generic soc:usbphy: soc:usbphy supply vcc not found, usin
g dummy regulator
[    0.028884] pps_core: LinuxPPS API ver. 1 registered
[    0.028906] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giome
tti <giometti@linux.it>
[    0.028941] PTP clock support registered
[    0.029114] FPGA manager framework
[    0.030434] clocksource: Switched to clocksource timer1
[    0.078659] NET: Registered protocol family 2
[    0.079128] tcp_listen_portaddr_hash hash table entries: 512 (order: 0, 6144
bytes)
[    0.079164] TCP established hash table entries: 8192 (order: 3, 32768 bytes)
[    0.079229] TCP bind hash table entries: 8192 (order: 4, 65536 bytes)
[    0.079332] TCP: Hash tables configured (established 8192 bind 8192)
[    0.079428] UDP hash table entries: 512 (order: 2, 16384 bytes)
[    0.079469] UDP-Lite hash table entries: 512 (order: 2, 16384 bytes)
[    0.079611] NET: Registered protocol family 1
[    0.080101] RPC: Registered named UNIX socket transport module.
[    0.080122] RPC: Registered udp transport module.
[    0.080133] RPC: Registered tcp transport module.
[    0.080143] RPC: Registered tcp NFSv4.1 backchannel transport module.
[    0.080160] PCI: CLS 0 bytes, default 64
[    0.080784] hw perfevents: enabled with armv7_cortex_a9 PMU driver, 7 counter
s available
[    0.082584] workingset: timestamp_bits=30 max_order=18 bucket_order=0
[    0.090349] NFS: Registering the id_resolver key type
[    0.090453] Key type id_resolver registered
[    0.090469] Key type id_legacy registered
[    0.090491] Installing knfsd (copyright (C) 1996 okir@monad.swb.de).
[    0.091186] ntfs: driver 2.1.32 [Flags: R/W].
[    0.091551] jffs2: version 2.2. (NAND) ▒© 2001-2006 Red Hat, Inc.
[    0.092807] bounce: pool size: 64 pages
[    0.092835] io scheduler noop registered (default)
[    0.092848] io scheduler mq-deadline registered
[    0.092859] io scheduler kyber registered
[    0.099974] dma-pl330 ffe01000.pdma: Loaded driver for PL330 DMAC-341330
[    0.100011] dma-pl330 ffe01000.pdma:         DBUFF-512x8bytes Num_Chans-8 Num
_Peri-32 Num_Events-8
[    0.105043] Serial: 8250/16550 driver, 2 ports, IRQ sharing disabled
[    0.106125] ffc02000.serial0: ttyS0 at MMIO 0xffc02000 (irq = 38, base_baud =
 6250000) is a 16550A
[    0.763357] console [ttyS0] enabled
[    0.767408] ffc03000.serial1: ttyS1 at MMIO 0xffc03000 (irq = 39, base_baud =
 6250000) is a 16550A
[    0.777740] brd: module loaded
[    0.781670] cadence-qspi ff705000.spi: n25q512ax3 (65536 Kbytes)
[    0.787808] 2 fixed-partitions partitions found on MTD device ff705000.spi.0
[    0.794855] Creating 2 MTD partitions on "ff705000.spi.0":
[    0.800328] 0x000000000000-0x000000800000 : "Flash 0 Raw Data"
[    0.806873] 0x000000800000-0x000008000000 : "Flash 0 jffs2 Filesystem"
[    0.813416] mtd: partition "Flash 0 jffs2 Filesystem" extends beyond the end
of device "ff705000.spi.0" -- size truncated to 0x3800000
[    0.826562] libphy: Fixed MDIO Bus: probed
[    0.831312] CAN device driver interface
[    0.835537] socfpga-dwmac ff702000.ethernet: PTP uses main clock
[    0.841794] socfpga-dwmac ff702000.ethernet: Version ID not available
[    0.848223] socfpga-dwmac ff702000.ethernet:         DWMAC1000
[    0.853454] socfpga-dwmac ff702000.ethernet: Normal descriptors
[    0.859357] socfpga-dwmac ff702000.ethernet: Ring mode enabled
[    0.865184] socfpga-dwmac ff702000.ethernet: DMA HW capability register suppo
rted
[    0.872654] socfpga-dwmac ff702000.ethernet: RX Checksum Offload Engine suppo
rted
[    0.880113] socfpga-dwmac ff702000.ethernet: COE Type 2
[    0.885329] socfpga-dwmac ff702000.ethernet: TX Checksum insertion supported
[    0.899744] libphy: stmmac: probed
[    0.903175] Micrel KSZ9021 Gigabit PHY stmmac-0:04: attached PHY driver [Micr
el KSZ9021 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:04, irq=POLL)
[    0.916772] dwc2 ffb40000.usb: ffb40000.usb supply vusb_d not found, using du
mmy regulator
[    0.925092] dwc2 ffb40000.usb: ffb40000.usb supply vusb_a not found, using du
mmy regulator
[    0.933461] dwc2 ffb40000.usb: dwc2_check_params: Invalid parameter lpm=1
[    0.940230] dwc2 ffb40000.usb: dwc2_check_params: Invalid parameter lpm_clock
_gating=1
[    0.948136] dwc2 ffb40000.usb: dwc2_check_params: Invalid parameter besl=1
[    0.954998] dwc2 ffb40000.usb: dwc2_check_params: Invalid parameter hird_thre
shold_en=1
[    0.963004] dwc2 ffb40000.usb: EPs: 16, dedicated fifos, 8064 entries in SPRA
M
[    0.970490] dwc2 ffb40000.usb: DWC OTG Controller
[    0.975204] dwc2 ffb40000.usb: new USB bus registered, assigned bus number 1
[    0.982265] dwc2 ffb40000.usb: irq 40, io mem 0xffb40000
[    0.988221] hub 1-0:1.0: USB hub found
[    0.992038] hub 1-0:1.0: 1 port detected
[    0.996636] usbcore: registered new interface driver usb-storage
[    1.002925] i2c /dev entries driver
[    1.007280] Synopsys Designware Multimedia Card Interface Driver
[    1.013615] dw_mmc ff704000.dwmmc0: IDMAC supports 32-bit address mode.
[    1.020245] dw_mmc ff704000.dwmmc0: Using internal DMA controller.
[    1.026433] dw_mmc ff704000.dwmmc0: Version ID is 240a
[    1.031604] dw_mmc ff704000.dwmmc0: DW MMC controller at irq 32,32 bit host d
ata width,1024 deep fifo
[    1.040982] mmc_host mmc0: card is polling.
[    1.057816] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req 400000Hz
, actual 396825HZ div = 63)
[    1.080628] ledtrig-cpu: registered to indicate activity on CPUs
[    1.086793] usbcore: registered new interface driver usbhid
[    1.092376] usbhid: USB HID core driver
[    1.096453] fpga_manager fpga0: Altera SOCFPGA FPGA Manager registered
[    1.103496] altera_hps2fpga_bridge ff400000.fpga_bridge: fpga bridge [lwhps2f
pga] registered
[    1.112159] altera_hps2fpga_bridge ff500000.fpga_bridge: fpga bridge [hps2fpg
a] registered
[    1.120864] oprofile: using arm/armv7-ca9
[    1.125539] NET: Registered protocol family 10
[    1.130705] Segment Routing with IPv6
[    1.134425] sit: IPv6, IPv4 and MPLS over IPv4 tunneling driver
[    1.140892] NET: Registered protocol family 17
[    1.145346] NET: Registered protocol family 15
[    1.149776] can: controller area network core (rev 20170425 abi 9)
[    1.156001] NET: Registered protocol family 29
[    1.160447] can: raw protocol (rev 20170425)
[    1.164704] can: broadcast manager protocol (rev 20170425 t)
[    1.170354] can: netlink gateway (rev 20170425) max_hops=1
[    1.175998] 8021q: 802.1Q VLAN Support v1.8
[    1.180204] Key type dns_resolver registered
[    1.184561] ThumbEE CPU extension supported.
[    1.188825] Registering SWP/SWPB emulation handler
[    1.198329] at24 0-0051: 4096 byte 24c32 EEPROM, writable, 32 bytes/write
[    1.206310] rtc-ds1307 0-0068: SET TIME!
[    1.214145] rtc-ds1307 0-0068: registered as rtc0
[    1.220796] rtc-ds1307 0-0068: setting system clock to 2000-01-01 00:00:07 UT
C (946684807)
[    1.249625] mmc_host mmc0: Bus speed (slot 0) = 50000000Hz (slot req 50000000
Hz, actual 50000000HZ div = 0)
[    1.259416] mmc0: new high speed SDHC card at address 0007
[    1.265633] mmcblk0: mmc0:0007 SD4GB 3.71 GiB
[    1.271840]  mmcblk0: p1 p2 p3 p4
[    1.341106] Micrel KSZ9021 Gigabit PHY stmmac-0:04: attached PHY driver [Micr
el KSZ9021 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:04, irq=POLL)
[    1.355710] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support
found
[    1.363460] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
[    1.370219] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
[    3.441194] socfpga-dwmac ff702000.ethernet eth0: Link is Up - 100Mbps/Full -
 flow control rx/tx
[    3.450432] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
[    3.480411] Sending DHCP requests ...... timed out!
[   85.627555] Removed PTP HW clock successfully on eth0
[   85.632788] IP-Config: Retrying forever (NFS root)...
[   85.731113] Micrel KSZ9021 Gigabit PHY stmmac-0:04: attached PHY driver [Micr
el KSZ9021 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:04, irq=POLL)
[   85.750434] socfpga-dwmac ff702000.ethernet eth0: No Safety Features support
found
[   85.758160] socfpga-dwmac ff702000.ethernet eth0: registered PTP clock
[   85.764825] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
[   87.831196] socfpga-dwmac ff702000.ethernet eth0: Link is Up - 100Mbps/Full -
 flow control rx/tx
[   87.840438] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Jose Abreu]

On 14-06-2018 15:21, Dinh Nguyen wrote:
>
> [    0.835537] socfpga-dwmac ff702000.ethernet: PTP uses main clock
> [    0.841794] socfpga-dwmac ff702000.ethernet: Version ID not available
> [    0.848223] socfpga-dwmac ff702000.ethernet:         DWMAC1000
> [    0.853454] socfpga-dwmac ff702000.ethernet: Normal descriptors
> [    0.859357] socfpga-dwmac ff702000.ethernet: Ring mode enabled
> [    0.865184] socfpga-dwmac ff702000.ethernet: DMA HW capability register suppo
> rted
> [    0.872654] socfpga-dwmac ff702000.ethernet: RX Checksum Offload Engine suppo
> rted
> [    0.880113] socfpga-dwmac ff702000.ethernet: COE Type 2
> [    0.885329] socfpga-dwmac ff702000.ethernet: TX Checksum insertion supported
>

Interesting ... Please check if bellow patch makes thing work
again (if not please send me the resultant dmesg log and also the
log without the problematic patch that you identified):

-------------------->8------------------
diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c
b/drivers/net/ethernet/stmicro/stmmac/hwif.c
index 14770fc..1961819 100644
--- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
+++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
@@ -252,12 +252,8 @@ int stmmac_hwif_init(struct stmmac_priv *priv)
                 return ret;
         }
 
-        /* Run quirks, if needed */
-        if (entry->quirks) {
-            ret = entry->quirks(priv);
-            if (ret)
-                return ret;
-        }
+        /* Save quirks, if needed for posterior use */
+        priv->hwif_quirks = entry->quirks;
 
         return 0;
     }
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
index 025efbf..be7da43 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
@@ -193,6 +193,9 @@ struct stmmac_priv {
 
     /* Pulse Per Second output */
     struct stmmac_pps_cfg pps[STMMAC_PPS_MAX];
+
+    /* DEBUG */
+    int (*hwif_quirks)(struct stmmac_priv *priv);
 };
 
 enum stmmac_state {
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 11fb7c7..fbe74f2 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4130,6 +4130,12 @@ static int stmmac_hw_init(struct
stmmac_priv *priv)
     if (priv->dma_cap.tsoen)
         dev_info(priv->device, "TSO supported\n");
 
+    if (priv->hwif_quirks) {
+        ret = priv->hwif_quirks(priv);
+        if (ret)
+            return ret;
+    }
+
     return 0;
 }
 
-------------------->8------------------

Thanks and Best Regards,
Jose Miguel Abreu

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Dinh Nguyen]

On Thu, Jun 14, 2018 at 10:23 AM Jose Abreu <Jose.Abreu@synopsys.com> wrote:
>
> On 14-06-2018 15:21, Dinh Nguyen wrote:
> >
> > [    0.835537] socfpga-dwmac ff702000.ethernet: PTP uses main clock
> > [    0.841794] socfpga-dwmac ff702000.ethernet: Version ID not available
> > [    0.848223] socfpga-dwmac ff702000.ethernet:         DWMAC1000
> > [    0.853454] socfpga-dwmac ff702000.ethernet: Normal descriptors
> > [    0.859357] socfpga-dwmac ff702000.ethernet: Ring mode enabled
> > [    0.865184] socfpga-dwmac ff702000.ethernet: DMA HW capability register suppo
> > rted
> > [    0.872654] socfpga-dwmac ff702000.ethernet: RX Checksum Offload Engine suppo
> > rted
> > [    0.880113] socfpga-dwmac ff702000.ethernet: COE Type 2
> > [    0.885329] socfpga-dwmac ff702000.ethernet: TX Checksum insertion supported
> >
>
> Interesting ... Please check if bellow patch makes thing work
> again (if not please send me the resultant dmesg log and also the
> log without the problematic patch that you identified):
>
> -------------------->8------------------
> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c
> b/drivers/net/ethernet/stmicro/stmmac/hwif.c
> index 14770fc..1961819 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
> @@ -252,12 +252,8 @@ int stmmac_hwif_init(struct stmmac_priv *priv)
>                  return ret;
>          }
>
> -        /* Run quirks, if needed */
> -        if (entry->quirks) {
> -            ret = entry->quirks(priv);
> -            if (ret)
> -                return ret;
> -        }
> +        /* Save quirks, if needed for posterior use */
> +        priv->hwif_quirks = entry->quirks;
>
>          return 0;
>      }
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> index 025efbf..be7da43 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> @@ -193,6 +193,9 @@ struct stmmac_priv {
>
>      /* Pulse Per Second output */
>      struct stmmac_pps_cfg pps[STMMAC_PPS_MAX];
> +
> +    /* DEBUG */
> +    int (*hwif_quirks)(struct stmmac_priv *priv);
>  };
>
>  enum stmmac_state {
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 11fb7c7..fbe74f2 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -4130,6 +4130,12 @@ static int stmmac_hw_init(struct
> stmmac_priv *priv)
>      if (priv->dma_cap.tsoen)
>          dev_info(priv->device, "TSO supported\n");
>
> +    if (priv->hwif_quirks) {
> +        ret = priv->hwif_quirks(priv);
> +        if (ret)
> +            return ret;
> +    }
> +
>      return 0;
>  }
>
> -------------------->8------------------
>

The above patch fixed it!

Dinh

Re: [BUG] net: stmmac: socfpga ethernet no longer working on linux-next

[Jose Abreu]

On 14-06-2018 17:18, Dinh Nguyen wrote:
> On Thu, Jun 14, 2018 at 10:23 AM Jose Abreu <Jose.Abreu@synopsys.com> wrote:
>> On 14-06-2018 15:21, Dinh Nguyen wrote:
>>> [    0.835537] socfpga-dwmac ff702000.ethernet: PTP uses main clock
>>> [    0.841794] socfpga-dwmac ff702000.ethernet: Version ID not available
>>> [    0.848223] socfpga-dwmac ff702000.ethernet:         DWMAC1000
>>> [    0.853454] socfpga-dwmac ff702000.ethernet: Normal descriptors
>>> [    0.859357] socfpga-dwmac ff702000.ethernet: Ring mode enabled
>>> [    0.865184] socfpga-dwmac ff702000.ethernet: DMA HW capability register suppo
>>> rted
>>> [    0.872654] socfpga-dwmac ff702000.ethernet: RX Checksum Offload Engine suppo
>>> rted
>>> [    0.880113] socfpga-dwmac ff702000.ethernet: COE Type 2
>>> [    0.885329] socfpga-dwmac ff702000.ethernet: TX Checksum insertion supported
>>>
>> Interesting ... Please check if bellow patch makes thing work
>> again (if not please send me the resultant dmesg log and also the
>> log without the problematic patch that you identified):
>>
>> -------------------->8------------------
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> index 14770fc..1961819 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> @@ -252,12 +252,8 @@ int stmmac_hwif_init(struct stmmac_priv *priv)
>>                  return ret;
>>          }
>>
>> -        /* Run quirks, if needed */
>> -        if (entry->quirks) {
>> -            ret = entry->quirks(priv);
>> -            if (ret)
>> -                return ret;
>> -        }
>> +        /* Save quirks, if needed for posterior use */
>> +        priv->hwif_quirks = entry->quirks;
>>
>>          return 0;
>>      }
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
>> index 025efbf..be7da43 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
>> @@ -193,6 +193,9 @@ struct stmmac_priv {
>>
>>      /* Pulse Per Second output */
>>      struct stmmac_pps_cfg pps[STMMAC_PPS_MAX];
>> +
>> +    /* DEBUG */
>> +    int (*hwif_quirks)(struct stmmac_priv *priv);
>>  };
>>
>>  enum stmmac_state {
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 11fb7c7..fbe74f2 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -4130,6 +4130,12 @@ static int stmmac_hw_init(struct
>> stmmac_priv *priv)
>>      if (priv->dma_cap.tsoen)
>>          dev_info(priv->device, "TSO supported\n");
>>
>> +    if (priv->hwif_quirks) {
>> +        ret = priv->hwif_quirks(priv);
>> +        if (ret)
>> +            return ret;
>> +    }
>> +
>>      return 0;
>>  }
>>
>> -------------------->8------------------
>>
> The above patch fixed it!

Thanks for testing. I will send a proper patch next week.

Thanks and Best Regards,
Jose Miguel Abreu

>
> Dinh