All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChiYuan Huang <u0084500@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com,
	Rob Herring <robh+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, lkml <linux-kernel@vger.kernel.org>,
	cy_huang <cy_huang@richtek.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, allen lin <allen_lin@richtek.com>
Subject: Re: [PATCH 2/2] ASoC: rt9120: Add rt9210 audio amplifier support
Date: Wed, 6 Oct 2021 17:09:12 +0800	[thread overview]
Message-ID: <CADiBU3-A3vcn9ekKnL+mRjafHzi25W0OQs8HzGg_t99mtJurWQ@mail.gmail.com> (raw)
In-Reply-To: <YVxIv6NOiVdNSkXf@sirena.org.uk>

Hi, Mark:

Mark Brown <broonie@kernel.org> 於 2021年10月5日 週二 下午8:44寫道：
>
> On Tue, Oct 05, 2021 at 08:36:44PM +0800, ChiYuan Huang wrote:
> > Mark Brown <broonie@kernel.org> 於 2021年10月5日 週二 下午7:54寫道：
> > > On Tue, Oct 05, 2021 at 09:16:55AM +0800, cy_huang wrote:
>
> > > > +     /* Default config volume to 0dB */
> > > > +     snd_soc_component_write(comp, RT9120_REG_MSVOL, 0x180);
> > > > +     /* Mute by default */
> > > > +     snd_soc_component_update_bits(comp, RT9120_REG_VOLRAMP,
> > > > +                                   RT9120_MUTE_MASK, RT9120_MUTE_MASK);
>
> > > As ever you should leave the defaults at whatever the hardware defaults
> > > to, the defaults for one machine may not be suitable for another so we
> > > shouldn't be trying to do that in software.
>
> > The default volume will be kept in value 0x7ff (mute).
> > I just want to follow the ASoC flow to control mute/unmute mask by AMP on/off.
> > If to default set volume to 0dB and mute is improper, user have to use
> > mixer control to configure the volume.
> > Does mute function also need to be removed also?
>
> It's totally fine and indeed quite common for devices to be muted by
> default - usually systems will have UCM profiles that unmute things by
> the time users actually interact with them.
>
> Please don't take things off-list unless there is a really strong reason
> to do so.  Sending things to the list ensures that everyone gets a
> chance to read and comment on things.

After asking the HW member, there's already builtin HW volume ramp function.
Mute API is still no need. There's already no pop issue without mute function.

So the next change, I'll remove the default volume and mute config,
and also mute API.

Thx.

WARNING: multiple messages have this Message-ID (diff)
From: ChiYuan Huang <u0084500@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: oder_chiou@realtek.com,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	alsa-devel@alsa-project.org, lkml <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	tiwai@suse.com, cy_huang <cy_huang@richtek.com>,
	Rob Herring <robh+dt@kernel.org>,
	allen lin <allen_lin@richtek.com>
Subject: Re: [PATCH 2/2] ASoC: rt9120: Add rt9210 audio amplifier support
Date: Wed, 6 Oct 2021 17:09:12 +0800	[thread overview]
Message-ID: <CADiBU3-A3vcn9ekKnL+mRjafHzi25W0OQs8HzGg_t99mtJurWQ@mail.gmail.com> (raw)
In-Reply-To: <YVxIv6NOiVdNSkXf@sirena.org.uk>

Hi, Mark:

Mark Brown <broonie@kernel.org> 於 2021年10月5日 週二 下午8:44寫道：
>
> On Tue, Oct 05, 2021 at 08:36:44PM +0800, ChiYuan Huang wrote:
> > Mark Brown <broonie@kernel.org> 於 2021年10月5日 週二 下午7:54寫道：
> > > On Tue, Oct 05, 2021 at 09:16:55AM +0800, cy_huang wrote:
>
> > > > +     /* Default config volume to 0dB */
> > > > +     snd_soc_component_write(comp, RT9120_REG_MSVOL, 0x180);
> > > > +     /* Mute by default */
> > > > +     snd_soc_component_update_bits(comp, RT9120_REG_VOLRAMP,
> > > > +                                   RT9120_MUTE_MASK, RT9120_MUTE_MASK);
>
> > > As ever you should leave the defaults at whatever the hardware defaults
> > > to, the defaults for one machine may not be suitable for another so we
> > > shouldn't be trying to do that in software.
>
> > The default volume will be kept in value 0x7ff (mute).
> > I just want to follow the ASoC flow to control mute/unmute mask by AMP on/off.
> > If to default set volume to 0dB and mute is improper, user have to use
> > mixer control to configure the volume.
> > Does mute function also need to be removed also?
>
> It's totally fine and indeed quite common for devices to be muted by
> default - usually systems will have UCM profiles that unmute things by
> the time users actually interact with them.
>
> Please don't take things off-list unless there is a really strong reason
> to do so.  Sending things to the list ensures that everyone gets a
> chance to read and comment on things.

After asking the HW member, there's already builtin HW volume ramp function.
Mute API is still no need. There's already no pop issue without mute function.

So the next change, I'll remove the default volume and mute config,
and also mute API.

Thx.

  parent reply	other threads:[~2021-10-06  9:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  1:16 [PATCH 1/2] ASoC: dt-bindings: rt9120: Add initial bindings cy_huang
2021-10-05  1:16 ` [PATCH 2/2] ASoC: rt9120: Add rt9210 audio amplifier support cy_huang
2021-10-05 11:54   ` Mark Brown
2021-10-05 11:54     ` Mark Brown
     [not found]     ` <CADiBU38X6nY1D7NpgW8+61AX6rUU7jngnPagryDKxUAKdtGjAg@mail.gmail.com>
2021-10-05 12:41       ` ChiYuan Huang
     [not found]       ` <YVxIv6NOiVdNSkXf@sirena.org.uk>
2021-10-06  9:09         ` ChiYuan Huang [this message]
2021-10-06  9:09           ` ChiYuan Huang
2021-10-05 11:49 ` [PATCH 1/2] ASoC: dt-bindings: rt9120: Add initial bindings Mark Brown
2021-10-05 11:49   ` Mark Brown
     [not found]   ` <CADiBU39dvKS_a5FDgw9yMVFe8Uycn6bfjGwBWq+7MN_DdxkL1g@mail.gmail.com>
     [not found]     ` <YVxFMaPhZdAFniMa@sirena.org.uk>
2021-10-05 12:39       ` ChiYuan Huang
2021-10-06  8:47         ` ChiYuan Huang
2021-10-06  8:47           ` ChiYuan Huang
2021-10-07  2:44           ` ChiYuan Huang
2021-10-07  2:44             ` ChiYuan Huang
2021-10-07 13:45             ` Mark Brown
2021-10-07 13:45               ` Mark Brown
2021-10-08  0:25               ` ChiYuan Huang
2021-10-08  0:25                 ` ChiYuan Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADiBU3-A3vcn9ekKnL+mRjafHzi25W0OQs8HzGg_t99mtJurWQ@mail.gmail.com \
    --to=u0084500@gmail.com \
    --cc=allen_lin@richtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.