All of lore.kernel.org
 help / color / mirror / Atom feed
From: ChiYuan Huang <u0084500@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: perex@perex.cz, tiwai@suse.com, oder_chiou@realtek.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, lkml <linux-kernel@vger.kernel.org>,
	cy_huang <cy_huang@richtek.com>,
	allen lin <allen_lin@richtek.com>
Subject: Re: [PATCH 1/2] ASoC: rt9120: Update internal setting and fix auto sync problem
Date: Tue, 9 Nov 2021 21:38:45 +0800	[thread overview]
Message-ID: <CADiBU38kyx6hA-xPp-EH34YmvDfXRtOBr3Zuzj2Yc7Sx+HJWcw@mail.gmail.com> (raw)
In-Reply-To: <YYp2+gqjn6+M/hZ7@sirena.org.uk>

Mark Brown <broonie@kernel.org> 於 2021年11月9日 週二 下午9:26寫道：
>
> On Tue, Nov 09, 2021 at 02:23:43PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > - Update internal setting to fix issue.
> > - Disable auto sync if fs is divided by 48.
>
> Please submit one patch per change, each with a clear changelog, as
> covered in SubmittingPatches.  This makes it much easier to review
> things since it's easier to tell if the patch does what it was intended
> to do.  When splitting patches up git gui can be helpful, you can stage
> and unstage individual lines by right clicking on them.

OK, I'll split it with two changes to make it more clear.

WARNING: multiple messages have this Message-ID (diff)
From: ChiYuan Huang <u0084500@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
	lkml <linux-kernel@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	tiwai@suse.com, cy_huang <cy_huang@richtek.com>,
	allen lin <allen_lin@richtek.com>
Subject: Re: [PATCH 1/2] ASoC: rt9120: Update internal setting and fix auto sync problem
Date: Tue, 9 Nov 2021 21:38:45 +0800	[thread overview]
Message-ID: <CADiBU38kyx6hA-xPp-EH34YmvDfXRtOBr3Zuzj2Yc7Sx+HJWcw@mail.gmail.com> (raw)
In-Reply-To: <YYp2+gqjn6+M/hZ7@sirena.org.uk>

Mark Brown <broonie@kernel.org> 於 2021年11月9日 週二 下午9:26寫道：
>
> On Tue, Nov 09, 2021 at 02:23:43PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > - Update internal setting to fix issue.
> > - Disable auto sync if fs is divided by 48.
>
> Please submit one patch per change, each with a clear changelog, as
> covered in SubmittingPatches.  This makes it much easier to review
> things since it's easier to tell if the patch does what it was intended
> to do.  When splitting patches up git gui can be helpful, you can stage
> and unstage individual lines by right clicking on them.

OK, I'll split it with two changes to make it more clear.

  reply	other threads:[~2021-11-09 13:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09  6:23 [PATCH 0/2] ASoC: rt9120: Fix settings and add rt9120s compatibility cy_huang
2021-11-09  6:23 ` cy_huang
2021-11-09  6:23 ` [PATCH 1/2] ASoC: rt9120: Update internal setting and fix auto sync problem cy_huang
2021-11-09  6:23   ` cy_huang
2021-11-09 13:26   ` Mark Brown
2021-11-09 13:26     ` Mark Brown
2021-11-09 13:38     ` ChiYuan Huang [this message]
2021-11-09 13:38       ` ChiYuan Huang
2021-11-09  6:23 ` [PATCH 2/2] ASoC: rt9120: Add the compatibility with rt9120s cy_huang
2021-11-09  6:23   ` cy_huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADiBU38kyx6hA-xPp-EH34YmvDfXRtOBr3Zuzj2Yc7Sx+HJWcw@mail.gmail.com \
    --to=u0084500@gmail.com \
    --cc=allen_lin@richtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.