From: ChiYuan Huang <u0084500@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
jingoohan1@gmail.com, Pavel Machek <pavel@ucw.cz>,
deller@gmx.de, cy_huang <cy_huang@richtek.com>,
lucas_tsai@richtek.com,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection
Date: Thu, 26 May 2022 16:13:13 +0800 [thread overview]
Message-ID: <CADiBU39jZ6TdYZoH80m4R-X2_fUXZOvDA4yUd_TQdPzBJLE+JA@mail.gmail.com> (raw)
In-Reply-To: <1c7ab94c-a736-c629-bd8c-8a974803e2b9@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年5月26日 週四 下午4:06寫道：
>
> On 26/05/2022 05:16, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add the new property for ocp level selection.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > .../bindings/leds/backlight/richtek,rt4831-backlight.yaml | 8 ++++++++
> > include/dt-bindings/leds/rt4831-backlight.h | 5 +++++
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > index e0ac686..c1c59de 100644
> > --- a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > @@ -47,6 +47,14 @@ properties:
> > minimum: 0
> > maximum: 3
> >
> > + richtek,bled-ocp-sel:
>
> Skip "sel" as it is a shortcut of selection. Name instead:
> "richtek,backlight-ocp"
>
OK, if so, do I need to rename all properties from 'bled' to 'backlight' ?
If only this property is naming as 'backlight'. it may conflict with
the others like as "richtek,bled-ovp-sel".
>
> > + description: |
> > + Backlight OCP level selection, currently support 0.9A/1.2A/1.5A/1.8A
>
> Could you explain here what is OCP (unfold the acronym)?
Yes. And the full name is 'over current protection'.
>
>
> Best regards,
> Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: ChiYuan Huang <u0084500@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
lucas_tsai@richtek.com, jingoohan1@gmail.com, deller@gmx.de,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
lkml <linux-kernel@vger.kernel.org>,
cy_huang <cy_huang@richtek.com>, Rob Herring <robh+dt@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection
Date: Thu, 26 May 2022 16:13:13 +0800 [thread overview]
Message-ID: <CADiBU39jZ6TdYZoH80m4R-X2_fUXZOvDA4yUd_TQdPzBJLE+JA@mail.gmail.com> (raw)
In-Reply-To: <1c7ab94c-a736-c629-bd8c-8a974803e2b9@linaro.org>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年5月26日 週四 下午4:06寫道：
>
> On 26/05/2022 05:16, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add the new property for ocp level selection.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > .../bindings/leds/backlight/richtek,rt4831-backlight.yaml | 8 ++++++++
> > include/dt-bindings/leds/rt4831-backlight.h | 5 +++++
> > 2 files changed, 13 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > index e0ac686..c1c59de 100644
> > --- a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> > @@ -47,6 +47,14 @@ properties:
> > minimum: 0
> > maximum: 3
> >
> > + richtek,bled-ocp-sel:
>
> Skip "sel" as it is a shortcut of selection. Name instead:
> "richtek,backlight-ocp"
>
OK, if so, do I need to rename all properties from 'bled' to 'backlight' ?
If only this property is naming as 'backlight'. it may conflict with
the others like as "richtek,bled-ovp-sel".
>
> > + description: |
> > + Backlight OCP level selection, currently support 0.9A/1.2A/1.5A/1.8A
>
> Could you explain here what is OCP (unfold the acronym)?
Yes. And the full name is 'over current protection'.
>
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2022-05-26 8:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 3:16 [PATCH 0/2] Add the property to make ocp level selectable cy_huang
2022-05-26 3:16 ` cy_huang
2022-05-26 3:16 ` [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection cy_huang
2022-05-26 3:16 ` cy_huang
2022-05-26 8:06 ` Krzysztof Kozlowski
2022-05-26 8:06 ` Krzysztof Kozlowski
2022-05-26 8:13 ` ChiYuan Huang [this message]
2022-05-26 8:13 ` ChiYuan Huang
2022-05-26 10:32 ` Krzysztof Kozlowski
2022-05-26 10:32 ` Krzysztof Kozlowski
2022-06-02 13:56 ` Rob Herring
2022-06-02 13:56 ` Rob Herring
2022-06-02 13:58 ` Krzysztof Kozlowski
2022-06-02 13:58 ` Krzysztof Kozlowski
2022-06-02 15:31 ` ChiYuan Huang
2022-06-02 15:31 ` ChiYuan Huang
2022-06-05 16:11 ` Krzysztof Kozlowski
2022-06-05 16:11 ` Krzysztof Kozlowski
2022-06-06 1:39 ` ChiYuan Huang
2022-06-06 1:39 ` ChiYuan Huang
2022-06-06 6:20 ` Krzysztof Kozlowski
2022-06-06 6:20 ` Krzysztof Kozlowski
2022-05-26 3:16 ` [PATCH 2/2] backlight: rt4831: Add the property parsing " cy_huang
2022-05-26 3:16 ` cy_huang
2022-05-26 10:05 ` Daniel Thompson
2022-05-26 10:05 ` Daniel Thompson
2022-05-27 2:24 ` ChiYuan Huang
2022-05-27 2:24 ` ChiYuan Huang
2022-05-27 10:56 ` Daniel Thompson
2022-05-27 10:56 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADiBU39jZ6TdYZoH80m4R-X2_fUXZOvDA4yUd_TQdPzBJLE+JA@mail.gmail.com \
--to=u0084500@gmail.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lucas_tsai@richtek.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.