[PATCH] libvirt: do not defer postinstall to first boot when not necessary

[PATCH] libvirt: do not defer postinstall to first boot when not necessary

[Chen Qi]

The postinstall in libvirt has already got a check against $D to
tell whether it's running on target or not, we do not need to use
pkg_postinstall_ontarget. Otherwise, we get unnecessary postinstall
deferred to first boot, which is not what we want.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 recipes-extended/libvirt/libvirt_4.7.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-extended/libvirt/libvirt_4.7.0.bb b/recipes-extended/libvirt/libvirt_4.7.0.bb
index 47275ae..ecccfee 100644
--- a/recipes-extended/libvirt/libvirt_4.7.0.bb
+++ b/recipes-extended/libvirt/libvirt_4.7.0.bb
@@ -311,7 +311,7 @@ do_install_ptest() {
 	done
 }
 
-pkg_postinst_ontarget_${PN}() {
+pkg_postinst_${PN}() {
         if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
                 /etc/init.d/populate-volatile.sh update
         fi
-- 
2.7.4

Re: [PATCH] libvirt: do not defer postinstall to first boot when not necessary

[Bruce Ashfield]

On Mon, Oct 15, 2018 at 3:28 AM Chen Qi <Qi.Chen@windriver.com> wrote:
>
> The postinstall in libvirt has already got a check against $D to
> tell whether it's running on target or not, we do not need to use
> pkg_postinstall_ontarget. Otherwise, we get unnecessary postinstall
> deferred to first boot, which is not what we want.

This commit message isn't complete ...

So when is the postinstall run for the target case ?

Bruce

>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  recipes-extended/libvirt/libvirt_4.7.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/libvirt/libvirt_4.7.0.bb b/recipes-extended/libvirt/libvirt_4.7.0.bb
> index 47275ae..ecccfee 100644
> --- a/recipes-extended/libvirt/libvirt_4.7.0.bb
> +++ b/recipes-extended/libvirt/libvirt_4.7.0.bb
> @@ -311,7 +311,7 @@ do_install_ptest() {
>         done
>  }
>
> -pkg_postinst_ontarget_${PN}() {
> +pkg_postinst_${PN}() {
>          if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
>                  /etc/init.d/populate-volatile.sh update
>          fi
> --
> 2.7.4
>
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [PATCH] libvirt: do not defer postinstall to first boot when not necessary

[ChenQi]

On 10/15/2018 08:49 PM, Bruce Ashfield wrote:
> On Mon, Oct 15, 2018 at 3:28 AM Chen Qi <Qi.Chen@windriver.com> wrote:
>> The postinstall in libvirt has already got a check against $D to
>> tell whether it's running on target or not, we do not need to use
>> pkg_postinstall_ontarget. Otherwise, we get unnecessary postinstall
>> deferred to first boot, which is not what we want.
> This commit message isn't complete ...
>
> So when is the postinstall run for the target case ?
>
> Bruce

This postinstall is only valid for the target case. The 
`/etc/init.d/populate-volatile.sh update' is only useful for an 
on-target package upgrade.
But we should ensure this by checking $D instead of using 
'pkg_postinstall_ontarget', as the latter case will always defer it 
first boot, which is obviously not what we want.
In fact, the postinstall was originally written as 
'pkg_postinstall_${PN}', it was incorrectly changed to 
'pkg_postinstall_ontarget_${PN} by the following commit.

commit 1e67a44db7ec87617455b3228ee5237ceb037173
Author: He Zhe <zhe.he@windriver.com>
Date:   Tue Jul 24 05:50:01 2018 -0700

     libvirt: Remove unsupported configure options and fix warning

     xen and xen-inotify have been removed from upstream. We change
     PACKAGECONFIG accordingly.

     pkg_postinst has been deprecated, use pkg_postinst_ontarget instead.

     WARNING: do_rootfs: Intentionally failing postinstall scriptlets of
     ['libvirt'] to defer them to first boot is deprecated. Please place
     them into pkg_postinst_ontarget_${PN} ().

     Signed-off-by: He Zhe <zhe.he@windriver.com>
     Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>

I think the failing postinstall is caused by some bbappend file instead 
of the one in meta-virtualization.

I'll send out V2 to add more information in the commit message.

Best Regards,
Chen Qi

>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   recipes-extended/libvirt/libvirt_4.7.0.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-extended/libvirt/libvirt_4.7.0.bb b/recipes-extended/libvirt/libvirt_4.7.0.bb
>> index 47275ae..ecccfee 100644
>> --- a/recipes-extended/libvirt/libvirt_4.7.0.bb
>> +++ b/recipes-extended/libvirt/libvirt_4.7.0.bb
>> @@ -311,7 +311,7 @@ do_install_ptest() {
>>          done
>>   }
>>
>> -pkg_postinst_ontarget_${PN}() {
>> +pkg_postinst_${PN}() {
>>           if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
>>                   /etc/init.d/populate-volatile.sh update
>>           fi
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>