[meta-virtualization][PATCH] libvirt: fix do_package issue

[meta-virtualization][PATCH] libvirt: fix do_package issue

[preeti.sachan]

From: Preeti Sachan <preeti.sachan@intel.com>

Signed-off-by: Preeti Sachan <preeti.sachan@intel.com>
---
 recipes-extended/libvirt/libvirt_8.1.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-extended/libvirt/libvirt_8.1.0.bb b/recipes-extended/libvirt/libvirt_8.1.0.bb
index b90fb70..712cea8 100644
--- a/recipes-extended/libvirt/libvirt_8.1.0.bb
+++ b/recipes-extended/libvirt/libvirt_8.1.0.bb
@@ -63,6 +63,7 @@ FILES:${PN}-libvirtd = " \
 	${sysconfdir}/logrotate.d \
 	${sysconfdir}/libvirt/libvirtd.conf \
         /usr/lib/sysctl.d/60-libvirtd.conf \
+        /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf \
 	${sbindir}/libvirtd \
 	${systemd_system_unitdir} \
 	${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '', '${libexecdir}/libvirt-guests.sh', d)} \
-- 
2.25.1

Re: [meta-virtualization][PATCH] libvirt: fix do_package issue

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

I'm not seeing any packaging issues here.

Can you elaborate on what warning/QA/other issue you are seeing ?

Bruce

On Sun, Apr 10, 2022 at 8:38 PM <preeti.sachan@intel.com> wrote:

> From: Preeti Sachan <preeti.sachan@intel.com>
>
> Signed-off-by: Preeti Sachan <preeti.sachan@intel.com>
> ---
>  recipes-extended/libvirt/libvirt_8.1.0.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/recipes-extended/libvirt/libvirt_8.1.0.bb
> b/recipes-extended/libvirt/libvirt_8.1.0.bb
> index b90fb70..712cea8 100644
> --- a/recipes-extended/libvirt/libvirt_8.1.0.bb
> +++ b/recipes-extended/libvirt/libvirt_8.1.0.bb
> @@ -63,6 +63,7 @@ FILES:${PN}-libvirtd = " \
>         ${sysconfdir}/logrotate.d \
>         ${sysconfdir}/libvirt/libvirtd.conf \
>          /usr/lib/sysctl.d/60-libvirtd.conf \
> +        /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf \
>         ${sbindir}/libvirtd \
>         ${systemd_system_unitdir} \
>         ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', '',
> '${libexecdir}/libvirt-guests.sh', d)} \
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7144):
> https://lists.yoctoproject.org/g/meta-virtualization/message/7144
> Mute This Topic: https://lists.yoctoproject.org/mt/90385357/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 3450 bytes --]

Re: [PATCH] libvirt: fix do_package issue

[preeti.sachan]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt: Files/directories were installed but not shipped in any package:
/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libvirt: 1 installed and not shipped files. [installed-vs-shipped]
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were found, failing task.

[-- Attachment #2: Type: text/html, Size: 551 bytes --]

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]

There's definitely something different in your configuration, so that needs
to be understood first.

That file is packaged as part of libvirt-python here, and should be the
same for others, as I haven't had any reports of failures.

You have a multiconfig in play. Anything else ? What is your init system ?
Any bbappends in play ?

Bruce

On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com> wrote:

> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt:
> Files/directories were installed but not shipped in any package:
>   /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
> Please set FILES such that these items are packaged. Alternatively if they
> are unneeded, avoid installing them or delete them within do_install.
> libvirt: 1 installed and not shipped files. [installed-vs-shipped]
> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were
> found, failing task.
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7146):
> https://lists.yoctoproject.org/g/meta-virtualization/message/7146
> Mute This Topic: https://lists.yoctoproject.org/mt/90385357/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 2846 bytes --]

Re: [PATCH] libvirt: fix do_package issue

[preeti.sachan]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

No libvirt bbappend file in build and multiconfig is created to build with particular kernel version.
In recipe https://git.yoctoproject.org/meta-virtualization/tree/recipes-extended/libvirt/libvirt_8.1.0.bb , FILES : ${ PN } - libvirtd is not including "/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf " neither something " usr/lib/sysctl.d/* ". It's strange how it is packaging file "/usr/lib/sysctl.d/60-qemu-postcopy-migration.conf "

[-- Attachment #2: Type: text/html, Size: 1774 bytes --]

RE: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Chen, Qi]

[-- Attachment #1: Type: text/plain, Size: 1728 bytes --]

Hi Bruce & Preeti,

I was trying to fix the same issue when I found this thread.
This issue appears when multilib is enabled.

When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file into libvirt-python.
When multilib is enabled, ${libdir} is /usr/lib64, and the file is not packaged.

Regards,
Qi

From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield
Sent: Monday, April 11, 2022 8:44 PM
To: preeti.sachan@intel.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

There's definitely something different in your configuration, so that needs to be understood first.

That file is packaged as part of libvirt-python here, and should be the same for others, as I haven't had any reports of failures.

You have a multiconfig in play. Anything else ? What is your init system ? Any bbappends in play ?

Bruce

On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>> wrote:
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt: Files/directories were installed but not shipped in any package:
  /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libvirt: 1 installed and not shipped files. [installed-vs-shipped]
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were found, failing task.




--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 5551 bytes --]

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2461 bytes --]

On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@windriver.com> wrote:

> Hi Bruce & Preeti,
>
>
>
> I was trying to fix the same issue when I found this thread.
>
> This issue appears when multilib is enabled.
>
>
>
> When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file
> into libvirt-python.
>
> When multilib is enabled, ${libdir} is /usr/lib64, and the file is not
> packaged.
>

Aha. Right you are.

So we should tweak libvirt to use ${libdir} and not the hardcoded /user/lib
(which it never really should have been), and package anything that gets
installed into sysctl.d/

It isn't clear that this particular .conf belongs in libvirtd, but it is
just as good there, as in the libvirt-python.

I'll do some tests in the non-multiconfig configuration to ensure that
everything still packages properly.

Bruce



>
>
> Regards,
>
> Qi
>
>
>
> *From:* meta-virtualization@lists.yoctoproject.org <
> meta-virtualization@lists.yoctoproject.org> *On Behalf Of *Bruce Ashfield
> *Sent:* Monday, April 11, 2022 8:44 PM
> *To:* preeti.sachan@intel.com
> *Cc:* meta-virtualization@lists.yoctoproject.org
> *Subject:* Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
>
>
>
> There's definitely something different in your configuration, so that
> needs to be understood first.
>
>
>
> That file is packaged as part of libvirt-python here, and should be the
> same for others, as I haven't had any reports of failures.
>
>
>
> You have a multiconfig in play. Anything else ? What is your init system ?
> Any bbappends in play ?
>
>
>
> Bruce
>
>
>
> On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com> wrote:
>
> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt:
> Files/directories were installed but not shipped in any package:
>
>   /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
>
> Please set FILES such that these items are packaged. Alternatively if they
> are unneeded, avoid installing them or delete them within do_install.
>
> libvirt: 1 installed and not shipped files. [installed-vs-shipped]
>
> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were
> found, failing task.
>
>
>
>
>
>
> --
>
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 6447 bytes --]

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 3420 bytes --]

On Mon, Apr 11, 2022 at 9:05 AM Bruce Ashfield via lists.yoctoproject.org
<bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:

>
>
> On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@windriver.com> wrote:
>
>> Hi Bruce & Preeti,
>>
>>
>>
>> I was trying to fix the same issue when I found this thread.
>>
>> This issue appears when multilib is enabled.
>>
>>
>>
>> When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file
>> into libvirt-python.
>>
>> When multilib is enabled, ${libdir} is /usr/lib64, and the file is not
>> packaged.
>>
>
> Aha. Right you are.
>
> So we should tweak libvirt to use ${libdir} and not the hardcoded
> /user/lib (which it never really should have been), and package anything
> that gets installed into sysctl.d/
>
> It isn't clear that this particular .conf belongs in libvirtd, but it is
> just as good there, as in the libvirt-python.
>
> I'll do some tests in the non-multiconfig configuration to ensure that
> everything still packages properly.
>

I've pushed my WIP patch here:

https://git.yoctoproject.org/meta-virtualization/commit/?h=master-next

Bruce



>
> Bruce
>
>
>
>>
>>
>> Regards,
>>
>> Qi
>>
>>
>>
>> *From:* meta-virtualization@lists.yoctoproject.org <
>> meta-virtualization@lists.yoctoproject.org> *On Behalf Of *Bruce Ashfield
>> *Sent:* Monday, April 11, 2022 8:44 PM
>> *To:* preeti.sachan@intel.com
>> *Cc:* meta-virtualization@lists.yoctoproject.org
>> *Subject:* Re: [meta-virtualization] [PATCH] libvirt: fix do_package
>> issue
>>
>>
>>
>> There's definitely something different in your configuration, so that
>> needs to be understood first.
>>
>>
>>
>> That file is packaged as part of libvirt-python here, and should be the
>> same for others, as I haven't had any reports of failures.
>>
>>
>>
>> You have a multiconfig in play. Anything else ? What is your init system
>> ? Any bbappends in play ?
>>
>>
>>
>> Bruce
>>
>>
>>
>> On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com> wrote:
>>
>> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt:
>> Files/directories were installed but not shipped in any package:
>>
>>   /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
>>
>> Please set FILES such that these items are packaged. Alternatively if
>> they are unneeded, avoid installing them or delete them within do_install.
>>
>> libvirt: 1 installed and not shipped files. [installed-vs-shipped]
>>
>> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were
>> found, failing task.
>>
>>
>>
>>
>>
>>
>> --
>>
>> - Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end
>> - "Use the force Harry" - Gandalf, Star Trek II
>>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7153):
> https://lists.yoctoproject.org/g/meta-virtualization/message/7153
> Mute This Topic: https://lists.yoctoproject.org/mt/90385357/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 8505 bytes --]

RE: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Chen, Qi]

[-- Attachment #1: Type: text/plain, Size: 3444 bytes --]

Hi Bruce,

Looking at the issue a little further, I found we need to use the hardcoded ‘/usr/lib’.
This is because sysctl is hardcoding that.

Some codes in sysctl.c from procps:
static int PreloadSystem(void)
{
        unsigned di, i;
        const char *dirs[] = {
                "/etc/sysctl.d",
                "/run/sysctl.d",
                "/usr/local/lib/sysctl.d",
                "/usr/lib/sysctl.d",
                "/lib/sysctl.d",
        };

I’ve sent out a patch to fix the issue. Please help review it.

Regards,
Qi

From: Bruce Ashfield <bruce.ashfield@gmail.com>
Sent: Monday, April 11, 2022 9:05 PM
To: Chen, Qi <Qi.Chen@windriver.com>
Cc: preeti.sachan@intel.com; meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue



On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> wrote:
Hi Bruce & Preeti,

I was trying to fix the same issue when I found this thread.
This issue appears when multilib is enabled.

When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file into libvirt-python.
When multilib is enabled, ${libdir} is /usr/lib64, and the file is not packaged.

Aha. Right you are.

So we should tweak libvirt to use ${libdir} and not the hardcoded /user/lib (which it never really should have been), and package anything that gets installed into sysctl.d/

It isn't clear that this particular .conf belongs in libvirtd, but it is just as good there, as in the libvirt-python.

I'll do some tests in the non-multiconfig configuration to ensure that everything still packages properly.

Bruce



Regards,
Qi

From: meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org> <meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>> On Behalf Of Bruce Ashfield
Sent: Monday, April 11, 2022 8:44 PM
To: preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>
Cc: meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

There's definitely something different in your configuration, so that needs to be understood first.

That file is packaged as part of libvirt-python here, and should be the same for others, as I haven't had any reports of failures.

You have a multiconfig in play. Anything else ? What is your init system ? Any bbappends in play ?

Bruce

On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>> wrote:
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt: Files/directories were installed but not shipped in any package:
  /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libvirt: 1 installed and not shipped files. [installed-vs-shipped]
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were found, failing task.



--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 12674 bytes --]

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 4158 bytes --]

On Mon, Apr 11, 2022 at 9:32 AM Chen, Qi <Qi.Chen@windriver.com> wrote:

> Hi Bruce,
>
>
>
> Looking at the issue a little further, I found we need to use the
> hardcoded ‘/usr/lib’.
>
> This is because sysctl is hardcoding that.
>

That's a larger issue, and it breaks other parts of the system. We
shouldn't have anything with hard coded /usr/lib.

How are other packages dealing with this ?

In that case, I'll do individual scripts in the packaging, since I don't
want a global /usr/lib/ as part of the packaging.

Bruce



>
>
> Some codes in sysctl.c from procps:
>
> static int PreloadSystem(void)
>
> {
>
>         unsigned di, i;
>
>         const char *dirs[] = {
>
>                 "/etc/sysctl.d",
>
>                 "/run/sysctl.d",
>
>                 "/usr/local/lib/sysctl.d",
>
>                 "/usr/lib/sysctl.d",
>
>                 "/lib/sysctl.d",
>
>         };
>
>
>
> I’ve sent out a patch to fix the issue. Please help review it.
>
>
>
> Regards,
>
> Qi
>
>
>
> *From:* Bruce Ashfield <bruce.ashfield@gmail.com>
> *Sent:* Monday, April 11, 2022 9:05 PM
> *To:* Chen, Qi <Qi.Chen@windriver.com>
> *Cc:* preeti.sachan@intel.com; meta-virtualization@lists.yoctoproject.org
> *Subject:* Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
>
>
>
>
>
>
>
> On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@windriver.com> wrote:
>
> Hi Bruce & Preeti,
>
>
>
> I was trying to fix the same issue when I found this thread.
>
> This issue appears when multilib is enabled.
>
>
>
> When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file
> into libvirt-python.
>
> When multilib is enabled, ${libdir} is /usr/lib64, and the file is not
> packaged.
>
>
>
> Aha. Right you are.
>
>
>
> So we should tweak libvirt to use ${libdir} and not the hardcoded
> /user/lib (which it never really should have been), and package anything
> that gets installed into sysctl.d/
>
>
>
> It isn't clear that this particular .conf belongs in libvirtd, but it is
> just as good there, as in the libvirt-python.
>
>
>
> I'll do some tests in the non-multiconfig configuration to ensure that
> everything still packages properly.
>
>
>
> Bruce
>
>
>
>
>
>
>
> Regards,
>
> Qi
>
>
>
> *From:* meta-virtualization@lists.yoctoproject.org <
> meta-virtualization@lists.yoctoproject.org> *On Behalf Of *Bruce Ashfield
> *Sent:* Monday, April 11, 2022 8:44 PM
> *To:* preeti.sachan@intel.com
> *Cc:* meta-virtualization@lists.yoctoproject.org
> *Subject:* Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
>
>
>
> There's definitely something different in your configuration, so that
> needs to be understood first.
>
>
>
> That file is packaged as part of libvirt-python here, and should be the
> same for others, as I haven't had any reports of failures.
>
>
>
> You have a multiconfig in play. Anything else ? What is your init system ?
> Any bbappends in play ?
>
>
>
> Bruce
>
>
>
> On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com> wrote:
>
> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt:
> Files/directories were installed but not shipped in any package:
>
>   /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
>
> Please set FILES such that these items are packaged. Alternatively if they
> are unneeded, avoid installing them or delete them within do_install.
>
> libvirt: 1 installed and not shipped files. [installed-vs-shipped]
>
> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were
> found, failing task.
>
>
>
>
>
>
> --
>
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>
>
>
> --
>
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 11174 bytes --]

RE: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Chen, Qi]

[-- Attachment #1: Type: text/plain, Size: 4938 bytes --]

The only package I found which uses /usr/lib/sysctl.d is systemd.
It packages ${exec_prefix}/lib/sysctl.d.
And it has its reason. It treats /usr/lib as an arch-independent vendor dir, and $libdir is treated as the dir to hold libs.
file-hierarchy (www.freedesktop.org)<https://www.freedesktop.org/software/systemd/man/file-hierarchy.html#:~:text=Operating%20systems%20using%20the%20systemd%281%29%20system%20and%20service,XDG%20Base%20Directory%20Specification%20and%20XDG%20User%20Directories.>

Regards,
Qi

From: Bruce Ashfield <bruce.ashfield@gmail.com>
Sent: Monday, April 11, 2022 9:35 PM
To: Chen, Qi <Qi.Chen@windriver.com>
Cc: preeti.sachan@intel.com; meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue



On Mon, Apr 11, 2022 at 9:32 AM Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> wrote:
Hi Bruce,

Looking at the issue a little further, I found we need to use the hardcoded ‘/usr/lib’.
This is because sysctl is hardcoding that.

That's a larger issue, and it breaks other parts of the system. We shouldn't have anything with hard coded /usr/lib.

How are other packages dealing with this ?

In that case, I'll do individual scripts in the packaging, since I don't want a global /usr/lib/ as part of the packaging.

Bruce



Some codes in sysctl.c from procps:
static int PreloadSystem(void)
{
        unsigned di, i;
        const char *dirs[] = {
                "/etc/sysctl.d",
                "/run/sysctl.d",
                "/usr/local/lib/sysctl.d",
                "/usr/lib/sysctl.d",
                "/lib/sysctl.d",
        };

I’ve sent out a patch to fix the issue. Please help review it.

Regards,
Qi

From: Bruce Ashfield <bruce.ashfield@gmail.com<mailto:bruce.ashfield@gmail.com>>
Sent: Monday, April 11, 2022 9:05 PM
To: Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>>
Cc: preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>; meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue



On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> wrote:
Hi Bruce & Preeti,

I was trying to fix the same issue when I found this thread.
This issue appears when multilib is enabled.

When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file into libvirt-python.
When multilib is enabled, ${libdir} is /usr/lib64, and the file is not packaged.

Aha. Right you are.

So we should tweak libvirt to use ${libdir} and not the hardcoded /user/lib (which it never really should have been), and package anything that gets installed into sysctl.d/

It isn't clear that this particular .conf belongs in libvirtd, but it is just as good there, as in the libvirt-python.

I'll do some tests in the non-multiconfig configuration to ensure that everything still packages properly.

Bruce



Regards,
Qi

From: meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org> <meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>> On Behalf Of Bruce Ashfield
Sent: Monday, April 11, 2022 8:44 PM
To: preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>
Cc: meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

There's definitely something different in your configuration, so that needs to be understood first.

That file is packaged as part of libvirt-python here, and should be the same for others, as I haven't had any reports of failures.

You have a multiconfig in play. Anything else ? What is your init system ? Any bbappends in play ?

Bruce

On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>> wrote:
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt: Files/directories were installed but not shipped in any package:
  /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libvirt: 1 installed and not shipped files. [installed-vs-shipped]
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were found, failing task.



--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 19042 bytes --]

Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 5470 bytes --]

On Mon, Apr 11, 2022 at 9:45 AM Chen, Qi <Qi.Chen@windriver.com> wrote:

> The only package I found which uses /usr/lib/sysctl.d is systemd.
>
> It packages ${exec_prefix}/lib/sysctl.d.
>
> And it has its reason. It treats /usr/lib as an arch-independent vendor
> dir, and $libdir is treated as the dir to hold libs.
>
> file-hierarchy (www.freedesktop.org)
> <https://www.freedesktop.org/software/systemd/man/file-hierarchy.html#:~:text=Operating%20systems%20using%20the%20systemd%281%29%20system%20and%20service,XDG%20Base%20Directory%20Specification%20and%20XDG%20User%20Directories.>
>
>
>

Hmm.  Indeed. In that case, I'll go with a variant of the original patch,
with a tweaked commit log. I'll take care of that now.

Bruce



> Regards,
>
> Qi
>
>
>
> *From:* Bruce Ashfield <bruce.ashfield@gmail.com>
> *Sent:* Monday, April 11, 2022 9:35 PM
> *To:* Chen, Qi <Qi.Chen@windriver.com>
> *Cc:* preeti.sachan@intel.com; meta-virtualization@lists.yoctoproject.org
> *Subject:* Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
>
>
>
>
>
>
>
> On Mon, Apr 11, 2022 at 9:32 AM Chen, Qi <Qi.Chen@windriver.com> wrote:
>
> Hi Bruce,
>
>
>
> Looking at the issue a little further, I found we need to use the
> hardcoded ‘/usr/lib’.
>
> This is because sysctl is hardcoding that.
>
>
>
> That's a larger issue, and it breaks other parts of the system. We
> shouldn't have anything with hard coded /usr/lib.
>
>
>
> How are other packages dealing with this ?
>
>
>
> In that case, I'll do individual scripts in the packaging, since I don't
> want a global /usr/lib/ as part of the packaging.
>
>
>
> Bruce
>
>
>
>
>
>
>
> Some codes in sysctl.c from procps:
>
> static int PreloadSystem(void)
>
> {
>
>         unsigned di, i;
>
>         const char *dirs[] = {
>
>                 "/etc/sysctl.d",
>
>                 "/run/sysctl.d",
>
>                 "/usr/local/lib/sysctl.d",
>
>                 "/usr/lib/sysctl.d",
>
>                 "/lib/sysctl.d",
>
>         };
>
>
>
> I’ve sent out a patch to fix the issue. Please help review it.
>
>
>
> Regards,
>
> Qi
>
>
>
> *From:* Bruce Ashfield <bruce.ashfield@gmail.com>
> *Sent:* Monday, April 11, 2022 9:05 PM
> *To:* Chen, Qi <Qi.Chen@windriver.com>
> *Cc:* preeti.sachan@intel.com; meta-virtualization@lists.yoctoproject.org
> *Subject:* Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
>
>
>
>
>
>
>
> On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@windriver.com> wrote:
>
> Hi Bruce & Preeti,
>
>
>
> I was trying to fix the same issue when I found this thread.
>
> This issue appears when multilib is enabled.
>
>
>
> When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file
> into libvirt-python.
>
> When multilib is enabled, ${libdir} is /usr/lib64, and the file is not
> packaged.
>
>
>
> Aha. Right you are.
>
>
>
> So we should tweak libvirt to use ${libdir} and not the hardcoded
> /user/lib (which it never really should have been), and package anything
> that gets installed into sysctl.d/
>
>
>
> It isn't clear that this particular .conf belongs in libvirtd, but it is
> just as good there, as in the libvirt-python.
>
>
>
> I'll do some tests in the non-multiconfig configuration to ensure that
> everything still packages properly.
>
>
>
> Bruce
>
>
>
>
>
>
>
> Regards,
>
> Qi
>
>
>
> *From:* meta-virtualization@lists.yoctoproject.org <
> meta-virtualization@lists.yoctoproject.org> *On Behalf Of *Bruce Ashfield
> *Sent:* Monday, April 11, 2022 8:44 PM
> *To:* preeti.sachan@intel.com
> *Cc:* meta-virtualization@lists.yoctoproject.org
> *Subject:* Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
>
>
>
> There's definitely something different in your configuration, so that
> needs to be understood first.
>
>
>
> That file is packaged as part of libvirt-python here, and should be the
> same for others, as I haven't had any reports of failures.
>
>
>
> You have a multiconfig in play. Anything else ? What is your init system ?
> Any bbappends in play ?
>
>
>
> Bruce
>
>
>
> On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com> wrote:
>
> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt:
> Files/directories were installed but not shipped in any package:
>
>   /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
>
> Please set FILES such that these items are packaged. Alternatively if they
> are unneeded, avoid installing them or delete them within do_install.
>
> libvirt: 1 installed and not shipped files. [installed-vs-shipped]
>
> ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were
> found, failing task.
>
>
>
>
>
>
> --
>
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>
>
>
> --
>
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>
>
>
> --
>
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 14781 bytes --]

Re: [PATCH] libvirt: fix do_package issue

[preeti.sachan]

[-- Attachment #1: Type: text/plain, Size: 96 bytes --]

Hi Qi

You are right. My build configuration is also using multilib and this issue appeared.

[-- Attachment #2: Type: text/html, Size: 104 bytes --]

RE: [meta-virtualization] [PATCH] libvirt: fix do_package issue

[Peter Kjellerstedt]

[-- Attachment #1: Type: text/plain, Size: 5354 bytes --]

Just for the record, there is ${nonarch_libdir} that expands to “/usr/lib” regardless of whether multilib is used or not. It is typically intended for cases like this.

//Peter

From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Bruce Ashfield
Sent: den 11 april 2022 15:53
To: Chen, Qi <Qi.Chen@windriver.com>
Cc: preeti.sachan@intel.com; meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue

On Mon, Apr 11, 2022 at 9:45 AM Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> wrote:
The only package I found which uses /usr/lib/sysctl.d is systemd.
It packages ${exec_prefix}/lib/sysctl.d.
And it has its reason. It treats /usr/lib as an arch-independent vendor dir, and $libdir is treated as the dir to hold libs.
file-hierarchy (www.freedesktop.org)<https://www.freedesktop.org/software/systemd/man/file-hierarchy.html#:~:text=Operating%20systems%20using%20the%20systemd%281%29%20system%20and%20service,XDG%20Base%20Directory%20Specification%20and%20XDG%20User%20Directories.>
Hmm.  Indeed. In that case, I'll go with a variant of the original patch, with a tweaked commit log. I'll take care of that now.

Bruce

 Regards,
Qi
From: Bruce Ashfield <bruce.ashfield@gmail.com<mailto:bruce.ashfield@gmail.com>>
Sent: Monday, April 11, 2022 9:35 PM
To: Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>>
Cc: preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>; meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
 On Mon, Apr 11, 2022 at 9:32 AM Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> wrote:
Hi Bruce,
Looking at the issue a little further, I found we need to use the hardcoded ‘/usr/lib’.
This is because sysctl is hardcoding that.
That's a larger issue, and it breaks other parts of the system. We shouldn't have anything with hard coded /usr/lib.
How are other packages dealing with this ?
In that case, I'll do individual scripts in the packaging, since I don't want a global /usr/lib/ as part of the packaging.
Bruce
Some codes in sysctl.c from procps:
static int PreloadSystem(void)
{
        unsigned di, i;
        const char *dirs[] = {
                "/etc/sysctl.d",
                "/run/sysctl.d",
                "/usr/local/lib/sysctl.d",
                "/usr/lib/sysctl.d",
                "/lib/sysctl.d",
        };
I’ve sent out a patch to fix the issue. Please help review it.
Regards,
Qi
From: Bruce Ashfield <bruce.ashfield@gmail.com<mailto:bruce.ashfield@gmail.com>>
Sent: Monday, April 11, 2022 9:05 PM
To: Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>>
Cc: preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>; meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
 On Mon, Apr 11, 2022 at 9:01 AM Chen, Qi <Qi.Chen@windriver.com<mailto:Qi.Chen@windriver.com>> wrote:
Hi Bruce & Preeti,
I was trying to fix the same issue when I found this thread.
This issue appears when multilib is enabled.
When multilib is disabled, ${libdir} is /usr/lib, thus packaging the file into libvirt-python.
When multilib is enabled, ${libdir} is /usr/lib64, and the file is not packaged.
Aha. Right you are.
So we should tweak libvirt to use ${libdir} and not the hardcoded /user/lib (which it never really should have been), and package anything that gets installed into sysctl.d/
It isn't clear that this particular .conf belongs in libvirtd, but it is just as good there, as in the libvirt-python.
I'll do some tests in the non-multiconfig configuration to ensure that everything still packages properly.
Bruce
Regards,
Qi
From: meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org> <meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>> On Behalf Of Bruce Ashfield
Sent: Monday, April 11, 2022 8:44 PM
To: preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>
Cc: meta-virtualization@lists.yoctoproject.org<mailto:meta-virtualization@lists.yoctoproject.org>
Subject: Re: [meta-virtualization] [PATCH] libvirt: fix do_package issue
There's definitely something different in your configuration, so that needs to be understood first.
That file is packaged as part of libvirt-python here, and should be the same for others, as I haven't had any reports of failures.
You have a multiconfig in play. Anything else ? What is your init system ? Any bbappends in play ?
Bruce
On Sun, Apr 10, 2022 at 11:49 PM <preeti.sachan@intel.com<mailto:preeti.sachan@intel.com>> wrote:
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: QA Issue: libvirt: Files/directories were installed but not shipped in any package:
  /usr/lib/sysctl.d/60-qemu-postcopy-migration.conf
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
libvirt: 1 installed and not shipped files. [installed-vs-shipped]
ERROR: mc:x86-2020:libvirt-8.1.0-r0 do_package: Fatal QA errors were found, failing task.

[-- Attachment #2: Type: text/html, Size: 18587 bytes --]