All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] python: python3-idna: fix non-existent Unicode license
@ 2021-12-01 16:13 Quentin Schulz
  2021-12-01 16:57 ` Bruce Ashfield
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Quentin Schulz @ 2021-12-01 16:13 UTC (permalink / raw)
  To: openembedded-core; +Cc: bruce.ashfield, Quentin Schulz, Quentin Schulz

In addition to not being an SPDX license, Unicode license also isn't
available in any of the LICENSE_PATH available in openembedded, meaning
the following warning is printed:

python3-idna: No generic license file exists for: Unicode in any provider [license-exists]

Unfortunately the license is not really explicit in the project. After
looking at the code, it seems that this license gets pulled by
idna/idnadata.py and idna/uts46data.py which are auto-generated by
tools/idna-data which downloads data from
http://www.unicode.org/Public/{version}/ucd/ and
http://www.unicode.org/Public/idna/ which are covered by
https://www.unicode.org/license.txt as mentioned in
https://www.unicode.org/copyright.html.

Comparing https://www.unicode.org/license.txt to Unicode-DFS-2016
resulted in a match so let's point to that SPDX license instead.

Cc: Quentin Schulz <foss+yocto@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
 meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
index a0e6b79a56..f3c53a8717 100644
--- a/meta/recipes-devtools/python/python3-idna_3.3.bb
+++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
@@ -1,6 +1,11 @@
 SUMMARY = "Internationalised Domain Names in Applications"
 HOMEPAGE = "https://github.com/kjd/idna"
-LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
+# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
+# files auto-generated by tools/idna-data which downloads data from
+# http://www.unicode.org/Public/{version}/ucd/ and http://www.unicode.org/Public/idna/
+# which are covered by https://www.unicode.org/license.txt as mentioned by
+# https://www.unicode.org/copyright.html
+LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
 LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
 
 SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
-- 
2.33.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] python: python3-idna: fix non-existent Unicode license
  2021-12-01 16:13 [PATCH] python: python3-idna: fix non-existent Unicode license Quentin Schulz
@ 2021-12-01 16:57 ` Bruce Ashfield
  2021-12-01 17:04 ` [OE-core] " Konrad Weihmann
  2021-12-02 16:37 ` Khem Raj
  2 siblings, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2021-12-01 16:57 UTC (permalink / raw)
  To: Quentin Schulz
  Cc: Patches and discussions about the oe-core layer, Quentin Schulz

On Wed, Dec 1, 2021 at 11:13 AM Quentin Schulz
<quentin.schulz@theobroma-systems.com> wrote:
>
> In addition to not being an SPDX license, Unicode license also isn't
> available in any of the LICENSE_PATH available in openembedded, meaning
> the following warning is printed:
>
> python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
>
> Unfortunately the license is not really explicit in the project. After
> looking at the code, it seems that this license gets pulled by
> idna/idnadata.py and idna/uts46data.py which are auto-generated by
> tools/idna-data which downloads data from
> http://www.unicode.org/Public/{version}/ucd/ and
> http://www.unicode.org/Public/idna/ which are covered by
> https://www.unicode.org/license.txt as mentioned in
> https://www.unicode.org/copyright.html.
>
> Comparing https://www.unicode.org/license.txt to Unicode-DFS-2016
> resulted in a match so let's point to that SPDX license instead.

I'm not able to reproduce the warning yet, but the license cleanup
makes sense even without that.

Looks good to me.

Bruce


>
> Cc: Quentin Schulz <foss+yocto@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>  meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
> index a0e6b79a56..f3c53a8717 100644
> --- a/meta/recipes-devtools/python/python3-idna_3.3.bb
> +++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
> @@ -1,6 +1,11 @@
>  SUMMARY = "Internationalised Domain Names in Applications"
>  HOMEPAGE = "https://github.com/kjd/idna"
> -LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
> +# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
> +# files auto-generated by tools/idna-data which downloads data from
> +# http://www.unicode.org/Public/{version}/ucd/ and http://www.unicode.org/Public/idna/
> +# which are covered by https://www.unicode.org/license.txt as mentioned by
> +# https://www.unicode.org/copyright.html
> +LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
>  LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
>
>  SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
> --
> 2.33.1
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] python: python3-idna: fix non-existent Unicode license
  2021-12-01 16:13 [PATCH] python: python3-idna: fix non-existent Unicode license Quentin Schulz
  2021-12-01 16:57 ` Bruce Ashfield
@ 2021-12-01 17:04 ` Konrad Weihmann
  2021-12-01 17:20   ` Quentin Schulz
  2021-12-02 16:37 ` Khem Raj
  2 siblings, 1 reply; 8+ messages in thread
From: Konrad Weihmann @ 2021-12-01 17:04 UTC (permalink / raw)
  To: Quentin Schulz, openembedded-core; +Cc: bruce.ashfield, Quentin Schulz

I'm kind of following the argumentation in the commit message, still I 
see differences between the Unicode-DFS-2016 template file and the text 
downloadable from https://www.unicode.org/license.txt.

Not much, but enough to make me think, if we wouldn't instead need a 
Unicode-DFS-2021 file and reference to that.

Anyway I fully support that change

On a different note - I think any unicode license reference would also 
need a copy of https://www.unicode.org/copyright.html, as all the 
downloads point to that (and the license in just a subset of a broader 
scope of rights and regulations) - INAL, but from my limited legal 
understanding we should reference both

On 01.12.21 17:13, Quentin Schulz wrote:
> In addition to not being an SPDX license, Unicode license also isn't
> available in any of the LICENSE_PATH available in openembedded, meaning
> the following warning is printed:
> 
> python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
> 
> Unfortunately the license is not really explicit in the project. After
> looking at the code, it seems that this license gets pulled by
> idna/idnadata.py and idna/uts46data.py which are auto-generated by
> tools/idna-data which downloads data from
> http://www.unicode.org/Public/{version}/ucd/ and
> http://www.unicode.org/Public/idna/ which are covered by
> https://www.unicode.org/license.txt as mentioned in
> https://www.unicode.org/copyright.html.
> 
> Comparing https://www.unicode.org/license.txt to Unicode-DFS-2016
> resulted in a match so let's point to that SPDX license instead.
> 
> Cc: Quentin Schulz <foss+yocto@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>   meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
> index a0e6b79a56..f3c53a8717 100644
> --- a/meta/recipes-devtools/python/python3-idna_3.3.bb
> +++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
> @@ -1,6 +1,11 @@
>   SUMMARY = "Internationalised Domain Names in Applications"
>   HOMEPAGE = "https://github.com/kjd/idna"
> -LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
> +# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
> +# files auto-generated by tools/idna-data which downloads data from
> +# http://www.unicode.org/Public/{version}/ucd/ and http://www.unicode.org/Public/idna/
> +# which are covered by https://www.unicode.org/license.txt as mentioned by
> +# https://www.unicode.org/copyright.html
> +LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
>   LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
>   
>   SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159041): https://lists.openembedded.org/g/openembedded-core/message/159041
> Mute This Topic: https://lists.openembedded.org/mt/87431709/3647476
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kweihmann@outlook.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] python: python3-idna: fix non-existent Unicode license
  2021-12-01 17:04 ` [OE-core] " Konrad Weihmann
@ 2021-12-01 17:20   ` Quentin Schulz
  2021-12-01 17:30     ` Konrad Weihmann
  0 siblings, 1 reply; 8+ messages in thread
From: Quentin Schulz @ 2021-12-01 17:20 UTC (permalink / raw)
  To: Konrad Weihmann; +Cc: openembedded-core, bruce.ashfield, Quentin Schulz

Hi Konrad,

On Wed, Dec 01, 2021 at 06:04:36PM +0100, Konrad Weihmann wrote:
> I'm kind of following the argumentation in the commit message, still I see
> differences between the Unicode-DFS-2016 template file and the text
> downloadable from https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=
> .
> 
> Not much, but enough to make me think, if we wouldn't instead need a
> Unicode-DFS-2021 file and reference to that.
> 

We'd need to upload the new license to spdx and I've absolutely no clue
if the differences are enough to warrant a new SPDX entry... especially
since AFAICT, it's just that some of the content is moved to
copyright.txt (which is linked in the new license.txt) resulting to me
to basically a noop? But me stating it was a match was incorrect, thanks
for pointing this out.

> Anyway I fully support that change
> 
> On a different note - I think any unicode license reference would also need
> a copy of https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e=
> , as all the downloads point to that (and the license in just a subset of a
> broader scope of rights and regulations) - INAL, but from my limited legal
> understanding we should reference both
> 

AFAICT, this looks like it would be Unicode-TOU but it's again not a
perfect match.

So /me shrugs, don't know what we should be doing with that except
fixing the warning one way or the other (preferrably the best one :) ).

Cheers,
Quentin

> On 01.12.21 17:13, Quentin Schulz wrote:
> > In addition to not being an SPDX license, Unicode license also isn't
> > available in any of the LICENSE_PATH available in openembedded, meaning
> > the following warning is printed:
> > 
> > python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
> > 
> > Unfortunately the license is not really explicit in the project. After
> > looking at the code, it seems that this license gets pulled by
> > idna/idnadata.py and idna/uts46data.py which are auto-generated by
> > tools/idna-data which downloads data from
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_-257Bversion-257D_ucd_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=NVUVu2hKfeamx4mn_29KhgBwY_drrHGSIiEbbTpoUsk&e=  and
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_idna_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=XmJGToF17xNKllS2M3Zw4q82BF0PBORm7gMWm2E6sgA&e=  which are covered by
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=  as mentioned in
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e= .
> > 
> > Comparing https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=  to Unicode-DFS-2016
> > resulted in a match so let's point to that SPDX license instead.
> > 
> > Cc: Quentin Schulz <foss+yocto@0leil.net>
> > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> > ---
> >   meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
> >   1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
> > index a0e6b79a56..f3c53a8717 100644
> > --- a/meta/recipes-devtools/python/python3-idna_3.3.bb
> > +++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
> > @@ -1,6 +1,11 @@
> >   SUMMARY = "Internationalised Domain Names in Applications"
> >   HOMEPAGE = "https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kjd_idna&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=Nh_apZKGYGza7AOqJ_dDAmZxqmdkIrXfuP_F90MfKI8&e= "
> > -LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
> > +# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
> > +# files auto-generated by tools/idna-data which downloads data from
> > +# https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_-257Bversion-257D_ucd_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=NVUVu2hKfeamx4mn_29KhgBwY_drrHGSIiEbbTpoUsk&e=
> > and https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_idna_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=XmJGToF17xNKllS2M3Zw4q82BF0PBORm7gMWm2E6sgA&e=
> > +# which are covered by https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=
> > as mentioned by
> > +# https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e=
> > +LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
> >   LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
> >   SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
> > 
> > 
> > 
> > 
> > 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159051): https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_message_159051&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=m23VxgYB7N-z7CNAG3EUeP2_RAn-l_VogarWnXYJcBc&e= 
> Mute This Topic: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_87431709_6293953&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=DDak0KjV1SEd72iTEHY9dvcK-WxIeQMs_zHFcPUz4Pc&e= 
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=jzle4OEBHNHhq3VCzjPWFmTQ3J16MLZ1vEwyz91pgAU&e=  [quentin.schulz@theobroma-systems.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] python: python3-idna: fix non-existent Unicode license
  2021-12-01 17:20   ` Quentin Schulz
@ 2021-12-01 17:30     ` Konrad Weihmann
  2021-12-02 14:42       ` Quentin Schulz
  0 siblings, 1 reply; 8+ messages in thread
From: Konrad Weihmann @ 2021-12-01 17:30 UTC (permalink / raw)
  To: Quentin Schulz; +Cc: openembedded-core, bruce.ashfield, Quentin Schulz



On 01.12.21 18:20, Quentin Schulz wrote:
> Hi Konrad,
> 
> On Wed, Dec 01, 2021 at 06:04:36PM +0100, Konrad Weihmann wrote:
>> I'm kind of following the argumentation in the commit message, still I see
>> differences between the Unicode-DFS-2016 template file and the text
>> downloadable from https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=
>> .
>>
>> Not much, but enough to make me think, if we wouldn't instead need a
>> Unicode-DFS-2021 file and reference to that.
>>
> 
> We'd need to upload the new license to spdx and I've absolutely no clue
> if the differences are enough to warrant a new SPDX entry... especially
> since AFAICT, it's just that some of the content is moved to
> copyright.txt (which is linked in the new license.txt) resulting to me
> to basically a noop? But me stating it was a match was incorrect, thanks
> for pointing this out.

Yeah, I'm also not a 100% sure if that's worth all the hustle - maybe 
someone with a more legal like background could just add her/his two 
cents, so things could be cleaned up in a followup

> 
>> Anyway I fully support that change
>>
>> On a different note - I think any unicode license reference would also need
>> a copy of https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e=
>> , as all the downloads point to that (and the license in just a subset of a
>> broader scope of rights and regulations) - INAL, but from my limited legal
>> understanding we should reference both
>>
> 
> AFAICT, this looks like it would be Unicode-TOU but it's again not a
> perfect match.
> 
> So /me shrugs, don't know what we should be doing with that except
> fixing the warning one way or the other (preferrably the best one :) ).

same here - *calling for lawyers to jump into the discussion* :)

Still I think the patch should be picked as it is, as it clearly solves 
an issue, that I've seen as well.

> 
> Cheers,
> Quentin
> 
>> On 01.12.21 17:13, Quentin Schulz wrote:
>>> In addition to not being an SPDX license, Unicode license also isn't
>>> available in any of the LICENSE_PATH available in openembedded, meaning
>>> the following warning is printed:
>>>
>>> python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
>>>
>>> Unfortunately the license is not really explicit in the project. After
>>> looking at the code, it seems that this license gets pulled by
>>> idna/idnadata.py and idna/uts46data.py which are auto-generated by
>>> tools/idna-data which downloads data from
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_-257Bversion-257D_ucd_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=NVUVu2hKfeamx4mn_29KhgBwY_drrHGSIiEbbTpoUsk&e=  and
>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_idna_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=XmJGToF17xNKllS2M3Zw4q82BF0PBORm7gMWm2E6sgA&e=  which are covered by
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=  as mentioned in
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e= .
>>>
>>> Comparing https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=  to Unicode-DFS-2016
>>> resulted in a match so let's point to that SPDX license instead.
>>>
>>> Cc: Quentin Schulz <foss+yocto@0leil.net>
>>> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>> ---
>>>    meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
>>>    1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
>>> index a0e6b79a56..f3c53a8717 100644
>>> --- a/meta/recipes-devtools/python/python3-idna_3.3.bb
>>> +++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
>>> @@ -1,6 +1,11 @@
>>>    SUMMARY = "Internationalised Domain Names in Applications"
>>>    HOMEPAGE = "https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kjd_idna&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=Nh_apZKGYGza7AOqJ_dDAmZxqmdkIrXfuP_F90MfKI8&e= "
>>> -LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
>>> +# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
>>> +# files auto-generated by tools/idna-data which downloads data from
>>> +# https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_-257Bversion-257D_ucd_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=NVUVu2hKfeamx4mn_29KhgBwY_drrHGSIiEbbTpoUsk&e=
>>> and https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_idna_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=XmJGToF17xNKllS2M3Zw4q82BF0PBORm7gMWm2E6sgA&e=
>>> +# which are covered by https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=
>>> as mentioned by
>>> +# https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e=
>>> +LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
>>>    LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
>>>    SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
>>>
>>>
>>>
>>>
>>>
> 
>>
>>
>>
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159052): https://lists.openembedded.org/g/openembedded-core/message/159052
> Mute This Topic: https://lists.openembedded.org/mt/87431709/3647476
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kweihmann@outlook.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] python: python3-idna: fix non-existent Unicode license
  2021-12-01 17:30     ` Konrad Weihmann
@ 2021-12-02 14:42       ` Quentin Schulz
  0 siblings, 0 replies; 8+ messages in thread
From: Quentin Schulz @ 2021-12-02 14:42 UTC (permalink / raw)
  To: Konrad Weihmann
  Cc: openembedded-core, bruce.ashfield, Quentin Schulz, licensing

Cc'ing licensing@lists.yoctoproject.org to hopefully get knowledgeable
people on the topic?

Thanks,
Quentin

On Wed, Dec 01, 2021 at 06:30:39PM +0100, Konrad Weihmann wrote:
> 
> 
> On 01.12.21 18:20, Quentin Schulz wrote:
> > Hi Konrad,
> > 
> > On Wed, Dec 01, 2021 at 06:04:36PM +0100, Konrad Weihmann wrote:
> > > I'm kind of following the argumentation in the commit message, still I see
> > > differences between the Unicode-DFS-2016 template file and the text
> > > downloadable from https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=
> > > .
> > > 
> > > Not much, but enough to make me think, if we wouldn't instead need a
> > > Unicode-DFS-2021 file and reference to that.
> > > 
> > 
> > We'd need to upload the new license to spdx and I've absolutely no clue
> > if the differences are enough to warrant a new SPDX entry... especially
> > since AFAICT, it's just that some of the content is moved to
> > copyright.txt (which is linked in the new license.txt) resulting to me
> > to basically a noop? But me stating it was a match was incorrect, thanks
> > for pointing this out.
> 
> Yeah, I'm also not a 100% sure if that's worth all the hustle - maybe
> someone with a more legal like background could just add her/his two cents,
> so things could be cleaned up in a followup
> 
> > 
> > > Anyway I fully support that change
> > > 
> > > On a different note - I think any unicode license reference would also need
> > > a copy of https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e=
> > > , as all the downloads point to that (and the license in just a subset of a
> > > broader scope of rights and regulations) - INAL, but from my limited legal
> > > understanding we should reference both
> > > 
> > 
> > AFAICT, this looks like it would be Unicode-TOU but it's again not a
> > perfect match.
> > 
> > So /me shrugs, don't know what we should be doing with that except
> > fixing the warning one way or the other (preferrably the best one :) ).
> 
> same here - *calling for lawyers to jump into the discussion* :)
> 
> Still I think the patch should be picked as it is, as it clearly solves an
> issue, that I've seen as well.
> 
> > 
> > Cheers,
> > Quentin
> > 
> > > On 01.12.21 17:13, Quentin Schulz wrote:
> > > > In addition to not being an SPDX license, Unicode license also isn't
> > > > available in any of the LICENSE_PATH available in openembedded, meaning
> > > > the following warning is printed:
> > > > 
> > > > python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
> > > > 
> > > > Unfortunately the license is not really explicit in the project. After
> > > > looking at the code, it seems that this license gets pulled by
> > > > idna/idnadata.py and idna/uts46data.py which are auto-generated by
> > > > tools/idna-data which downloads data from
> > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_-257Bversion-257D_ucd_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=NVUVu2hKfeamx4mn_29KhgBwY_drrHGSIiEbbTpoUsk&e=  and
> > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_idna_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=XmJGToF17xNKllS2M3Zw4q82BF0PBORm7gMWm2E6sgA&e=  which are covered by
> > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=  as mentioned in
> > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e= .
> > > > 
> > > > Comparing https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=  to Unicode-DFS-2016
> > > > resulted in a match so let's point to that SPDX license instead.
> > > > 
> > > > Cc: Quentin Schulz <foss+yocto@0leil.net>
> > > > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> > > > ---
> > > >    meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
> > > >    1 file changed, 6 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
> > > > index a0e6b79a56..f3c53a8717 100644
> > > > --- a/meta/recipes-devtools/python/python3-idna_3.3.bb
> > > > +++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
> > > > @@ -1,6 +1,11 @@
> > > >    SUMMARY = "Internationalised Domain Names in Applications"
> > > >    HOMEPAGE = "https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kjd_idna&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=Nh_apZKGYGza7AOqJ_dDAmZxqmdkIrXfuP_F90MfKI8&e= "
> > > > -LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
> > > > +# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
> > > > +# files auto-generated by tools/idna-data which downloads data from
> > > > +# https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_-257Bversion-257D_ucd_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=NVUVu2hKfeamx4mn_29KhgBwY_drrHGSIiEbbTpoUsk&e=
> > > > and https://urldefense.proofpoint.com/v2/url?u=http-3A__www.unicode.org_Public_idna_&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=XmJGToF17xNKllS2M3Zw4q82BF0PBORm7gMWm2E6sgA&e=
> > > > +# which are covered by https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_license.txt&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=TL5gUxzxy8LLKVu26a2BDDq1J8fal1pDvVz0ry1MulM&e=
> > > > as mentioned by
> > > > +# https://urldefense.proofpoint.com/v2/url?u=https-3A__www.unicode.org_copyright.html&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=-XEY2f17PVO0eg4ZpVBl4VpV5wPmG0K8z8LDsTQAPRs7x2MriQXaHDjlbwAVuKMk&s=GCcxTAmd-wOZF6SPpTOHW392veMDM8RBwO_IAMvDbZA&e=
> > > > +LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
> > > >    LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
> > > >    SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > 
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#159052): https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_message_159052&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=IjDO634_inh9Zk4sO5-plKSa_dksKdn1z6ZV2sjdhG1NrTNoMI93IvqJ87i0iKnX&s=wBfi3XoBP11dwE47mT0s0R8UQSZCXA4VU4127GsgCFc&e=
> > Mute This Topic: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_mt_87431709_3647476&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=IjDO634_inh9Zk4sO5-plKSa_dksKdn1z6ZV2sjdhG1NrTNoMI93IvqJ87i0iKnX&s=2rzq_sfY8q_1WqaDiRJFk31PLx4a92t2gStbSSkSK5Y&e=
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.openembedded.org_g_openembedded-2Dcore_unsub&d=DwICaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=IjDO634_inh9Zk4sO5-plKSa_dksKdn1z6ZV2sjdhG1NrTNoMI93IvqJ87i0iKnX&s=kTULOJx-xnSF7ie8Ixh8t6oWWxGOVd79R7oQcs8mh6w&e=  [kweihmann@outlook.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] python: python3-idna: fix non-existent Unicode license
  2021-12-01 16:13 [PATCH] python: python3-idna: fix non-existent Unicode license Quentin Schulz
  2021-12-01 16:57 ` Bruce Ashfield
  2021-12-01 17:04 ` [OE-core] " Konrad Weihmann
@ 2021-12-02 16:37 ` Khem Raj
  2021-12-02 16:59   ` Konrad Weihmann
  2 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2021-12-02 16:37 UTC (permalink / raw)
  To: Quentin Schulz
  Cc: Patches and discussions about the oe-core layer, Bruce Ashfield,
	Quentin Schulz

On Wed, Dec 1, 2021 at 8:14 AM Quentin Schulz
<quentin.schulz@theobroma-systems.com> wrote:
>
> In addition to not being an SPDX license, Unicode license also isn't
> available in any of the LICENSE_PATH available in openembedded, meaning
> the following warning is printed:
>
> python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
>
> Unfortunately the license is not really explicit in the project. After
> looking at the code, it seems that this license gets pulled by
> idna/idnadata.py and idna/uts46data.py which are auto-generated by
> tools/idna-data which downloads data from
> http://www.unicode.org/Public/{version}/ucd/ and
> http://www.unicode.org/Public/idna/ which are covered by
> https://www.unicode.org/license.txt as mentioned in
> https://www.unicode.org/copyright.html.
>
> Comparing https://www.unicode.org/license.txt to Unicode-DFS-2016
> resulted in a match so let's point to that SPDX license instead.
>
> Cc: Quentin Schulz <foss+yocto@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>  meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
> index a0e6b79a56..f3c53a8717 100644
> --- a/meta/recipes-devtools/python/python3-idna_3.3.bb
> +++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
> @@ -1,6 +1,11 @@
>  SUMMARY = "Internationalised Domain Names in Applications"
>  HOMEPAGE = "https://github.com/kjd/idna"
> -LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
> +# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
> +# files auto-generated by tools/idna-data which downloads data from
> +# http://www.unicode.org/Public/{version}/ucd/ and http://www.unicode.org/Public/idna/
> +# which are covered by https://www.unicode.org/license.txt as mentioned by
> +# https://www.unicode.org/copyright.html
> +LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
>  LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"

I looked at
https://github.com/kjd/idna/blob/master/LICENSE.md
https://pypi.org/project/idna/

and they seem to indicate that it is BSD-3-Clause so where do the
other licenses come from ?

>
>  SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
> --
> 2.33.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#159041): https://lists.openembedded.org/g/openembedded-core/message/159041
> Mute This Topic: https://lists.openembedded.org/mt/87431709/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core] [PATCH] python: python3-idna: fix non-existent Unicode license
  2021-12-02 16:37 ` Khem Raj
@ 2021-12-02 16:59   ` Konrad Weihmann
  0 siblings, 0 replies; 8+ messages in thread
From: Konrad Weihmann @ 2021-12-02 16:59 UTC (permalink / raw)
  To: Khem Raj, Quentin Schulz
  Cc: Patches and discussions about the oe-core layer, Bruce Ashfield,
	Quentin Schulz

I think the Unicode should be clear, as the tool (in)directly uses 
downloads from unicode, but kindly ignores the licensing part of that 
operation.

Looking into the history of that lib I found 
https://github.com/kjd/idna/commit/dd8841d50fd506a0b4986542c21fff32ba1779d1, 
which explains the Python-2.0 part. Not sure, but I think that one can 
be dropped now.

Maybe someone should raise a ticket upstream to tell them, that even 
though they convert the upstream unicode data, they still have to apply 
the unicode terms and conditions

On 02.12.21 17:37, Khem Raj wrote:
> On Wed, Dec 1, 2021 at 8:14 AM Quentin Schulz
> <quentin.schulz@theobroma-systems.com> wrote:
>>
>> In addition to not being an SPDX license, Unicode license also isn't
>> available in any of the LICENSE_PATH available in openembedded, meaning
>> the following warning is printed:
>>
>> python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
>>
>> Unfortunately the license is not really explicit in the project. After
>> looking at the code, it seems that this license gets pulled by
>> idna/idnadata.py and idna/uts46data.py which are auto-generated by
>> tools/idna-data which downloads data from
>> http://www.unicode.org/Public/{version}/ucd/ and
>> http://www.unicode.org/Public/idna/ which are covered by
>> https://www.unicode.org/license.txt as mentioned in
>> https://www.unicode.org/copyright.html.
>>
>> Comparing https://www.unicode.org/license.txt to Unicode-DFS-2016
>> resulted in a match so let's point to that SPDX license instead.
>>
>> Cc: Quentin Schulz <foss+yocto@0leil.net>
>> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>> ---
>>   meta/recipes-devtools/python/python3-idna_3.3.bb | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
>> index a0e6b79a56..f3c53a8717 100644
>> --- a/meta/recipes-devtools/python/python3-idna_3.3.bb
>> +++ b/meta/recipes-devtools/python/python3-idna_3.3.bb
>> @@ -1,6 +1,11 @@
>>   SUMMARY = "Internationalised Domain Names in Applications"
>>   HOMEPAGE = "https://github.com/kjd/idna"
>> -LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
>> +# Note: Unicode license is pulled in by idna/idnadata.py and idna/uts46data.py
>> +# files auto-generated by tools/idna-data which downloads data from
>> +# http://www.unicode.org/Public/{version}/ucd/ and http://www.unicode.org/Public/idna/
>> +# which are covered by https://www.unicode.org/license.txt as mentioned by
>> +# https://www.unicode.org/copyright.html
>> +LICENSE = "BSD-3-Clause & Python-2.0 & Unicode-DFS-2016"
>>   LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
> 
> I looked at
> https://github.com/kjd/idna/blob/master/LICENSE.md
> https://pypi.org/project/idna/
> 
> and they seem to indicate that it is BSD-3-Clause so where do the
> other licenses come from ?
> 
>>
>>   SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
>> --
>> 2.33.1
>>
>>
>>
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#159093): https://lists.openembedded.org/g/openembedded-core/message/159093
>> Mute This Topic: https://lists.openembedded.org/mt/87431709/3647476
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kweihmann@outlook.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-12-02 17:00 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 16:13 [PATCH] python: python3-idna: fix non-existent Unicode license Quentin Schulz
2021-12-01 16:57 ` Bruce Ashfield
2021-12-01 17:04 ` [OE-core] " Konrad Weihmann
2021-12-01 17:20   ` Quentin Schulz
2021-12-01 17:30     ` Konrad Weihmann
2021-12-02 14:42       ` Quentin Schulz
2021-12-02 16:37 ` Khem Raj
2021-12-02 16:59   ` Konrad Weihmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.