[meta-virtualization] [PATCH] criu: skip QA checks textrel

[meta-virtualization] [PATCH] criu: skip QA checks textrel

[zangrc]

WARNING: criu-3.14+gitAUTOINC+e49ce513c8-r0 do_package_qa: QA Issue: criu: ELF binary /usr/sbin/criu has relocations in .text [textrel]

Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com>
---
 recipes-containers/criu/criu_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/recipes-containers/criu/criu_git.bb b/recipes-containers/criu/criu_git.bb
index febf81e..6342620 100644
--- a/recipes-containers/criu/criu_git.bb
+++ b/recipes-containers/criu/criu_git.bb
@@ -22,6 +22,8 @@ SRC_URI = "git://github.com/checkpoint-restore/criu.git;branch=criu-dev \
            file://lib-Makefile-overwrite-install-lib-to-allow-multiarc.patch \
           "
 
+INSANE_SKIP_${PN} += "textrel"
+
 COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
 
 DEPENDS += "libnl libcap protobuf-c-native protobuf-c util-linux-native libbsd libnet"
-- 
2.25.1

Re: [meta-virtualization] [PATCH] criu: skip QA checks textrel

[Bruce Ashfield]

Were these warnings always there ? or has it been something introduced
by recent uprevs of crui ?

Bruce


In message: [meta-virtualization] [PATCH] criu: skip QA checks textrel
on 07/07/2021 zangrc wrote:

> WARNING: criu-3.14+gitAUTOINC+e49ce513c8-r0 do_package_qa: QA Issue: criu: ELF binary /usr/sbin/criu has relocations in .text [textrel]
> 
> Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com>
> ---
>  recipes-containers/criu/criu_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/recipes-containers/criu/criu_git.bb b/recipes-containers/criu/criu_git.bb
> index febf81e..6342620 100644
> --- a/recipes-containers/criu/criu_git.bb
> +++ b/recipes-containers/criu/criu_git.bb
> @@ -22,6 +22,8 @@ SRC_URI = "git://github.com/checkpoint-restore/criu.git;branch=criu-dev \
>             file://lib-Makefile-overwrite-install-lib-to-allow-multiarc.patch \
>            "
>  
> +INSANE_SKIP_${PN} += "textrel"
> +
>  COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
>  
>  DEPENDS += "libnl libcap protobuf-c-native protobuf-c util-linux-native libbsd libnet"
> -- 
> 2.25.1
> 

> 
> 
> 

Re: [meta-virtualization] [PATCH] criu: skip QA checks textrel

[zangrc]

This warning always exists. I think it is caused by not enabling pie on ARM platform.

# For simplicity - compile code in Arm mode without interwork.
# We could choose Thumb mode as default instead - but a dirty
# experiment shows that with 90Kb PIEs Thumb code doesn't save
# even one page. So, let's stick so far to Arm mode as it's more
# universal around all different Arm variations, until someone
# will find any use for Thumb mode. -dima

Zang Ruochen

> -----Original Message-----
> From: Bruce Ashfield <bruce.ashfield@gmail.com>
> Sent: Thursday, July 8, 2021 3:44 AM
> To: Zang, Ruochen/臧 若尘 <zangrc.fnst@fujitsu.com>
> Cc: meta-virtualization@yoctoproject.org
> Subject: Re: [meta-virtualization] [PATCH] criu: skip QA checks textrel
> 
> Were these warnings always there ? or has it been something introduced by
> recent uprevs of crui ?
> 
> Bruce
> 
> 
> In message: [meta-virtualization] [PATCH] criu: skip QA checks textrel on
> 07/07/2021 zangrc wrote:
> 
> > WARNING: criu-3.14+gitAUTOINC+e49ce513c8-r0 do_package_qa: QA Issue:
> > criu: ELF binary /usr/sbin/criu has relocations in .text [textrel]
> >
> > Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com>
> > ---
> >  recipes-containers/criu/criu_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/recipes-containers/criu/criu_git.bb
> > b/recipes-containers/criu/criu_git.bb
> > index febf81e..6342620 100644
> > --- a/recipes-containers/criu/criu_git.bb
> > +++ b/recipes-containers/criu/criu_git.bb
> > @@ -22,6 +22,8 @@ SRC_URI =
> "git://github.com/checkpoint-restore/criu.git;branch=criu-dev \
> >             file://lib-Makefile-overwrite-install-lib-to-allow-multiarc.patch
> \
> >            "
> >
> > +INSANE_SKIP_${PN} += "textrel"
> > +
> >  COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
> >
> >  DEPENDS += "libnl libcap protobuf-c-native protobuf-c util-linux-native libbsd
> libnet"
> > --
> > 2.25.1
> >
> 
> >
> > 
> >

Re: [meta-virtualization] [PATCH] criu: skip QA checks textrel

[Bruce Ashfield]

On Wed, Jul 7, 2021 at 3:43 PM Bruce Ashfield via
lists.yoctoproject.org
<bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>
> Were these warnings always there ? or has it been something introduced
> by recent uprevs of crui ?

We should also document why this QA warning is safe to skip/ignore as
part of this commit message (and even a comment above the QA check in
the recipe itself).

Cheers,

Bruce


>
> Bruce
>
>
> In message: [meta-virtualization] [PATCH] criu: skip QA checks textrel
> on 07/07/2021 zangrc wrote:
>
> > WARNING: criu-3.14+gitAUTOINC+e49ce513c8-r0 do_package_qa: QA Issue: criu: ELF binary /usr/sbin/criu has relocations in .text [textrel]
> >
> > Signed-off-by: Zang Ruochen <zangrc.fnst@fujitsu.com>
> > ---
> >  recipes-containers/criu/criu_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/recipes-containers/criu/criu_git.bb b/recipes-containers/criu/criu_git.bb
> > index febf81e..6342620 100644
> > --- a/recipes-containers/criu/criu_git.bb
> > +++ b/recipes-containers/criu/criu_git.bb
> > @@ -22,6 +22,8 @@ SRC_URI = "git://github.com/checkpoint-restore/criu.git;branch=criu-dev \
> >             file://lib-Makefile-overwrite-install-lib-to-allow-multiarc.patch \
> >            "
> >
> > +INSANE_SKIP_${PN} += "textrel"
> > +
> >  COMPATIBLE_HOST = "(x86_64|arm|aarch64).*-linux"
> >
> >  DEPENDS += "libnl libcap protobuf-c-native protobuf-c util-linux-native libbsd libnet"
> > --
> > 2.25.1
> >
>
> >
> >
> >
>
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II