From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: saul.wold@intel.com
Subject: Re: [PATCH 0/1] kernel-yocto: export GUILT_BASE
Date: Wed, 9 May 2012 16:14:48 -0400 [thread overview]
Message-ID: <CADkTA4OPD6bkH_VsAzqAvzACmn3Q4-8FM=HTJgM6-WkJYUPyrg@mail.gmail.com> (raw)
In-Reply-To: <1336593873.2494.74.camel@ted>
On Wed, May 9, 2012 at 4:04 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2012-05-09 at 09:08 -0400, Bruce Ashfield wrote:
>> On Wed, May 9, 2012 at 8:42 AM, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>> > On Wed, May 9, 2012 at 2:51 AM, Richard Purdie
>> > <richard.purdie@linuxfoundation.org> wrote:
>> >> On Tue, 2012-05-08 at 15:23 -0400, Bruce Ashfield wrote:
>> >>> Richard/Saul,
>> >>>
>> >>> As Frans Meulenbroeks noted this morning, guilt wasn't functional
>> >>> in the devshell. The fix was simple enough, and by ensuring that
>> >>> GUILT_BASE is exported, it works without any extra steps now.
>> >>>
>> >>> I wasn't sure if there a better way to call 'up' to the base
>> >>> method, so I repeated the call to oe_terminal in the do_devshell()
>> >>> in kernel-yocto.bbclass.
>> >>>
>> >>> If there's another approach, let me know and I'll respin the patch.
>> >>
>> >> Can't you just set:
>> >>
>> >> GUILT_BASE = "meta"
>> >
>> > Will that export to the subshell ? I didn't try it .. since I didn't
>> > think it would.
>> > I'll give that a go here :)
>>
>> With just that set in kernel-yocto.bbclass, and I launch devshell, I get this:
>>
>> % guilt applied
>> Patches directory doesn't exist, try guilt-init
>>
>> So unless I misunderstood what you are suggesting, I still need that explicit
>> export.
>
> Sorry, let me be more clear. I meant does:
>
> OE_TERMINAL_EXPORTS += "GUILT_BASE"
> GUILT_BASE = "meta"
Aha. Yes. That does work, since the setVar does that same thing :)
I can drop my devshell override and it works. I'll update my patch and push it
back to the branch in the pull request.
Bruce
>
> work?
>
> I'm not sure we need everything in the original patch...
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
prev parent reply other threads:[~2012-05-09 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 19:23 [PATCH 0/1] kernel-yocto: export GUILT_BASE Bruce Ashfield
2012-05-08 19:23 ` [PATCH 1/1] " Bruce Ashfield
2012-05-09 6:51 ` [PATCH 0/1] " Richard Purdie
2012-05-09 12:42 ` Bruce Ashfield
2012-05-09 13:08 ` Bruce Ashfield
2012-05-09 20:04 ` Richard Purdie
2012-05-09 20:14 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADkTA4OPD6bkH_VsAzqAvzACmn3Q4-8FM=HTJgM6-WkJYUPyrg@mail.gmail.com' \
--to=bruce.ashfield@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=saul.wold@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.