All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/5] upx: fix build with gcc-11
@ 2021-05-14  9:51 Martin Jansa
  2021-05-14  9:51 ` [PATCH 2/5] ipxe: Inhibit -Werror to " Martin Jansa
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: Martin Jansa @ 2021-05-14  9:51 UTC (permalink / raw)
  To: meta-virtualization; +Cc: Martin Jansa

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 .../0001-MyCom.h-fix-build-with-gcc-11.patch  | 31 +++++++++++++++++++
 recipes-extended/upx/upx_git.bb               |  4 ++-
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch

diff --git a/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
new file mode 100644
index 0000000..8b07c77
--- /dev/null
+++ b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
@@ -0,0 +1,31 @@
+From 8fe8cd22163fe11b791aac15b642d122ea98b9b5 Mon Sep 17 00:00:00 2001
+From: Martin Jansa <martin.jansa@lge.com>
+Date: Fri, 14 May 2021 02:26:13 -0700
+Subject: [PATCH] MyCom.h: fix build with gcc-11
+
+* fixes:
+  ./../src/lzma-sdk/C/7zip/Compress/LZMA/LZMAEncoder.h: In member function 'virtual ULONG NCompress::NLZMA::CEncoder::Release()':
+  ./../src/lzma-sdk/C/7zip/Compress/LZMA/../../../Common/MyCom.h:159:32: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
+    159 | STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
+        |                                ^~
+
+Upstream-Status: Submitted [https://github.com/upx/upx-lzma-sdk/pull/5]
+Signed-off-by: Martin Jansa <martin.jansa@lge.com>
+---
+ C/Common/MyCom.h | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/C/Common/MyCom.h b/C/Common/MyCom.h
+index b8dbf38..2e3c54a 100644
+--- a/C/Common/MyCom.h
++++ b/C/Common/MyCom.h
+@@ -156,8 +156,7 @@ public:
+ 
+ #define MY_ADDREF_RELEASE \
+ STDMETHOD_(ULONG, AddRef)() { return ++__m_RefCount; } \
+-STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
+-  return __m_RefCount; delete this; return 0; }
++STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0) return __m_RefCount; delete this; return 0; }
+ 
+ #define MY_UNKNOWN_IMP_SPEC(i) \
+   MY_QUERYINTERFACE_BEGIN \
diff --git a/recipes-extended/upx/upx_git.bb b/recipes-extended/upx/upx_git.bb
index b77e658..96d2e99 100644
--- a/recipes-extended/upx/upx_git.bb
+++ b/recipes-extended/upx/upx_git.bb
@@ -2,7 +2,9 @@ HOMEPAGE = "http://upx.sourceforge.net"
 SUMMARY = "Ultimate executable compressor."
 
 SRCREV = "4e1ae22a1a07be5135c68b25ff05058ae8ae48e1"
-SRC_URI = "gitsm://github.com/upx/upx;branch=devel"
+SRC_URI = "gitsm://github.com/upx/upx;branch=devel \
+    file://0001-MyCom.h-fix-build-with-gcc-11.patch;patchdir=src/lzma-sdk \
+"
 
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/5] ipxe: Inhibit -Werror to fix build with gcc-11
  2021-05-14  9:51 [PATCH 1/5] upx: fix build with gcc-11 Martin Jansa
@ 2021-05-14  9:51 ` Martin Jansa
  2021-05-14  9:51 ` [PATCH 3/5] ipxe: set PV Martin Jansa
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Martin Jansa @ 2021-05-14  9:51 UTC (permalink / raw)
  To: meta-virtualization; +Cc: Martin Jansa

* with gcc-11 it fails with:
  drivers/net/ath/ath5k/ath5k_eeprom.c:437:65: error: 'val' may be used uninitialized [-Werror=maybe-uninitialized]
    437 |                 ee->ee_switch_settling_turbo[mode] = (val >> 8) & 0x7f;
        |                                                      ~~~~~~~~~~~^~~~~~

  tests/bigint_test.c: In function 'bigint_test_exec':
  tests/bigint_test.c:232:14: error: 'result_raw' may be used uninitialized [-Werror=maybe-uninitialized]
    232 |         ok ( memcmp ( result_raw, expected_raw,                         \
        |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    233 |                       sizeof ( result_raw ) ) == 0 );                   \
        |                       ~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-extended/ipxe/ipxe_git.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-extended/ipxe/ipxe_git.bb b/recipes-extended/ipxe/ipxe_git.bb
index 43c8f0e..9e98495 100644
--- a/recipes-extended/ipxe/ipxe_git.bb
+++ b/recipes-extended/ipxe/ipxe_git.bb
@@ -28,6 +28,7 @@ EXTRA_OEMAKE = " \
     CROSS_COMPILE="${TARGET_PREFIX}" \
     EXTRA_HOST_CFLAGS="${BUILD_CFLAGS}" \
     EXTRA_HOST_LDFLAGS="${BUILD_LDFLAGS}" \
+    NO_WERROR="1" \
 "
 
 S = "${WORKDIR}/git/src"
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/5] ipxe: set PV
  2021-05-14  9:51 [PATCH 1/5] upx: fix build with gcc-11 Martin Jansa
  2021-05-14  9:51 ` [PATCH 2/5] ipxe: Inhibit -Werror to " Martin Jansa
@ 2021-05-14  9:51 ` Martin Jansa
  2021-05-14  9:51 ` [PATCH 4/5] dev86: add dependency on gperf-native Martin Jansa
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Martin Jansa @ 2021-05-14  9:51 UTC (permalink / raw)
  To: meta-virtualization; +Cc: Martin Jansa

  ipxe/gitrAUTOINC+18dc73d27e-r0/git$ git describe --tags
  v1.20.1-1-g18dc73d2

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-extended/ipxe/ipxe_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-extended/ipxe/ipxe_git.bb b/recipes-extended/ipxe/ipxe_git.bb
index 9e98495..ff6154e 100644
--- a/recipes-extended/ipxe/ipxe_git.bb
+++ b/recipes-extended/ipxe/ipxe_git.bb
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://../COPYING.GPLv2;md5=b234ee4d69f5fce4486a80fdaf4a4263
 COMPATIBLE_HOST_class-target = '(x86_64|i.86).*-(linux|freebsd.*)'
 
 SRCREV = "18dc73d27edb55ebe9cb13c58d59af3da3bd374b"
-PV = "gitr${SRCPV}"
+PV = "1.20.1+git${SRCPV}"
 PR = "r0"
 
 FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/5] dev86: add dependency on gperf-native
  2021-05-14  9:51 [PATCH 1/5] upx: fix build with gcc-11 Martin Jansa
  2021-05-14  9:51 ` [PATCH 2/5] ipxe: Inhibit -Werror to " Martin Jansa
  2021-05-14  9:51 ` [PATCH 3/5] ipxe: set PV Martin Jansa
@ 2021-05-14  9:51 ` Martin Jansa
  2021-05-14  9:51 ` [PATCH 5/5] dev86: switch to still maintained fork of dev86 Martin Jansa
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 10+ messages in thread
From: Martin Jansa @ 2021-05-14  9:51 UTC (permalink / raw)
  To: meta-virtualization; +Cc: Martin Jansa

* fails to build on hosts without gperf:
  /bin/sh: gperf: command not found
  Makefile:27: recipe for target 'token2.h' failed

* normally this isn't triggered, because token[12].h
  are included in git repo, but regenerating them fails:
  tmp-glibc/work/x86_64-linux/dev86-native/0.16.21-r0/git/cpp$ touch token1.tok
  tmp-glibc/work/x86_64-linux/dev86-native/0.16.21-r0/git/cpp$ make bcc-cpp
  gperf -aptTc -N is_ctok -H hash1 token1.tok > tmp.h
  /bin/sh: gperf: command not found
  Makefile:23: recipe for target 'token1.h' failed
  make: *** [token1.h] Error 127

* unfortunately this isn't enough, because new gperf 3.1 from oe-core
  isn't compatible, we need to upgrade to different dev86 fork which
  contains:
  https://github.com/jbruchon/dev86/pull/19

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-extended/dev86/dev86_0.16.21.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/recipes-extended/dev86/dev86_0.16.21.bb b/recipes-extended/dev86/dev86_0.16.21.bb
index cf64a9d..def7c5c 100644
--- a/recipes-extended/dev86/dev86_0.16.21.bb
+++ b/recipes-extended/dev86/dev86_0.16.21.bb
@@ -9,6 +9,8 @@ SRC_URI = "git://github.com/lkundrak/${BPN}.git;protocol=https"
 
 S = "${WORKDIR}/git"
 
+DEPENDS = "gperf-native"
+
 BBCLASSEXTEND = "native"
 EXTRA_OEMAKE = "VERSION=${PV} PREFIX=${prefix} DIST=${D} LDFLAGS='${LDFLAGS}'"
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 5/5] dev86: switch to still maintained fork of dev86
  2021-05-14  9:51 [PATCH 1/5] upx: fix build with gcc-11 Martin Jansa
                   ` (2 preceding siblings ...)
  2021-05-14  9:51 ` [PATCH 4/5] dev86: add dependency on gperf-native Martin Jansa
@ 2021-05-14  9:51 ` Martin Jansa
  2021-05-14 12:46 ` [meta-virtualization] [PATCH 1/5] upx: fix build with gcc-11 Bruce Ashfield
       [not found] ` <167EEF9E05F75E35.12986@lists.yoctoproject.org>
  5 siblings, 0 replies; 10+ messages in thread
From: Martin Jansa @ 2021-05-14  9:51 UTC (permalink / raw)
  To: meta-virtualization; +Cc: Martin Jansa

* as mentioned in:
  https://github.com/lkundrak/dev86/pull/17
  the original lkundrak repo is no longer maintained

* pass only BASE_PV as VERSION in EXTRA_OEMAKE to prevent:
  | version.h:4:20: error: ‘gitAUTOINC’ undeclared (first use in this function)
  |  #define VER_PAT 21+gitAUTOINC+e254e0b196
  |                     ^

* there are many new commits, we need at least that fix for
  newer gperf

git log --oneline v0.16.21..jbruchon/master
e254e0b (jbruchon/master) Merge pull request #21 from tkchia/master
3473bde [libc] update _signal syscall semantics, per ABI change in ELKS at https://github.com/jbruchon/elks/pull/629
d74e90d Merge pull request #20 from tkchia/tkchia/update-syscalls
541a8d5 [libc] update syscall list & ino_t type, per ELKS tree
710e852 Merge pull request #16 from spacerace/master
b215454 Merge pull request #17 from mfld-fr/master
870635e Move EMU86 & MON86 to standalone projects
84e3d00 [mon86] Latest touch before moving
c2f288c [emu86] Latest touch before moving
f7449f3 libc tests for MSDOS target (far away from complete ;))
6cbd64d fixing problem in string.h introduced by myself -.-
39e04cd Merge branch 'master' of https://github.com/spacerace/dev86
b44e43d Added OpenBSD's timingsafe_bcmp() and timingsafe_memcmp()
857c30e Added BSD's strlcat() and strlcpy(), safe string copy/cat
0764e09 typo in string.h
2fb6a3a swab()
4e09d08 strupr()
2bd985f strset()
5a7bb33 strrev()
56be26a strnset()
c919b2d strlwr()
b63f295 h+Mf bzero() strnset() strset() strlwr() strupr() strrev() swab()
5985246 removed old implementation of strstr. if anyone needs this file => remains in git history
7b481c0 added bzero()
776929c Merge pull request #15 from spacerace/master
8206ed2 stdlib.h + Makefile changes for getenv() and system()
b995d1e getenv() implementation
60466fe system() implementation
12439ac note on __mkenv (related to getenv commits from me)
aae041a removed empty line on top of file
6d6d91f removed uneeded empty file (see sound.c)
ff7d37e formatting (tabs)
246418a formatting in one line fixed
4ff1f48 Merge pull request #14 from mfld-fr/emu86
1b8f8db Add data & suspicious opcode breakpoints
798c4a2 Merge pull request #13 from rdebath/jbruchon
2eb4d82 Add .travis.yml for running "make distribution" tests.
2ea54e1 Merge pull request #12 from mgorny/makez
f14f78e build: Always use $(MAKE) to spawn sub-make
dfb9b42 Merge pull request #11 from mfld-fr/emu86
6ae2b54 Make dev86 working "in tree"
224843f Merge pull request #10 from mfld-fr/emu86
e56a958 [emu86] Test against ELKS - Round 3
0099ec8 Merge pull request #9 from mfld-fr/emu86
32865c8 [emu86] Test against ELKS - Round 2
e1aa9bd Merge pull request #8 from mfld-fr/emu86
c7ebb2a [emu86] Optimize execution lookup
57019a7 [emu86] Complete decoding optimization
de516a5 [emu86] Fix mfld-fr#21 : opcode 90h (NOP)
40f7c99 [emu86] Optimize decoding < C0h
91d4c61 [emu86] Fix mfld-fr#16 : add pcat timing options
d519caf [emu86] Fix mfld-fr#14 : trace support
3a479e7 [emu86] Check vector before interrupt
7eec401 Optimize decoding < 80h
98334d3 Fix mfld-fr#8 and warning cleanup
0579c82 Merge pull request #7 from mfld-fr/master
49492b9 [emu86] Add option for tiny model
da6a960 [emu86] fix #19 : remove PT1 test
e3b465f [dis88] Move back from ELKS
f2ea895 Merge pull request #6 from mfld-fr/master
b0700f4 [mon86] First stage removal after second validated
6ef705d [mon86] Fix #18 : Complete host tool
1fa5a70 Fix #10 and #11 : Target specific code
22c7770 Merge branch 'bug86'
e25c996 [mon86] Tune host tool for read & write
47aadb5 [mon86] Fix #15 : Cleanup in host tool
ae7c628 [mon86] Makefile for host part + more testing
ae6c84a [mon86] New host tool + fix context parsing
c9205ac Add missing void types to libc/misc/qsort.c
7a4f074 unproto: fix macOS Sierra compilation error reported by scontini76
ac6d924 unproto: better CFLAGS
f86ad57 bcc: if EOF is hit before end of comment, report it as an error
fcdbcd7 limits.h: add PATH_MAX
7239fea include: Add a skeleton for inttypes.h
f3e88f9 Remove accidental ignoring of "include"
0ac417a Merge branch 'master' of https://github.com/jbruchon/dev86
74753fa Fix size_t declaration, add ssize_t declaration
4be53b7 Merge pull request #5 from mfld-fr/master
d5ecd9c [mon86] Second stage tested on real SBC
81b0ab2 [mon86] Second stage monitor completed
b55cbbc [mon86] Trace & break interrupt support
18a5ba8 Merge pull request #4 from mfld-fr/master
77f028b [mon86] First stage monitor completed
07689d4 Merge remote-tracking branch 'upstream/master'
e043007 Revert accidental bcc changes in commit 3c83dee
495b99a [emu86] Test against ELKS - Round 1
5508efa Merge pull request #3 from mfld-fr/master
8aa3313 [emu86] Testing against a real ROM - Round 1
d8ac93e [emu86] Fixed #7 : segment selection & override
5b521d6 [emu86] Test against a real POST - Round 2
3c83dee [emu86] Test against a real POST - Round 1
b45a3d2 [emu86] Command line options
345513c [emu86] Fixed #6 : simplified variable size
2d7d316 [emu86] Fixed #2 + FAR call & ret
8ac48bf Import MON86 standalone project needed by EMU86
1da15c0 Bug fixes after EMU86 testing
1dc5fd3 Merge pull request #2 from mfld-fr/master
24935c0 [emu86] Final touch before the weekend
9090120 [emu86] Fixed #5 : redirect serial I/O to PTS
96dfb1a [emu86] Added memory and stack dumps
4fbcead [emu86] Fixed #1 : move reg num out of val struct
205e47d Improved EMU86 for MON86 testing
377ed40 Merge branch 'master' into emu86
fd3cf7e Added partial ZF and CF flags support
c758426 Merge pull request #1 from mfld-fr/master
72ad336 Merge branch 'master' of git://github.com/jbruchon/dev86 into emu86
2d8398b More support of 8086 instruction set
b2eadba EMU86 second draft
9a8e116 EMU86 first draft
fb3b436 Revert "fix linker alignment for .bss segment"
bf19066 Merge https://github.com/anchorz/dev86-1
4e8476e Revert "copt: fix a minor glitch in copt/rules.86"
1bcc185 Merge remote-tracking branch 'upstream/master'
b0426b2 Force output of initial segment directive
a44b267 fix linker alignment for .bss segment
c0832c8 under CYGWIN bcc requires -o option to compile an .o file otherwise it ends up as .exe and cannot link
80d485b (origin/master, origin/HEAD) Add stdint.h header to recognize some C99 types
29dbfca libc/msdos: program name missing in argv[0]
b0e9b25 libc/msdos: __mkargv es register changed
4a350d3 ar: rename of temporary libary fails on some platforms
cf72284 copt: fix a minor glitch in copt/rules.86
ce888f6 Allow copt rules with empty outputs; fix minor glitch in copt/rules.86
4ed1997 bcc/dbprintf.c: ix implicit declaration warnings
9de6f00 Make a.out.h portable to 64 bit systems
7eae1c0 Change strstr() to Jody's two-way implementation
2f53e83 Add a .gitignore file
c21e14a initial version with minimal routines
fa9c32e Add stdint.h header to recognize some C99 types
6e8432b Minor style cleanups
b7a191c Add "make distclean" and make it really clean everything
dab04fb bootblocks: long -> int32_t for proper building on 64-bit hosts
0d9ee41 bootblocks requires as86_encap to build
---
 recipes-extended/dev86/{dev86_0.16.21.bb => dev86_git.bb} | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
 rename recipes-extended/dev86/{dev86_0.16.21.bb => dev86_git.bb} (79%)

diff --git a/recipes-extended/dev86/dev86_0.16.21.bb b/recipes-extended/dev86/dev86_git.bb
similarity index 79%
rename from recipes-extended/dev86/dev86_0.16.21.bb
rename to recipes-extended/dev86/dev86_git.bb
index def7c5c..476bf38 100644
--- a/recipes-extended/dev86/dev86_0.16.21.bb
+++ b/recipes-extended/dev86/dev86_git.bb
@@ -4,15 +4,17 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b"
 SECTION = "console/tools"
 
-SRCREV = "c6f36cbafa979710b809f117562773dbd6825918"
-SRC_URI = "git://github.com/lkundrak/${BPN}.git;protocol=https"
+BASE_PV="0.16.21"
+PV = "${BASE_PV}+git${SRCPV}"
+SRCREV = "e254e0b19651d3b8a20225b40281c9974a95dec4"
+SRC_URI = "git://github.com/jbruchon/${BPN}.git;protocol=https"
 
 S = "${WORKDIR}/git"
 
 DEPENDS = "gperf-native"
 
 BBCLASSEXTEND = "native"
-EXTRA_OEMAKE = "VERSION=${PV} PREFIX=${prefix} DIST=${D} LDFLAGS='${LDFLAGS}'"
+EXTRA_OEMAKE = "VERSION=${BASE_PV} PREFIX=${prefix} DIST=${D} LDFLAGS='${LDFLAGS}'"
 
 do_compile() {
 	# ${S}/Makefile does respect LDFLAGS, but ${S}/cpp/Makefile doesn't when building bcc-cpp
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 1/5] upx: fix build with gcc-11
  2021-05-14  9:51 [PATCH 1/5] upx: fix build with gcc-11 Martin Jansa
                   ` (3 preceding siblings ...)
  2021-05-14  9:51 ` [PATCH 5/5] dev86: switch to still maintained fork of dev86 Martin Jansa
@ 2021-05-14 12:46 ` Bruce Ashfield
       [not found] ` <167EEF9E05F75E35.12986@lists.yoctoproject.org>
  5 siblings, 0 replies; 10+ messages in thread
From: Bruce Ashfield @ 2021-05-14 12:46 UTC (permalink / raw)
  To: Martin Jansa; +Cc: meta-virtualization

Thanks for the fixups.

I haven't been able to spend time on any gcc11 fixes, so these are appreciated.

These built for me ... so they are merged.

But then I switched to a different machine on a different builder, and
dev86 blew up during compilation.

I'm leaving the changes as-is in the tree, and we can fix them as
required as new patches (I'm done mucking with history for one day;)

Cheers,

Bruce



On Fri, May 14, 2021 at 5:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  .../0001-MyCom.h-fix-build-with-gcc-11.patch  | 31 +++++++++++++++++++
>  recipes-extended/upx/upx_git.bb               |  4 ++-
>  2 files changed, 34 insertions(+), 1 deletion(-)
>  create mode 100644 recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
>
> diff --git a/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> new file mode 100644
> index 0000000..8b07c77
> --- /dev/null
> +++ b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> @@ -0,0 +1,31 @@
> +From 8fe8cd22163fe11b791aac15b642d122ea98b9b5 Mon Sep 17 00:00:00 2001
> +From: Martin Jansa <martin.jansa@lge.com>
> +Date: Fri, 14 May 2021 02:26:13 -0700
> +Subject: [PATCH] MyCom.h: fix build with gcc-11
> +
> +* fixes:
> +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/LZMAEncoder.h: In member function 'virtual ULONG NCompress::NLZMA::CEncoder::Release()':
> +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/../../../Common/MyCom.h:159:32: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
> +    159 | STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> +        |                                ^~
> +
> +Upstream-Status: Submitted [https://github.com/upx/upx-lzma-sdk/pull/5]
> +Signed-off-by: Martin Jansa <martin.jansa@lge.com>
> +---
> + C/Common/MyCom.h | 3 +--
> + 1 file changed, 1 insertion(+), 2 deletions(-)
> +
> +diff --git a/C/Common/MyCom.h b/C/Common/MyCom.h
> +index b8dbf38..2e3c54a 100644
> +--- a/C/Common/MyCom.h
> ++++ b/C/Common/MyCom.h
> +@@ -156,8 +156,7 @@ public:
> +
> + #define MY_ADDREF_RELEASE \
> + STDMETHOD_(ULONG, AddRef)() { return ++__m_RefCount; } \
> +-STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> +-  return __m_RefCount; delete this; return 0; }
> ++STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0) return __m_RefCount; delete this; return 0; }
> +
> + #define MY_UNKNOWN_IMP_SPEC(i) \
> +   MY_QUERYINTERFACE_BEGIN \
> diff --git a/recipes-extended/upx/upx_git.bb b/recipes-extended/upx/upx_git.bb
> index b77e658..96d2e99 100644
> --- a/recipes-extended/upx/upx_git.bb
> +++ b/recipes-extended/upx/upx_git.bb
> @@ -2,7 +2,9 @@ HOMEPAGE = "http://upx.sourceforge.net"
>  SUMMARY = "Ultimate executable compressor."
>
>  SRCREV = "4e1ae22a1a07be5135c68b25ff05058ae8ae48e1"
> -SRC_URI = "gitsm://github.com/upx/upx;branch=devel"
> +SRC_URI = "gitsm://github.com/upx/upx;branch=devel \
> +    file://0001-MyCom.h-fix-build-with-gcc-11.patch;patchdir=src/lzma-sdk \
> +"
>
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
> --
> 2.30.2
>
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 1/5] upx: fix build with gcc-11
       [not found] ` <167EEF9E05F75E35.12986@lists.yoctoproject.org>
@ 2021-05-14 13:04   ` Bruce Ashfield
  2021-05-14 13:25     ` Martin Jansa
  0 siblings, 1 reply; 10+ messages in thread
From: Bruce Ashfield @ 2021-05-14 13:04 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: Martin Jansa, meta-virtualization

On Fri, May 14, 2021 at 8:46 AM Bruce Ashfield via
lists.yoctoproject.org
<bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>
> Thanks for the fixups.
>
> I haven't been able to spend time on any gcc11 fixes, so these are appreciated.
>
> These built for me ... so they are merged.
>
> But then I switched to a different machine on a different builder, and
> dev86 blew up during compilation.
>

I can confirm that my second builder is consistently showing this:

Log data follows:
| DEBUG: Executing shell function do_compile
| NOTE: make -j 16 VERSION=0.16.21 PREFIX=/usr
DIST=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/image
LDFLAGS=-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
-Wl,-z,relro,-z,now make.fil
| make[1]: Entering directory
'/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
| x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
-mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
-Wformat -Wformat-security -Werror=format-security -Wdate-time
--sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
 -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
-Wl,-z,relro,-z,now -o ifdefg ifdef.c
| ./ifdefg -MU  makefile.in >tmp.mak
| /bin/sh: 1: ./ifdefg: not found
| make[1]: *** [Makefile:46: make.fil] Error 127
| make[1]: Leaving directory
'/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
| make: *** [GNUmakefile:9: make.fil] Error 2
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.
| ERROR: Execution of
'/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/temp/run.do_compile.30233'
failed with exit code 1:
| make[1]: Entering directory
'/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
| x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
-mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
-Wformat -Wformat-security -Werror=format-security -Wdate-time
--sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
 -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
-Wl,-z,relro,-z,now -o ifdefg ifdef.c
| ./ifdefg -MU  makefile.in >tmp.mak
| /bin/sh: 1: ./ifdefg: not found
| make[1]: *** [Makefile:46: make.fil] Error 127
| make[1]: Leaving directory
'/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
| make: *** [GNUmakefile:9: make.fil] Error 2
| WARNING: exit code 1 from a shell command.
|
ERROR: Task (/home/bruce/poky/meta-virtualization/recipes-extended/dev86/dev86_git.bb:do_compile)
failed with exit code '1'

Does that ring a bell ? I'll dig into it now, but it is worth checking
to see if you ran into it during your recipe update.

Bruce


> I'm leaving the changes as-is in the tree, and we can fix them as
> required as new patches (I'm done mucking with history for one day;)
>
> Cheers,
>
> Bruce
>
>
>
> On Fri, May 14, 2021 at 5:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  .../0001-MyCom.h-fix-build-with-gcc-11.patch  | 31 +++++++++++++++++++
> >  recipes-extended/upx/upx_git.bb               |  4 ++-
> >  2 files changed, 34 insertions(+), 1 deletion(-)
> >  create mode 100644 recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> >
> > diff --git a/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > new file mode 100644
> > index 0000000..8b07c77
> > --- /dev/null
> > +++ b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > @@ -0,0 +1,31 @@
> > +From 8fe8cd22163fe11b791aac15b642d122ea98b9b5 Mon Sep 17 00:00:00 2001
> > +From: Martin Jansa <martin.jansa@lge.com>
> > +Date: Fri, 14 May 2021 02:26:13 -0700
> > +Subject: [PATCH] MyCom.h: fix build with gcc-11
> > +
> > +* fixes:
> > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/LZMAEncoder.h: In member function 'virtual ULONG NCompress::NLZMA::CEncoder::Release()':
> > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/../../../Common/MyCom.h:159:32: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
> > +    159 | STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > +        |                                ^~
> > +
> > +Upstream-Status: Submitted [https://github.com/upx/upx-lzma-sdk/pull/5]
> > +Signed-off-by: Martin Jansa <martin.jansa@lge.com>
> > +---
> > + C/Common/MyCom.h | 3 +--
> > + 1 file changed, 1 insertion(+), 2 deletions(-)
> > +
> > +diff --git a/C/Common/MyCom.h b/C/Common/MyCom.h
> > +index b8dbf38..2e3c54a 100644
> > +--- a/C/Common/MyCom.h
> > ++++ b/C/Common/MyCom.h
> > +@@ -156,8 +156,7 @@ public:
> > +
> > + #define MY_ADDREF_RELEASE \
> > + STDMETHOD_(ULONG, AddRef)() { return ++__m_RefCount; } \
> > +-STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > +-  return __m_RefCount; delete this; return 0; }
> > ++STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0) return __m_RefCount; delete this; return 0; }
> > +
> > + #define MY_UNKNOWN_IMP_SPEC(i) \
> > +   MY_QUERYINTERFACE_BEGIN \
> > diff --git a/recipes-extended/upx/upx_git.bb b/recipes-extended/upx/upx_git.bb
> > index b77e658..96d2e99 100644
> > --- a/recipes-extended/upx/upx_git.bb
> > +++ b/recipes-extended/upx/upx_git.bb
> > @@ -2,7 +2,9 @@ HOMEPAGE = "http://upx.sourceforge.net"
> >  SUMMARY = "Ultimate executable compressor."
> >
> >  SRCREV = "4e1ae22a1a07be5135c68b25ff05058ae8ae48e1"
> > -SRC_URI = "gitsm://github.com/upx/upx;branch=devel"
> > +SRC_URI = "gitsm://github.com/upx/upx;branch=devel \
> > +    file://0001-MyCom.h-fix-build-with-gcc-11.patch;patchdir=src/lzma-sdk \
> > +"
> >
> >  LICENSE = "GPLv2"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
> > --
> > 2.30.2
> >
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 1/5] upx: fix build with gcc-11
  2021-05-14 13:04   ` Bruce Ashfield
@ 2021-05-14 13:25     ` Martin Jansa
  2021-05-14 13:39       ` Bruce Ashfield
  0 siblings, 1 reply; 10+ messages in thread
From: Martin Jansa @ 2021-05-14 13:25 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: meta-virtualization

[-- Attachment #1: Type: text/plain, Size: 8524 bytes --]

On Fri, May 14, 2021 at 09:04:31AM -0400, Bruce Ashfield wrote:
> On Fri, May 14, 2021 at 8:46 AM Bruce Ashfield via
> lists.yoctoproject.org
> <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
> >
> > Thanks for the fixups.
> >
> > I haven't been able to spend time on any gcc11 fixes, so these are appreciated.
> >
> > These built for me ... so they are merged.
> >
> > But then I switched to a different machine on a different builder, and
> > dev86 blew up during compilation.
> >
> 
> I can confirm that my second builder is consistently showing this:
> 
> Log data follows:
> | DEBUG: Executing shell function do_compile
> | NOTE: make -j 16 VERSION=0.16.21 PREFIX=/usr
> DIST=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/image
> LDFLAGS=-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> -Wl,-z,relro,-z,now make.fil
> | make[1]: Entering directory
> '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> | x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> -Wformat -Wformat-security -Werror=format-security -Wdate-time
> --sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
>  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> | ./ifdefg -MU  makefile.in >tmp.mak
> | /bin/sh: 1: ./ifdefg: not found
> | make[1]: *** [Makefile:46: make.fil] Error 127
> | make[1]: Leaving directory
> '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> | make: *** [GNUmakefile:9: make.fil] Error 2
> | ERROR: oe_runmake failed
> | WARNING: exit code 1 from a shell command.
> | ERROR: Execution of
> '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/temp/run.do_compile.30233'
> failed with exit code 1:
> | make[1]: Entering directory
> '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> | x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> -Wformat -Wformat-security -Werror=format-security -Wdate-time
> --sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
>  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> | ./ifdefg -MU  makefile.in >tmp.mak
> | /bin/sh: 1: ./ifdefg: not found
> | make[1]: *** [Makefile:46: make.fil] Error 127
> | make[1]: Leaving directory
> '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> | make: *** [GNUmakefile:9: make.fil] Error 2
> | WARNING: exit code 1 from a shell command.
> |
> ERROR: Task (/home/bruce/poky/meta-virtualization/recipes-extended/dev86/dev86_git.bb:do_compile)
> failed with exit code '1'
> 
> Does that ring a bell ? I'll dig into it now, but it is worth checking
> to see if you ran into it during your recipe update.

It didn't fail for me like this, is your other builder x86_64?

Either it's some race, that it tried to call ifdefg before building it for you (was in correct order in my build):

dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git$ grep ifdefg ../temp/log.do_compile
i686-webos-linux-gcc  -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Werror=return-type --sysroot=/jenkins/mjansa/build/ros/webos-dashing-honister/tmp-glibc/work/qemux86-webos-linux/
dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,relro,-z,now -o ifdefg ifdef.c
./ifdefg -MU  makefile.in >tmp.mak

dev86/0.16.21+gitAUTOINC+e254e0b196-r0$ file git/ifdefg
git/ifdefg: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=3edc52ae7ee0ef4fcd9d9148c63df9977c772780, with debug_info, not stripped

but we should change it to call ifdefg from dev86-native anyway, let me try to reproduce this somehow.

And looks like the older version called ifdefg the same:

dev86/0.16.21-r0$ grep ifdefg temp/log.do_compile
i686-webos-linux-gcc  -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Werror=return-type --sysroot=/jenkins/mjansa/build/ros/webos-dashing-hardknott/tmp-glibc/work/qemux86-webos-linux
/dev86/0.16.21-r0/recipe-sysroot  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,relro,-z,now -o ifdefg ifdef.c
./ifdefg -MU  makefile.in >tmp.mak

> > I'm leaving the changes as-is in the tree, and we can fix them as
> > required as new patches (I'm done mucking with history for one day;)
> >
> > Cheers,
> >
> > Bruce
> >
> >
> >
> > On Fri, May 14, 2021 at 5:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > >
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > >  .../0001-MyCom.h-fix-build-with-gcc-11.patch  | 31 +++++++++++++++++++
> > >  recipes-extended/upx/upx_git.bb               |  4 ++-
> > >  2 files changed, 34 insertions(+), 1 deletion(-)
> > >  create mode 100644 recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > >
> > > diff --git a/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > new file mode 100644
> > > index 0000000..8b07c77
> > > --- /dev/null
> > > +++ b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > @@ -0,0 +1,31 @@
> > > +From 8fe8cd22163fe11b791aac15b642d122ea98b9b5 Mon Sep 17 00:00:00 2001
> > > +From: Martin Jansa <martin.jansa@lge.com>
> > > +Date: Fri, 14 May 2021 02:26:13 -0700
> > > +Subject: [PATCH] MyCom.h: fix build with gcc-11
> > > +
> > > +* fixes:
> > > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/LZMAEncoder.h: In member function 'virtual ULONG NCompress::NLZMA::CEncoder::Release()':
> > > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/../../../Common/MyCom.h:159:32: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
> > > +    159 | STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > > +        |                                ^~
> > > +
> > > +Upstream-Status: Submitted [https://github.com/upx/upx-lzma-sdk/pull/5]
> > > +Signed-off-by: Martin Jansa <martin.jansa@lge.com>
> > > +---
> > > + C/Common/MyCom.h | 3 +--
> > > + 1 file changed, 1 insertion(+), 2 deletions(-)
> > > +
> > > +diff --git a/C/Common/MyCom.h b/C/Common/MyCom.h
> > > +index b8dbf38..2e3c54a 100644
> > > +--- a/C/Common/MyCom.h
> > > ++++ b/C/Common/MyCom.h
> > > +@@ -156,8 +156,7 @@ public:
> > > +
> > > + #define MY_ADDREF_RELEASE \
> > > + STDMETHOD_(ULONG, AddRef)() { return ++__m_RefCount; } \
> > > +-STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > > +-  return __m_RefCount; delete this; return 0; }
> > > ++STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0) return __m_RefCount; delete this; return 0; }
> > > +
> > > + #define MY_UNKNOWN_IMP_SPEC(i) \
> > > +   MY_QUERYINTERFACE_BEGIN \
> > > diff --git a/recipes-extended/upx/upx_git.bb b/recipes-extended/upx/upx_git.bb
> > > index b77e658..96d2e99 100644
> > > --- a/recipes-extended/upx/upx_git.bb
> > > +++ b/recipes-extended/upx/upx_git.bb
> > > @@ -2,7 +2,9 @@ HOMEPAGE = "http://upx.sourceforge.net"
> > >  SUMMARY = "Ultimate executable compressor."
> > >
> > >  SRCREV = "4e1ae22a1a07be5135c68b25ff05058ae8ae48e1"
> > > -SRC_URI = "gitsm://github.com/upx/upx;branch=devel"
> > > +SRC_URI = "gitsm://github.com/upx/upx;branch=devel \
> > > +    file://0001-MyCom.h-fix-build-with-gcc-11.patch;patchdir=src/lzma-sdk \
> > > +"
> > >
> > >  LICENSE = "GPLv2"
> > >  LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
> > > --
> > > 2.30.2
> > >
> > >
> > >
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II
> >
> > 
> >
> 
> 
> -- 
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 1/5] upx: fix build with gcc-11
  2021-05-14 13:25     ` Martin Jansa
@ 2021-05-14 13:39       ` Bruce Ashfield
  2021-05-14 13:41         ` Bruce Ashfield
  0 siblings, 1 reply; 10+ messages in thread
From: Bruce Ashfield @ 2021-05-14 13:39 UTC (permalink / raw)
  To: Martin Jansa; +Cc: meta-virtualization

On Fri, May 14, 2021 at 9:25 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> On Fri, May 14, 2021 at 09:04:31AM -0400, Bruce Ashfield wrote:
> > On Fri, May 14, 2021 at 8:46 AM Bruce Ashfield via
> > lists.yoctoproject.org
> > <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
> > >
> > > Thanks for the fixups.
> > >
> > > I haven't been able to spend time on any gcc11 fixes, so these are appreciated.
> > >
> > > These built for me ... so they are merged.
> > >
> > > But then I switched to a different machine on a different builder, and
> > > dev86 blew up during compilation.
> > >
> >
> > I can confirm that my second builder is consistently showing this:
> >
> > Log data follows:
> > | DEBUG: Executing shell function do_compile
> > | NOTE: make -j 16 VERSION=0.16.21 PREFIX=/usr
> > DIST=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/image
> > LDFLAGS=-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > -Wl,-z,relro,-z,now make.fil
> > | make[1]: Entering directory
> > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > | x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> > -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> > -Wformat -Wformat-security -Werror=format-security -Wdate-time
> > --sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
> >  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> > | ./ifdefg -MU  makefile.in >tmp.mak
> > | /bin/sh: 1: ./ifdefg: not found
> > | make[1]: *** [Makefile:46: make.fil] Error 127
> > | make[1]: Leaving directory
> > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > | make: *** [GNUmakefile:9: make.fil] Error 2
> > | ERROR: oe_runmake failed
> > | WARNING: exit code 1 from a shell command.
> > | ERROR: Execution of
> > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/temp/run.do_compile.30233'
> > failed with exit code 1:
> > | make[1]: Entering directory
> > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > | x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> > -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> > -Wformat -Wformat-security -Werror=format-security -Wdate-time
> > --sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
> >  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> > | ./ifdefg -MU  makefile.in >tmp.mak
> > | /bin/sh: 1: ./ifdefg: not found
> > | make[1]: *** [Makefile:46: make.fil] Error 127
> > | make[1]: Leaving directory
> > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > | make: *** [GNUmakefile:9: make.fil] Error 2
> > | WARNING: exit code 1 from a shell command.
> > |
> > ERROR: Task (/home/bruce/poky/meta-virtualization/recipes-extended/dev86/dev86_git.bb:do_compile)
> > failed with exit code '1'
> >
> > Does that ring a bell ? I'll dig into it now, but it is worth checking
> > to see if you ran into it during your recipe update.
>
> It didn't fail for me like this, is your other builder x86_64?
>

They are both x86-64, but one was building qemux86-64 and the other
genericx86-64 as the target.

> Either it's some race, that it tried to call ifdefg before building it for you (was in correct order in my build):
>

Since that helper is running on the build host, the following made it
work on my broken builder:

diff --git a/recipes-extended/dev86/dev86_git.bb
b/recipes-extended/dev86/dev86_git.bb
index 476bf38..bc68cca 100644
--- a/recipes-extended/dev86/dev86_git.bb
+++ b/recipes-extended/dev86/dev86_git.bb
@@ -19,7 +19,7 @@ EXTRA_OEMAKE = "VERSION=${BASE_PV} PREFIX=${prefix}
DIST=${D} LDFLAGS='${LDFLAGS
 do_compile() {
        # ${S}/Makefile does respect LDFLAGS, but ${S}/cpp/Makefile
doesn't when building bcc-cpp
        sed -i 's#$(CC) $(CFLAGS) -o bcc-cpp#$(CC) $(CFLAGS)
$(LDFLAGS) -o bcc-cpp#g' ${S}/cpp/Makefile
-       oe_runmake make.fil
+       CC=${BUILD_CC} oe_runmake make.fil
        oe_runmake -f make.fil bcc86 as86 ld86
 }


But maybe it just changed the timing, and the fix, really isn't a fix.

Bruce


> dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git$ grep ifdefg ../temp/log.do_compile
> i686-webos-linux-gcc  -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Werror=return-type --sysroot=/jenkins/mjansa/build/ros/webos-dashing-honister/tmp-glibc/work/qemux86-webos-linux/
> dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> ./ifdefg -MU  makefile.in >tmp.mak
>
> dev86/0.16.21+gitAUTOINC+e254e0b196-r0$ file git/ifdefg
> git/ifdefg: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=3edc52ae7ee0ef4fcd9d9148c63df9977c772780, with debug_info, not stripped
>
> but we should change it to call ifdefg from dev86-native anyway, let me try to reproduce this somehow.
>
> And looks like the older version called ifdefg the same:
>
> dev86/0.16.21-r0$ grep ifdefg temp/log.do_compile
> i686-webos-linux-gcc  -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Werror=return-type --sysroot=/jenkins/mjansa/build/ros/webos-dashing-hardknott/tmp-glibc/work/qemux86-webos-linux
> /dev86/0.16.21-r0/recipe-sysroot  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> ./ifdefg -MU  makefile.in >tmp.mak
>
> > > I'm leaving the changes as-is in the tree, and we can fix them as
> > > required as new patches (I'm done mucking with history for one day;)
> > >
> > > Cheers,
> > >
> > > Bruce
> > >
> > >
> > >
> > > On Fri, May 14, 2021 at 5:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > > >
> > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > ---
> > > >  .../0001-MyCom.h-fix-build-with-gcc-11.patch  | 31 +++++++++++++++++++
> > > >  recipes-extended/upx/upx_git.bb               |  4 ++-
> > > >  2 files changed, 34 insertions(+), 1 deletion(-)
> > > >  create mode 100644 recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > >
> > > > diff --git a/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > > new file mode 100644
> > > > index 0000000..8b07c77
> > > > --- /dev/null
> > > > +++ b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > > @@ -0,0 +1,31 @@
> > > > +From 8fe8cd22163fe11b791aac15b642d122ea98b9b5 Mon Sep 17 00:00:00 2001
> > > > +From: Martin Jansa <martin.jansa@lge.com>
> > > > +Date: Fri, 14 May 2021 02:26:13 -0700
> > > > +Subject: [PATCH] MyCom.h: fix build with gcc-11
> > > > +
> > > > +* fixes:
> > > > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/LZMAEncoder.h: In member function 'virtual ULONG NCompress::NLZMA::CEncoder::Release()':
> > > > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/../../../Common/MyCom.h:159:32: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
> > > > +    159 | STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > > > +        |                                ^~
> > > > +
> > > > +Upstream-Status: Submitted [https://github.com/upx/upx-lzma-sdk/pull/5]
> > > > +Signed-off-by: Martin Jansa <martin.jansa@lge.com>
> > > > +---
> > > > + C/Common/MyCom.h | 3 +--
> > > > + 1 file changed, 1 insertion(+), 2 deletions(-)
> > > > +
> > > > +diff --git a/C/Common/MyCom.h b/C/Common/MyCom.h
> > > > +index b8dbf38..2e3c54a 100644
> > > > +--- a/C/Common/MyCom.h
> > > > ++++ b/C/Common/MyCom.h
> > > > +@@ -156,8 +156,7 @@ public:
> > > > +
> > > > + #define MY_ADDREF_RELEASE \
> > > > + STDMETHOD_(ULONG, AddRef)() { return ++__m_RefCount; } \
> > > > +-STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > > > +-  return __m_RefCount; delete this; return 0; }
> > > > ++STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0) return __m_RefCount; delete this; return 0; }
> > > > +
> > > > + #define MY_UNKNOWN_IMP_SPEC(i) \
> > > > +   MY_QUERYINTERFACE_BEGIN \
> > > > diff --git a/recipes-extended/upx/upx_git.bb b/recipes-extended/upx/upx_git.bb
> > > > index b77e658..96d2e99 100644
> > > > --- a/recipes-extended/upx/upx_git.bb
> > > > +++ b/recipes-extended/upx/upx_git.bb
> > > > @@ -2,7 +2,9 @@ HOMEPAGE = "http://upx.sourceforge.net"
> > > >  SUMMARY = "Ultimate executable compressor."
> > > >
> > > >  SRCREV = "4e1ae22a1a07be5135c68b25ff05058ae8ae48e1"
> > > > -SRC_URI = "gitsm://github.com/upx/upx;branch=devel"
> > > > +SRC_URI = "gitsm://github.com/upx/upx;branch=devel \
> > > > +    file://0001-MyCom.h-fix-build-with-gcc-11.patch;patchdir=src/lzma-sdk \
> > > > +"
> > > >
> > > >  LICENSE = "GPLv2"
> > > >  LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
> > > > --
> > > > 2.30.2
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > > thee at its end
> > > - "Use the force Harry" - Gandalf, Star Trek II
> > >
> > > 
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [meta-virtualization] [PATCH 1/5] upx: fix build with gcc-11
  2021-05-14 13:39       ` Bruce Ashfield
@ 2021-05-14 13:41         ` Bruce Ashfield
  0 siblings, 0 replies; 10+ messages in thread
From: Bruce Ashfield @ 2021-05-14 13:41 UTC (permalink / raw)
  To: Martin Jansa; +Cc: meta-virtualization

On Fri, May 14, 2021 at 9:39 AM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
> On Fri, May 14, 2021 at 9:25 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> >
> > On Fri, May 14, 2021 at 09:04:31AM -0400, Bruce Ashfield wrote:
> > > On Fri, May 14, 2021 at 8:46 AM Bruce Ashfield via
> > > lists.yoctoproject.org
> > > <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
> > > >
> > > > Thanks for the fixups.
> > > >
> > > > I haven't been able to spend time on any gcc11 fixes, so these are appreciated.
> > > >
> > > > These built for me ... so they are merged.
> > > >
> > > > But then I switched to a different machine on a different builder, and
> > > > dev86 blew up during compilation.
> > > >
> > >
> > > I can confirm that my second builder is consistently showing this:
> > >
> > > Log data follows:
> > > | DEBUG: Executing shell function do_compile
> > > | NOTE: make -j 16 VERSION=0.16.21 PREFIX=/usr
> > > DIST=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/image
> > > LDFLAGS=-Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > > -Wl,-z,relro,-z,now make.fil
> > > | make[1]: Entering directory
> > > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > > | x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> > > -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> > > -Wformat -Wformat-security -Werror=format-security -Wdate-time
> > > --sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
> > >  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > > -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> > > | ./ifdefg -MU  makefile.in >tmp.mak
> > > | /bin/sh: 1: ./ifdefg: not found
> > > | make[1]: *** [Makefile:46: make.fil] Error 127
> > > | make[1]: Leaving directory
> > > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > > | make: *** [GNUmakefile:9: make.fil] Error 2
> > > | ERROR: oe_runmake failed
> > > | WARNING: exit code 1 from a shell command.
> > > | ERROR: Execution of
> > > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/temp/run.do_compile.30233'
> > > failed with exit code 1:
> > > | make[1]: Entering directory
> > > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > > | x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> > > -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2
> > > -Wformat -Wformat-security -Werror=format-security -Wdate-time
> > > --sysroot=/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot
> > >  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > > -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> > > | ./ifdefg -MU  makefile.in >tmp.mak
> > > | /bin/sh: 1: ./ifdefg: not found
> > > | make[1]: *** [Makefile:46: make.fil] Error 127
> > > | make[1]: Leaving directory
> > > '/opt/poky/build/tmp/work/core2-64-poky-linux/dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git'
> > > | make: *** [GNUmakefile:9: make.fil] Error 2
> > > | WARNING: exit code 1 from a shell command.
> > > |
> > > ERROR: Task (/home/bruce/poky/meta-virtualization/recipes-extended/dev86/dev86_git.bb:do_compile)
> > > failed with exit code '1'
> > >
> > > Does that ring a bell ? I'll dig into it now, but it is worth checking
> > > to see if you ran into it during your recipe update.
> >
> > It didn't fail for me like this, is your other builder x86_64?
> >
>
> They are both x86-64, but one was building qemux86-64 and the other
> genericx86-64 as the target.
>
> > Either it's some race, that it tried to call ifdefg before building it for you (was in correct order in my build):
> >
>
> Since that helper is running on the build host, the following made it
> work on my broken builder:
>
> diff --git a/recipes-extended/dev86/dev86_git.bb
> b/recipes-extended/dev86/dev86_git.bb
> index 476bf38..bc68cca 100644
> --- a/recipes-extended/dev86/dev86_git.bb
> +++ b/recipes-extended/dev86/dev86_git.bb
> @@ -19,7 +19,7 @@ EXTRA_OEMAKE = "VERSION=${BASE_PV} PREFIX=${prefix}
> DIST=${D} LDFLAGS='${LDFLAGS
>  do_compile() {
>         # ${S}/Makefile does respect LDFLAGS, but ${S}/cpp/Makefile
> doesn't when building bcc-cpp
>         sed -i 's#$(CC) $(CFLAGS) -o bcc-cpp#$(CC) $(CFLAGS)
> $(LDFLAGS) -o bcc-cpp#g' ${S}/cpp/Makefile
> -       oe_runmake make.fil
> +       CC=${BUILD_CC} oe_runmake make.fil
>         oe_runmake -f make.fil bcc86 as86 ld86
>  }
>
>
> But maybe it just changed the timing, and the fix, really isn't a fix.

Sorry for the extra email.

I meant to say, that is of course assuming that the first call to
make.fil is only building ifdefg, otherwise, I built the whole thing
for the build host :D .. and it is of course the same thing you were
saying about ifdefg-native.

Bruce

>
> Bruce
>
>
> > dev86/0.16.21+gitAUTOINC+e254e0b196-r0/git$ grep ifdefg ../temp/log.do_compile
> > i686-webos-linux-gcc  -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Werror=return-type --sysroot=/jenkins/mjansa/build/ros/webos-dashing-honister/tmp-glibc/work/qemux86-webos-linux/
> > dev86/0.16.21+gitAUTOINC+e254e0b196-r0/recipe-sysroot  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> > ./ifdefg -MU  makefile.in >tmp.mak
> >
> > dev86/0.16.21+gitAUTOINC+e254e0b196-r0$ file git/ifdefg
> > git/ifdefg: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=3edc52ae7ee0ef4fcd9d9148c63df9977c772780, with debug_info, not stripped
> >
> > but we should change it to call ifdefg from dev86-native anyway, let me try to reproduce this somehow.
> >
> > And looks like the older version called ifdefg the same:
> >
> > dev86/0.16.21-r0$ grep ifdefg temp/log.do_compile
> > i686-webos-linux-gcc  -m32 -march=core2 -mtune=core2 -msse3 -mfpmath=sse -fstack-protector-strong  -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Werror=return-type --sysroot=/jenkins/mjansa/build/ros/webos-dashing-hardknott/tmp-glibc/work/qemux86-webos-linux
> > /dev86/0.16.21-r0/recipe-sysroot  -O -DGNUMAKE -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,relro,-z,now -o ifdefg ifdef.c
> > ./ifdefg -MU  makefile.in >tmp.mak
> >
> > > > I'm leaving the changes as-is in the tree, and we can fix them as
> > > > required as new patches (I'm done mucking with history for one day;)
> > > >
> > > > Cheers,
> > > >
> > > > Bruce
> > > >
> > > >
> > > >
> > > > On Fri, May 14, 2021 at 5:52 AM Martin Jansa <Martin.Jansa@gmail.com> wrote:
> > > > >
> > > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > > ---
> > > > >  .../0001-MyCom.h-fix-build-with-gcc-11.patch  | 31 +++++++++++++++++++
> > > > >  recipes-extended/upx/upx_git.bb               |  4 ++-
> > > > >  2 files changed, 34 insertions(+), 1 deletion(-)
> > > > >  create mode 100644 recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > > >
> > > > > diff --git a/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > > > new file mode 100644
> > > > > index 0000000..8b07c77
> > > > > --- /dev/null
> > > > > +++ b/recipes-extended/upx/upx/0001-MyCom.h-fix-build-with-gcc-11.patch
> > > > > @@ -0,0 +1,31 @@
> > > > > +From 8fe8cd22163fe11b791aac15b642d122ea98b9b5 Mon Sep 17 00:00:00 2001
> > > > > +From: Martin Jansa <martin.jansa@lge.com>
> > > > > +Date: Fri, 14 May 2021 02:26:13 -0700
> > > > > +Subject: [PATCH] MyCom.h: fix build with gcc-11
> > > > > +
> > > > > +* fixes:
> > > > > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/LZMAEncoder.h: In member function 'virtual ULONG NCompress::NLZMA::CEncoder::Release()':
> > > > > +  ./../src/lzma-sdk/C/7zip/Compress/LZMA/../../../Common/MyCom.h:159:32: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
> > > > > +    159 | STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > > > > +        |                                ^~
> > > > > +
> > > > > +Upstream-Status: Submitted [https://github.com/upx/upx-lzma-sdk/pull/5]
> > > > > +Signed-off-by: Martin Jansa <martin.jansa@lge.com>
> > > > > +---
> > > > > + C/Common/MyCom.h | 3 +--
> > > > > + 1 file changed, 1 insertion(+), 2 deletions(-)
> > > > > +
> > > > > +diff --git a/C/Common/MyCom.h b/C/Common/MyCom.h
> > > > > +index b8dbf38..2e3c54a 100644
> > > > > +--- a/C/Common/MyCom.h
> > > > > ++++ b/C/Common/MyCom.h
> > > > > +@@ -156,8 +156,7 @@ public:
> > > > > +
> > > > > + #define MY_ADDREF_RELEASE \
> > > > > + STDMETHOD_(ULONG, AddRef)() { return ++__m_RefCount; } \
> > > > > +-STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0)  \
> > > > > +-  return __m_RefCount; delete this; return 0; }
> > > > > ++STDMETHOD_(ULONG, Release)() { if (--__m_RefCount != 0) return __m_RefCount; delete this; return 0; }
> > > > > +
> > > > > + #define MY_UNKNOWN_IMP_SPEC(i) \
> > > > > +   MY_QUERYINTERFACE_BEGIN \
> > > > > diff --git a/recipes-extended/upx/upx_git.bb b/recipes-extended/upx/upx_git.bb
> > > > > index b77e658..96d2e99 100644
> > > > > --- a/recipes-extended/upx/upx_git.bb
> > > > > +++ b/recipes-extended/upx/upx_git.bb
> > > > > @@ -2,7 +2,9 @@ HOMEPAGE = "http://upx.sourceforge.net"
> > > > >  SUMMARY = "Ultimate executable compressor."
> > > > >
> > > > >  SRCREV = "4e1ae22a1a07be5135c68b25ff05058ae8ae48e1"
> > > > > -SRC_URI = "gitsm://github.com/upx/upx;branch=devel"
> > > > > +SRC_URI = "gitsm://github.com/upx/upx;branch=devel \
> > > > > +    file://0001-MyCom.h-fix-build-with-gcc-11.patch;patchdir=src/lzma-sdk \
> > > > > +"
> > > > >
> > > > >  LICENSE = "GPLv2"
> > > > >  LIC_FILES_CHKSUM = "file://LICENSE;md5=353753597aa110e0ded3508408c6374a"
> > > > > --
> > > > > 2.30.2
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > > > thee at its end
> > > > - "Use the force Harry" - Gandalf, Star Trek II
> > > >
> > > > 
> > > >
> > >
> > >
> > > --
> > > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > > thee at its end
> > > - "Use the force Harry" - Gandalf, Star Trek II
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-05-14 13:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14  9:51 [PATCH 1/5] upx: fix build with gcc-11 Martin Jansa
2021-05-14  9:51 ` [PATCH 2/5] ipxe: Inhibit -Werror to " Martin Jansa
2021-05-14  9:51 ` [PATCH 3/5] ipxe: set PV Martin Jansa
2021-05-14  9:51 ` [PATCH 4/5] dev86: add dependency on gperf-native Martin Jansa
2021-05-14  9:51 ` [PATCH 5/5] dev86: switch to still maintained fork of dev86 Martin Jansa
2021-05-14 12:46 ` [meta-virtualization] [PATCH 1/5] upx: fix build with gcc-11 Bruce Ashfield
     [not found] ` <167EEF9E05F75E35.12986@lists.yoctoproject.org>
2021-05-14 13:04   ` Bruce Ashfield
2021-05-14 13:25     ` Martin Jansa
2021-05-14 13:39       ` Bruce Ashfield
2021-05-14 13:41         ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.