[PATCH] libvirt: fix warning of sysctl.d/libvirtd.conf

[PATCH] libvirt: fix warning of sysctl.d/libvirtd.conf

[Olivia Yin]

WARNING: QA Issue: libvirt: Files/directories were installed but not shipped
  /usr/lib
  /usr/lib/sysctl.d
  /usr/lib/sysctl.d/libvirtd.conf

$(DESTDIR)$(prefix)/lib is hardcoded in libvirt Makefile due to following
reason that is stated in the daemon/Makefile.in of libvirt.
    # Use $(prefix)/lib rather than $(libdir), since man sysctl.d insists on
    # /usr/lib/sysctl.d/ even when libdir is /usr/lib64
    @WITH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@install-sysctl:
    @WITH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@  $(MKDIR_P) $(DESTDIR)$(prefix)/lib/sysctl.d
    @WI TH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@  $(INSTALL_DATA) $(srcdir)/libvirtd.sysctl \
    @WITH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@    $(DESTDIR)$(prefix)/lib/sysctl.d/libvirtd.conf

Signed-off-by: Olivia Yin <hong-hua.yin@freescale.com>
---
 recipes-extended/libvirt/libvirt_1.0.3.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/recipes-extended/libvirt/libvirt_1.0.3.bb b/recipes-extended/libvirt/libvirt_1.0.3.bb
index 88cb018..f0683c8 100644
--- a/recipes-extended/libvirt/libvirt_1.0.3.bb
+++ b/recipes-extended/libvirt/libvirt_1.0.3.bb
@@ -3,7 +3,7 @@ HOMEPAGE = "http://libvirt.org"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=fb919cc88dbe06ec0b0bd50e001ccf1f"
 SECTION = "console/tools"
-PR = "r2"
+PR = "r333"
 
 DEPENDS = "bridge-utils gnutls libxml2 lvm2 avahi parted curl libpcap util-linux e2fsprogs pm-utils \
 	   iptables ebtables dnsmasq readline"
@@ -87,6 +87,7 @@ FILES_${PN}-libvirtd = "${sysconfdir}/init.d \
 	${sysconfdir}/sysctl.d \
 	${sysconfdir}/logrotate.d \
 	${sysconfdir}/libvirt/libvirtd.conf \
+        /usr/lib/sysctl.d/libvirtd.conf \
 	${sbindir}/libvirtd"
 
 FILES_${PN}-virsh = "${bindir}/virsh"
-- 
1.7.0.4

Re: [PATCH] libvirt: fix warning of sysctl.d/libvirtd.conf

[Bruce Ashfield]

On Tue, May 14, 2013 at 5:48 AM, Olivia Yin <hong-hua.yin@freescale.com> wrote:
> WARNING: QA Issue: libvirt: Files/directories were installed but not shipped
>   /usr/lib
>   /usr/lib/sysctl.d
>   /usr/lib/sysctl.d/libvirtd.conf
>
> $(DESTDIR)$(prefix)/lib is hardcoded in libvirt Makefile due to following
> reason that is stated in the daemon/Makefile.in of libvirt.
>     # Use $(prefix)/lib rather than $(libdir), since man sysctl.d insists on
>     # /usr/lib/sysctl.d/ even when libdir is /usr/lib64
>     @WITH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@install-sysctl:
>     @WITH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@  $(MKDIR_P) $(DESTDIR)$(prefix)/lib/sysctl.d
>     @WI TH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@  $(INSTALL_DATA) $(srcdir)/libvirtd.sysctl \
>     @WITH_LIBVIRTD_TRUE@@WITH_SYSCTL_TRUE@    $(DESTDIR)$(prefix)/lib/sysctl.d/libvirtd.conf

Great commit log!

>
> Signed-off-by: Olivia Yin <hong-hua.yin@freescale.com>
> ---
>  recipes-extended/libvirt/libvirt_1.0.3.bb |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/recipes-extended/libvirt/libvirt_1.0.3.bb b/recipes-extended/libvirt/libvirt_1.0.3.bb
> index 88cb018..f0683c8 100644
> --- a/recipes-extended/libvirt/libvirt_1.0.3.bb
> +++ b/recipes-extended/libvirt/libvirt_1.0.3.bb
> @@ -3,7 +3,7 @@ HOMEPAGE = "http://libvirt.org"
>  LICENSE = "GPLv2+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=fb919cc88dbe06ec0b0bd50e001ccf1f"
>  SECTION = "console/tools"
> -PR = "r2"
> +PR = "r333"

Typo ? or is your keystuck ? :)

Resend with that fixed, and I have no objections.

Bruce

>
>  DEPENDS = "bridge-utils gnutls libxml2 lvm2 avahi parted curl libpcap util-linux e2fsprogs pm-utils \
>            iptables ebtables dnsmasq readline"
> @@ -87,6 +87,7 @@ FILES_${PN}-libvirtd = "${sysconfdir}/init.d \
>         ${sysconfdir}/sysctl.d \
>         ${sysconfdir}/logrotate.d \
>         ${sysconfdir}/libvirt/libvirtd.conf \
> +        /usr/lib/sysctl.d/libvirtd.conf \
>         ${sbindir}/libvirtd"
>
>  FILES_${PN}-virsh = "${bindir}/virsh"
> --
> 1.7.0.4
>
>
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization



--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"