* perf.bb on poky master branch @ 2019-09-04 8:46 vygu 2019-09-04 12:48 ` Bruce Ashfield 2019-09-04 12:51 ` Alexander Kanavin 0 siblings, 2 replies; 3+ messages in thread From: vygu @ 2019-09-04 8:46 UTC (permalink / raw) To: yocto [-- Attachment #1: Type: text/plain, Size: 514 bytes --] Hello, Just to signal there are several mistakes with the recipe "perf.bb" from poky on master (currently: e2bde009b325b40641407ecf50f54ed8c41726d6) - If "Python 3 is not yet supported" by "perf" sources, it causes an issue during the do_compile task - The last "install" in the do_configure_prepend task about "tools/include/linux/bits.h" does not work with a linux kernel 4.5 to 4.18 because this file does not exist [- The usage of _prepend or _append in this bb file does not help to create a bbappend] Vygu [-- Attachment #2: Type: text/html, Size: 773 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: perf.bb on poky master branch 2019-09-04 8:46 perf.bb on poky master branch vygu @ 2019-09-04 12:48 ` Bruce Ashfield 2019-09-04 12:51 ` Alexander Kanavin 1 sibling, 0 replies; 3+ messages in thread From: Bruce Ashfield @ 2019-09-04 12:48 UTC (permalink / raw) To: vygu; +Cc: yocto On Wed, Sep 4, 2019 at 4:53 AM vygu <vygu@protonmail.ch> wrote: > > Hello, > > Just to signal there are several mistakes with the recipe "perf.bb" from poky on master (currently: e2bde009b325b40641407ecf50f54ed8c41726d6) > > - If "Python 3 is not yet supported" by "perf" sources, it causes an issue during the do_compile task In master the decision was that If you still have a kernel that doesn't support python3, you'll need to create your own python2 based perf recipe. Or create a patch that makes the version of python configurable (I'm doing something for 4.19 at the moment). But in master, we need to support the release for a period that is longer than the python2 EOL, so the python2 dependencies need to go. > - The last "install" in the do_configure_prepend task about "tools/include/linux/bits.h" does not work with a linux kernel 4.5 to 4.18 because this file does not exist Again, those are older kernels that we support in master. Which are the only ones we can test. So the copying of that file was tested against the versions I could see/support. We can definitely protect those copies with conditionals, but someone that is actively using a kernel of that vintage, would be better to send the patches. > [- The usage of _prepend or _append in this bb file does not help to create a bbappend] We don't have a lot of choices for this. The perf recipe is unique in that it used to work directly in the kernel source and it has to support some undefined set of kernels (hence it can't patch the source). We could move some of that work to new tasks and have them run before configure, etc, there just hasn't been a need until now. As usual, patches are welcome (and/or bugzilla entries), since I'm not currently the issues it isn't as easy to spin patches. Cheers, Bruce > > > Vygu > > -- > _______________________________________________ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: perf.bb on poky master branch 2019-09-04 8:46 perf.bb on poky master branch vygu 2019-09-04 12:48 ` Bruce Ashfield @ 2019-09-04 12:51 ` Alexander Kanavin 1 sibling, 0 replies; 3+ messages in thread From: Alexander Kanavin @ 2019-09-04 12:51 UTC (permalink / raw) To: vygu; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 910 bytes --] On Wed, 4 Sep 2019 at 10:53, vygu <vygu@protonmail.ch> wrote: > Just to signal there are several mistakes with the recipe "perf.bb" from > poky on master (currently: e2bde009b325b40641407ecf50f54ed8c41726d6) > > - If "Python 3 is not yet supported" by "perf" sources, it causes an issue > during the do_compile task > - The last "install" in the do_configure_prepend task about > "tools/include/linux/bits.h" does not work with a linux kernel 4.5 to 4.18 > because this file does not exist > [- The usage of _prepend or _append in this bb file does not help to > create a bbappend] > I think this is expected: perf from oe-core is not guaranteed to work with kernels other than those provided by oe-core. If this cannot be solved by patching the original recipe (and sending patches to oe-core list), then you can probably just make a custom perf recipe instead that works for you. Alex [-- Attachment #2: Type: text/html, Size: 1325 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-04 12:51 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-09-04 8:46 perf.bb on poky master branch vygu 2019-09-04 12:48 ` Bruce Ashfield 2019-09-04 12:51 ` Alexander Kanavin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.