[meta-virtualization][m-c-s][PATCH] python3-salttesting: use SRCREV instead of tag

[meta-virtualization][m-c-s][PATCH] python3-salttesting: use SRCREV instead of tag

[Chen Qi]

If we enable BB_NO_NETWORK, using tag in SRC_URI causes problem.
Merely parsing the recipes will raise error. For example, `bitbake -p'.

So use SRCREV instead of tag to solve this problem.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 .../recipes-devtools/python/python3-salttesting_git.bb         | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb b/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb
index 34476219..fdc0341a 100644
--- a/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb
+++ b/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb
@@ -4,10 +4,11 @@ SECTION = "devel/python"
 LICENSE = "Apache-2.0"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=f36f1e9e3e30f90180efdf7e40d943e5"
 
-SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop;tag=v2018.9.21 \
+SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop \
            file://0001-Add-ptest-output-option-to-test-suite.patch \
            "
 
+SRCREV = "8d21627a4eef316d22cc424deeca16a0ec8472e9"
 PV = "2018.9.21+git${SRCPV}"
 
 S = "${WORKDIR}/git"
-- 
2.17.1

Re: [meta-virtualization][m-c-s][PATCH] python3-salttesting: use SRCREV instead of tag

[Bruce Ashfield]

On Sun, Dec 6, 2020 at 9:35 PM Chen Qi <Qi.Chen@windriver.com> wrote:
>
> If we enable BB_NO_NETWORK, using tag in SRC_URI causes problem.
> Merely parsing the recipes will raise error. For example, `bitbake -p'.
>

I'm surprised we only noticed this now!

Thanks for the fix, it has been merged.

Bruce

> So use SRCREV instead of tag to solve this problem.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  .../recipes-devtools/python/python3-salttesting_git.bb         | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb b/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb
> index 34476219..fdc0341a 100644
> --- a/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb
> +++ b/meta-openstack/recipes-devtools/python/python3-salttesting_git.bb
> @@ -4,10 +4,11 @@ SECTION = "devel/python"
>  LICENSE = "Apache-2.0"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=f36f1e9e3e30f90180efdf7e40d943e5"
>
> -SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop;tag=v2018.9.21 \
> +SRC_URI = "git://github.com/saltstack/salt-testing.git;branch=develop \
>             file://0001-Add-ptest-output-option-to-test-suite.patch \
>             "
>
> +SRCREV = "8d21627a4eef316d22cc424deeca16a0ec8472e9"
>  PV = "2018.9.21+git${SRCPV}"
>
>  S = "${WORKDIR}/git"
> --
> 2.17.1
>
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II