All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Drop config guard for DC_LOG_DP2
@ 2021-11-18 16:53 Leo (Hanghong) Ma
  2021-11-18 17:01 ` Alex Deucher
  0 siblings, 1 reply; 3+ messages in thread
From: Leo (Hanghong) Ma @ 2021-11-18 16:53 UTC (permalink / raw)
  To: nicholas.kazlauskas, amd-gfx
  Cc: Alexander.Deucher, Nicholas.Choi, Leo (Hanghong) Ma, harry.wentland

[Why & How]
It doesn't make sense to guard DC_LOG_DP2 by CONFIG_DRM_AMD_DCN, and
this also caused build failure for allmodconfig; So drop the guard
to fix the compile failure;

Signed-off-by: Leo (Hanghong) Ma <hanghong.ma@amd.com>
---
 drivers/gpu/drm/amd/display/include/logger_types.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/display/include/logger_types.h
index 370fad883e33..f093b49c5e6e 100644
--- a/drivers/gpu/drm/amd/display/include/logger_types.h
+++ b/drivers/gpu/drm/amd/display/include/logger_types.h
@@ -72,9 +72,7 @@
 #define DC_LOG_DSC(...) DRM_DEBUG_KMS(__VA_ARGS__)
 #define DC_LOG_SMU(...) pr_debug("[SMU_MSG]:"__VA_ARGS__)
 #define DC_LOG_DWB(...) DRM_DEBUG_KMS(__VA_ARGS__)
-#if defined(CONFIG_DRM_AMD_DC_DCN)
 #define DC_LOG_DP2(...) DRM_DEBUG_KMS(__VA_ARGS__)
-#endif
 
 struct dal_logger;
 
@@ -126,9 +124,7 @@ enum dc_log_type {
 	LOG_MAX_HW_POINTS,
 	LOG_ALL_TF_CHANNELS,
 	LOG_SAMPLE_1DLUT,
-#if defined(CONFIG_DRM_AMD_DC_DCN)
 	LOG_DP2,
-#endif
 	LOG_SECTION_TOTAL_COUNT
 };
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: Drop config guard for DC_LOG_DP2
  2021-11-18 16:53 [PATCH] drm/amd/display: Drop config guard for DC_LOG_DP2 Leo (Hanghong) Ma
@ 2021-11-18 17:01 ` Alex Deucher
  2021-11-18 17:12   ` Ma, Leo
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2021-11-18 17:01 UTC (permalink / raw)
  To: Leo (Hanghong) Ma
  Cc: Deucher, Alexander, Wentland, Harry, Nicholas.Choi, Kazlauskas,
	Nicholas, amd-gfx list

On Thu, Nov 18, 2021 at 11:53 AM Leo (Hanghong) Ma <hanghong.ma@amd.com> wrote:
>
> [Why & How]
> It doesn't make sense to guard DC_LOG_DP2 by CONFIG_DRM_AMD_DCN, and
> this also caused build failure for allmodconfig; So drop the guard
> to fix the compile failure;
>
> Signed-off-by: Leo (Hanghong) Ma <hanghong.ma@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

At some point we may want to rework what the DC_LOG stuff maps too
(e.g., use dev_debug or the newer drm interfaces).

Alex

> ---
>  drivers/gpu/drm/amd/display/include/logger_types.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/display/include/logger_types.h
> index 370fad883e33..f093b49c5e6e 100644
> --- a/drivers/gpu/drm/amd/display/include/logger_types.h
> +++ b/drivers/gpu/drm/amd/display/include/logger_types.h
> @@ -72,9 +72,7 @@
>  #define DC_LOG_DSC(...) DRM_DEBUG_KMS(__VA_ARGS__)
>  #define DC_LOG_SMU(...) pr_debug("[SMU_MSG]:"__VA_ARGS__)
>  #define DC_LOG_DWB(...) DRM_DEBUG_KMS(__VA_ARGS__)
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
>  #define DC_LOG_DP2(...) DRM_DEBUG_KMS(__VA_ARGS__)
> -#endif
>
>  struct dal_logger;
>
> @@ -126,9 +124,7 @@ enum dc_log_type {
>         LOG_MAX_HW_POINTS,
>         LOG_ALL_TF_CHANNELS,
>         LOG_SAMPLE_1DLUT,
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
>         LOG_DP2,
> -#endif
>         LOG_SECTION_TOTAL_COUNT
>  };
>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amd/display: Drop config guard for DC_LOG_DP2
  2021-11-18 17:01 ` Alex Deucher
@ 2021-11-18 17:12   ` Ma, Leo
  0 siblings, 0 replies; 3+ messages in thread
From: Ma, Leo @ 2021-11-18 17:12 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Deucher, Alexander, Wentland, Harry, Choi, Nicholas, Kazlauskas,
	Nicholas, amd-gfx list

[AMD Official Use Only]

Agree. 
Patch applied. Thanks for your review

-Leo

-----Original Message-----
From: Alex Deucher <alexdeucher@gmail.com> 
Sent: Thursday, November 18, 2021 12:02 PM
To: Ma, Leo <Hanghong.Ma@amd.com>
Cc: Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; amd-gfx list <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Choi, Nicholas <Nicholas.Choi@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>
Subject: Re: [PATCH] drm/amd/display: Drop config guard for DC_LOG_DP2

On Thu, Nov 18, 2021 at 11:53 AM Leo (Hanghong) Ma <hanghong.ma@amd.com> wrote:
>
> [Why & How]
> It doesn't make sense to guard DC_LOG_DP2 by CONFIG_DRM_AMD_DCN, and 
> this also caused build failure for allmodconfig; So drop the guard to 
> fix the compile failure;
>
> Signed-off-by: Leo (Hanghong) Ma <hanghong.ma@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

At some point we may want to rework what the DC_LOG stuff maps too (e.g., use dev_debug or the newer drm interfaces).

Alex

> ---
>  drivers/gpu/drm/amd/display/include/logger_types.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h 
> b/drivers/gpu/drm/amd/display/include/logger_types.h
> index 370fad883e33..f093b49c5e6e 100644
> --- a/drivers/gpu/drm/amd/display/include/logger_types.h
> +++ b/drivers/gpu/drm/amd/display/include/logger_types.h
> @@ -72,9 +72,7 @@
>  #define DC_LOG_DSC(...) DRM_DEBUG_KMS(__VA_ARGS__)  #define 
> DC_LOG_SMU(...) pr_debug("[SMU_MSG]:"__VA_ARGS__)  #define 
> DC_LOG_DWB(...) DRM_DEBUG_KMS(__VA_ARGS__) -#if 
> defined(CONFIG_DRM_AMD_DC_DCN)  #define DC_LOG_DP2(...) 
> DRM_DEBUG_KMS(__VA_ARGS__) -#endif
>
>  struct dal_logger;
>
> @@ -126,9 +124,7 @@ enum dc_log_type {
>         LOG_MAX_HW_POINTS,
>         LOG_ALL_TF_CHANNELS,
>         LOG_SAMPLE_1DLUT,
> -#if defined(CONFIG_DRM_AMD_DC_DCN)
>         LOG_DP2,
> -#endif
>         LOG_SECTION_TOTAL_COUNT
>  };
>
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-18 17:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18 16:53 [PATCH] drm/amd/display: Drop config guard for DC_LOG_DP2 Leo (Hanghong) Ma
2021-11-18 17:01 ` Alex Deucher
2021-11-18 17:12   ` Ma, Leo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.