* [PATCH 1/2] drm/amd/display: make wake_up_aux_channel static
@ 2022-10-26 7:01 ` Jiapeng Chong
0 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2022-10-26 7:01 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
This symbol is not used outside of dc_link_dp.c, so marks it static.
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5230:16: warning: no previous prototype for function 'wake_up_aux_channel'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2581
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 420119efcf5f..e5ab751a5ca1 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -5227,7 +5227,7 @@ static void retrieve_cable_id(struct dc_link *link)
&link->dpcd_caps.cable_id, &usbc_cable_id);
}
-enum dc_status wake_up_aux_channel(struct dc_link *link)
+static enum dc_status wake_up_aux_channel(struct dc_link *link)
{
enum dc_status status = DC_ERROR_UNEXPECTED;
uint32_t aux_channel_retry_cnt = 0;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] drm/amd/display: make wake_up_aux_channel static
@ 2022-10-26 7:01 ` Jiapeng Chong
0 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2022-10-26 7:01 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, christian.koenig
This symbol is not used outside of dc_link_dp.c, so marks it static.
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5230:16: warning: no previous prototype for function 'wake_up_aux_channel'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2581
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 420119efcf5f..e5ab751a5ca1 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -5227,7 +5227,7 @@ static void retrieve_cable_id(struct dc_link *link)
&link->dpcd_caps.cable_id, &usbc_cable_id);
}
-enum dc_status wake_up_aux_channel(struct dc_link *link)
+static enum dc_status wake_up_aux_channel(struct dc_link *link)
{
enum dc_status status = DC_ERROR_UNEXPECTED;
uint32_t aux_channel_retry_cnt = 0;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] drm/amd/display: make wake_up_aux_channel static
@ 2022-10-26 7:01 ` Jiapeng Chong
0 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2022-10-26 7:01 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, daniel, airlied, christian.koenig
This symbol is not used outside of dc_link_dp.c, so marks it static.
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:5230:16: warning: no previous prototype for function 'wake_up_aux_channel'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2581
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 420119efcf5f..e5ab751a5ca1 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -5227,7 +5227,7 @@ static void retrieve_cable_id(struct dc_link *link)
&link->dpcd_caps.cable_id, &usbc_cable_id);
}
-enum dc_status wake_up_aux_channel(struct dc_link *link)
+static enum dc_status wake_up_aux_channel(struct dc_link *link)
{
enum dc_status status = DC_ERROR_UNEXPECTED;
uint32_t aux_channel_retry_cnt = 0;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm/amd/display: Modify mismatched function name
2022-10-26 7:01 ` Jiapeng Chong
(?)
@ 2022-10-26 7:01 ` Jiapeng Chong
-1 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2022-10-26 7:01 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:615: warning: expecting prototype for setup_subvp_dmub_command(). Prototype was for populate_subvp_cmd_pipe_info() instead.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2587
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index 774e06936661..67eef5beab95 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
@@ -595,7 +595,7 @@ static void update_subvp_prefetch_end_to_mall_start(struct dc *dc,
}
/**
- * setup_subvp_dmub_command - Helper to populate the SubVP pipe info for the DMUB subvp command
+ * populate_subvp_cmd_pipe_info - Helper to populate the SubVP pipe info for the DMUB subvp command
*
* @dc: [in] current dc state
* @context: [in] new dc state
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm/amd/display: Modify mismatched function name
@ 2022-10-26 7:01 ` Jiapeng Chong
0 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2022-10-26 7:01 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, christian.koenig
No functional modification involved.
drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:615: warning: expecting prototype for setup_subvp_dmub_command(). Prototype was for populate_subvp_cmd_pipe_info() instead.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2587
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index 774e06936661..67eef5beab95 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
@@ -595,7 +595,7 @@ static void update_subvp_prefetch_end_to_mall_start(struct dc *dc,
}
/**
- * setup_subvp_dmub_command - Helper to populate the SubVP pipe info for the DMUB subvp command
+ * populate_subvp_cmd_pipe_info - Helper to populate the SubVP pipe info for the DMUB subvp command
*
* @dc: [in] current dc state
* @context: [in] new dc state
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] drm/amd/display: Modify mismatched function name
@ 2022-10-26 7:01 ` Jiapeng Chong
0 siblings, 0 replies; 8+ messages in thread
From: Jiapeng Chong @ 2022-10-26 7:01 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, daniel, airlied, christian.koenig
No functional modification involved.
drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:615: warning: expecting prototype for setup_subvp_dmub_command(). Prototype was for populate_subvp_cmd_pipe_info() instead.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2587
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index 774e06936661..67eef5beab95 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
@@ -595,7 +595,7 @@ static void update_subvp_prefetch_end_to_mall_start(struct dc *dc,
}
/**
- * setup_subvp_dmub_command - Helper to populate the SubVP pipe info for the DMUB subvp command
+ * populate_subvp_cmd_pipe_info - Helper to populate the SubVP pipe info for the DMUB subvp command
*
* @dc: [in] current dc state
* @context: [in] new dc state
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm/amd/display: Modify mismatched function name
2022-10-26 7:01 ` Jiapeng Chong
@ 2022-10-27 18:13 ` Alex Deucher
-1 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2022-10-27 18:13 UTC (permalink / raw)
To: Jiapeng Chong
Cc: alexander.deucher, Xinhui.Pan, Abaci Robot, linux-kernel,
amd-gfx, dri-devel, christian.koenig
Applied the series. Thanks!
Alex
On Wed, Oct 26, 2022 at 3:02 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> No functional modification involved.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:615: warning: expecting prototype for setup_subvp_dmub_command(). Prototype was for populate_subvp_cmd_pipe_info() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2587
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> index 774e06936661..67eef5beab95 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> @@ -595,7 +595,7 @@ static void update_subvp_prefetch_end_to_mall_start(struct dc *dc,
> }
>
> /**
> - * setup_subvp_dmub_command - Helper to populate the SubVP pipe info for the DMUB subvp command
> + * populate_subvp_cmd_pipe_info - Helper to populate the SubVP pipe info for the DMUB subvp command
> *
> * @dc: [in] current dc state
> * @context: [in] new dc state
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] drm/amd/display: Modify mismatched function name
@ 2022-10-27 18:13 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2022-10-27 18:13 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Xinhui.Pan, Abaci Robot, linux-kernel, dri-devel, amd-gfx,
alexander.deucher, christian.koenig
Applied the series. Thanks!
Alex
On Wed, Oct 26, 2022 at 3:02 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> No functional modification involved.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dc_dmub_srv.c:615: warning: expecting prototype for setup_subvp_dmub_command(). Prototype was for populate_subvp_cmd_pipe_info() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2587
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> index 774e06936661..67eef5beab95 100644
> --- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> +++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
> @@ -595,7 +595,7 @@ static void update_subvp_prefetch_end_to_mall_start(struct dc *dc,
> }
>
> /**
> - * setup_subvp_dmub_command - Helper to populate the SubVP pipe info for the DMUB subvp command
> + * populate_subvp_cmd_pipe_info - Helper to populate the SubVP pipe info for the DMUB subvp command
> *
> * @dc: [in] current dc state
> * @context: [in] new dc state
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-10-27 18:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-26 7:01 [PATCH 1/2] drm/amd/display: make wake_up_aux_channel static Jiapeng Chong
2022-10-26 7:01 ` Jiapeng Chong
2022-10-26 7:01 ` Jiapeng Chong
2022-10-26 7:01 ` [PATCH 2/2] drm/amd/display: Modify mismatched function name Jiapeng Chong
2022-10-26 7:01 ` Jiapeng Chong
2022-10-26 7:01 ` Jiapeng Chong
2022-10-27 18:13 ` Alex Deucher
2022-10-27 18:13 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.