* [PATCH] drm/radeon: Simplify bool comparison
@ 2021-02-08 10:17 ` Jiapeng Chong
0 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2021-02-08 10:17 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, airlied, daniel, amd-gfx, dri-devel,
linux-kernel, Jiapeng Chong
Fix the following coccicheck warning:
./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/radeon/rs690.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
index c296f94..7bc302a 100644
--- a/drivers/gpu/drm/radeon/rs690.c
+++ b/drivers/gpu/drm/radeon/rs690.c
@@ -187,7 +187,7 @@ static void rs690_mc_init(struct radeon_device *rdev)
/* FastFB shall be used with UMA memory. Here it is simply disabled when sideport
* memory is present.
*/
- if (rdev->mc.igp_sideport_enabled == false && radeon_fastfb == 1) {
+ if (!rdev->mc.igp_sideport_enabled && radeon_fastfb == 1) {
DRM_INFO("Direct mapping: aper base at 0x%llx, replaced by direct mapping base 0x%llx.\n",
(unsigned long long)rdev->mc.aper_base, k8_addr);
rdev->mc.aper_base = (resource_size_t)k8_addr;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm/radeon: Simplify bool comparison
@ 2021-02-08 10:17 ` Jiapeng Chong
0 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2021-02-08 10:17 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, airlied, linux-kernel, dri-devel, amd-gfx, daniel,
christian.koenig
Fix the following coccicheck warning:
./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/radeon/rs690.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
index c296f94..7bc302a 100644
--- a/drivers/gpu/drm/radeon/rs690.c
+++ b/drivers/gpu/drm/radeon/rs690.c
@@ -187,7 +187,7 @@ static void rs690_mc_init(struct radeon_device *rdev)
/* FastFB shall be used with UMA memory. Here it is simply disabled when sideport
* memory is present.
*/
- if (rdev->mc.igp_sideport_enabled == false && radeon_fastfb == 1) {
+ if (!rdev->mc.igp_sideport_enabled && radeon_fastfb == 1) {
DRM_INFO("Direct mapping: aper base at 0x%llx, replaced by direct mapping base 0x%llx.\n",
(unsigned long long)rdev->mc.aper_base, k8_addr);
rdev->mc.aper_base = (resource_size_t)k8_addr;
--
1.8.3.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm/radeon: Simplify bool comparison
@ 2021-02-08 10:17 ` Jiapeng Chong
0 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2021-02-08 10:17 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, airlied, linux-kernel, dri-devel, amd-gfx,
christian.koenig
Fix the following coccicheck warning:
./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/radeon/rs690.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
index c296f94..7bc302a 100644
--- a/drivers/gpu/drm/radeon/rs690.c
+++ b/drivers/gpu/drm/radeon/rs690.c
@@ -187,7 +187,7 @@ static void rs690_mc_init(struct radeon_device *rdev)
/* FastFB shall be used with UMA memory. Here it is simply disabled when sideport
* memory is present.
*/
- if (rdev->mc.igp_sideport_enabled == false && radeon_fastfb == 1) {
+ if (!rdev->mc.igp_sideport_enabled && radeon_fastfb == 1) {
DRM_INFO("Direct mapping: aper base at 0x%llx, replaced by direct mapping base 0x%llx.\n",
(unsigned long long)rdev->mc.aper_base, k8_addr);
rdev->mc.aper_base = (resource_size_t)k8_addr;
--
1.8.3.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/radeon: Simplify bool comparison
2021-02-08 10:17 ` Jiapeng Chong
(?)
@ 2021-02-09 19:41 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2021-02-09 19:41 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Deucher, Alexander, Dave Airlie, LKML,
Maling list - DRI developers, amd-gfx list, Christian Koenig
Applied. Thanks!
Alex
On Mon, Feb 8, 2021 at 5:17 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/radeon/rs690.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
> index c296f94..7bc302a 100644
> --- a/drivers/gpu/drm/radeon/rs690.c
> +++ b/drivers/gpu/drm/radeon/rs690.c
> @@ -187,7 +187,7 @@ static void rs690_mc_init(struct radeon_device *rdev)
> /* FastFB shall be used with UMA memory. Here it is simply disabled when sideport
> * memory is present.
> */
> - if (rdev->mc.igp_sideport_enabled == false && radeon_fastfb == 1) {
> + if (!rdev->mc.igp_sideport_enabled && radeon_fastfb == 1) {
> DRM_INFO("Direct mapping: aper base at 0x%llx, replaced by direct mapping base 0x%llx.\n",
> (unsigned long long)rdev->mc.aper_base, k8_addr);
> rdev->mc.aper_base = (resource_size_t)k8_addr;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/radeon: Simplify bool comparison
@ 2021-02-09 19:41 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2021-02-09 19:41 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Dave Airlie, LKML, amd-gfx list, Maling list - DRI developers,
Deucher, Alexander, Christian Koenig
Applied. Thanks!
Alex
On Mon, Feb 8, 2021 at 5:17 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/radeon/rs690.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
> index c296f94..7bc302a 100644
> --- a/drivers/gpu/drm/radeon/rs690.c
> +++ b/drivers/gpu/drm/radeon/rs690.c
> @@ -187,7 +187,7 @@ static void rs690_mc_init(struct radeon_device *rdev)
> /* FastFB shall be used with UMA memory. Here it is simply disabled when sideport
> * memory is present.
> */
> - if (rdev->mc.igp_sideport_enabled == false && radeon_fastfb == 1) {
> + if (!rdev->mc.igp_sideport_enabled && radeon_fastfb == 1) {
> DRM_INFO("Direct mapping: aper base at 0x%llx, replaced by direct mapping base 0x%llx.\n",
> (unsigned long long)rdev->mc.aper_base, k8_addr);
> rdev->mc.aper_base = (resource_size_t)k8_addr;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/radeon: Simplify bool comparison
@ 2021-02-09 19:41 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2021-02-09 19:41 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Dave Airlie, LKML, amd-gfx list, Maling list - DRI developers,
Deucher, Alexander, Christian Koenig
Applied. Thanks!
Alex
On Mon, Feb 8, 2021 at 5:17 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
>
> ./drivers/gpu/drm/radeon/rs690.c:190:6-35: WARNING: Comparison to bool.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/radeon/rs690.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/rs690.c b/drivers/gpu/drm/radeon/rs690.c
> index c296f94..7bc302a 100644
> --- a/drivers/gpu/drm/radeon/rs690.c
> +++ b/drivers/gpu/drm/radeon/rs690.c
> @@ -187,7 +187,7 @@ static void rs690_mc_init(struct radeon_device *rdev)
> /* FastFB shall be used with UMA memory. Here it is simply disabled when sideport
> * memory is present.
> */
> - if (rdev->mc.igp_sideport_enabled == false && radeon_fastfb == 1) {
> + if (!rdev->mc.igp_sideport_enabled && radeon_fastfb == 1) {
> DRM_INFO("Direct mapping: aper base at 0x%llx, replaced by direct mapping base 0x%llx.\n",
> (unsigned long long)rdev->mc.aper_base, k8_addr);
> rdev->mc.aper_base = (resource_size_t)k8_addr;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-09 22:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 10:17 [PATCH] drm/radeon: Simplify bool comparison Jiapeng Chong
2021-02-08 10:17 ` Jiapeng Chong
2021-02-08 10:17 ` Jiapeng Chong
2021-02-09 19:41 ` Alex Deucher
2021-02-09 19:41 ` Alex Deucher
2021-02-09 19:41 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.