[PATCH] drm/amdgpu: fix adev variable used in amdgpu_device_gpu_recover()

[PATCH] drm/amdgpu: fix adev variable used in amdgpu_device_gpu_recover()

[Alex Deucher]

Use the correct adev variable for the drm_fb_helper in
amdgpu_device_gpu_recover().  Noticed by inspection.

Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up AMD own's.")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 2b92281dd0c1..eacecc672a4d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -5186,7 +5186,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
 		 */
 		amdgpu_unregister_gpu_instance(tmp_adev);
 
-		drm_fb_helper_set_suspend_unlocked(adev_to_drm(adev)->fb_helper, true);
+		drm_fb_helper_set_suspend_unlocked(adev_to_drm(tmp_adev)->fb_helper, true);
 
 		/* disable ras on ALL IPs */
 		if (!need_emergency_restart &&
-- 
2.35.3

Re: [PATCH] drm/amdgpu: fix adev variable used in amdgpu_device_gpu_recover()

[Alex Deucher]

Ping?

Alex

On Thu, Jun 16, 2022 at 5:12 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> Use the correct adev variable for the drm_fb_helper in
> amdgpu_device_gpu_recover().  Noticed by inspection.
>
> Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up AMD own's.")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 2b92281dd0c1..eacecc672a4d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -5186,7 +5186,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
>                  */
>                 amdgpu_unregister_gpu_instance(tmp_adev);
>
> -               drm_fb_helper_set_suspend_unlocked(adev_to_drm(adev)->fb_helper, true);
> +               drm_fb_helper_set_suspend_unlocked(adev_to_drm(tmp_adev)->fb_helper, true);
>
>                 /* disable ras on ALL IPs */
>                 if (!need_emergency_restart &&
> --
> 2.35.3
>

RE: [PATCH] drm/amdgpu: fix adev variable used in amdgpu_device_gpu_recover()

[Chen, Guchun]

Reviewed-by: Guchun Chen <guchun.chen@amd.com>

Regards,
Guchun

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Monday, June 20, 2022 10:54 PM
To: Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: fix adev variable used in amdgpu_device_gpu_recover()

Ping?

Alex

On Thu, Jun 16, 2022 at 5:12 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> Use the correct adev variable for the drm_fb_helper in 
> amdgpu_device_gpu_recover().  Noticed by inspection.
>
> Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of 
> setting up AMD own's.")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 2b92281dd0c1..eacecc672a4d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -5186,7 +5186,7 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
>                  */
>                 amdgpu_unregister_gpu_instance(tmp_adev);
>
> -               drm_fb_helper_set_suspend_unlocked(adev_to_drm(adev)->fb_helper, true);
> +               
> + drm_fb_helper_set_suspend_unlocked(adev_to_drm(tmp_adev)->fb_helper, 
> + true);
>
>                 /* disable ras on ALL IPs */
>                 if (!need_emergency_restart &&
> --
> 2.35.3
>