All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Yifan Zhang <yifan1.zhang@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	Huang Rui <Ray.Huang@amd.com>,
	Christian Koenig <christian.koenig@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/3] drm/amdgpu: move amdgpu_gmc_noretry_set after ip_versions populated
Date: Tue, 1 Mar 2022 10:11:47 -0500	[thread overview]
Message-ID: <CADnq5_MEzjYEnB6BtacemOSNj7WG5EQ18vQD8XUhVpY80yBH=w@mail.gmail.com> (raw)
In-Reply-To: <20220301150121.3785743-1-yifan1.zhang@amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

On Tue, Mar 1, 2022 at 10:02 AM Yifan Zhang <yifan1.zhang@amd.com> wrote:
>
> otherwise adev->ip_versions is still empty when amdgpu_gmc_noretry_set
> is called.
>
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 6113ddc765a7..61a6a7920c76 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1554,7 +1554,6 @@ static int amdgpu_device_check_arguments(struct amdgpu_device *adev)
>
>         amdgpu_gmc_tmz_set(adev);
>
> -       amdgpu_gmc_noretry_set(adev);
>
>         return 0;
>  }
> @@ -3641,6 +3640,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>         if (r)
>                 return r;
>
> +       amdgpu_gmc_noretry_set(adev);
>         /* Need to get xgmi info early to decide the reset behavior*/
>         if (adev->gmc.xgmi.supported) {
>                 r = adev->gfxhub.funcs->get_xgmi_info(adev);
> --
> 2.25.1
>

  parent reply	other threads:[~2022-03-01 15:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 15:01 [PATCH v2 1/3] drm/amdgpu: move amdgpu_gmc_noretry_set after ip_versions populated Yifan Zhang
2022-03-01 15:01 ` [PATCH v2 2/3] drm/amdgpu: convert code name to ip version for noretry set Yifan Zhang
2022-03-01 15:24   ` Paul Menzel
2022-03-02  7:46     ` Christian König
2022-03-02  7:52       ` Paul Menzel
2022-03-02  7:47   ` Christian König
2022-03-01 15:01 ` [PATCH v2 3/3] drm/amdgpu: set noretry=1 for gc 10.3.6 Yifan Zhang
2022-03-01 15:11 ` Alex Deucher [this message]
2022-03-02  8:49 ` [PATCH v2 1/3] drm/amdgpu: move amdgpu_gmc_noretry_set after ip_versions populated Huang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADnq5_MEzjYEnB6BtacemOSNj7WG5EQ18vQD8XUhVpY80yBH=w@mail.gmail.com' \
    --to=alexdeucher@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Ray.Huang@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=yifan1.zhang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.