Re: [PATCH v2 1/3] drm/amdgpu: move amdgpu_gmc_noretry_set after ip_versions populated

From: Huang Rui <ray.huang@amd.com>
To: "Zhang, Yifan" <Yifan1.Zhang@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 1/3] drm/amdgpu: move amdgpu_gmc_noretry_set after ip_versions populated
Date: Wed, 2 Mar 2022 16:49:52 +0800	[thread overview]
Message-ID: <Yh8vsB182O9cGBOR@amd.com> (raw)
In-Reply-To: <20220301150121.3785743-1-yifan1.zhang@amd.com>

On Tue, Mar 01, 2022 at 11:01:19PM +0800, Zhang, Yifan wrote:
> otherwise adev->ip_versions is still empty when amdgpu_gmc_noretry_set
> is called.
> 
> Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>

Series are Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 6113ddc765a7..61a6a7920c76 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1554,7 +1554,6 @@ static int amdgpu_device_check_arguments(struct amdgpu_device *adev)
>  
>  	amdgpu_gmc_tmz_set(adev);
>  
> -	amdgpu_gmc_noretry_set(adev);
>  
>  	return 0;
>  }
> @@ -3641,6 +3640,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
>  	if (r)
>  		return r;
>  
> +	amdgpu_gmc_noretry_set(adev);
>  	/* Need to get xgmi info early to decide the reset behavior*/
>  	if (adev->gmc.xgmi.supported) {
>  		r = adev->gfxhub.funcs->get_xgmi_info(adev);
> -- 
> 2.25.1
>