[PATCH] drm/amd/pm: Return auto perf level, if unsupported

[PATCH] drm/amd/pm: Return auto perf level, if unsupported

[Lijo Lazar]

When powerplay is not enabled, return AUTO as default level.

Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
---
 drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
index 5472f9936feb..d1bf073adf54 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
@@ -770,6 +770,9 @@ enum amd_dpm_forced_level amdgpu_dpm_get_performance_level(struct amdgpu_device
 	const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
 	enum amd_dpm_forced_level level;
 
+	if (!pp_funcs)
+		return AMD_DPM_FORCED_LEVEL_AUTO;
+
 	mutex_lock(&adev->pm.mutex);
 	if (pp_funcs->get_performance_level)
 		level = pp_funcs->get_performance_level(adev->powerplay.pp_handle);
-- 
2.25.1

Re: [PATCH] drm/amd/pm: Return auto perf level, if unsupported

[Alex Deucher]

On Tue, May 24, 2022 at 8:36 AM Lijo Lazar <lijo.lazar@amd.com> wrote:
>
> When powerplay is not enabled, return AUTO as default level.
>
> Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
> ---
>  drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> index 5472f9936feb..d1bf073adf54 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> @@ -770,6 +770,9 @@ enum amd_dpm_forced_level amdgpu_dpm_get_performance_level(struct amdgpu_device
>         const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
>         enum amd_dpm_forced_level level;
>
> +       if (!pp_funcs)
> +               return AMD_DPM_FORCED_LEVEL_AUTO;

Maybe LOW?  Either way,
Acked-by: Alex Deucher <alexander.deucher@amd.com>

> +
>         mutex_lock(&adev->pm.mutex);
>         if (pp_funcs->get_performance_level)
>                 level = pp_funcs->get_performance_level(adev->powerplay.pp_handle);
> --
> 2.25.1
>

Re: [PATCH] drm/amd/pm: Return auto perf level, if unsupported

[Lazar, Lijo]

On 5/24/2022 6:49 PM, Alex Deucher wrote:
> On Tue, May 24, 2022 at 8:36 AM Lijo Lazar <lijo.lazar@amd.com> wrote:
>>
>> When powerplay is not enabled, return AUTO as default level.
>>
>> Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
>> ---
>>   drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
>> index 5472f9936feb..d1bf073adf54 100644
>> --- a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
>> +++ b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
>> @@ -770,6 +770,9 @@ enum amd_dpm_forced_level amdgpu_dpm_get_performance_level(struct amdgpu_device
>>          const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
>>          enum amd_dpm_forced_level level;
>>
>> +       if (!pp_funcs)
>> +               return AMD_DPM_FORCED_LEVEL_AUTO;
> 
> Maybe LOW?  Either way,

Picked AUTO as that maps with AMDGPU_CTX_STABLE_PSTATE_NONE.

Thanks,
Lijo

> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> 
>> +
>>          mutex_lock(&adev->pm.mutex);
>>          if (pp_funcs->get_performance_level)
>>                  level = pp_funcs->get_performance_level(adev->powerplay.pp_handle);
>> --
>> 2.25.1
>>